Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: GDB patches <gdb-patches@sourceware.org>
Cc: Stafford Horne <shorne@gmail.com>
Subject: [PATCH] sim: common: Fix pointer sign warnings
Date: Tue, 03 Oct 2017 15:44:00 -0000	[thread overview]
Message-ID: <20171003154437.11329-1-shorne@gmail.com> (raw)

When compiling we get the following warnings:

  common/cgen-accfp.c: In function ‘fixsfsi’:
  common/cgen-accfp.c:370:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
     sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
                  ^
  common/cgen-accfp.c: In function ‘fixdfsi’:
  common/cgen-accfp.c:381:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign]
     sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
                  ^
sim/common/ChangeLog:

yyyy-mm-dd  Stafford Horne  <shorne@gmail.com>

	* cgen-accfp.c (fixsfsi): Change res from unsigned32 to signed32.
	(fixdfsi): Change res from unsigned32 to signed32.
---
 sim/common/cgen-accfp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sim/common/cgen-accfp.c b/sim/common/cgen-accfp.c
index 5d600c6e41..ab3a477bbe 100644
--- a/sim/common/cgen-accfp.c
+++ b/sim/common/cgen-accfp.c
@@ -364,7 +364,7 @@ static SI
 fixsfsi (CGEN_FPU* fpu, int how UNUSED, SF x)
 {
   sim_fpu op1;
-  unsigned32 res;
+  signed32 res;
 
   sim_fpu_32to (&op1, x);
   sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
@@ -375,7 +375,7 @@ static SI
 fixdfsi (CGEN_FPU* fpu, int how UNUSED, DF x)
 {
   sim_fpu op1;
-  unsigned32 res;
+  signed32 res;
 
   sim_fpu_64to (&op1, x);
   sim_fpu_to32i (&res, &op1, sim_fpu_round_near);
-- 
2.13.5


             reply	other threads:[~2017-10-03 15:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-03 15:44 Stafford Horne [this message]
2021-01-31 20:26 ` Mike Frysinger via Gdb-patches
2021-02-01  1:31   ` Stafford Horne via Gdb-patches
2021-02-01  2:14     ` Mike Frysinger via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171003154437.11329-1-shorne@gmail.com \
    --to=shorne@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox