From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id smCaDQ1aF2BYdgAAWB0awg (envelope-from ) for ; Sun, 31 Jan 2021 20:31:57 -0500 Received: by simark.ca (Postfix, from userid 112) id 20D9F1E945; Sun, 31 Jan 2021 20:31:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 648D81E945 for ; Sun, 31 Jan 2021 20:31:56 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ACA6A384B406; Mon, 1 Feb 2021 01:31:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ACA6A384B406 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1612143115; bh=3JuHn2cfSJZ8uiRJR3SjFU2jqSQRRIDZE4h+4ifKtjs=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Y25cPLVrLYYtdNS1kAfCgFIxnitg3O+S4fGGjJqS1iySd9iGCsq7e41k/xT5jfSuf CQ6/1sfTFNkktwDZDrq4rCcs4SpzGaraIJ2oZ+As5mo9lBNzX9mnnD9ZlAzTjYxaCA Cz6Zk5E13X4rq3FQxEaYWIgctd9yix6tvlbm3bc4= Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 68605384B406 for ; Mon, 1 Feb 2021 01:31:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 68605384B406 Received: by mail-pl1-x633.google.com with SMTP id 8so3741240plc.10 for ; Sun, 31 Jan 2021 17:31:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=3JuHn2cfSJZ8uiRJR3SjFU2jqSQRRIDZE4h+4ifKtjs=; b=Nd6dC5Rj0NSSw0OZEKIRbNQsfxxkbStgo2zM6PgLklZFa8vuLaJy527s+uVPX7RB5n 7hitC+WVvpY8j+QwGbX/JdXyte9z9dP3nF7hxaH1sYl+APy+4FVPuzhfB/TLpMHws1Oa JYxwISEMxf+PdzTuDV+9n9C0Ub2BiWOMZGV34SPU/AVkGOci/lXYXzBsKC0GADrtTonr he0WEOtZffwfEpWS+ciwtXf4tFD9S7MefFAzJS5GeyHzf/ZSKDTRJNBx+nC8hyfHcDsM MkQWvLAOivZv2b3lBzIGWiMXCgIqSjp3BJ459/in/WqxzCzEKdNkI81lW5HWl93iW9KR elsA== X-Gm-Message-State: AOAM5315+Hd+5l7zzxs9IQlQ8Ngok7XC7rmC7SE11b1USelCcRX2JQ51 UWmn/W6olKtveO+OH7gczzZF42dLVbY= X-Google-Smtp-Source: ABdhPJzltlulhLK0RPRjQZvZjBhp2yb6XoIq/1wQiR3xbJtPxERd5kskeU0J4iEbyAftxNFM+lykbQ== X-Received: by 2002:a17:90b:3886:: with SMTP id mu6mr14613609pjb.153.1612143110143; Sun, 31 Jan 2021 17:31:50 -0800 (PST) Received: from localhost (g186.222-224-165.ppp.wakwak.ne.jp. [222.224.165.186]) by smtp.gmail.com with ESMTPSA id 9sm15191132pfy.110.2021.01.31.17.31.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 Jan 2021 17:31:49 -0800 (PST) Date: Mon, 1 Feb 2021 10:31:47 +0900 To: GDB patches Subject: Re: [PATCH] sim: common: Fix pointer sign warnings Message-ID: <20210201013147.GH2002709@lianli.shorne-pla.net> References: <20171003154437.11329-1-shorne@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Stafford Horne via Gdb-patches Reply-To: Stafford Horne Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Sun, Jan 31, 2021 at 03:26:35PM -0500, Mike Frysinger wrote: > On 04 Oct 2017 00:44, Stafford Horne wrote: > > When compiling we get the following warnings: > > > > common/cgen-accfp.c: In function ‘fixsfsi’: > > common/cgen-accfp.c:370:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign] > > sim_fpu_to32i (&res, &op1, sim_fpu_round_near); > > ^ > > common/cgen-accfp.c: In function ‘fixdfsi’: > > common/cgen-accfp.c:381:18: warning: pointer targets in passing argument 1 of ‘sim_fpu_to32i’ differ in signedness [-Wpointer-sign] > > sim_fpu_to32i (&res, &op1, sim_fpu_round_near); > > ^ > > thanks for the fix, i've pushed it now. > there's one more too exactly like this: > fixdfdi (CGEN_FPU* fpu, int how UNUSED, DF x) > { > sim_fpu op1; > - unsigned64 res; > + signed64 res; > > sim_fpu_64to (&op1, x); > sim_fpu_to64i (&res, &op1, sim_fpu_round_near); Thanks, it's nice to see you back working on this. Did you commit that fix in fixdffi also? -Stafford