Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: yao@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: [_Complex test 1/4]  support_complex_tests in gdb.exp and pass _Complex args to func
Date: Thu, 19 May 2011 10:16:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.1105191014340.8691@digraph.polyomino.org.uk> (raw)
In-Reply-To: <201105190814.p4J8EMYF020774@glazunov.sibelius.xs4all.nl>

On Thu, 19 May 2011, Mark Kettenis wrote:

> Sorry, but this is wrong on many levels.  For one thing, _Complex
> support has very little to do with with the OS you're running.  It's
> primarily a compiler issue.  So you should probably use a test based
> on test_compiler_info here.  The GCC C99 status page suggests that the
> first release to properly support complex is GCC 4.5.  Earlier
> versions are marked as "broken" but may actually have enough support
> for these simple tests.

I don't believe the breakage (issues such as mixed real/complex arithmetic 
wrongly converting the real operand to complex type, with implications for 
NaNs and signed zeros) is of any relevance to the GDB tests.

I'd think the right approach is simply to see if the compiler accepts a 
trivial source file of the form

_Complex float cf;
_Complex double cd;
_Complex long double cld;

and if it does, then presume complex support is present.

-- 
Joseph S. Myers
joseph@codesourcery.com


  reply	other threads:[~2011-05-19 10:16 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-06 14:13 [patch, testsuite] Tests to _Complex type Yao Qi
2011-05-06 14:33 ` Joseph S. Myers
2011-05-09  2:24   ` Yao Qi
2011-05-09 15:06     ` Tom Tromey
2011-05-19  4:26       ` [_Complex test 1/4] support_complex_tests in gdb.exp and pass _Complex args to func Yao Qi
2011-05-19  8:16         ` Mark Kettenis
2011-05-19 10:16           ` Joseph S. Myers [this message]
2011-05-19 13:26             ` Yao Qi
2011-05-19 17:10               ` Tom Tromey
2011-05-20  8:10                 ` Yao Qi
2011-05-26 17:07                   ` Tom Tromey
2011-05-30  2:53                     ` [committed] " Yao Qi
2011-05-19 13:01           ` Yao Qi
2011-05-19 13:24             ` Mark Kettenis
2011-05-19 13:38               ` Mark Kettenis
2011-05-19 10:12         ` Joseph S. Myers
2011-05-19  4:34       ` [_Complex test 2/4] _Complex type in varargs.exp Yao Qi
2011-05-19 10:13         ` Joseph S. Myers
2011-05-19 13:42           ` Yao Qi
2011-05-19 15:27             ` Joseph S. Myers
2011-05-20  9:09               ` Pedro Alves
2011-05-20 15:22               ` Yao Qi
2011-05-20 15:37                 ` Pedro Alves
2011-05-23  4:09                   ` Yao Qi
2011-05-23 10:27                     ` Pedro Alves
2011-05-30  2:55                       ` [committed] " Yao Qi
2011-05-19 17:12         ` Tom Tromey
2011-05-20  8:11           ` Yao Qi
2011-05-19  4:46       ` [_Complex test 3/4] Isolate each test's effect in callfuncs.exp Yao Qi
2011-05-19 18:46         ` Tom Tromey
2011-05-30  2:56           ` [committed] " Yao Qi
2011-05-19  5:09       ` [_Complex test 4/4] _Complex tests " Yao Qi
2011-05-20  8:17         ` Yao Qi
2011-05-24  1:46           ` [_Complex test 4/4 V3] " Yao Qi
2011-05-24  9:00             ` Mark Kettenis
2011-05-24  9:34               ` Yao Qi
2011-05-24 10:00                 ` Mark Kettenis
2011-05-24 13:54                   ` Yao Qi
2011-05-26 17:07         ` [_Complex test 4/4] " Tom Tromey
2011-05-30  2:57           ` [committed] " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1105191014340.8691@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox