From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: "Joseph S. Myers" <joseph@codesourcery.com>,
Yao Qi <yao@codesourcery.com>
Subject: Re: [_Complex test 2/4] _Complex type in varargs.exp
Date: Fri, 20 May 2011 09:09:00 -0000 [thread overview]
Message-ID: <201105201009.07830.pedro@codesourcery.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1105191525110.13146@digraph.polyomino.org.uk>
I completely agree.
On Thursday 19 May 2011 16:27:39, Joseph S. Myers wrote:
> On Thu, 19 May 2011, Yao Qi wrote:
>
> > Tests in this case also fail on armv7l-unknown-linux-gnueabi and
> > x86_64-unknown-linux-gnu. Shall I have to file yet another two PRs for
> > armv7l-unknown-linux-gnueabi and x86_64-unknown-linux-gnu respectively,
> > and KFAIL them to different PR separately? At least, I didn't see such
> > usage elsewhere in gdb testsuite.
>
> I think the correct division is one PR per target architecture for all
> complex types ABI issues, rather than one PR per test failure. That's the
> only way a target maintainer can sensibly fix their target's problems,
> test that they are fixed, and close the relevant PR; otherwise you have a
> catch-all bug that's open for ever without meaningfully reflecting what
> actually needs to be done to fix the problem.
>
> > IMO, KFAIL with target triplet works for the situation that one test
> > passes on all ports except one or two. However, our test fails on most
> > ports, different from KFAIL's typical usage.
>
> The aim is that soon the bug *is* fixed for all the most commonly used
> targets - but will likely remain open much longer for many more rarely
> used targets.
--
Pedro Alves
next prev parent reply other threads:[~2011-05-20 9:09 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 14:13 [patch, testsuite] Tests to _Complex type Yao Qi
2011-05-06 14:33 ` Joseph S. Myers
2011-05-09 2:24 ` Yao Qi
2011-05-09 15:06 ` Tom Tromey
2011-05-19 4:26 ` [_Complex test 1/4] support_complex_tests in gdb.exp and pass _Complex args to func Yao Qi
2011-05-19 8:16 ` Mark Kettenis
2011-05-19 10:16 ` Joseph S. Myers
2011-05-19 13:26 ` Yao Qi
2011-05-19 17:10 ` Tom Tromey
2011-05-20 8:10 ` Yao Qi
2011-05-26 17:07 ` Tom Tromey
2011-05-30 2:53 ` [committed] " Yao Qi
2011-05-19 13:01 ` Yao Qi
2011-05-19 13:24 ` Mark Kettenis
2011-05-19 13:38 ` Mark Kettenis
2011-05-19 10:12 ` Joseph S. Myers
2011-05-19 4:34 ` [_Complex test 2/4] _Complex type in varargs.exp Yao Qi
2011-05-19 10:13 ` Joseph S. Myers
2011-05-19 13:42 ` Yao Qi
2011-05-19 15:27 ` Joseph S. Myers
2011-05-20 9:09 ` Pedro Alves [this message]
2011-05-20 15:22 ` Yao Qi
2011-05-20 15:37 ` Pedro Alves
2011-05-23 4:09 ` Yao Qi
2011-05-23 10:27 ` Pedro Alves
2011-05-30 2:55 ` [committed] " Yao Qi
2011-05-19 17:12 ` Tom Tromey
2011-05-20 8:11 ` Yao Qi
2011-05-19 4:46 ` [_Complex test 3/4] Isolate each test's effect in callfuncs.exp Yao Qi
2011-05-19 18:46 ` Tom Tromey
2011-05-30 2:56 ` [committed] " Yao Qi
2011-05-19 5:09 ` [_Complex test 4/4] _Complex tests " Yao Qi
2011-05-20 8:17 ` Yao Qi
2011-05-24 1:46 ` [_Complex test 4/4 V3] " Yao Qi
2011-05-24 9:00 ` Mark Kettenis
2011-05-24 9:34 ` Yao Qi
2011-05-24 10:00 ` Mark Kettenis
2011-05-24 13:54 ` Yao Qi
2011-05-26 17:07 ` [_Complex test 4/4] " Tom Tromey
2011-05-30 2:57 ` [committed] " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105201009.07830.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=joseph@codesourcery.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox