Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch, testsuite] Tests to _Complex type
Date: Mon, 09 May 2011 02:24:00 -0000	[thread overview]
Message-ID: <4DC75036.4040806@codesourcery.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1105061426440.8538@digraph.polyomino.org.uk>

On 05/06/2011 10:33 PM, Joseph S. Myers wrote:
> It would be good to include a much wider range of tests.  structs and 
> unions containing complex values (and arrays of complex values, and 
> complex values mixed with real ones, etc.), complex values in many 
> different argument positions, and after integer arguments as well as 
> floating-point ones, all three types _Complex float, _Complex double, 
> _Complex long double properly covered in these ways.  For structs and 
> unions and arrays therein, the sort of case you want to cover includes the 
> ARM (VFP ABI) and IA64 rules on homogeneous aggregates.

Yes, I agree.  After go through gdb testsuite, we may do several tests
for _Complex in these following areas,
1. pass and return _Complex type and _Complex type in aggregate type in
function call, like funcargs.exp and callfuncs.exp.
2. vararg for _Complex type and _Complex type in aggregate type, like
varargs.exp
3. _Complex type in struct, like struct.exp.

GDB maintainers,
Shall we propagate _Complex related tests to each *.exp file, such as
funcargs.exp/callfuncs.exp/varargs.exp/struct.arg? or keep all _Complex
tests in a single exp file complex.exp?  I prefer the former one, but I
am afraid this will break some platforms which don't support _Complex.
Thoughts?

-- 
Yao (齐尧)


  reply	other threads:[~2011-05-09  2:24 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-06 14:13 Yao Qi
2011-05-06 14:33 ` Joseph S. Myers
2011-05-09  2:24   ` Yao Qi [this message]
2011-05-09 15:06     ` Tom Tromey
2011-05-19  4:26       ` [_Complex test 1/4] support_complex_tests in gdb.exp and pass _Complex args to func Yao Qi
2011-05-19  8:16         ` Mark Kettenis
2011-05-19 10:16           ` Joseph S. Myers
2011-05-19 13:26             ` Yao Qi
2011-05-19 17:10               ` Tom Tromey
2011-05-20  8:10                 ` Yao Qi
2011-05-26 17:07                   ` Tom Tromey
2011-05-30  2:53                     ` [committed] " Yao Qi
2011-05-19 13:01           ` Yao Qi
2011-05-19 13:24             ` Mark Kettenis
2011-05-19 13:38               ` Mark Kettenis
2011-05-19 10:12         ` Joseph S. Myers
2011-05-19  4:34       ` [_Complex test 2/4] _Complex type in varargs.exp Yao Qi
2011-05-19 10:13         ` Joseph S. Myers
2011-05-19 13:42           ` Yao Qi
2011-05-19 15:27             ` Joseph S. Myers
2011-05-20  9:09               ` Pedro Alves
2011-05-20 15:22               ` Yao Qi
2011-05-20 15:37                 ` Pedro Alves
2011-05-23  4:09                   ` Yao Qi
2011-05-23 10:27                     ` Pedro Alves
2011-05-30  2:55                       ` [committed] " Yao Qi
2011-05-19 17:12         ` Tom Tromey
2011-05-20  8:11           ` Yao Qi
2011-05-19  4:46       ` [_Complex test 3/4] Isolate each test's effect in callfuncs.exp Yao Qi
2011-05-19 18:46         ` Tom Tromey
2011-05-30  2:56           ` [committed] " Yao Qi
2011-05-19  5:09       ` [_Complex test 4/4] _Complex tests " Yao Qi
2011-05-20  8:17         ` Yao Qi
2011-05-24  1:46           ` [_Complex test 4/4 V3] " Yao Qi
2011-05-24  9:00             ` Mark Kettenis
2011-05-24  9:34               ` Yao Qi
2011-05-24 10:00                 ` Mark Kettenis
2011-05-24 13:54                   ` Yao Qi
2011-05-26 17:07         ` [_Complex test 4/4] " Tom Tromey
2011-05-30  2:57           ` [committed] " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC75036.4040806@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=joseph@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox