From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch, testsuite] Tests to _Complex type
Date: Fri, 06 May 2011 14:33:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1105061426440.8538@digraph.polyomino.org.uk> (raw)
In-Reply-To: <4DC401D0.1050500@codesourcery.com>
On Fri, 6 May 2011, Yao Qi wrote:
> When I am fixing GDB's inf-call in one port, I find tests to _Complex
> type is quite limited, especially on argument passing, there is none.
> This patch is to add more tests to _Complex type on argument passing and
> vararg support.
It would be good to include a much wider range of tests. structs and
unions containing complex values (and arrays of complex values, and
complex values mixed with real ones, etc.), complex values in many
different argument positions, and after integer arguments as well as
floating-point ones, all three types _Complex float, _Complex double,
_Complex long double properly covered in these ways. For structs and
unions and arrays therein, the sort of case you want to cover includes the
ARM (VFP ABI) and IA64 rules on homogeneous aggregates.
(The reason I don't suggest covering complex integer types is that they
are a GNU extension with no documented GNU DWARF extension to represent
them. In principle target-specific types such as __float80 and __float128
(on x86 and IA64) and their complex versions *should* be covered, but at
present GCC doesn't support using _Complex with those type names so
accessing the complex versions requires using mode attributes.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2011-05-06 14:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 14:13 Yao Qi
2011-05-06 14:33 ` Joseph S. Myers [this message]
2011-05-09 2:24 ` Yao Qi
2011-05-09 15:06 ` Tom Tromey
2011-05-19 4:26 ` [_Complex test 1/4] support_complex_tests in gdb.exp and pass _Complex args to func Yao Qi
2011-05-19 8:16 ` Mark Kettenis
2011-05-19 10:16 ` Joseph S. Myers
2011-05-19 13:26 ` Yao Qi
2011-05-19 17:10 ` Tom Tromey
2011-05-20 8:10 ` Yao Qi
2011-05-26 17:07 ` Tom Tromey
2011-05-30 2:53 ` [committed] " Yao Qi
2011-05-19 13:01 ` Yao Qi
2011-05-19 13:24 ` Mark Kettenis
2011-05-19 13:38 ` Mark Kettenis
2011-05-19 10:12 ` Joseph S. Myers
2011-05-19 4:34 ` [_Complex test 2/4] _Complex type in varargs.exp Yao Qi
2011-05-19 10:13 ` Joseph S. Myers
2011-05-19 13:42 ` Yao Qi
2011-05-19 15:27 ` Joseph S. Myers
2011-05-20 9:09 ` Pedro Alves
2011-05-20 15:22 ` Yao Qi
2011-05-20 15:37 ` Pedro Alves
2011-05-23 4:09 ` Yao Qi
2011-05-23 10:27 ` Pedro Alves
2011-05-30 2:55 ` [committed] " Yao Qi
2011-05-19 17:12 ` Tom Tromey
2011-05-20 8:11 ` Yao Qi
2011-05-19 4:46 ` [_Complex test 3/4] Isolate each test's effect in callfuncs.exp Yao Qi
2011-05-19 18:46 ` Tom Tromey
2011-05-30 2:56 ` [committed] " Yao Qi
2011-05-19 5:09 ` [_Complex test 4/4] _Complex tests " Yao Qi
2011-05-20 8:17 ` Yao Qi
2011-05-24 1:46 ` [_Complex test 4/4 V3] " Yao Qi
2011-05-24 9:00 ` Mark Kettenis
2011-05-24 9:34 ` Yao Qi
2011-05-24 10:00 ` Mark Kettenis
2011-05-24 13:54 ` Yao Qi
2011-05-26 17:07 ` [_Complex test 4/4] " Tom Tromey
2011-05-30 2:57 ` [committed] " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1105061426440.8538@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox