From: Yao Qi <yao@codesourcery.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [_Complex test 4/4 V3] _Complex tests in callfuncs.exp
Date: Tue, 24 May 2011 13:54:00 -0000 [thread overview]
Message-ID: <4DDBB880.3010900@codesourcery.com> (raw)
In-Reply-To: <201105240958.p4O9wuUb030981@glazunov.sibelius.xs4all.nl>
On 05/24/2011 05:58 PM, Mark Kettenis wrote:
> Ah, I didn't realize that setup_kfail was part of dejagnu proper.
> Still I think that setup_kfail_for_target is what the behaviour of
> setup_kfail should be. So dejagnu should be changed.
>
IMO, it is a separate issue to change setup_kfail to what
setup_kfail_for_target like.
> I'd say you should just go with your previous version that uses
> setup_kfail, and submit the enhancement of setup_kfail to the dejagnu
> maintainers. I believe you can link together bugs in bugzilla, so in
> the interim, you could use that feature to link together the various
> bug reports such that people can find the right one even if the bug ID
> that gets printed is the wrong one.
>
There are various tricks in bugzilla to link different PRs together, but
it should not be recommended. We don't know how long these bugs can be
fixed, so it is important to keep an *correct* PR number in KFAIL
message. That is reason why KFAIL was invented, I think.
Despite of changes going to GDB or DejaGnu, the patch is almost the
same. Only difference is setup_kfail vs. setup_kfail_for_target.
> Anyway, getting these tests in is more important than getting the
> linking to bug reports exactly right. If other people think that
Now, we have the approach from which we can get tests running and get
the the correct bug report number. As I said above, moving
setup_kfail_for_target to setup_kfail is a separate issue, and is a
little bit out of scope of GDB.
> setup_kfail_for_target is the way to go, feel free to ignore me.
--
Yao (é½å°§)
next prev parent reply other threads:[~2011-05-24 13:54 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 14:13 [patch, testsuite] Tests to _Complex type Yao Qi
2011-05-06 14:33 ` Joseph S. Myers
2011-05-09 2:24 ` Yao Qi
2011-05-09 15:06 ` Tom Tromey
2011-05-19 4:26 ` [_Complex test 1/4] support_complex_tests in gdb.exp and pass _Complex args to func Yao Qi
2011-05-19 8:16 ` Mark Kettenis
2011-05-19 10:16 ` Joseph S. Myers
2011-05-19 13:26 ` Yao Qi
2011-05-19 17:10 ` Tom Tromey
2011-05-20 8:10 ` Yao Qi
2011-05-26 17:07 ` Tom Tromey
2011-05-30 2:53 ` [committed] " Yao Qi
2011-05-19 13:01 ` Yao Qi
2011-05-19 13:24 ` Mark Kettenis
2011-05-19 13:38 ` Mark Kettenis
2011-05-19 10:12 ` Joseph S. Myers
2011-05-19 4:34 ` [_Complex test 2/4] _Complex type in varargs.exp Yao Qi
2011-05-19 10:13 ` Joseph S. Myers
2011-05-19 13:42 ` Yao Qi
2011-05-19 15:27 ` Joseph S. Myers
2011-05-20 9:09 ` Pedro Alves
2011-05-20 15:22 ` Yao Qi
2011-05-20 15:37 ` Pedro Alves
2011-05-23 4:09 ` Yao Qi
2011-05-23 10:27 ` Pedro Alves
2011-05-30 2:55 ` [committed] " Yao Qi
2011-05-19 17:12 ` Tom Tromey
2011-05-20 8:11 ` Yao Qi
2011-05-19 4:46 ` [_Complex test 3/4] Isolate each test's effect in callfuncs.exp Yao Qi
2011-05-19 18:46 ` Tom Tromey
2011-05-30 2:56 ` [committed] " Yao Qi
2011-05-19 5:09 ` [_Complex test 4/4] _Complex tests " Yao Qi
2011-05-20 8:17 ` Yao Qi
2011-05-24 1:46 ` [_Complex test 4/4 V3] " Yao Qi
2011-05-24 9:00 ` Mark Kettenis
2011-05-24 9:34 ` Yao Qi
2011-05-24 10:00 ` Mark Kettenis
2011-05-24 13:54 ` Yao Qi [this message]
2011-05-26 17:07 ` [_Complex test 4/4] " Tom Tromey
2011-05-30 2:57 ` [committed] " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDBB880.3010900@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox