RE: [RFC] fullname attribute for GDB/MI stack frames

["Dennis Brueni" <dbrueni@slickedit.com>]

> -----Original Message-----
> From: Bob Rossi [mailto:bob@brasko.net] 
> Sent: Thursday, March 31, 2005 9:40 PM
> To: Dennis Brueni
> Cc: gdb-patches@sources.redhat.com
> Subject: Re: [RFC] fullname attribute for GDB/MI stack frames
> 
> 
> > > I would look at mi-file.exp. Make sure the regex you use in the 
> > > testsuite for matching the fullname is fullname=\"/.*/${srcfile}\"
> > > 
> > > I know that I originally committed something different, 
> and it ended 
> > > up morphing into this, so that it could pass the testsuite in a 
> > > variety of different environments.
> > > 
> > > Bob Rossi
> > 
> > 
> > Apologies for the broken lines; I also noticed that, after 
> the fact :( 
> > Updated patch set follows.
> > 
> > I have fixed the path issues in gdb.texinfo and also added 
> ChangeLog 
> > entries to the patch set.
> > 
> > For the testsuite regex's, I was just trying to remain 
> consistent with 
> > the tests for "file=" and not break anything.
> >   # # NOTE: cagney/2003-02-03: Not yet.
> >   # mi_gdb_test "-exec-continue" \
> > ! #    
> {.*\*stopped,reason="breakpoint-hit",.*func="callee4".*file=".
> *basics.c",line="8"\}} \
> >   #    "-interpreter-exec console \"continue to callee4\""
> >   send_gdb "999-exec-continue\n"
> >   gdb_expect {
> > --- 100,106 ----
> >   
> >   # # NOTE: cagney/2003-02-03: Not yet.
> >   # mi_gdb_test "-exec-continue" \
> > ! #    
> {.*\*stopped,reason="breakpoint-hit",.*func="callee4".*file=".
> *basics.c",fullname=".*basics.c",line="8"\}} \
> >   #    "-interpreter-exec console \"continue to callee4\""
> >   send_gdb "999-exec-continue\n"
> >   gdb_expect {
> 
> Hi,
> 
> Again, for the fullname regex, I would recommend using the 
> same regex used in mi-file.exp. This would be like 
> fullname="/.*basics.c" This forces the regex to ensure that 
> the path is absolute, which the check you have does not.
> 
> Bob Rossi
>

I was concerned that regex would fail in cases where the
fullname path starts with a drive letter.  Nevertheless,
I will rework the patch again and post it later today.

--Dennis Brueni