From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4158 invoked by alias); 1 Apr 2005 15:09:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4097 invoked from network); 1 Apr 2005 15:09:25 -0000 Received: from unknown (HELO wampa.office.slickedit.com) (24.106.178.205) by sourceware.org with SMTP; 1 Apr 2005 15:09:25 -0000 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: [RFC] fullname attribute for GDB/MI stack frames Date: Fri, 01 Apr 2005 15:09:00 -0000 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: From: "Dennis Brueni" To: "Bob Rossi" Cc: X-SW-Source: 2005-04/txt/msg00007.txt.bz2 > -----Original Message----- > From: Bob Rossi [mailto:bob@brasko.net]=20 > Sent: Thursday, March 31, 2005 9:40 PM > To: Dennis Brueni > Cc: gdb-patches@sources.redhat.com > Subject: Re: [RFC] fullname attribute for GDB/MI stack frames >=20 >=20 > > > I would look at mi-file.exp. Make sure the regex you use in the=20 > > > testsuite for matching the fullname is fullname=3D\"/.*/${srcfile}\" > > >=20 > > > I know that I originally committed something different,=20 > and it ended=20 > > > up morphing into this, so that it could pass the testsuite in a=20 > > > variety of different environments. > > >=20 > > > Bob Rossi > >=20 > >=20 > > Apologies for the broken lines; I also noticed that, after=20 > the fact :(=20 > > Updated patch set follows. > >=20 > > I have fixed the path issues in gdb.texinfo and also added=20 > ChangeLog=20 > > entries to the patch set. > >=20 > > For the testsuite regex's, I was just trying to remain=20 > consistent with=20 > > the tests for "file=3D" and not break anything. > > # # NOTE: cagney/2003-02-03: Not yet. > > # mi_gdb_test "-exec-continue" \ > > ! #=20=20=20=20 > {.*\*stopped,reason=3D"breakpoint-hit",.*func=3D"callee4".*file=3D". > *basics.c",line=3D"8"\}} \ > > # "-interpreter-exec console \"continue to callee4\"" > > send_gdb "999-exec-continue\n" > > gdb_expect { > > --- 100,106 ---- > >=20=20=20 > > # # NOTE: cagney/2003-02-03: Not yet. > > # mi_gdb_test "-exec-continue" \ > > ! #=20=20=20=20 > {.*\*stopped,reason=3D"breakpoint-hit",.*func=3D"callee4".*file=3D". > *basics.c",fullname=3D".*basics.c",line=3D"8"\}} \ > > # "-interpreter-exec console \"continue to callee4\"" > > send_gdb "999-exec-continue\n" > > gdb_expect { >=20 > Hi, >=20 > Again, for the fullname regex, I would recommend using the=20 > same regex used in mi-file.exp. This would be like=20 > fullname=3D"/.*basics.c" This forces the regex to ensure that=20 > the path is absolute, which the check you have does not. >=20 > Bob Rossi > I was concerned that regex would fail in cases where the fullname path starts with a drive letter. Nevertheless, I will rework the patch again and post it later today. --Dennis Brueni