Re: [RFC] fullname attribute for GDB/MI stack frames

[Bob Rossi <bob@brasko.net>]

On Tue, May 03, 2005 at 03:48:56PM -0400, Daniel Jacobowitz wrote:
> On Tue, May 03, 2005 at 10:34:15PM +0300, Eli Zaretskii wrote:
> > > Date: Mon, 2 May 2005 23:46:05 -0400
> > > From: Daniel Jacobowitz <drow@false.org>
> > > Cc: gdb-patches@sources.redhat.com
> > > 
> > > > > That's not what we're testing for in the testsuite, though.
> > > > 
> > > > What _are_ we trying to test?
> > > 
> > > GDB is outputting an absolute path, which will be used by either the
> > > user or by a front end.  In either case, it should locate the file
> > > entirely unambiguously.
> > 
> > If that is what we want to test, then the test is IMHO inappropriate:
> > we shouldn't try to identify an absolute file name, we should see if
> > the name it produces corresponds to a real file.  I.e., try to stat
> > the file, or maybe cmp it against the source whose path we know, or
> > something like that.
> 
> Round and round we go... I believe I just argued the same point you're
> making here a little earlier, but gave in to Bob's wishes.
> 
> These tests are not for the fullname feature.  They merely include a
> fullname in their output.  I'm all for putting fullname=".*basics.c" in
> them and leaving it at that.  But if we're going to be more precise,
> then we should try to be completely precise; the regexp can be easily
> centralized.

I would be more than willing to make the initial regex variable be '/.*'
or even '.*' to get this patch resolved.

Later, the burden will be on me to update the regex to an appropriate
value.

Thanks,
Bob Rossi