Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Bob Rossi <bob@brasko.net>
To: Dennis Brueni <dbrueni@slickedit.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] fullname attribute for GDB/MI stack frames
Date: Fri, 01 Apr 2005 01:41:00 -0000	[thread overview]
Message-ID: <20050401024019.GA1937@white> (raw)
In-Reply-To: <ECCC6E9907B4CD4A83260A191A91F20E22C6D1@wampa.office.slickedit.com>

> > I would look at mi-file.exp. Make sure the regex you use in the
> > testsuite for matching the fullname is fullname=\"/.*/${srcfile}\"
> > 
> > I know that I originally committed something different, and it ended up
> > morphing into this, so that it could pass the testsuite in a variety of
> > different environments.
> > 
> > Bob Rossi
> 
> 
> Apologies for the broken lines; I also noticed that, after the fact :(
> Updated patch set follows.
> 
> I have fixed the path issues in gdb.texinfo and also added ChangeLog
> entries to the patch set.
> 
> For the testsuite regex's, I was just trying to remain consistent
> with the tests for "file=" and not break anything.
>   # # NOTE: cagney/2003-02-03: Not yet.
>   # mi_gdb_test "-exec-continue" \
> ! #    {.*\*stopped,reason="breakpoint-hit",.*func="callee4".*file=".*basics.c",line="8"\}} \
>   #    "-interpreter-exec console \"continue to callee4\""
>   send_gdb "999-exec-continue\n"
>   gdb_expect {
> --- 100,106 ----
>   
>   # # NOTE: cagney/2003-02-03: Not yet.
>   # mi_gdb_test "-exec-continue" \
> ! #    {.*\*stopped,reason="breakpoint-hit",.*func="callee4".*file=".*basics.c",fullname=".*basics.c",line="8"\}} \
>   #    "-interpreter-exec console \"continue to callee4\""
>   send_gdb "999-exec-continue\n"
>   gdb_expect {

Hi,

Again, for the fullname regex, I would recommend using the same regex
used in mi-file.exp. This would be like fullname="/.*basics.c"
This forces the regex to ensure that the path is absolute, which the
check you have does not.

Bob Rossi


  parent reply	other threads:[~2005-04-01  1:41 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-29 20:43 Dennis Brueni
2005-03-30  4:46 ` Eli Zaretskii
2005-04-01  1:41 ` Bob Rossi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-05-05 15:15 Dennis Brueni
2005-05-05 15:25 ` Bob Rossi
2005-05-05 15:28   ` Daniel Jacobowitz
2005-05-05 15:32     ` Bob Rossi
2005-05-02 14:22 Dennis Brueni
2005-05-02 19:38 ` Eli Zaretskii
2005-04-01 19:13 Dennis Brueni
2005-04-02  9:22 ` Eli Zaretskii
2005-04-30 19:18 ` Daniel Jacobowitz
2005-05-01  2:19   ` Bob Rossi
2005-05-01 18:24     ` Eli Zaretskii
2005-05-01 18:34       ` Bob Rossi
2005-05-01 19:02         ` Daniel Jacobowitz
2005-05-02  0:55           ` Bob Rossi
2005-05-02  0:54       ` Bob Rossi
2005-05-02  0:58         ` Daniel Jacobowitz
2005-05-02 19:30         ` Eli Zaretskii
2005-05-02 19:36           ` Bob Rossi
2005-05-02 19:52             ` Eli Zaretskii
2005-05-02 19:55               ` Daniel Jacobowitz
2005-05-02 20:42                 ` Eli Zaretskii
2005-05-02 20:49                   ` Daniel Jacobowitz
2005-05-02 21:20                     ` Bob Rossi
2005-05-03  3:49                       ` Eli Zaretskii
2005-05-03  3:42                     ` Eli Zaretskii
2005-05-03  3:46                       ` Daniel Jacobowitz
2005-05-03 19:36                         ` Eli Zaretskii
2005-05-03 19:49                           ` Daniel Jacobowitz
2005-05-03 20:05                             ` Bob Rossi
2005-05-03 20:49                             ` Eli Zaretskii
2005-05-04 13:34                               ` Daniel Jacobowitz
2005-05-04 13:51                                 ` Bob Rossi
2005-05-04 13:52                                   ` Daniel Jacobowitz
2005-05-04 17:51                                   ` Eli Zaretskii
2005-05-04 18:06                                     ` Bob Rossi
2005-05-04 20:32                                       ` Eli Zaretskii
2005-05-04 18:05                                 ` Eli Zaretskii
2005-05-04 18:32                                   ` Daniel Jacobowitz
2005-05-04 20:53                                     ` Eli Zaretskii
2005-05-04 21:07                                       ` Daniel Jacobowitz
2005-05-04 21:42                                         ` Eli Zaretskii
2005-05-04 22:01                                           ` Daniel Jacobowitz
2005-05-04 23:42                                             ` Christopher Faylor
2005-05-05  4:15                                             ` Eli Zaretskii
2005-05-04 23:40                                         ` Christopher Faylor
2005-05-05  0:05                                           ` Bob Rossi
2005-05-05  4:02                                           ` Eli Zaretskii
2005-05-04 23:37                                       ` Christopher Faylor
2005-05-05  4:05                                         ` Eli Zaretskii
2005-05-03 19:57                           ` Bob Rossi
2005-05-03 21:15                             ` Eli Zaretskii
2005-05-03 21:39                               ` Christopher Faylor
2005-05-03 22:24                                 ` Daniel Jacobowitz
2005-05-03 22:27                                   ` Christopher Faylor
2005-05-04  2:32                                     ` Bob Rossi
2005-05-04  3:05                                       ` Christopher Faylor
2005-05-04 17:42                                       ` Eli Zaretskii
2005-05-04  4:12                                   ` Eli Zaretskii
2005-05-04 13:00                                     ` Daniel Jacobowitz
2005-05-04  4:27                                 ` Eli Zaretskii
2005-05-04 11:48                                   ` Bob Rossi
2005-05-04 14:55                                     ` Christopher Faylor
2005-05-04 15:02                                       ` Bob Rossi
2005-05-04 17:43                                       ` Eli Zaretskii
2005-05-04 17:58                                         ` Christopher Faylor
2005-05-04 18:29                                           ` Eli Zaretskii
2005-05-04 20:39                                           ` Eli Zaretskii
2005-05-04 23:34                                             ` Christopher Faylor
2005-05-05  4:08                                               ` Eli Zaretskii
2005-05-04 13:45                                   ` Daniel Jacobowitz
2005-05-04 20:20                                     ` Eli Zaretskii
2005-05-04 20:30                                       ` Daniel Jacobowitz
2005-05-04 21:24                                         ` Eli Zaretskii
2005-05-04 14:52                                   ` Christopher Faylor
2005-05-04 17:48                                     ` Eli Zaretskii
2005-05-04 18:03                                       ` Christopher Faylor
2005-05-04 18:26                                         ` Eli Zaretskii
2005-05-03 21:39                               ` Bob Rossi
2005-05-03 22:14                                 ` Christopher Faylor
2005-05-04  4:08                                   ` Eli Zaretskii
2005-05-04 13:39                                     ` Daniel Jacobowitz
2005-05-04 17:49                                       ` Eli Zaretskii
2005-05-04  4:18                                 ` Eli Zaretskii
2005-05-03 22:50                           ` Bob Rossi
2005-05-04  4:04                             ` Eli Zaretskii
2005-05-05 17:20       ` Bob Rossi
2005-05-05 18:04         ` Eli Zaretskii
2005-05-05 19:18         ` Christopher Faylor
2005-05-05 23:53           ` Bob Rossi
2005-05-05 16:22     ` Bob Rossi
2005-05-05 16:26       ` Daniel Jacobowitz
2005-05-05 16:46         ` Bob Rossi
2005-05-05 17:17           ` Daniel Jacobowitz
2005-05-18  4:44   ` Daniel Jacobowitz
2005-04-01 15:09 Dennis Brueni
2005-03-26 13:43 Eli Zaretskii
2005-03-26 13:50 ` Bob Rossi
2005-03-24 20:49 Dennis Brueni
2005-03-23 22:22 Dennis Brueni
2005-03-23 22:34 ` Bob Rossi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050401024019.GA1937@white \
    --to=bob@brasko.net \
    --cc=dbrueni@slickedit.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox