From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20769 invoked by alias); 1 Apr 2005 01:41:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20754 invoked from network); 1 Apr 2005 01:41:36 -0000 Received: from unknown (HELO lakermmtao01.cox.net) (68.230.240.38) by sourceware.org with SMTP; 1 Apr 2005 01:41:36 -0000 Received: from white ([68.9.64.121]) by lakermmtao01.cox.net (InterMail vM.6.01.04.00 201-2131-118-20041027) with ESMTP id <20050401014134.IJGB29182.lakermmtao01.cox.net@white>; Thu, 31 Mar 2005 20:41:34 -0500 Received: from bob by white with local (Exim 3.35 #1 (Debian)) id 1DHC55-0000Yl-00; Thu, 31 Mar 2005 21:40:19 -0500 Date: Fri, 01 Apr 2005 01:41:00 -0000 From: Bob Rossi To: Dennis Brueni Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] fullname attribute for GDB/MI stack frames Message-ID: <20050401024019.GA1937@white> Mail-Followup-To: Dennis Brueni , gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i X-SW-Source: 2005-04/txt/msg00003.txt.bz2 > > I would look at mi-file.exp. Make sure the regex you use in the > > testsuite for matching the fullname is fullname=\"/.*/${srcfile}\" > > > > I know that I originally committed something different, and it ended up > > morphing into this, so that it could pass the testsuite in a variety of > > different environments. > > > > Bob Rossi > > > Apologies for the broken lines; I also noticed that, after the fact :( > Updated patch set follows. > > I have fixed the path issues in gdb.texinfo and also added ChangeLog > entries to the patch set. > > For the testsuite regex's, I was just trying to remain consistent > with the tests for "file=" and not break anything. > # # NOTE: cagney/2003-02-03: Not yet. > # mi_gdb_test "-exec-continue" \ > ! # {.*\*stopped,reason="breakpoint-hit",.*func="callee4".*file=".*basics.c",line="8"\}} \ > # "-interpreter-exec console \"continue to callee4\"" > send_gdb "999-exec-continue\n" > gdb_expect { > --- 100,106 ---- > > # # NOTE: cagney/2003-02-03: Not yet. > # mi_gdb_test "-exec-continue" \ > ! # {.*\*stopped,reason="breakpoint-hit",.*func="callee4".*file=".*basics.c",fullname=".*basics.c",line="8"\}} \ > # "-interpreter-exec console \"continue to callee4\"" > send_gdb "999-exec-continue\n" > gdb_expect { Hi, Again, for the fullname regex, I would recommend using the same regex used in mi-file.exp. This would be like fullname="/.*basics.c" This forces the regex to ensure that the path is absolute, which the check you have does not. Bob Rossi