[PATCH] Fix darwin build error

[PATCH] Fix darwin build error

[Josh Matthews]

I hope this is the right way to do this. GDB currently doesn't build
on darwin, and this patch makes it do so.

gdb/
2011-08-22  Josh Matthews  <josh@joshmatthews.net>

	Fix build error in darwin port.

--- a/gdb/darwin-nat-info.c
+++ b/gdb/darwin-nat-info.c
@@ -620,6 +620,7 @@ darwin_debug_regions_recurse (task_t task)
   kern_return_t kret;
   int ret;
   struct cleanup *table_chain;
+  struct ui_out* uiout = current_uiout;

   table_chain = make_cleanup_ui_out_table_begin_end (uiout, 9, -1, "regions");

Re: [PATCH] Fix darwin build error

[Sergio Durigan Junior]

Hello Josh,

Josh Matthews <josh@joshmatthews.net> writes:

> I hope this is the right way to do this. GDB currently doesn't build
> on darwin, and this patch makes it do so.

Thanks for this.  There are some nits, though.

Also, I don't see your name on the MAINTAINERS file.  Do you have
copyright assignment from FSF?  I don't know what's the procedure on
these cases...  Maybe someone could commit the patch for you?

> gdb/
> 2011-08-22  Josh Matthews  <josh@joshmatthews.net>
>
> 	Fix build error in darwin port.

You have to cite the file.  Also, I believe you could be more
descriptive on the message.  Something like:

        * darwin-nat-info.c (darwin_debug_regions_recurse): Replacing
          `uiout' by `current_uiout', fixing build error.

> --- a/gdb/darwin-nat-info.c
> +++ b/gdb/darwin-nat-info.c
> @@ -620,6 +620,7 @@ darwin_debug_regions_recurse (task_t task)
>    kern_return_t kret;
>    int ret;
>    struct cleanup *table_chain;
> +  struct ui_out* uiout = current_uiout;

The `*' shouldn't be placed there.  This is the standard:

    struct ui_out *uiout = current_uiout;

I think the current approach is to actually replace the occurrences of
`uiout' by `current_uiout', but I don't mind having a local `uiout'
variable.

Regards,

Sergio.

Re: [PATCH] Fix darwin build error

[Jan Kratochvil]

On Tue, 23 Aug 2011 00:15:35 +0200, Sergio Durigan Junior wrote:
> Also, I don't see your name on the MAINTAINERS file.  Do you have
> copyright assignment from FSF?  I don't know what's the procedure on
> these cases...  Maybe someone could commit the patch for you?

I hope I made not assignment violation but I doubt this single-line "rename"
change needs copyright assignment.  Still it would be sure great if there is
one in place for future contributions, please contact Tom Tromey.


> The `*' shouldn't be placed there.  This is the standard:
> 
>     struct ui_out *uiout = current_uiout;

I agree, I have checked in the patch below.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2011-08/msg00099.html

--- src/gdb/ChangeLog	2011/08/21 14:33:05	1.13274
+++ src/gdb/ChangeLog	2011/08/23 19:40:48	1.13275
@@ -1,3 +1,8 @@
+2011-08-23  Josh Matthews  <josh@joshmatthews.net>
+
+	Fix build error in Darwin port.
+	* darwin-nat-info.c (darwin_debug_regions_recurse): New variable uiout.
+
 2011-08-21  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	Code cleanup.
--- src/gdb/darwin-nat-info.c	2011/03/18 14:22:34	1.15
+++ src/gdb/darwin-nat-info.c	2011/08/23 19:40:50	1.16
@@ -620,6 +620,7 @@
   kern_return_t kret;
   int ret;
   struct cleanup *table_chain;
+  struct ui_out *uiout = current_uiout;
 
   table_chain = make_cleanup_ui_out_table_begin_end (uiout, 9, -1, "regions");
 

Re: [PATCH] Fix darwin build error

[Josh Matthews]

Thanks very much everybody. I couldn't find any good guideline for how
to format the email (and especially the changelot entry) so I cribbed
off of a random email that was sent recently. It would be quite
helpful if someone could put together a webpage that listed

1) what you do with a patch you've written (attach to a bug tracker?
send to the list?)
2) how to format the email
3) how to do stuff related to copyright assignment

to make future contributions from newcomers easier.

Cheers,
Josh

On 23 August 2011 15:42, Jan Kratochvil <jan.kratochvil@redhat.com> wrote:
> On Tue, 23 Aug 2011 00:15:35 +0200, Sergio Durigan Junior wrote:
>> Also, I don't see your name on the MAINTAINERS file.  Do you have
>> copyright assignment from FSF?  I don't know what's the procedure on
>> these cases...  Maybe someone could commit the patch for you?
>
> I hope I made not assignment violation but I doubt this single-line "rename"
> change needs copyright assignment.  Still it would be sure great if there is
> one in place for future contributions, please contact Tom Tromey.
>
>
>> The `*' shouldn't be placed there.  This is the standard:
>>
>>     struct ui_out *uiout = current_uiout;
>
> I agree, I have checked in the patch below.
>
>
> Thanks,
> Jan
>
>
> http://sourceware.org/ml/gdb-cvs/2011-08/msg00099.html
>
> --- src/gdb/ChangeLog   2011/08/21 14:33:05     1.13274
> +++ src/gdb/ChangeLog   2011/08/23 19:40:48     1.13275
> @@ -1,3 +1,8 @@
> +2011-08-23  Josh Matthews  <josh@joshmatthews.net>
> +
> +       Fix build error in Darwin port.
> +       * darwin-nat-info.c (darwin_debug_regions_recurse): New variable uiout.
> +
>  2011-08-21  Jan Kratochvil  <jan.kratochvil@redhat.com>
>
>        Code cleanup.
> --- src/gdb/darwin-nat-info.c   2011/03/18 14:22:34     1.15
> +++ src/gdb/darwin-nat-info.c   2011/08/23 19:40:50     1.16
> @@ -620,6 +620,7 @@
>   kern_return_t kret;
>   int ret;
>   struct cleanup *table_chain;
> +  struct ui_out *uiout = current_uiout;
>
>   table_chain = make_cleanup_ui_out_table_begin_end (uiout, 9, -1, "regions");
>
>

Re: [PATCH] Fix darwin build error

[Keith Seitz]

On 08/23/2011 01:47 PM, Josh Matthews wrote:
> It would be quite helpful if someone could put together a webpage
> that listed  [snip]

It's in gdb/CONTRIBUTE, available from the "contributing" link on the 
top of the gdb home page.

http://sourceware.org/gdb/contribute/

Keith

Re: [PATCH] Fix darwin build error

[Jan Kratochvil]

On Tue, 23 Aug 2011 22:47:01 +0200, Josh Matthews wrote:
> 1) what you do with a patch you've written (attach to a bug tracker?
> send to the list?)
> 2) how to format the email
> 3) how to do stuff related to copyright assignment
> 
> to make future contributions from newcomers easier.

gdb/CONTRIBUTE should describe those.

Depending on what you mean by "how to format the email", if you mean "code"
then the GDB code formatting is described by the courtesy of Pedro in:
	make -C gdb/doc gdbint.info; info '(gdb/doc/gdbint.info)Coding Standards'


Thanks,
Jan

Re: [PATCH] Fix darwin build error

[Sergio Durigan Junior]

Hi Josh,

Josh Matthews <josh@joshmatthews.net> writes:

> Thanks very much everybody. I couldn't find any good guideline for how
> to format the email (and especially the changelot entry) so I cribbed
> off of a random email that was sent recently. It would be quite
> helpful if someone could put together a webpage that listed

Ok, you did good, thanks for the patch.

> 1) what you do with a patch you've written (attach to a bug tracker?
> send to the list?)
> 2) how to format the email

As Jan already mentioned, you can find most of this information in
gdb/CONTRIBUTE.  Note that we also follow coding standards (Jan already
mentioned that, too).

> 3) how to do stuff related to copyright assignment

There is an entry abou this on gdb/CONTRIBUTE as well.

I may be wrong here, but in my understanding we take care of this issue
only when the person submits the patch (as you did).  I will forward the
procedure to you.

Thanks,

Sergio.

[PATCH] Fix Darwin build error

[Josh Matthews]

Darwin is busted again. Here's a fix.

Cheers,
Josh

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index daf970c..105e6e5 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2012-01-31  Josh Matthews  <josh@joshmatthews.net>
+
+       Fix build error in Darwin port.
+       * i386-darwin-nat.c: Include i386-nat.h.
+
 2012-01-31  Tom Tromey  <tromey@redhat.com>

        * language.h (struct language_defn) <la_iterate_over_symbols>: Fix
diff --git a/gdb/i386-darwin-nat.c b/gdb/i386-darwin-nat.c
index 12e2e65..a4f11e0 100644
--- a/gdb/i386-darwin-nat.c
+++ b/gdb/i386-darwin-nat.c
@@ -19,6 +19,7 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */

 #include "defs.h"
+#include "i386-nat.h"
 #include "frame.h"
 #include "inferior.h"
 #include "target.h"

Re: [PATCH] Fix Darwin build error

[Tristan Gingold]

On Jan 31, 2012, at 9:18 PM, Josh Matthews wrote:

> Darwin is busted again. Here's a fix.

Ok (and obvious).

Tristan.

> 
> Cheers,
> Josh
> 
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index daf970c..105e6e5 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,8 @@
> +2012-01-31  Josh Matthews  <josh@joshmatthews.net>
> +
> +       Fix build error in Darwin port.
> +       * i386-darwin-nat.c: Include i386-nat.h.
> +
> 2012-01-31  Tom Tromey  <tromey@redhat.com>
> 
>        * language.h (struct language_defn) <la_iterate_over_symbols>: Fix
> diff --git a/gdb/i386-darwin-nat.c b/gdb/i386-darwin-nat.c
> index 12e2e65..a4f11e0 100644
> --- a/gdb/i386-darwin-nat.c
> +++ b/gdb/i386-darwin-nat.c
> @@ -19,6 +19,7 @@
>    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
> 
> #include "defs.h"
> +#include "i386-nat.h"
> #include "frame.h"
> #include "inferior.h"
> #include "target.h"

Re: [PATCH] Fix Darwin build error

[Joel Brobecker]

Thank you, Josh.

> On Jan 31, 2012, at 9:18 PM, Josh Matthews wrote:
> 
> > Darwin is busted again. Here's a fix.
> 
> Ok (and obvious).

I applied the patch for you.

I noticed that you do not have a copyright assignment on file
with the FSF. For this change, it's OK because it is tiny and
obvious.  But if you would like to continue contributing to
the GDB project, you'll need one. The process is a little bit
on the long-ish side, so you might want to start it sooner
rather than later, if you're interested.

-- 
Joel