Re: [PATCH] Fix darwin build error

[Josh Matthews <josh@joshmatthews.net>]

Thanks very much everybody. I couldn't find any good guideline for how
to format the email (and especially the changelot entry) so I cribbed
off of a random email that was sent recently. It would be quite
helpful if someone could put together a webpage that listed

1) what you do with a patch you've written (attach to a bug tracker?
send to the list?)
2) how to format the email
3) how to do stuff related to copyright assignment

to make future contributions from newcomers easier.

Cheers,
Josh

On 23 August 2011 15:42, Jan Kratochvil <jan.kratochvil@redhat.com> wrote:
> On Tue, 23 Aug 2011 00:15:35 +0200, Sergio Durigan Junior wrote:
>> Also, I don't see your name on the MAINTAINERS file.  Do you have
>> copyright assignment from FSF?  I don't know what's the procedure on
>> these cases...  Maybe someone could commit the patch for you?
>
> I hope I made not assignment violation but I doubt this single-line "rename"
> change needs copyright assignment.  Still it would be sure great if there is
> one in place for future contributions, please contact Tom Tromey.
>
>
>> The `*' shouldn't be placed there.  This is the standard:
>>
>>     struct ui_out *uiout = current_uiout;
>
> I agree, I have checked in the patch below.
>
>
> Thanks,
> Jan
>
>
> http://sourceware.org/ml/gdb-cvs/2011-08/msg00099.html
>
> --- src/gdb/ChangeLog   2011/08/21 14:33:05     1.13274
> +++ src/gdb/ChangeLog   2011/08/23 19:40:48     1.13275
> @@ -1,3 +1,8 @@
> +2011-08-23  Josh Matthews  <josh@joshmatthews.net>
> +
> +       Fix build error in Darwin port.
> +       * darwin-nat-info.c (darwin_debug_regions_recurse): New variable uiout.
> +
>  2011-08-21  Jan Kratochvil  <jan.kratochvil@redhat.com>
>
>        Code cleanup.
> --- src/gdb/darwin-nat-info.c   2011/03/18 14:22:34     1.15
> +++ src/gdb/darwin-nat-info.c   2011/08/23 19:40:50     1.16
> @@ -620,6 +620,7 @@
>   kern_return_t kret;
>   int ret;
>   struct cleanup *table_chain;
> +  struct ui_out *uiout = current_uiout;
>
>   table_chain = make_cleanup_ui_out_table_begin_end (uiout, 9, -1, "regions");
>
>