From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21712 invoked by alias); 23 Aug 2011 20:47:41 -0000 Received: (qmail 21699 invoked by uid 22791); 23 Aug 2011 20:47:38 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-pz0-f44.google.com (HELO mail-pz0-f44.google.com) (209.85.210.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Aug 2011 20:47:21 +0000 Received: by pzk36 with SMTP id 36so99750pzk.3 for ; Tue, 23 Aug 2011 13:47:21 -0700 (PDT) Received: by 10.142.48.10 with SMTP id v10mr2341810wfv.185.1314132441055; Tue, 23 Aug 2011 13:47:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.65.134 with HTTP; Tue, 23 Aug 2011 13:47:01 -0700 (PDT) In-Reply-To: <20110823194241.GA31319@host1.jankratochvil.net> References: <20110823194241.GA31319@host1.jankratochvil.net> From: Josh Matthews Date: Tue, 23 Aug 2011 20:47:00 -0000 Message-ID: Subject: Re: [PATCH] Fix darwin build error To: Jan Kratochvil Cc: Sergio Durigan Junior , gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00426.txt.bz2 Thanks very much everybody. I couldn't find any good guideline for how to format the email (and especially the changelot entry) so I cribbed off of a random email that was sent recently. It would be quite helpful if someone could put together a webpage that listed 1) what you do with a patch you've written (attach to a bug tracker? send to the list?) 2) how to format the email 3) how to do stuff related to copyright assignment to make future contributions from newcomers easier. Cheers, Josh On 23 August 2011 15:42, Jan Kratochvil wrote: > On Tue, 23 Aug 2011 00:15:35 +0200, Sergio Durigan Junior wrote: >> Also, I don't see your name on the MAINTAINERS file. =A0Do you have >> copyright assignment from FSF? =A0I don't know what's the procedure on >> these cases... =A0Maybe someone could commit the patch for you? > > I hope I made not assignment violation but I doubt this single-line "rena= me" > change needs copyright assignment. =A0Still it would be sure great if the= re is > one in place for future contributions, please contact Tom Tromey. > > >> The `*' shouldn't be placed there. =A0This is the standard: >> >> =A0 =A0 struct ui_out *uiout =3D current_uiout; > > I agree, I have checked in the patch below. > > > Thanks, > Jan > > > http://sourceware.org/ml/gdb-cvs/2011-08/msg00099.html > > --- src/gdb/ChangeLog =A0 2011/08/21 14:33:05 =A0 =A0 1.13274 > +++ src/gdb/ChangeLog =A0 2011/08/23 19:40:48 =A0 =A0 1.13275 > @@ -1,3 +1,8 @@ > +2011-08-23 =A0Josh Matthews =A0 > + > + =A0 =A0 =A0 Fix build error in Darwin port. > + =A0 =A0 =A0 * darwin-nat-info.c (darwin_debug_regions_recurse): New var= iable uiout. > + > =A02011-08-21 =A0Jan Kratochvil =A0 > > =A0 =A0 =A0 =A0Code cleanup. > --- src/gdb/darwin-nat-info.c =A0 2011/03/18 14:22:34 =A0 =A0 1.15 > +++ src/gdb/darwin-nat-info.c =A0 2011/08/23 19:40:50 =A0 =A0 1.16 > @@ -620,6 +620,7 @@ > =A0 kern_return_t kret; > =A0 int ret; > =A0 struct cleanup *table_chain; > + =A0struct ui_out *uiout =3D current_uiout; > > =A0 table_chain =3D make_cleanup_ui_out_table_begin_end (uiout, 9, -1, "r= egions"); > >