Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Josh Matthews <josh@joshmatthews.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix darwin build error
Date: Tue, 23 Aug 2011 19:43:00 -0000	[thread overview]
Message-ID: <20110823194241.GA31319@host1.jankratochvil.net> (raw)
In-Reply-To: <m3r54d3xfc.fsf@redhat.com>

On Tue, 23 Aug 2011 00:15:35 +0200, Sergio Durigan Junior wrote:
> Also, I don't see your name on the MAINTAINERS file.  Do you have
> copyright assignment from FSF?  I don't know what's the procedure on
> these cases...  Maybe someone could commit the patch for you?

I hope I made not assignment violation but I doubt this single-line "rename"
change needs copyright assignment.  Still it would be sure great if there is
one in place for future contributions, please contact Tom Tromey.


> The `*' shouldn't be placed there.  This is the standard:
> 
>     struct ui_out *uiout = current_uiout;

I agree, I have checked in the patch below.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2011-08/msg00099.html

--- src/gdb/ChangeLog	2011/08/21 14:33:05	1.13274
+++ src/gdb/ChangeLog	2011/08/23 19:40:48	1.13275
@@ -1,3 +1,8 @@
+2011-08-23  Josh Matthews  <josh@joshmatthews.net>
+
+	Fix build error in Darwin port.
+	* darwin-nat-info.c (darwin_debug_regions_recurse): New variable uiout.
+
 2011-08-21  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	Code cleanup.
--- src/gdb/darwin-nat-info.c	2011/03/18 14:22:34	1.15
+++ src/gdb/darwin-nat-info.c	2011/08/23 19:40:50	1.16
@@ -620,6 +620,7 @@
   kern_return_t kret;
   int ret;
   struct cleanup *table_chain;
+  struct ui_out *uiout = current_uiout;
 
   table_chain = make_cleanup_ui_out_table_begin_end (uiout, 9, -1, "regions");
 


  reply	other threads:[~2011-08-23 19:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22 20:27 Josh Matthews
2011-08-22 22:16 ` Sergio Durigan Junior
2011-08-23 19:43   ` Jan Kratochvil [this message]
2011-08-23 20:47     ` Josh Matthews
2011-08-23 20:53       ` Keith Seitz
2011-08-23 20:57       ` Jan Kratochvil
2011-08-23 22:06       ` Sergio Durigan Junior
2012-01-31 22:00 [PATCH] Fix Darwin " Josh Matthews
2012-02-01  9:27 ` Tristan Gingold
2012-02-01 10:56   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110823194241.GA31319@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=josh@joshmatthews.net \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox