From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 532 invoked by alias); 23 Aug 2011 19:43:07 -0000 Received: (qmail 521 invoked by uid 22791); 23 Aug 2011 19:43:06 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Aug 2011 19:42:47 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7NJgkqE006817 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 23 Aug 2011 15:42:46 -0400 Received: from host1.jankratochvil.net (ovpn-116-42.ams2.redhat.com [10.36.116.42]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7NJgi2K020732 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 23 Aug 2011 15:42:45 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p7NJghkV000603; Tue, 23 Aug 2011 21:42:43 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p7NJggPV000595; Tue, 23 Aug 2011 21:42:42 +0200 Date: Tue, 23 Aug 2011 19:43:00 -0000 From: Jan Kratochvil To: Sergio Durigan Junior Cc: Josh Matthews , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix darwin build error Message-ID: <20110823194241.GA31319@host1.jankratochvil.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00423.txt.bz2 On Tue, 23 Aug 2011 00:15:35 +0200, Sergio Durigan Junior wrote: > Also, I don't see your name on the MAINTAINERS file. Do you have > copyright assignment from FSF? I don't know what's the procedure on > these cases... Maybe someone could commit the patch for you? I hope I made not assignment violation but I doubt this single-line "rename" change needs copyright assignment. Still it would be sure great if there is one in place for future contributions, please contact Tom Tromey. > The `*' shouldn't be placed there. This is the standard: > > struct ui_out *uiout = current_uiout; I agree, I have checked in the patch below. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2011-08/msg00099.html --- src/gdb/ChangeLog 2011/08/21 14:33:05 1.13274 +++ src/gdb/ChangeLog 2011/08/23 19:40:48 1.13275 @@ -1,3 +1,8 @@ +2011-08-23 Josh Matthews + + Fix build error in Darwin port. + * darwin-nat-info.c (darwin_debug_regions_recurse): New variable uiout. + 2011-08-21 Jan Kratochvil Code cleanup. --- src/gdb/darwin-nat-info.c 2011/03/18 14:22:34 1.15 +++ src/gdb/darwin-nat-info.c 2011/08/23 19:40:50 1.16 @@ -620,6 +620,7 @@ kern_return_t kret; int ret; struct cleanup *table_chain; + struct ui_out *uiout = current_uiout; table_chain = make_cleanup_ui_out_table_begin_end (uiout, 9, -1, "regions");