From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83154-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16726 invoked by alias); 22 Aug 2011 22:16:08 -0000
Received: (qmail 16717 invoked by uid 22791); 22 Aug 2011 22:16:07 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Aug 2011 22:15:50 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7MMFmF1004942	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 22 Aug 2011 18:15:48 -0400
Received: from psique ([10.3.112.13])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7MMFe24012370;	Mon, 22 Aug 2011 18:15:44 -0400
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Josh Matthews <josh@joshmatthews.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix darwin build error
References: <CAOvJiVUJT4Q5K0Od1MMci1grP-dND+9xRGy-FEXeVNPuRfv7iA@mail.gmail.com>
Date: Mon, 22 Aug 2011 22:16:00 -0000
In-Reply-To: <CAOvJiVUJT4Q5K0Od1MMci1grP-dND+9xRGy-FEXeVNPuRfv7iA@mail.gmail.com>	(Josh Matthews's message of "Mon, 22 Aug 2011 16:19:25 -0400")
Message-ID: <m3r54d3xfc.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00414.txt.bz2

Hello Josh,

Josh Matthews <josh@joshmatthews.net> writes:

> I hope this is the right way to do this. GDB currently doesn't build
> on darwin, and this patch makes it do so.

Thanks for this.  There are some nits, though.

Also, I don't see your name on the MAINTAINERS file.  Do you have
copyright assignment from FSF?  I don't know what's the procedure on
these cases...  Maybe someone could commit the patch for you?

> gdb/
> 2011-08-22  Josh Matthews  <josh@joshmatthews.net>
>
> 	Fix build error in darwin port.

You have to cite the file.  Also, I believe you could be more
descriptive on the message.  Something like:

        * darwin-nat-info.c (darwin_debug_regions_recurse): Replacing
          `uiout' by `current_uiout', fixing build error.

> --- a/gdb/darwin-nat-info.c
> +++ b/gdb/darwin-nat-info.c
> @@ -620,6 +620,7 @@ darwin_debug_regions_recurse (task_t task)
>    kern_return_t kret;
>    int ret;
>    struct cleanup *table_chain;
> +  struct ui_out* uiout = current_uiout;

The `*' shouldn't be placed there.  This is the standard:

    struct ui_out *uiout = current_uiout;

I think the current approach is to actually replace the occurrences of
`uiout' by `current_uiout', but I don't mind having a local `uiout'
variable.

Regards,

Sergio.