* [PATCH 7/7] Enables gdb.reverse testsuite for aarch64*-linux targets
2014-06-04 16:21 [PATCH 0/7] Process record and reverse debugging support on aarch64-linux Omair Javaid
@ 2014-06-04 16:21 ` Omair Javaid
2014-06-05 9:00 ` Will Newton
2014-06-04 16:21 ` [PATCH 4/7] Implements aarch64 process record and reverse debugging support Omair Javaid
` (7 subsequent siblings)
8 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-06-04 16:21 UTC (permalink / raw)
To: gdb-patches; +Cc: Omair Javaid
This patch enables gdb.reverse testsuite for aarch64*-linux targets.
gdb/testsuite:
2014-06-04 Omair Javaid <omair.javaid@linaro.org>
* lib/gdb.exp (supports_process_record): Return true for aarch64*-linux*.
(supports_reverse): Likewise.
---
gdb/testsuite/lib/gdb.exp | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 30463a9..7f51fb0 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -1834,8 +1834,8 @@ proc supports_process_record {} {
return [target_info gdb,use_precord]
}
- if { [istarget "arm*-*-linux*"] || [istarget "x86_64-*-linux*"]
- || [istarget "i\[34567\]86-*-linux*"] } {
+ if { [istarget "aarch64*-*-linux*"] || [istarget "arm*-*-linux*"] ||
+ [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } {
return 1
}
@@ -1850,8 +1850,8 @@ proc supports_reverse {} {
return [target_info gdb,can_reverse]
}
- if { [istarget "arm*-*-linux*"] || [istarget "x86_64-*-linux*"]
- || [istarget "i\[34567\]86-*-linux*"] } {
+ if { [istarget "aarch64*-*-linux*"] || [istarget "arm*-*-linux*"] ||
+ [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } {
return 1
}
--
1.9.1
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 7/7] Enables gdb.reverse testsuite for aarch64*-linux targets
2014-06-04 16:21 ` [PATCH 7/7] Enables gdb.reverse testsuite for aarch64*-linux targets Omair Javaid
@ 2014-06-05 9:00 ` Will Newton
2014-10-21 9:10 ` Omair Javaid
0 siblings, 1 reply; 53+ messages in thread
From: Will Newton @ 2014-06-05 9:00 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
On 4 June 2014 17:21, Omair Javaid <omair.javaid@linaro.org> wrote:
> This patch enables gdb.reverse testsuite for aarch64*-linux targets.
>
> gdb/testsuite:
>
> 2014-06-04 Omair Javaid <omair.javaid@linaro.org>
>
> * lib/gdb.exp (supports_process_record): Return true for aarch64*-linux*.
> (supports_reverse): Likewise.
>
> ---
> gdb/testsuite/lib/gdb.exp | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Looks OK to me.
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 30463a9..7f51fb0 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -1834,8 +1834,8 @@ proc supports_process_record {} {
> return [target_info gdb,use_precord]
> }
>
> - if { [istarget "arm*-*-linux*"] || [istarget "x86_64-*-linux*"]
> - || [istarget "i\[34567\]86-*-linux*"] } {
> + if { [istarget "aarch64*-*-linux*"] || [istarget "arm*-*-linux*"] ||
> + [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } {
> return 1
> }
>
> @@ -1850,8 +1850,8 @@ proc supports_reverse {} {
> return [target_info gdb,can_reverse]
> }
>
> - if { [istarget "arm*-*-linux*"] || [istarget "x86_64-*-linux*"]
> - || [istarget "i\[34567\]86-*-linux*"] } {
> + if { [istarget "aarch64*-*-linux*"] || [istarget "arm*-*-linux*"] ||
> + [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } {
> return 1
> }
>
> --
> 1.9.1
>
--
Will Newton
Toolchain Working Group, Linaro
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 7/7] Enables gdb.reverse testsuite for aarch64*-linux targets
2014-06-05 9:00 ` Will Newton
@ 2014-10-21 9:10 ` Omair Javaid
0 siblings, 0 replies; 53+ messages in thread
From: Omair Javaid @ 2014-10-21 9:10 UTC (permalink / raw)
To: Will Newton; +Cc: gdb-patches
On 05/06/2014 14:00, Will Newton wrote:
> On 4 June 2014 17:21, Omair Javaid <omair.javaid@linaro.org> wrote:
>> This patch enables gdb.reverse testsuite for aarch64*-linux targets.
>>
>> gdb/testsuite:
>>
>> 2014-06-04 Omair Javaid <omair.javaid@linaro.org>
>>
>> * lib/gdb.exp (supports_process_record): Return true for aarch64*-linux*.
>> (supports_reverse): Likewise.
>>
>> ---
>> gdb/testsuite/lib/gdb.exp | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Looks OK to me.
>
>> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
>> index 30463a9..7f51fb0 100644
>> --- a/gdb/testsuite/lib/gdb.exp
>> +++ b/gdb/testsuite/lib/gdb.exp
>> @@ -1834,8 +1834,8 @@ proc supports_process_record {} {
>> return [target_info gdb,use_precord]
>> }
>>
>> - if { [istarget "arm*-*-linux*"] || [istarget "x86_64-*-linux*"]
>> - || [istarget "i\[34567\]86-*-linux*"] } {
>> + if { [istarget "aarch64*-*-linux*"] || [istarget "arm*-*-linux*"] ||
>> + [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } {
>> return 1
>> }
>>
>> @@ -1850,8 +1850,8 @@ proc supports_reverse {} {
>> return [target_info gdb,can_reverse]
>> }
>>
>> - if { [istarget "arm*-*-linux*"] || [istarget "x86_64-*-linux*"]
>> - || [istarget "i\[34567\]86-*-linux*"] } {
>> + if { [istarget "aarch64*-*-linux*"] || [istarget "arm*-*-linux*"] ||
>> + [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } {
>> return 1
>> }
>>
>> --
>> 1.9.1
>>
>
>
>
ping!
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH 4/7] Implements aarch64 process record and reverse debugging support
2014-06-04 16:21 [PATCH 0/7] Process record and reverse debugging support on aarch64-linux Omair Javaid
2014-06-04 16:21 ` [PATCH 7/7] Enables gdb.reverse testsuite for aarch64*-linux targets Omair Javaid
@ 2014-06-04 16:21 ` Omair Javaid
2014-06-05 8:34 ` Will Newton
2014-08-30 3:27 ` Yao Qi
2014-06-04 16:21 ` [PATCH 1/7] NEWS entry about aarch64-linux record/replay support Omair Javaid
` (6 subsequent siblings)
8 siblings, 2 replies; 53+ messages in thread
From: Omair Javaid @ 2014-06-04 16:21 UTC (permalink / raw)
To: gdb-patches; +Cc: Omair Javaid
This patch defines structures, macros and functions required for process record
and reverse debugging support on aarch64-linux targets. Also implements
support for recording most if not all of instructions from a64 instruction set.
gdb:
2014-06-04 Omair Javaid <omair.javaid@linaro.org>
* aarch64-linux-tdep.c (aarch64_linux_init_abi): Updated.
* aarch64-tdep.c (record.h): Include.
(record-full.h): Include.
(aarch64_record_data_proc_reg): New function.
(aarch64_record_data_proc_imm): New function.
(aarch64_record_branch_except_sys): New function.
(aarch64_record_load_store): New function.
(aarch64_record_decode_insn_handler): New function.
(deallocate_reg_mem): New function.
(aarch64_process_record): New function.
* aarch64-tdep.h (submask): New macro.
(bit): New macro.
(bits): New macro.
(REG_ALLOC): New macro.
(MEM_ALLOC): New macro.
(struct aarch64_mem_r): Defined.
(aarch64_record_result): New enum.
(struct insn_decode_record): Defined.
(insn_decode_record): New typedef.
(aarch64_process_record): New extern declaration.
---
gdb/aarch64-linux-tdep.c | 3 +
gdb/aarch64-tdep.c | 517 +++++++++++++++++++++++++++++++++++++++++++++++
gdb/aarch64-tdep.h | 65 ++++++
3 files changed, 585 insertions(+)
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index b285818..dece0c3 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -468,6 +468,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
set_gdbarch_stap_is_single_operand (gdbarch, aarch64_stap_is_single_operand);
set_gdbarch_stap_parse_special_token (gdbarch,
aarch64_stap_parse_special_token);
+
+ /* Reversible debugging, process record. */
+ set_gdbarch_process_record (gdbarch, aarch64_process_record);
}
/* Provide a prototype to silence -Wmissing-prototypes. */
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index 4abe36e..bb533b2 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -52,6 +52,9 @@
#include "gdb_assert.h"
#include "vec.h"
+#include "record.h"
+#include "record-full.h"
+
#include "features/aarch64.c"
/* Pseudo register base numbers. */
@@ -2806,3 +2809,517 @@ When on, AArch64 specific debugging is enabled."),
show_aarch64_debug,
&setdebuglist, &showdebuglist);
}
+
+/* Record handler for data processing - register instructions. */
+static unsigned int
+aarch64_record_data_proc_reg (insn_decode_record *aarch64_insn_r)
+{
+ uint8_t reg_rd, insn_bits24_27, insn_bits21_23, setflags;
+ uint32_t record_buf[4];
+
+ reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
+ insn_bits21_23 = bits (aarch64_insn_r->aarch64_insn, 21, 23);
+
+ if (!bit (aarch64_insn_r->aarch64_insn, 28))
+ {
+ /* Logical (shifted register). */
+ if (insn_bits24_27 == 0x0a)
+ setflags = (bits (aarch64_insn_r->aarch64_insn, 29, 30) == 0x03);
+ /* Add/subtract. */
+ else if (insn_bits24_27 == 0x0b)
+ setflags = bit (aarch64_insn_r->aarch64_insn, 29);
+ else
+ return AARCH64_RECORD_USUPPORTED;
+
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ if (setflags)
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
+ }
+ else
+ {
+ if (insn_bits24_27 == 0x0b)
+ {
+ /* Data-processing (3 source). */
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ else if (insn_bits24_27 == 0x0a)
+ {
+ if (insn_bits21_23 == 0x00)
+ {
+ /* Add/subtract (with carry). */
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ if (bit (aarch64_insn_r->aarch64_insn, 29))
+ {
+ record_buf[1] = AARCH64_CPSR_REGNUM;
+ aarch64_insn_r->reg_rec_count = 2;
+ }
+ }
+ else if (insn_bits21_23 == 0x02)
+ {
+ /* Conditional compare (register) / Conditional compare (immediate). */
+ record_buf[0] = AARCH64_CPSR_REGNUM;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ else if (insn_bits21_23 == 0x04 || insn_bits21_23 == 0x06)
+ {
+ /* CConditional select. */
+ /* Data-processing (2 source). */
+ /* Data-processing (1 source). */
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ else
+ return AARCH64_RECORD_USUPPORTED;
+ }
+ }
+
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+
+/* Record handler for data processing - immediate instructions. */
+static unsigned int
+aarch64_record_data_proc_imm (insn_decode_record *aarch64_insn_r)
+{
+ uint8_t reg_rd, insn_bit28, insn_bit23, insn_bits24_27, setflags;
+ uint32_t record_buf[4];
+
+ reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ insn_bit28 = bit (aarch64_insn_r->aarch64_insn, 28);
+ insn_bit23 = bit (aarch64_insn_r->aarch64_insn, 23);
+ insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
+
+ /*PC rel addressing / Move wide immediate / BitField / Extract. */
+ if (insn_bits24_27 == 0x00 || insn_bits24_27 == 0x03 ||
+ (insn_bits24_27 == 0x02 && insn_bit23))
+ {
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ else if (insn_bits24_27 == 0x01)
+ {
+ /* Add/Subtract (immediate). */
+ setflags = bit (aarch64_insn_r->aarch64_insn, 29);
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ if (setflags)
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
+ }
+ else if (insn_bits24_27 == 0x02 && !insn_bit23)
+ {
+ /* Logical (immediate). */
+ setflags = bits (aarch64_insn_r->aarch64_insn, 29, 30) == 0x03;
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ if (setflags)
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
+ }
+ else
+ return AARCH64_RECORD_USUPPORTED;
+
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+
+/* Record handler for branch, exception generation and system instructions. */
+static unsigned int
+aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
+{
+ struct gdbarch_tdep *tdep = gdbarch_tdep (aarch64_insn_r->gdbarch);
+ uint8_t insn_bits24_27, insn_bits28_31, insn_bits22_23;
+ uint32_t record_buf[4];
+
+ insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
+ insn_bits28_31 = bits (aarch64_insn_r->aarch64_insn, 28, 31);
+ insn_bits22_23 = bits (aarch64_insn_r->aarch64_insn, 22, 23);
+
+ if (insn_bits28_31 == 0x0d)
+ {
+ /* Exception generation instructions. */
+ if (insn_bits24_27 == 0x04)
+ return AARCH64_RECORD_USUPPORTED;
+ /* System instructions. */
+ else if (insn_bits24_27 == 0x05 && insn_bits22_23 == 0x00)
+ {
+ record_buf[0] = AARCH64_CPSR_REGNUM;
+ record_buf[1] = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ aarch64_insn_r->reg_rec_count = 2;
+ }
+ else if((insn_bits24_27 & 0x0e) == 0x06)
+ {
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
+ if (bits (aarch64_insn_r->aarch64_insn, 21, 22) == 0x01)
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_LR_REGNUM;
+ }
+ else
+ return AARCH64_RECORD_USUPPORTED;
+ }
+ else if ((insn_bits28_31 & 0x07) == 0x01 && (insn_bits24_27 & 0x0c) == 0x04)
+ {
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
+ if (bit (aarch64_insn_r->aarch64_insn, 31))
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_LR_REGNUM;
+ }
+ else
+ /* All other types of branch instructions. */
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
+
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+
+/* Record handler for load and store instructions. */
+static unsigned int
+aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
+{
+ uint8_t insn_bits24_27, insn_bits28_29, insn_bits10_11;
+ uint8_t insn_bit23, insn_bit21;
+ uint8_t opc, size_bits, ld_flag, vector_flag;
+ uint32_t reg_rn, reg_rt, reg_rt2;
+ uint64_t datasize, offset;
+ uint32_t record_buf[8];
+ uint64_t record_buf_mem[8];
+ CORE_ADDR address;
+
+ insn_bits10_11 = bits (aarch64_insn_r->aarch64_insn, 10, 11);
+ insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
+ insn_bits28_29 = bits (aarch64_insn_r->aarch64_insn, 28, 29);
+ insn_bit21 = bit (aarch64_insn_r->aarch64_insn, 21);
+ insn_bit23 = bit (aarch64_insn_r->aarch64_insn, 23);
+ ld_flag = bit (aarch64_insn_r->aarch64_insn, 22);
+ vector_flag = bit (aarch64_insn_r->aarch64_insn, 26);
+ reg_rt = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ reg_rn = bits (aarch64_insn_r->aarch64_insn, 5, 9);
+ reg_rt2 = bits (aarch64_insn_r->aarch64_insn, 10, 14);
+ size_bits = bits (aarch64_insn_r->aarch64_insn, 30, 31);
+
+ /* Load/store exclusive instructions decoding. */
+ if (insn_bits24_27 == 0x08 && insn_bits28_29 == 0x00)
+ {
+ if (ld_flag)
+ {
+ record_buf[0] = reg_rt;
+ aarch64_insn_r->reg_rec_count = 1;
+ if (insn_bit21)
+ {
+ record_buf[1] = reg_rt2;
+ aarch64_insn_r->reg_rec_count = 2;
+ }
+ }
+ else
+ {
+ if (insn_bit21)
+ datasize = (8 << size_bits) * 2;
+ else
+ datasize = (8 << size_bits);
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
+ &address);
+ record_buf_mem[0] = datasize / 8;
+ record_buf_mem[1] = address;
+ aarch64_insn_r->mem_rec_count = 1;
+ if (!insn_bit23)
+ {
+ /* Save register rs. */
+ record_buf[0] = bits (aarch64_insn_r->aarch64_insn, 16, 20);
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ }
+ }
+ /* Load register (literal) instructions decoding. */
+ else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x01)
+ {
+ if (vector_flag)
+ record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
+ else
+ record_buf[0] = reg_rt;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ /* All types of load/store pair instructions decoding. */
+ else if ((insn_bits24_27 & 0x0a) == 0x08 && insn_bits28_29 == 0x02)
+ {
+ if (ld_flag)
+ {
+ if (vector_flag)
+ {
+ record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
+ record_buf[1] = reg_rt2 + AARCH64_V0_REGNUM;
+ }
+ else
+ {
+ record_buf[0] = reg_rt;
+ record_buf[1] = reg_rt2;
+ }
+ aarch64_insn_r->reg_rec_count = 2;
+ }
+ else
+ {
+ uint16_t imm7_off;
+ imm7_off = bits (aarch64_insn_r->aarch64_insn, 15, 21);
+ if (!vector_flag)
+ size_bits = size_bits >> 1;
+ datasize = 8 << (2 + size_bits);
+ offset = (imm7_off & 0x40) ? (((~imm7_off) & 0x007f) + 1) : imm7_off;
+ offset = offset << (2 + size_bits);
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
+ &address);
+ if (!((insn_bits24_27 & 0x0b) == 0x08 && insn_bit23))
+ {
+ if (imm7_off & 0x40)
+ address = address - offset;
+ else
+ address = address + offset;
+ }
+
+ record_buf_mem[0] = datasize / 8;
+ record_buf_mem[1] = address;
+ record_buf_mem[2] = datasize / 8;
+ record_buf_mem[3] = address + (datasize / 8);
+ aarch64_insn_r->mem_rec_count = 2;
+ }
+ if (bit (aarch64_insn_r->aarch64_insn, 23))
+ record_buf[aarch64_insn_r->reg_rec_count++] = reg_rn;
+ }
+ /* Load/store register (unsigned immediate) instructions. */
+ else if ((insn_bits24_27 & 0x0b) == 0x09 && insn_bits28_29 == 0x03)
+ {
+ opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
+ if (!(opc >> 1))
+ if (opc & 0x01)
+ ld_flag = 0x01;
+ else
+ ld_flag = 0x0;
+ else
+ if (size_bits != 0x03)
+ ld_flag = 0x01;
+ else
+ return AARCH64_RECORD_USUPPORTED;
+
+ if (!ld_flag)
+ {
+ offset = bits (aarch64_insn_r->aarch64_insn, 10, 21);
+ datasize = 8 << size_bits;
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
+ &address);
+ offset = offset << size_bits;
+ address = address + offset;
+
+ record_buf_mem[0] = datasize >> 3;
+ record_buf_mem[1] = address;
+ aarch64_insn_r->mem_rec_count = 1;
+ }
+ else
+ {
+ if (vector_flag)
+ record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
+ else
+ record_buf[0] = reg_rt;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ }
+ /* Load/store register (register offset) instructions. */
+ else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 &&
+ insn_bits10_11 == 0x02 && insn_bit21)
+ {
+ opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
+ if (!(opc >> 1))
+ if (opc & 0x01)
+ ld_flag = 0x01;
+ else
+ ld_flag = 0x0;
+ else
+ if (size_bits != 0x03)
+ ld_flag = 0x01;
+ else
+ return AARCH64_RECORD_USUPPORTED;
+
+ if (!ld_flag)
+ {
+ uint64_t reg_rm_val;
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache,
+ bits (aarch64_insn_r->aarch64_insn, 16, 20), ®_rm_val);
+ if (bit (aarch64_insn_r->aarch64_insn, 12))
+ offset = reg_rm_val << size_bits;
+ else
+ offset = reg_rm_val;
+ datasize = 8 << size_bits;
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
+ &address);
+ address = address + offset;
+ record_buf_mem[0] = datasize >> 3;
+ record_buf_mem[1] = address;
+ aarch64_insn_r->mem_rec_count = 1;
+ }
+ else
+ {
+ if (vector_flag)
+ record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
+ else
+ record_buf[0] = reg_rt;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ }
+ /* Load/store register (immediate) instructions. */
+ else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 &&
+ !insn_bit21)
+ {
+ opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
+ if (!(opc >> 1))
+ if (opc & 0x01)
+ ld_flag = 0x01;
+ else
+ ld_flag = 0x0;
+ else
+ if (size_bits != 0x03)
+ ld_flag = 0x01;
+ else
+ return AARCH64_RECORD_USUPPORTED;
+
+ if (!ld_flag)
+ {
+ uint16_t imm9_off;
+ imm9_off = bits (aarch64_insn_r->aarch64_insn, 12, 20);
+ offset = (imm9_off & 0x0100) ? (((~imm9_off) & 0x01ff) + 1) : imm9_off;
+ datasize = 8 << size_bits;
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
+ &address);
+ if (insn_bits10_11 != 0x01)
+ {
+ if (imm9_off & 0x0100)
+ address = address - offset;
+ else
+ address = address + offset;
+ }
+ record_buf_mem[0] = datasize >> 3;
+ record_buf_mem[1] = address;
+ aarch64_insn_r->mem_rec_count = 1;
+ }
+ else
+ {
+ if (vector_flag)
+ record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
+ else
+ record_buf[0] = reg_rt;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ if (insn_bits10_11 == 0x01 || insn_bits10_11 == 0x03)
+ record_buf[aarch64_insn_r->reg_rec_count++] = reg_rn;
+ }
+ /* Advanced SIMD load/store instructions. */
+ else
+ return AARCH64_RECORD_USUPPORTED;
+
+ MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count,
+ record_buf_mem);
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+/* Decodes thumb2 instruction type and invokes its record handler. */
+
+static unsigned int
+aarch64_record_decode_insn_handler (insn_decode_record *aarch64_insn_r)
+{
+ uint32_t ins_bit25, ins_bit26, ins_bit27, ins_bit28;
+
+ ins_bit25 = bit (aarch64_insn_r->aarch64_insn, 25);
+ ins_bit26 = bit (aarch64_insn_r->aarch64_insn, 26);
+ ins_bit27 = bit (aarch64_insn_r->aarch64_insn, 27);
+ ins_bit28 = bit (aarch64_insn_r->aarch64_insn, 28);
+
+ /* Data processing - immediate instructions. */
+ if (!ins_bit26 && !ins_bit27 && ins_bit28)
+ return aarch64_record_data_proc_imm (aarch64_insn_r);
+
+ /* Branch, exception generation and system instructions. */
+ if (ins_bit26 && !ins_bit27 && ins_bit28)
+ return aarch64_record_branch_except_sys (aarch64_insn_r);
+
+ /* Load and store instructions. */
+ if (!ins_bit25 && ins_bit27)
+ return aarch64_record_load_store (aarch64_insn_r);
+
+ /* Data processing - register instructions. */
+ if (ins_bit25 && !ins_bit26 && ins_bit27)
+ return aarch64_record_data_proc_reg (aarch64_insn_r);
+
+ /* Data processing - SIMD and floating point instructions. */
+ if (ins_bit25 && ins_bit26 && ins_bit27)
+ return AARCH64_RECORD_USUPPORTED;
+
+ return AARCH64_RECORD_USUPPORTED;
+}
+
+/* Cleans up local record registers and memory allocations. */
+
+static void
+deallocate_reg_mem (insn_decode_record *record)
+{
+ xfree (record->aarch64_regs);
+ xfree (record->aarch64_mems);
+}
+
+/* Parse the current instruction and record the values of the registers and
+ memory that will be changed in current instruction to record_arch_list".
+ Return -1 if something is wrong. */
+
+int
+aarch64_process_record (struct gdbarch *gdbarch, struct regcache *regcache,
+ CORE_ADDR insn_addr)
+{
+ uint32_t rec_no = 0;
+ uint8_t insn_size = 4;
+ uint32_t ret = 0;
+ ULONGEST t_bit = 0, insn_id = 0;
+ gdb_byte buf[insn_size];
+ insn_decode_record aarch64_record;
+
+ memset (&buf[0], 0, insn_size);
+ memset (&aarch64_record, 0, sizeof (insn_decode_record));
+ target_read_memory (insn_addr, &buf[0], insn_size);
+ aarch64_record.aarch64_insn = (uint32_t) extract_unsigned_integer (&buf[0],
+ insn_size, gdbarch_byte_order (gdbarch));
+ aarch64_record.regcache = regcache;
+ aarch64_record.this_addr = insn_addr;
+ aarch64_record.gdbarch = gdbarch;
+
+ ret = aarch64_record_decode_insn_handler (&aarch64_record);
+ if (ret == AARCH64_RECORD_USUPPORTED)
+ {
+ printf_unfiltered (_("Process record does not support instruction "
+ "0x%0x at address %s.\n"),aarch64_record.aarch64_insn,
+ paddress (gdbarch, insn_addr));
+ ret = -1;
+ }
+
+ if (0 == ret)
+ {
+ /* Record registers. */
+ record_full_arch_list_add_reg (aarch64_record.regcache, AARCH64_PC_REGNUM);
+ if (aarch64_record.aarch64_regs)
+ for (rec_no = 0; rec_no < aarch64_record.reg_rec_count; rec_no++)
+ if (record_full_arch_list_add_reg (aarch64_record.regcache,
+ aarch64_record.aarch64_regs[rec_no]))
+ ret = -1;
+
+ /* Record memories. */
+ if (aarch64_record.aarch64_mems)
+ for (rec_no = 0; rec_no < aarch64_record.mem_rec_count; rec_no++)
+ if (record_full_arch_list_add_mem
+ ((CORE_ADDR)aarch64_record.aarch64_mems[rec_no].addr,
+ aarch64_record.aarch64_mems[rec_no].len))
+ ret = -1;
+
+ if (record_full_arch_list_add_end ())
+ ret = -1;
+ }
+
+ deallocate_reg_mem (&aarch64_record);
+ return ret;
+}
diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
index 78fb779..8a193f4 100644
--- a/gdb/aarch64-tdep.h
+++ b/gdb/aarch64-tdep.h
@@ -90,4 +90,69 @@ struct gdbarch_tdep
struct type *vnb_type;
};
+/* aarch64 process record-replay related structures, defines etc. */
+
+#define submask(x) ((1L << ((x) + 1)) - 1)
+#define bit(obj,st) (((obj) >> (st)) & 1)
+#define bits(obj,st,fn) (((obj) >> (st)) & submask ((fn) - (st)))
+
+#define REG_ALLOC(REGS, LENGTH, RECORD_BUF) \
+ do \
+ { \
+ unsigned int reg_len = LENGTH; \
+ if (reg_len) \
+ { \
+ REGS = XNEWVEC (uint32_t, reg_len); \
+ memcpy(®S[0], &RECORD_BUF[0], sizeof(uint32_t)*LENGTH); \
+ } \
+ } \
+ while (0)
+
+#define MEM_ALLOC(MEMS, LENGTH, RECORD_BUF) \
+ do \
+ { \
+ unsigned int mem_len = LENGTH; \
+ if (mem_len) \
+ { \
+ MEMS = XNEWVEC (struct aarch64_mem_r, mem_len); \
+ memcpy(&MEMS->len, &RECORD_BUF[0], \
+ sizeof(struct aarch64_mem_r) * LENGTH); \
+ } \
+ } \
+ while (0)
+
+/* ARM memory record structure. */
+struct aarch64_mem_r
+{
+ uint64_t len; /* Record length. */
+ uint64_t addr; /* Memory address. */
+};
+
+enum aarch64_record_result
+{
+ AARCH64_RECORD_SUCCESS,
+ AARCH64_RECORD_FAILURE,
+ AARCH64_RECORD_USUPPORTED
+};
+
+/* ARM instruction record contains opcode of current insn
+ and execution state (before entry to decode_insn()),
+ contains list of to-be-modified registers and
+ memory blocks (on return from decode_insn()). */
+
+typedef struct insn_decode_record_t
+{
+ struct gdbarch *gdbarch;
+ struct regcache *regcache;
+ CORE_ADDR this_addr;
+ uint32_t aarch64_insn;
+ uint32_t mem_rec_count;
+ uint32_t reg_rec_count;
+ uint32_t *aarch64_regs;
+ struct aarch64_mem_r *aarch64_mems;
+} insn_decode_record;
+
+extern int aarch64_process_record (struct gdbarch *gdbarch,
+ struct regcache *regcache, CORE_ADDR addr);
+
#endif /* aarch64-tdep.h */
--
1.9.1
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 4/7] Implements aarch64 process record and reverse debugging support
2014-06-04 16:21 ` [PATCH 4/7] Implements aarch64 process record and reverse debugging support Omair Javaid
@ 2014-06-05 8:34 ` Will Newton
2014-08-28 22:17 ` Omair Javaid
2014-08-30 3:27 ` Yao Qi
1 sibling, 1 reply; 53+ messages in thread
From: Will Newton @ 2014-06-05 8:34 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
On 4 June 2014 17:21, Omair Javaid <omair.javaid@linaro.org> wrote:
> This patch defines structures, macros and functions required for process record
> and reverse debugging support on aarch64-linux targets. Also implements
> support for recording most if not all of instructions from a64 instruction set.
>
> gdb:
>
> 2014-06-04 Omair Javaid <omair.javaid@linaro.org>
>
> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Updated.
> * aarch64-tdep.c (record.h): Include.
> (record-full.h): Include.
> (aarch64_record_data_proc_reg): New function.
> (aarch64_record_data_proc_imm): New function.
> (aarch64_record_branch_except_sys): New function.
> (aarch64_record_load_store): New function.
> (aarch64_record_decode_insn_handler): New function.
> (deallocate_reg_mem): New function.
> (aarch64_process_record): New function.
> * aarch64-tdep.h (submask): New macro.
> (bit): New macro.
> (bits): New macro.
> (REG_ALLOC): New macro.
> (MEM_ALLOC): New macro.
> (struct aarch64_mem_r): Defined.
> (aarch64_record_result): New enum.
> (struct insn_decode_record): Defined.
> (insn_decode_record): New typedef.
> (aarch64_process_record): New extern declaration.
>
> ---
> gdb/aarch64-linux-tdep.c | 3 +
> gdb/aarch64-tdep.c | 517 +++++++++++++++++++++++++++++++++++++++++++++++
> gdb/aarch64-tdep.h | 65 ++++++
> 3 files changed, 585 insertions(+)
>
> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
> index b285818..dece0c3 100644
> --- a/gdb/aarch64-linux-tdep.c
> +++ b/gdb/aarch64-linux-tdep.c
> @@ -468,6 +468,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
> set_gdbarch_stap_is_single_operand (gdbarch, aarch64_stap_is_single_operand);
> set_gdbarch_stap_parse_special_token (gdbarch,
> aarch64_stap_parse_special_token);
> +
> + /* Reversible debugging, process record. */
> + set_gdbarch_process_record (gdbarch, aarch64_process_record);
> }
>
> /* Provide a prototype to silence -Wmissing-prototypes. */
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index 4abe36e..bb533b2 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -52,6 +52,9 @@
> #include "gdb_assert.h"
> #include "vec.h"
>
> +#include "record.h"
> +#include "record-full.h"
> +
> #include "features/aarch64.c"
>
> /* Pseudo register base numbers. */
> @@ -2806,3 +2809,517 @@ When on, AArch64 specific debugging is enabled."),
> show_aarch64_debug,
> &setdebuglist, &showdebuglist);
> }
> +
> +/* Record handler for data processing - register instructions. */
> +static unsigned int
> +aarch64_record_data_proc_reg (insn_decode_record *aarch64_insn_r)
> +{
> + uint8_t reg_rd, insn_bits24_27, insn_bits21_23, setflags;
> + uint32_t record_buf[4];
> +
> + reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
> + insn_bits21_23 = bits (aarch64_insn_r->aarch64_insn, 21, 23);
> +
> + if (!bit (aarch64_insn_r->aarch64_insn, 28))
> + {
> + /* Logical (shifted register). */
> + if (insn_bits24_27 == 0x0a)
> + setflags = (bits (aarch64_insn_r->aarch64_insn, 29, 30) == 0x03);
> + /* Add/subtract. */
> + else if (insn_bits24_27 == 0x0b)
> + setflags = bit (aarch64_insn_r->aarch64_insn, 29);
> + else
> + return AARCH64_RECORD_USUPPORTED;
> +
> + record_buf[0] = reg_rd;
> + aarch64_insn_r->reg_rec_count = 1;
> + if (setflags)
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
> + }
> + else
> + {
> + if (insn_bits24_27 == 0x0b)
> + {
> + /* Data-processing (3 source). */
> + record_buf[0] = reg_rd;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + else if (insn_bits24_27 == 0x0a)
> + {
> + if (insn_bits21_23 == 0x00)
> + {
> + /* Add/subtract (with carry). */
> + record_buf[0] = reg_rd;
> + aarch64_insn_r->reg_rec_count = 1;
> + if (bit (aarch64_insn_r->aarch64_insn, 29))
> + {
> + record_buf[1] = AARCH64_CPSR_REGNUM;
> + aarch64_insn_r->reg_rec_count = 2;
> + }
> + }
> + else if (insn_bits21_23 == 0x02)
> + {
> + /* Conditional compare (register) / Conditional compare (immediate). */
> + record_buf[0] = AARCH64_CPSR_REGNUM;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + else if (insn_bits21_23 == 0x04 || insn_bits21_23 == 0x06)
> + {
> + /* CConditional select. */
> + /* Data-processing (2 source). */
> + /* Data-processing (1 source). */
> + record_buf[0] = reg_rd;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + else
> + return AARCH64_RECORD_USUPPORTED;
> + }
> + }
> +
> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
> + record_buf);
> + return AARCH64_RECORD_SUCCESS;
> +}
> +
> +/* Record handler for data processing - immediate instructions. */
> +static unsigned int
> +aarch64_record_data_proc_imm (insn_decode_record *aarch64_insn_r)
> +{
> + uint8_t reg_rd, insn_bit28, insn_bit23, insn_bits24_27, setflags;
> + uint32_t record_buf[4];
> +
> + reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
> + insn_bit28 = bit (aarch64_insn_r->aarch64_insn, 28);
> + insn_bit23 = bit (aarch64_insn_r->aarch64_insn, 23);
> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
> +
> + /*PC rel addressing / Move wide immediate / BitField / Extract. */
Missing space at the start of this comment.
> + if (insn_bits24_27 == 0x00 || insn_bits24_27 == 0x03 ||
> + (insn_bits24_27 == 0x02 && insn_bit23))
> + {
> + record_buf[0] = reg_rd;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + else if (insn_bits24_27 == 0x01)
> + {
> + /* Add/Subtract (immediate). */
> + setflags = bit (aarch64_insn_r->aarch64_insn, 29);
> + record_buf[0] = reg_rd;
> + aarch64_insn_r->reg_rec_count = 1;
> + if (setflags)
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
> + }
> + else if (insn_bits24_27 == 0x02 && !insn_bit23)
> + {
> + /* Logical (immediate). */
> + setflags = bits (aarch64_insn_r->aarch64_insn, 29, 30) == 0x03;
> + record_buf[0] = reg_rd;
> + aarch64_insn_r->reg_rec_count = 1;
> + if (setflags)
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
> + }
> + else
> + return AARCH64_RECORD_USUPPORTED;
> +
> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
> + record_buf);
> + return AARCH64_RECORD_SUCCESS;
> +}
> +
> +/* Record handler for branch, exception generation and system instructions. */
> +static unsigned int
> +aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
> +{
> + struct gdbarch_tdep *tdep = gdbarch_tdep (aarch64_insn_r->gdbarch);
> + uint8_t insn_bits24_27, insn_bits28_31, insn_bits22_23;
> + uint32_t record_buf[4];
> +
> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
> + insn_bits28_31 = bits (aarch64_insn_r->aarch64_insn, 28, 31);
> + insn_bits22_23 = bits (aarch64_insn_r->aarch64_insn, 22, 23);
> +
> + if (insn_bits28_31 == 0x0d)
> + {
> + /* Exception generation instructions. */
> + if (insn_bits24_27 == 0x04)
> + return AARCH64_RECORD_USUPPORTED;
> + /* System instructions. */
> + else if (insn_bits24_27 == 0x05 && insn_bits22_23 == 0x00)
> + {
> + record_buf[0] = AARCH64_CPSR_REGNUM;
> + record_buf[1] = bits (aarch64_insn_r->aarch64_insn, 0, 4);
> + aarch64_insn_r->reg_rec_count = 2;
> + }
> + else if((insn_bits24_27 & 0x0e) == 0x06)
> + {
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
> + if (bits (aarch64_insn_r->aarch64_insn, 21, 22) == 0x01)
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_LR_REGNUM;
> + }
> + else
> + return AARCH64_RECORD_USUPPORTED;
> + }
> + else if ((insn_bits28_31 & 0x07) == 0x01 && (insn_bits24_27 & 0x0c) == 0x04)
> + {
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
> + if (bit (aarch64_insn_r->aarch64_insn, 31))
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_LR_REGNUM;
> + }
> + else
> + /* All other types of branch instructions. */
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
> +
> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
> + record_buf);
> + return AARCH64_RECORD_SUCCESS;
> +}
> +
> +/* Record handler for load and store instructions. */
> +static unsigned int
> +aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
> +{
> + uint8_t insn_bits24_27, insn_bits28_29, insn_bits10_11;
> + uint8_t insn_bit23, insn_bit21;
> + uint8_t opc, size_bits, ld_flag, vector_flag;
> + uint32_t reg_rn, reg_rt, reg_rt2;
> + uint64_t datasize, offset;
> + uint32_t record_buf[8];
> + uint64_t record_buf_mem[8];
> + CORE_ADDR address;
> +
> + insn_bits10_11 = bits (aarch64_insn_r->aarch64_insn, 10, 11);
> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
> + insn_bits28_29 = bits (aarch64_insn_r->aarch64_insn, 28, 29);
> + insn_bit21 = bit (aarch64_insn_r->aarch64_insn, 21);
> + insn_bit23 = bit (aarch64_insn_r->aarch64_insn, 23);
> + ld_flag = bit (aarch64_insn_r->aarch64_insn, 22);
> + vector_flag = bit (aarch64_insn_r->aarch64_insn, 26);
> + reg_rt = bits (aarch64_insn_r->aarch64_insn, 0, 4);
> + reg_rn = bits (aarch64_insn_r->aarch64_insn, 5, 9);
> + reg_rt2 = bits (aarch64_insn_r->aarch64_insn, 10, 14);
> + size_bits = bits (aarch64_insn_r->aarch64_insn, 30, 31);
> +
> + /* Load/store exclusive instructions decoding. */
> + if (insn_bits24_27 == 0x08 && insn_bits28_29 == 0x00)
> + {
> + if (ld_flag)
> + {
> + record_buf[0] = reg_rt;
> + aarch64_insn_r->reg_rec_count = 1;
> + if (insn_bit21)
> + {
> + record_buf[1] = reg_rt2;
> + aarch64_insn_r->reg_rec_count = 2;
> + }
> + }
> + else
> + {
> + if (insn_bit21)
> + datasize = (8 << size_bits) * 2;
> + else
> + datasize = (8 << size_bits);
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
> + &address);
> + record_buf_mem[0] = datasize / 8;
> + record_buf_mem[1] = address;
> + aarch64_insn_r->mem_rec_count = 1;
> + if (!insn_bit23)
> + {
> + /* Save register rs. */
> + record_buf[0] = bits (aarch64_insn_r->aarch64_insn, 16, 20);
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + }
> + }
> + /* Load register (literal) instructions decoding. */
> + else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x01)
> + {
> + if (vector_flag)
> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
> + else
> + record_buf[0] = reg_rt;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + /* All types of load/store pair instructions decoding. */
> + else if ((insn_bits24_27 & 0x0a) == 0x08 && insn_bits28_29 == 0x02)
> + {
> + if (ld_flag)
> + {
> + if (vector_flag)
> + {
> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
> + record_buf[1] = reg_rt2 + AARCH64_V0_REGNUM;
> + }
> + else
> + {
> + record_buf[0] = reg_rt;
> + record_buf[1] = reg_rt2;
> + }
> + aarch64_insn_r->reg_rec_count = 2;
> + }
> + else
> + {
> + uint16_t imm7_off;
> + imm7_off = bits (aarch64_insn_r->aarch64_insn, 15, 21);
> + if (!vector_flag)
> + size_bits = size_bits >> 1;
> + datasize = 8 << (2 + size_bits);
> + offset = (imm7_off & 0x40) ? (((~imm7_off) & 0x007f) + 1) : imm7_off;
The brackets around ~imm7_off are not needed, and also around the
parts of the ternary conditional.
> + offset = offset << (2 + size_bits);
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
> + &address);
> + if (!((insn_bits24_27 & 0x0b) == 0x08 && insn_bit23))
> + {
> + if (imm7_off & 0x40)
> + address = address - offset;
> + else
> + address = address + offset;
> + }
> +
> + record_buf_mem[0] = datasize / 8;
> + record_buf_mem[1] = address;
> + record_buf_mem[2] = datasize / 8;
> + record_buf_mem[3] = address + (datasize / 8);
> + aarch64_insn_r->mem_rec_count = 2;
> + }
> + if (bit (aarch64_insn_r->aarch64_insn, 23))
> + record_buf[aarch64_insn_r->reg_rec_count++] = reg_rn;
> + }
> + /* Load/store register (unsigned immediate) instructions. */
> + else if ((insn_bits24_27 & 0x0b) == 0x09 && insn_bits28_29 == 0x03)
> + {
> + opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
> + if (!(opc >> 1))
> + if (opc & 0x01)
> + ld_flag = 0x01;
> + else
> + ld_flag = 0x0;
> + else
> + if (size_bits != 0x03)
> + ld_flag = 0x01;
> + else
> + return AARCH64_RECORD_USUPPORTED;
> +
> + if (!ld_flag)
> + {
> + offset = bits (aarch64_insn_r->aarch64_insn, 10, 21);
> + datasize = 8 << size_bits;
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
> + &address);
> + offset = offset << size_bits;
> + address = address + offset;
> +
> + record_buf_mem[0] = datasize >> 3;
> + record_buf_mem[1] = address;
> + aarch64_insn_r->mem_rec_count = 1;
> + }
> + else
> + {
> + if (vector_flag)
> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
> + else
> + record_buf[0] = reg_rt;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + }
> + /* Load/store register (register offset) instructions. */
> + else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 &&
> + insn_bits10_11 == 0x02 && insn_bit21)
> + {
> + opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
> + if (!(opc >> 1))
> + if (opc & 0x01)
> + ld_flag = 0x01;
> + else
> + ld_flag = 0x0;
> + else
> + if (size_bits != 0x03)
> + ld_flag = 0x01;
> + else
> + return AARCH64_RECORD_USUPPORTED;
> +
> + if (!ld_flag)
> + {
> + uint64_t reg_rm_val;
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache,
> + bits (aarch64_insn_r->aarch64_insn, 16, 20), ®_rm_val);
> + if (bit (aarch64_insn_r->aarch64_insn, 12))
> + offset = reg_rm_val << size_bits;
> + else
> + offset = reg_rm_val;
> + datasize = 8 << size_bits;
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
> + &address);
> + address = address + offset;
> + record_buf_mem[0] = datasize >> 3;
> + record_buf_mem[1] = address;
> + aarch64_insn_r->mem_rec_count = 1;
> + }
> + else
> + {
> + if (vector_flag)
> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
> + else
> + record_buf[0] = reg_rt;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + }
> + /* Load/store register (immediate) instructions. */
> + else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 &&
> + !insn_bit21)
> + {
> + opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
> + if (!(opc >> 1))
> + if (opc & 0x01)
> + ld_flag = 0x01;
> + else
> + ld_flag = 0x0;
> + else
> + if (size_bits != 0x03)
> + ld_flag = 0x01;
> + else
> + return AARCH64_RECORD_USUPPORTED;
> +
> + if (!ld_flag)
> + {
> + uint16_t imm9_off;
> + imm9_off = bits (aarch64_insn_r->aarch64_insn, 12, 20);
> + offset = (imm9_off & 0x0100) ? (((~imm9_off) & 0x01ff) + 1) : imm9_off;
> + datasize = 8 << size_bits;
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
> + &address);
> + if (insn_bits10_11 != 0x01)
> + {
> + if (imm9_off & 0x0100)
> + address = address - offset;
> + else
> + address = address + offset;
> + }
> + record_buf_mem[0] = datasize >> 3;
> + record_buf_mem[1] = address;
> + aarch64_insn_r->mem_rec_count = 1;
> + }
> + else
> + {
> + if (vector_flag)
> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
> + else
> + record_buf[0] = reg_rt;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + if (insn_bits10_11 == 0x01 || insn_bits10_11 == 0x03)
> + record_buf[aarch64_insn_r->reg_rec_count++] = reg_rn;
> + }
> + /* Advanced SIMD load/store instructions. */
> + else
> + return AARCH64_RECORD_USUPPORTED;
> +
> + MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count,
> + record_buf_mem);
> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
> + record_buf);
> + return AARCH64_RECORD_SUCCESS;
> +}
> +/* Decodes thumb2 instruction type and invokes its record handler. */
This comment needs updating.
> +
> +static unsigned int
> +aarch64_record_decode_insn_handler (insn_decode_record *aarch64_insn_r)
> +{
> + uint32_t ins_bit25, ins_bit26, ins_bit27, ins_bit28;
> +
> + ins_bit25 = bit (aarch64_insn_r->aarch64_insn, 25);
> + ins_bit26 = bit (aarch64_insn_r->aarch64_insn, 26);
> + ins_bit27 = bit (aarch64_insn_r->aarch64_insn, 27);
> + ins_bit28 = bit (aarch64_insn_r->aarch64_insn, 28);
> +
> + /* Data processing - immediate instructions. */
> + if (!ins_bit26 && !ins_bit27 && ins_bit28)
> + return aarch64_record_data_proc_imm (aarch64_insn_r);
> +
> + /* Branch, exception generation and system instructions. */
> + if (ins_bit26 && !ins_bit27 && ins_bit28)
> + return aarch64_record_branch_except_sys (aarch64_insn_r);
> +
> + /* Load and store instructions. */
> + if (!ins_bit25 && ins_bit27)
> + return aarch64_record_load_store (aarch64_insn_r);
> +
> + /* Data processing - register instructions. */
> + if (ins_bit25 && !ins_bit26 && ins_bit27)
> + return aarch64_record_data_proc_reg (aarch64_insn_r);
> +
> + /* Data processing - SIMD and floating point instructions. */
> + if (ins_bit25 && ins_bit26 && ins_bit27)
> + return AARCH64_RECORD_USUPPORTED;
> +
> + return AARCH64_RECORD_USUPPORTED;
> +}
> +
> +/* Cleans up local record registers and memory allocations. */
> +
> +static void
> +deallocate_reg_mem (insn_decode_record *record)
> +{
> + xfree (record->aarch64_regs);
> + xfree (record->aarch64_mems);
> +}
> +
> +/* Parse the current instruction and record the values of the registers and
> + memory that will be changed in current instruction to record_arch_list".
Should the quote after record_arch_list be here?
> + Return -1 if something is wrong. */
> +
> +int
> +aarch64_process_record (struct gdbarch *gdbarch, struct regcache *regcache,
> + CORE_ADDR insn_addr)
> +{
> + uint32_t rec_no = 0;
> + uint8_t insn_size = 4;
> + uint32_t ret = 0;
It would probably be cleaner to use int for ret.
> + ULONGEST t_bit = 0, insn_id = 0;
These two aren't used.
> + gdb_byte buf[insn_size];
> + insn_decode_record aarch64_record;
> +
> + memset (&buf[0], 0, insn_size);
> + memset (&aarch64_record, 0, sizeof (insn_decode_record));
> + target_read_memory (insn_addr, &buf[0], insn_size);
> + aarch64_record.aarch64_insn = (uint32_t) extract_unsigned_integer (&buf[0],
> + insn_size, gdbarch_byte_order (gdbarch));
> + aarch64_record.regcache = regcache;
> + aarch64_record.this_addr = insn_addr;
> + aarch64_record.gdbarch = gdbarch;
> +
> + ret = aarch64_record_decode_insn_handler (&aarch64_record);
> + if (ret == AARCH64_RECORD_USUPPORTED)
> + {
> + printf_unfiltered (_("Process record does not support instruction "
> + "0x%0x at address %s.\n"),aarch64_record.aarch64_insn,
> + paddress (gdbarch, insn_addr));
> + ret = -1;
> + }
> +
> + if (0 == ret)
> + {
> + /* Record registers. */
> + record_full_arch_list_add_reg (aarch64_record.regcache, AARCH64_PC_REGNUM);
> + if (aarch64_record.aarch64_regs)
> + for (rec_no = 0; rec_no < aarch64_record.reg_rec_count; rec_no++)
> + if (record_full_arch_list_add_reg (aarch64_record.regcache,
> + aarch64_record.aarch64_regs[rec_no]))
> + ret = -1;
> +
> + /* Record memories. */
> + if (aarch64_record.aarch64_mems)
> + for (rec_no = 0; rec_no < aarch64_record.mem_rec_count; rec_no++)
> + if (record_full_arch_list_add_mem
> + ((CORE_ADDR)aarch64_record.aarch64_mems[rec_no].addr,
> + aarch64_record.aarch64_mems[rec_no].len))
> + ret = -1;
> +
> + if (record_full_arch_list_add_end ())
> + ret = -1;
> + }
> +
> + deallocate_reg_mem (&aarch64_record);
> + return ret;
> +}
> diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
> index 78fb779..8a193f4 100644
> --- a/gdb/aarch64-tdep.h
> +++ b/gdb/aarch64-tdep.h
> @@ -90,4 +90,69 @@ struct gdbarch_tdep
> struct type *vnb_type;
> };
>
> +/* aarch64 process record-replay related structures, defines etc. */
> +
> +#define submask(x) ((1L << ((x) + 1)) - 1)
> +#define bit(obj,st) (((obj) >> (st)) & 1)
> +#define bits(obj,st,fn) (((obj) >> (st)) & submask ((fn) - (st)))
> +
> +#define REG_ALLOC(REGS, LENGTH, RECORD_BUF) \
> + do \
> + { \
> + unsigned int reg_len = LENGTH; \
> + if (reg_len) \
> + { \
> + REGS = XNEWVEC (uint32_t, reg_len); \
> + memcpy(®S[0], &RECORD_BUF[0], sizeof(uint32_t)*LENGTH); \
> + } \
> + } \
> + while (0)
> +
> +#define MEM_ALLOC(MEMS, LENGTH, RECORD_BUF) \
> + do \
> + { \
> + unsigned int mem_len = LENGTH; \
> + if (mem_len) \
> + { \
> + MEMS = XNEWVEC (struct aarch64_mem_r, mem_len); \
> + memcpy(&MEMS->len, &RECORD_BUF[0], \
> + sizeof(struct aarch64_mem_r) * LENGTH); \
> + } \
> + } \
> + while (0)
> +
> +/* ARM memory record structure. */
Comment needs updating.
> +struct aarch64_mem_r
> +{
> + uint64_t len; /* Record length. */
> + uint64_t addr; /* Memory address. */
> +};
> +
> +enum aarch64_record_result
> +{
> + AARCH64_RECORD_SUCCESS,
> + AARCH64_RECORD_FAILURE,
> + AARCH64_RECORD_USUPPORTED
Should this be UNSUPPORTED?
> +};
> +
> +/* ARM instruction record contains opcode of current insn
Also needs updating.
> + and execution state (before entry to decode_insn()),
> + contains list of to-be-modified registers and
> + memory blocks (on return from decode_insn()). */
> +
> +typedef struct insn_decode_record_t
> +{
> + struct gdbarch *gdbarch;
> + struct regcache *regcache;
> + CORE_ADDR this_addr;
> + uint32_t aarch64_insn;
> + uint32_t mem_rec_count;
> + uint32_t reg_rec_count;
> + uint32_t *aarch64_regs;
> + struct aarch64_mem_r *aarch64_mems;
> +} insn_decode_record;
> +
> +extern int aarch64_process_record (struct gdbarch *gdbarch,
> + struct regcache *regcache, CORE_ADDR addr);
> +
> #endif /* aarch64-tdep.h */
> --
> 1.9.1
>
--
Will Newton
Toolchain Working Group, Linaro
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 4/7] Implements aarch64 process record and reverse debugging support
2014-06-05 8:34 ` Will Newton
@ 2014-08-28 22:17 ` Omair Javaid
0 siblings, 0 replies; 53+ messages in thread
From: Omair Javaid @ 2014-08-28 22:17 UTC (permalink / raw)
To: gdb-patches
2014-06-04 Omair Javaid <omair.javaid@linaro.org>
* aarch64-linux-tdep.c (aarch64_linux_init_abi): Install AArch64
process record handler.
* aarch64-tdep.c (record.h): Include.
(record-full.h): Include.
(aarch64_record_data_proc_reg): Add record handler for data processing
register insns.
(aarch64_record_data_proc_imm): Add record handler for data processing
immediate insns.
(aarch64_record_branch_except_sys): Add record handler for branch,
exception and system insns.
(aarch64_record_load_store): Add record handler for load/store insns.
(aarch64_record_decode_insn_handler): Add record insn decoding function.
(deallocate_reg_mem): Add memory cleanup function for record data.
(aarch64_process_record): Add gdbarch handler for AArch64 process
record.
* aarch64-tdep.h (submask): New macro.
(bit): New macro.
(bits): New macro.
(REG_ALLOC): New macro.
(MEM_ALLOC): New macro.
(struct aarch64_mem_r): Define.
(aarch64_record_result): New enum.
(struct insn_decode_record): Define.
(insn_decode_record): New typedef.
(aarch64_process_record): New extern declaration.
---
gdb/aarch64-linux-tdep.c | 3 +
gdb/aarch64-tdep.c | 517 +++++++++++++++++++++++++++++++++++++++++++++++
gdb/aarch64-tdep.h | 64 ++++++
3 files changed, 584 insertions(+)
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index e5565a8..5ab7b37 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -401,6 +401,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
set_gdbarch_stap_is_single_operand (gdbarch, aarch64_stap_is_single_operand);
set_gdbarch_stap_parse_special_token (gdbarch,
aarch64_stap_parse_special_token);
+
+ /* Reversible debugging, process record. */
+ set_gdbarch_process_record (gdbarch, aarch64_process_record);
}
/* Provide a prototype to silence -Wmissing-prototypes. */
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index 1898f6b..0847585 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -50,6 +50,9 @@
#include "vec.h"
+#include "record.h"
+#include "record-full.h"
+
#include "features/aarch64.c"
/* Pseudo register base numbers. */
@@ -2804,3 +2807,517 @@ When on, AArch64 specific debugging is enabled."),
show_aarch64_debug,
&setdebuglist, &showdebuglist);
}
+
+/* Record handler for data processing - register instructions. */
+static unsigned int
+aarch64_record_data_proc_reg (insn_decode_record *aarch64_insn_r)
+{
+ uint8_t reg_rd, insn_bits24_27, insn_bits21_23, setflags;
+ uint32_t record_buf[4];
+
+ reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
+ insn_bits21_23 = bits (aarch64_insn_r->aarch64_insn, 21, 23);
+
+ if (!bit (aarch64_insn_r->aarch64_insn, 28))
+ {
+ /* Logical (shifted register). */
+ if (insn_bits24_27 == 0x0a)
+ setflags = (bits (aarch64_insn_r->aarch64_insn, 29, 30) == 0x03);
+ /* Add/subtract. */
+ else if (insn_bits24_27 == 0x0b)
+ setflags = bit (aarch64_insn_r->aarch64_insn, 29);
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ if (setflags)
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
+ }
+ else
+ {
+ if (insn_bits24_27 == 0x0b)
+ {
+ /* Data-processing (3 source). */
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ else if (insn_bits24_27 == 0x0a)
+ {
+ if (insn_bits21_23 == 0x00)
+ {
+ /* Add/subtract (with carry). */
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ if (bit (aarch64_insn_r->aarch64_insn, 29))
+ {
+ record_buf[1] = AARCH64_CPSR_REGNUM;
+ aarch64_insn_r->reg_rec_count = 2;
+ }
+ }
+ else if (insn_bits21_23 == 0x02)
+ {
+ /* Conditional compare (register) / Conditional compare (immediate). */
+ record_buf[0] = AARCH64_CPSR_REGNUM;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ else if (insn_bits21_23 == 0x04 || insn_bits21_23 == 0x06)
+ {
+ /* CConditional select. */
+ /* Data-processing (2 source). */
+ /* Data-processing (1 source). */
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+ }
+ }
+
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+
+/* Record handler for data processing - immediate instructions. */
+static unsigned int
+aarch64_record_data_proc_imm (insn_decode_record *aarch64_insn_r)
+{
+ uint8_t reg_rd, insn_bit28, insn_bit23, insn_bits24_27, setflags;
+ uint32_t record_buf[4];
+
+ reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ insn_bit28 = bit (aarch64_insn_r->aarch64_insn, 28);
+ insn_bit23 = bit (aarch64_insn_r->aarch64_insn, 23);
+ insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
+
+ /* PC rel addressing / Move wide immediate / BitField / Extract. */
+ if (insn_bits24_27 == 0x00 || insn_bits24_27 == 0x03 ||
+ (insn_bits24_27 == 0x02 && insn_bit23))
+ {
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ else if (insn_bits24_27 == 0x01)
+ {
+ /* Add/Subtract (immediate). */
+ setflags = bit (aarch64_insn_r->aarch64_insn, 29);
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ if (setflags)
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
+ }
+ else if (insn_bits24_27 == 0x02 && !insn_bit23)
+ {
+ /* Logical (immediate). */
+ setflags = bits (aarch64_insn_r->aarch64_insn, 29, 30) == 0x03;
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ if (setflags)
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
+ }
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+
+/* Record handler for branch, exception generation and system instructions. */
+static unsigned int
+aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
+{
+ struct gdbarch_tdep *tdep = gdbarch_tdep (aarch64_insn_r->gdbarch);
+ uint8_t insn_bits24_27, insn_bits28_31, insn_bits22_23;
+ uint32_t record_buf[4];
+
+ insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
+ insn_bits28_31 = bits (aarch64_insn_r->aarch64_insn, 28, 31);
+ insn_bits22_23 = bits (aarch64_insn_r->aarch64_insn, 22, 23);
+
+ if (insn_bits28_31 == 0x0d)
+ {
+ /* Exception generation instructions. */
+ if (insn_bits24_27 == 0x04)
+ return AARCH64_RECORD_UNSUPPORTED;
+ /* System instructions. */
+ else if (insn_bits24_27 == 0x05 && insn_bits22_23 == 0x00)
+ {
+ record_buf[0] = AARCH64_CPSR_REGNUM;
+ record_buf[1] = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ aarch64_insn_r->reg_rec_count = 2;
+ }
+ else if((insn_bits24_27 & 0x0e) == 0x06)
+ {
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
+ if (bits (aarch64_insn_r->aarch64_insn, 21, 22) == 0x01)
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_LR_REGNUM;
+ }
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+ }
+ else if ((insn_bits28_31 & 0x07) == 0x01 && (insn_bits24_27 & 0x0c) == 0x04)
+ {
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
+ if (bit (aarch64_insn_r->aarch64_insn, 31))
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_LR_REGNUM;
+ }
+ else
+ /* All other types of branch instructions. */
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
+
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+
+/* Record handler for load and store instructions. */
+static unsigned int
+aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
+{
+ uint8_t insn_bits24_27, insn_bits28_29, insn_bits10_11;
+ uint8_t insn_bit23, insn_bit21;
+ uint8_t opc, size_bits, ld_flag, vector_flag;
+ uint32_t reg_rn, reg_rt, reg_rt2;
+ uint64_t datasize, offset;
+ uint32_t record_buf[8];
+ uint64_t record_buf_mem[8];
+ CORE_ADDR address;
+
+ insn_bits10_11 = bits (aarch64_insn_r->aarch64_insn, 10, 11);
+ insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
+ insn_bits28_29 = bits (aarch64_insn_r->aarch64_insn, 28, 29);
+ insn_bit21 = bit (aarch64_insn_r->aarch64_insn, 21);
+ insn_bit23 = bit (aarch64_insn_r->aarch64_insn, 23);
+ ld_flag = bit (aarch64_insn_r->aarch64_insn, 22);
+ vector_flag = bit (aarch64_insn_r->aarch64_insn, 26);
+ reg_rt = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ reg_rn = bits (aarch64_insn_r->aarch64_insn, 5, 9);
+ reg_rt2 = bits (aarch64_insn_r->aarch64_insn, 10, 14);
+ size_bits = bits (aarch64_insn_r->aarch64_insn, 30, 31);
+
+ /* Load/store exclusive instructions decoding. */
+ if (insn_bits24_27 == 0x08 && insn_bits28_29 == 0x00)
+ {
+ if (ld_flag)
+ {
+ record_buf[0] = reg_rt;
+ aarch64_insn_r->reg_rec_count = 1;
+ if (insn_bit21)
+ {
+ record_buf[1] = reg_rt2;
+ aarch64_insn_r->reg_rec_count = 2;
+ }
+ }
+ else
+ {
+ if (insn_bit21)
+ datasize = (8 << size_bits) * 2;
+ else
+ datasize = (8 << size_bits);
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
+ &address);
+ record_buf_mem[0] = datasize / 8;
+ record_buf_mem[1] = address;
+ aarch64_insn_r->mem_rec_count = 1;
+ if (!insn_bit23)
+ {
+ /* Save register rs. */
+ record_buf[0] = bits (aarch64_insn_r->aarch64_insn, 16, 20);
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ }
+ }
+ /* Load register (literal) instructions decoding. */
+ else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x01)
+ {
+ if (vector_flag)
+ record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
+ else
+ record_buf[0] = reg_rt;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ /* All types of load/store pair instructions decoding. */
+ else if ((insn_bits24_27 & 0x0a) == 0x08 && insn_bits28_29 == 0x02)
+ {
+ if (ld_flag)
+ {
+ if (vector_flag)
+ {
+ record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
+ record_buf[1] = reg_rt2 + AARCH64_V0_REGNUM;
+ }
+ else
+ {
+ record_buf[0] = reg_rt;
+ record_buf[1] = reg_rt2;
+ }
+ aarch64_insn_r->reg_rec_count = 2;
+ }
+ else
+ {
+ uint16_t imm7_off;
+ imm7_off = bits (aarch64_insn_r->aarch64_insn, 15, 21);
+ if (!vector_flag)
+ size_bits = size_bits >> 1;
+ datasize = 8 << (2 + size_bits);
+ offset = (imm7_off & 0x40) ? (~imm7_off & 0x007f) + 1 : imm7_off;
+ offset = offset << (2 + size_bits);
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
+ &address);
+ if (!((insn_bits24_27 & 0x0b) == 0x08 && insn_bit23))
+ {
+ if (imm7_off & 0x40)
+ address = address - offset;
+ else
+ address = address + offset;
+ }
+
+ record_buf_mem[0] = datasize / 8;
+ record_buf_mem[1] = address;
+ record_buf_mem[2] = datasize / 8;
+ record_buf_mem[3] = address + (datasize / 8);
+ aarch64_insn_r->mem_rec_count = 2;
+ }
+ if (bit (aarch64_insn_r->aarch64_insn, 23))
+ record_buf[aarch64_insn_r->reg_rec_count++] = reg_rn;
+ }
+ /* Load/store register (unsigned immediate) instructions. */
+ else if ((insn_bits24_27 & 0x0b) == 0x09 && insn_bits28_29 == 0x03)
+ {
+ opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
+ if (!(opc >> 1))
+ if (opc & 0x01)
+ ld_flag = 0x01;
+ else
+ ld_flag = 0x0;
+ else
+ if (size_bits != 0x03)
+ ld_flag = 0x01;
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+
+ if (!ld_flag)
+ {
+ offset = bits (aarch64_insn_r->aarch64_insn, 10, 21);
+ datasize = 8 << size_bits;
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
+ &address);
+ offset = offset << size_bits;
+ address = address + offset;
+
+ record_buf_mem[0] = datasize >> 3;
+ record_buf_mem[1] = address;
+ aarch64_insn_r->mem_rec_count = 1;
+ }
+ else
+ {
+ if (vector_flag)
+ record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
+ else
+ record_buf[0] = reg_rt;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ }
+ /* Load/store register (register offset) instructions. */
+ else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 &&
+ insn_bits10_11 == 0x02 && insn_bit21)
+ {
+ opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
+ if (!(opc >> 1))
+ if (opc & 0x01)
+ ld_flag = 0x01;
+ else
+ ld_flag = 0x0;
+ else
+ if (size_bits != 0x03)
+ ld_flag = 0x01;
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+
+ if (!ld_flag)
+ {
+ uint64_t reg_rm_val;
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache,
+ bits (aarch64_insn_r->aarch64_insn, 16, 20), ®_rm_val);
+ if (bit (aarch64_insn_r->aarch64_insn, 12))
+ offset = reg_rm_val << size_bits;
+ else
+ offset = reg_rm_val;
+ datasize = 8 << size_bits;
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
+ &address);
+ address = address + offset;
+ record_buf_mem[0] = datasize >> 3;
+ record_buf_mem[1] = address;
+ aarch64_insn_r->mem_rec_count = 1;
+ }
+ else
+ {
+ if (vector_flag)
+ record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
+ else
+ record_buf[0] = reg_rt;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ }
+ /* Load/store register (immediate) instructions. */
+ else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 &&
+ !insn_bit21)
+ {
+ opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
+ if (!(opc >> 1))
+ if (opc & 0x01)
+ ld_flag = 0x01;
+ else
+ ld_flag = 0x0;
+ else
+ if (size_bits != 0x03)
+ ld_flag = 0x01;
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+
+ if (!ld_flag)
+ {
+ uint16_t imm9_off;
+ imm9_off = bits (aarch64_insn_r->aarch64_insn, 12, 20);
+ offset = (imm9_off & 0x0100) ? (((~imm9_off) & 0x01ff) + 1) : imm9_off;
+ datasize = 8 << size_bits;
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
+ &address);
+ if (insn_bits10_11 != 0x01)
+ {
+ if (imm9_off & 0x0100)
+ address = address - offset;
+ else
+ address = address + offset;
+ }
+ record_buf_mem[0] = datasize >> 3;
+ record_buf_mem[1] = address;
+ aarch64_insn_r->mem_rec_count = 1;
+ }
+ else
+ {
+ if (vector_flag)
+ record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
+ else
+ record_buf[0] = reg_rt;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ if (insn_bits10_11 == 0x01 || insn_bits10_11 == 0x03)
+ record_buf[aarch64_insn_r->reg_rec_count++] = reg_rn;
+ }
+ /* Advanced SIMD load/store instructions. */
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+
+ MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count,
+ record_buf_mem);
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+/* Decodes insns type and invokes its record handler. */
+
+static unsigned int
+aarch64_record_decode_insn_handler (insn_decode_record *aarch64_insn_r)
+{
+ uint32_t ins_bit25, ins_bit26, ins_bit27, ins_bit28;
+
+ ins_bit25 = bit (aarch64_insn_r->aarch64_insn, 25);
+ ins_bit26 = bit (aarch64_insn_r->aarch64_insn, 26);
+ ins_bit27 = bit (aarch64_insn_r->aarch64_insn, 27);
+ ins_bit28 = bit (aarch64_insn_r->aarch64_insn, 28);
+
+ /* Data processing - immediate instructions. */
+ if (!ins_bit26 && !ins_bit27 && ins_bit28)
+ return aarch64_record_data_proc_imm (aarch64_insn_r);
+
+ /* Branch, exception generation and system instructions. */
+ if (ins_bit26 && !ins_bit27 && ins_bit28)
+ return aarch64_record_branch_except_sys (aarch64_insn_r);
+
+ /* Load and store instructions. */
+ if (!ins_bit25 && ins_bit27)
+ return aarch64_record_load_store (aarch64_insn_r);
+
+ /* Data processing - register instructions. */
+ if (ins_bit25 && !ins_bit26 && ins_bit27)
+ return aarch64_record_data_proc_reg (aarch64_insn_r);
+
+ /* Data processing - SIMD and floating point instructions. */
+ if (ins_bit25 && ins_bit26 && ins_bit27)
+ return AARCH64_RECORD_UNSUPPORTED;
+
+ return AARCH64_RECORD_UNSUPPORTED;
+}
+
+/* Cleans up local record registers and memory allocations. */
+
+static void
+deallocate_reg_mem (insn_decode_record *record)
+{
+ xfree (record->aarch64_regs);
+ xfree (record->aarch64_mems);
+}
+
+/* Parse the current instruction and record the values of the registers and
+ memory that will be changed in current instruction to record_arch_list
+ return -1 if something is wrong. */
+
+int
+aarch64_process_record (struct gdbarch *gdbarch, struct regcache *regcache,
+ CORE_ADDR insn_addr)
+{
+ uint32_t rec_no = 0;
+ uint8_t insn_size = 4;
+ uint32_t ret = 0;
+ ULONGEST t_bit = 0, insn_id = 0;
+ gdb_byte buf[insn_size];
+ insn_decode_record aarch64_record;
+
+ memset (&buf[0], 0, insn_size);
+ memset (&aarch64_record, 0, sizeof (insn_decode_record));
+ target_read_memory (insn_addr, &buf[0], insn_size);
+ aarch64_record.aarch64_insn = (uint32_t) extract_unsigned_integer (&buf[0],
+ insn_size, gdbarch_byte_order (gdbarch));
+ aarch64_record.regcache = regcache;
+ aarch64_record.this_addr = insn_addr;
+ aarch64_record.gdbarch = gdbarch;
+
+ ret = aarch64_record_decode_insn_handler (&aarch64_record);
+ if (ret == AARCH64_RECORD_UNSUPPORTED)
+ {
+ printf_unfiltered (_("Process record does not support instruction "
+ "0x%0x at address %s.\n"),aarch64_record.aarch64_insn,
+ paddress (gdbarch, insn_addr));
+ ret = -1;
+ }
+
+ if (0 == ret)
+ {
+ /* Record registers. */
+ record_full_arch_list_add_reg (aarch64_record.regcache, AARCH64_PC_REGNUM);
+ if (aarch64_record.aarch64_regs)
+ for (rec_no = 0; rec_no < aarch64_record.reg_rec_count; rec_no++)
+ if (record_full_arch_list_add_reg (aarch64_record.regcache,
+ aarch64_record.aarch64_regs[rec_no]))
+ ret = -1;
+
+ /* Record memories. */
+ if (aarch64_record.aarch64_mems)
+ for (rec_no = 0; rec_no < aarch64_record.mem_rec_count; rec_no++)
+ if (record_full_arch_list_add_mem
+ ((CORE_ADDR)aarch64_record.aarch64_mems[rec_no].addr,
+ aarch64_record.aarch64_mems[rec_no].len))
+ ret = -1;
+
+ if (record_full_arch_list_add_end ())
+ ret = -1;
+ }
+
+ deallocate_reg_mem (&aarch64_record);
+ return ret;
+}
diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
index 78fb779..1d74ef8 100644
--- a/gdb/aarch64-tdep.h
+++ b/gdb/aarch64-tdep.h
@@ -90,4 +90,68 @@ struct gdbarch_tdep
struct type *vnb_type;
};
+/* AArch64 process record-replay related structures, defines etc. */
+
+#define submask(x) ((1L << ((x) + 1)) - 1)
+#define bit(obj,st) (((obj) >> (st)) & 1)
+#define bits(obj,st,fn) (((obj) >> (st)) & submask ((fn) - (st)))
+
+#define REG_ALLOC(REGS, LENGTH, RECORD_BUF) \
+ do \
+ { \
+ unsigned int reg_len = LENGTH; \
+ if (reg_len) \
+ { \
+ REGS = XNEWVEC (uint32_t, reg_len); \
+ memcpy(®S[0], &RECORD_BUF[0], sizeof(uint32_t)*LENGTH); \
+ } \
+ } \
+ while (0)
+
+#define MEM_ALLOC(MEMS, LENGTH, RECORD_BUF) \
+ do \
+ { \
+ unsigned int mem_len = LENGTH; \
+ if (mem_len) \
+ { \
+ MEMS = XNEWVEC (struct aarch64_mem_r, mem_len); \
+ memcpy(&MEMS->len, &RECORD_BUF[0], \
+ sizeof(struct aarch64_mem_r) * LENGTH); \
+ } \
+ } \
+ while (0)
+
+/* AArch64 memory record structure. */
+struct aarch64_mem_r
+{
+ uint64_t len; /* Record length. */
+ uint64_t addr; /* Memory address. */
+};
+
+enum aarch64_record_result
+{
+ AARCH64_RECORD_SUCCESS,
+ AARCH64_RECORD_FAILURE,
+ AARCH64_RECORD_UNSUPPORTED
+};
+
+/* AArch64 instruction record contains opcode of current insn and execution
+ state (before entry to decode_insn()), contains list of to-be-modified
+ registers and memory blocks (on return from decode_insn()). */
+
+typedef struct insn_decode_record_t
+{
+ struct gdbarch *gdbarch;
+ struct regcache *regcache;
+ CORE_ADDR this_addr;
+ uint32_t aarch64_insn;
+ uint32_t mem_rec_count;
+ uint32_t reg_rec_count;
+ uint32_t *aarch64_regs;
+ struct aarch64_mem_r *aarch64_mems;
+} insn_decode_record;
+
+extern int aarch64_process_record (struct gdbarch *gdbarch,
+ struct regcache *regcache, CORE_ADDR addr);
+
#endif /* aarch64-tdep.h */
--
1.9.1
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH 4/7] Implements aarch64 process record and reverse debugging support
2014-06-04 16:21 ` [PATCH 4/7] Implements aarch64 process record and reverse debugging support Omair Javaid
2014-06-05 8:34 ` Will Newton
@ 2014-08-30 3:27 ` Yao Qi
2014-09-01 20:08 ` Omair Javaid
1 sibling, 1 reply; 53+ messages in thread
From: Yao Qi @ 2014-08-30 3:27 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
Omair Javaid <omair.javaid@linaro.org> writes:
> This patch defines structures, macros and functions required for process record
> and reverse debugging support on aarch64-linux targets. Also implements
> support for recording most if not all of instructions from a64 instruction set.
>
> gdb:
>
> 2014-06-04 Omair Javaid <omair.javaid@linaro.org>
>
> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Updated.
> * aarch64-tdep.c (record.h): Include.
> (record-full.h): Include.
> (aarch64_record_data_proc_reg): New function.
> (aarch64_record_data_proc_imm): New function.
> (aarch64_record_branch_except_sys): New function.
> (aarch64_record_load_store): New function.
> (aarch64_record_decode_insn_handler): New function.
> (deallocate_reg_mem): New function.
> (aarch64_process_record): New function.
> * aarch64-tdep.h (submask): New macro.
> (bit): New macro.
> (bits): New macro.
> (REG_ALLOC): New macro.
> (MEM_ALLOC): New macro.
> (struct aarch64_mem_r): Defined.
> (aarch64_record_result): New enum.
> (struct insn_decode_record): Defined.
> (insn_decode_record): New typedef.
> (aarch64_process_record): New extern declaration.
We want to support process record on aarch64-linux, but the code is
added to aarch64-tdep.c. Does aarch64-elf target need process record?
I prefer to add code to aarch64-linux-tdep.c. I know that code for
process record on arm was added to arm-tdep.c too, but I don't think it
is correct either.
> diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
> index 78fb779..8a193f4 100644
> --- a/gdb/aarch64-tdep.h
> +++ b/gdb/aarch64-tdep.h
> @@ -90,4 +90,69 @@ struct gdbarch_tdep
> struct type *vnb_type;
> };
>
> +/* aarch64 process record-replay related structures, defines etc. */
> +
> +#define submask(x) ((1L << ((x) + 1)) - 1)
> +#define bit(obj,st) (((obj) >> (st)) & 1)
> +#define bits(obj,st,fn) (((obj) >> (st)) & submask ((fn) - (st)))
If they are only used in aarch64-tdep.c, please define them there.
> +
> +/* ARM memory record structure. */
s/ARM/AArch64/
> +struct aarch64_mem_r
> +{
> + uint64_t len; /* Record length. */
> + uint64_t addr; /* Memory address. */
> +};
> +
> +enum aarch64_record_result
> +{
> + AARCH64_RECORD_SUCCESS,
> + AARCH64_RECORD_FAILURE,
> + AARCH64_RECORD_USUPPORTED
> +};
> +
> +/* ARM instruction record contains opcode of current insn
Likewise.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 4/7] Implements aarch64 process record and reverse debugging support
2014-08-30 3:27 ` Yao Qi
@ 2014-09-01 20:08 ` Omair Javaid
2014-09-18 0:09 ` Omair Javaid
0 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-09-01 20:08 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
On 30 August 2014 08:23, Yao Qi <yao@codesourcery.com> wrote:
> Omair Javaid <omair.javaid@linaro.org> writes:
>
>> This patch defines structures, macros and functions required for process record
>> and reverse debugging support on aarch64-linux targets. Also implements
>> support for recording most if not all of instructions from a64 instruction set.
>>
>> gdb:
>>
>> 2014-06-04 Omair Javaid <omair.javaid@linaro.org>
>>
>> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Updated.
>> * aarch64-tdep.c (record.h): Include.
>> (record-full.h): Include.
>> (aarch64_record_data_proc_reg): New function.
>> (aarch64_record_data_proc_imm): New function.
>> (aarch64_record_branch_except_sys): New function.
>> (aarch64_record_load_store): New function.
>> (aarch64_record_decode_insn_handler): New function.
>> (deallocate_reg_mem): New function.
>> (aarch64_process_record): New function.
>> * aarch64-tdep.h (submask): New macro.
>> (bit): New macro.
>> (bits): New macro.
>> (REG_ALLOC): New macro.
>> (MEM_ALLOC): New macro.
>> (struct aarch64_mem_r): Defined.
>> (aarch64_record_result): New enum.
>> (struct insn_decode_record): Defined.
>> (insn_decode_record): New typedef.
>> (aarch64_process_record): New extern declaration.
>
> We want to support process record on aarch64-linux, but the code is
> added to aarch64-tdep.c. Does aarch64-elf target need process record?
> I prefer to add code to aarch64-linux-tdep.c. I know that code for
> process record on arm was added to arm-tdep.c too, but I don't think it
> is correct either.
If we try Record-Replay can work on any target running a gdb stub with
a little tweaking but we do need a linux host machine in all cases.
so I think *-tdep.c is the right place for it. Thats the reason
syscall recording code resides in *-linux-tdep.c but all other
instruction recording code is in *-tdep.c
>
>> diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
>> index 78fb779..8a193f4 100644
>> --- a/gdb/aarch64-tdep.h
>> +++ b/gdb/aarch64-tdep.h
>> @@ -90,4 +90,69 @@ struct gdbarch_tdep
>> struct type *vnb_type;
>> };
>>
>> +/* aarch64 process record-replay related structures, defines etc. */
>> +
>> +#define submask(x) ((1L << ((x) + 1)) - 1)
>> +#define bit(obj,st) (((obj) >> (st)) & 1)
>> +#define bits(obj,st,fn) (((obj) >> (st)) & submask ((fn) - (st)))
>
> If they are only used in aarch64-tdep.c, please define them there.
OK
>
>> +
>> +/* ARM memory record structure. */
>
> s/ARM/AArch64/
OK
>
>> +struct aarch64_mem_r
>> +{
>> + uint64_t len; /* Record length. */
>> + uint64_t addr; /* Memory address. */
>> +};
>> +
>> +enum aarch64_record_result
>> +{
>> + AARCH64_RECORD_SUCCESS,
>> + AARCH64_RECORD_FAILURE,
>> + AARCH64_RECORD_USUPPORTED
>> +};
>> +
>> +/* ARM instruction record contains opcode of current insn
OK
>
> Likewise.
>
> --
> Yao (齐尧)
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 4/7] Implements aarch64 process record and reverse debugging support
2014-09-01 20:08 ` Omair Javaid
@ 2014-09-18 0:09 ` Omair Javaid
2014-09-18 22:29 ` Omair Javaid
0 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-09-18 0:09 UTC (permalink / raw)
To: gdb-patches
2014-09-18 Omair Javaid <omair.javaid@linaro.org>
* aarch64-linux-tdep.c (aarch64_linux_init_abi): Install AArch64
process record handler.
* aarch64-tdep.c (record.h): Include.
(record-full.h): Include.
(submask): New macro.
(bit): New macro.
(bits): New macro.
(REG_ALLOC): New macro.
(MEM_ALLOC): New macro.
(struct aarch64_mem_r): Define.
(aarch64_record_result): New enum.
(struct insn_decode_record): Define.
(insn_decode_record): New typedef.
(aarch64_record_data_proc_reg): Add record handler for data processing
register insns.
(aarch64_record_data_proc_imm): Add record handler for data processing
immediate insns.
(aarch64_record_branch_except_sys): Add record handler for branch,
exception and system insns.
(aarch64_record_load_store): Add record handler for load/store insns.
(aarch64_record_decode_insn_handler): Add record insn decoding function.
(deallocate_reg_mem): Add memory cleanup function for record data.
(aarch64_process_record): Add gdbarch handler for AArch64 process
record.
* aarch64-tdep.h (aarch64_process_record): New extern declaration.
---
gdb/aarch64-linux-tdep.c | 3 +
gdb/aarch64-tdep.c | 578 +++++++++++++++++++++++++++++++++++++++++++++++
gdb/aarch64-tdep.h | 3 +
3 files changed, 584 insertions(+)
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index e5565a8..5ab7b37 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -401,6 +401,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
set_gdbarch_stap_is_single_operand (gdbarch, aarch64_stap_is_single_operand);
set_gdbarch_stap_parse_special_token (gdbarch,
aarch64_stap_parse_special_token);
+
+ /* Reversible debugging, process record. */
+ set_gdbarch_process_record (gdbarch, aarch64_process_record);
}
/* Provide a prototype to silence -Wmissing-prototypes. */
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index 1898f6b..ed28f68 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -50,6 +50,9 @@
#include "vec.h"
+#include "record.h"
+#include "record-full.h"
+
#include "features/aarch64.c"
/* Pseudo register base numbers. */
@@ -2804,3 +2807,578 @@ When on, AArch64 specific debugging is enabled."),
show_aarch64_debug,
&setdebuglist, &showdebuglist);
}
+
+/* AArch64 process record-replay related structures, defines etc. */
+
+#define submask(x) ((1L << ((x) + 1)) - 1)
+#define bit(obj,st) (((obj) >> (st)) & 1)
+#define bits(obj,st,fn) (((obj) >> (st)) & submask ((fn) - (st)))
+
+#define REG_ALLOC(REGS, LENGTH, RECORD_BUF) \
+ do \
+ { \
+ unsigned int reg_len = LENGTH; \
+ if (reg_len) \
+ { \
+ REGS = XNEWVEC (uint32_t, reg_len); \
+ memcpy(®S[0], &RECORD_BUF[0], sizeof(uint32_t)*LENGTH); \
+ } \
+ } \
+ while (0)
+
+#define MEM_ALLOC(MEMS, LENGTH, RECORD_BUF) \
+ do \
+ { \
+ unsigned int mem_len = LENGTH; \
+ if (mem_len) \
+ { \
+ MEMS = XNEWVEC (struct aarch64_mem_r, mem_len); \
+ memcpy(&MEMS->len, &RECORD_BUF[0], \
+ sizeof(struct aarch64_mem_r) * LENGTH); \
+ } \
+ } \
+ while (0)
+
+/* AArch64 memory record structure. */
+struct aarch64_mem_r
+{
+ uint64_t len; /* Record length. */
+ uint64_t addr; /* Memory address. */
+};
+
+enum aarch64_record_result
+{
+ AARCH64_RECORD_SUCCESS,
+ AARCH64_RECORD_FAILURE,
+ AARCH64_RECORD_UNSUPPORTED
+};
+
+/* AArch64 instruction record contains opcode of current insn and execution
+ state (before entry to decode_insn()), contains list of to-be-modified
+ registers and memory blocks (on return from decode_insn()). */
+
+typedef struct insn_decode_record_t
+{
+ struct gdbarch *gdbarch;
+ struct regcache *regcache;
+ CORE_ADDR this_addr;
+ uint32_t aarch64_insn;
+ uint32_t mem_rec_count;
+ uint32_t reg_rec_count;
+ uint32_t *aarch64_regs;
+ struct aarch64_mem_r *aarch64_mems;
+} insn_decode_record;
+
+/* Record handler for data processing - register instructions. */
+static unsigned int
+aarch64_record_data_proc_reg (insn_decode_record *aarch64_insn_r)
+{
+ uint8_t reg_rd, insn_bits24_27, insn_bits21_23, setflags;
+ uint32_t record_buf[4];
+
+ reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
+ insn_bits21_23 = bits (aarch64_insn_r->aarch64_insn, 21, 23);
+
+ if (!bit (aarch64_insn_r->aarch64_insn, 28))
+ {
+ /* Logical (shifted register). */
+ if (insn_bits24_27 == 0x0a)
+ setflags = (bits (aarch64_insn_r->aarch64_insn, 29, 30) == 0x03);
+ /* Add/subtract. */
+ else if (insn_bits24_27 == 0x0b)
+ setflags = bit (aarch64_insn_r->aarch64_insn, 29);
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ if (setflags)
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
+ }
+ else
+ {
+ if (insn_bits24_27 == 0x0b)
+ {
+ /* Data-processing (3 source). */
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ else if (insn_bits24_27 == 0x0a)
+ {
+ if (insn_bits21_23 == 0x00)
+ {
+ /* Add/subtract (with carry). */
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ if (bit (aarch64_insn_r->aarch64_insn, 29))
+ {
+ record_buf[1] = AARCH64_CPSR_REGNUM;
+ aarch64_insn_r->reg_rec_count = 2;
+ }
+ }
+ else if (insn_bits21_23 == 0x02)
+ {
+ /* Conditional compare (register) / Conditional compare (immediate). */
+ record_buf[0] = AARCH64_CPSR_REGNUM;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ else if (insn_bits21_23 == 0x04 || insn_bits21_23 == 0x06)
+ {
+ /* CConditional select. */
+ /* Data-processing (2 source). */
+ /* Data-processing (1 source). */
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+ }
+ }
+
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+
+/* Record handler for data processing - immediate instructions. */
+static unsigned int
+aarch64_record_data_proc_imm (insn_decode_record *aarch64_insn_r)
+{
+ uint8_t reg_rd, insn_bit28, insn_bit23, insn_bits24_27, setflags;
+ uint32_t record_buf[4];
+
+ reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ insn_bit28 = bit (aarch64_insn_r->aarch64_insn, 28);
+ insn_bit23 = bit (aarch64_insn_r->aarch64_insn, 23);
+ insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
+
+ /* PC rel addressing / Move wide immediate / BitField / Extract. */
+ if (insn_bits24_27 == 0x00 || insn_bits24_27 == 0x03 ||
+ (insn_bits24_27 == 0x02 && insn_bit23))
+ {
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ else if (insn_bits24_27 == 0x01)
+ {
+ /* Add/Subtract (immediate). */
+ setflags = bit (aarch64_insn_r->aarch64_insn, 29);
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ if (setflags)
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
+ }
+ else if (insn_bits24_27 == 0x02 && !insn_bit23)
+ {
+ /* Logical (immediate). */
+ setflags = bits (aarch64_insn_r->aarch64_insn, 29, 30) == 0x03;
+ record_buf[0] = reg_rd;
+ aarch64_insn_r->reg_rec_count = 1;
+ if (setflags)
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
+ }
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+
+/* Record handler for branch, exception generation and system instructions. */
+static unsigned int
+aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
+{
+ struct gdbarch_tdep *tdep = gdbarch_tdep (aarch64_insn_r->gdbarch);
+ uint8_t insn_bits24_27, insn_bits28_31, insn_bits22_23;
+ uint32_t record_buf[4];
+
+ insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
+ insn_bits28_31 = bits (aarch64_insn_r->aarch64_insn, 28, 31);
+ insn_bits22_23 = bits (aarch64_insn_r->aarch64_insn, 22, 23);
+
+ if (insn_bits28_31 == 0x0d)
+ {
+ /* Exception generation instructions. */
+ if (insn_bits24_27 == 0x04)
+ return AARCH64_RECORD_UNSUPPORTED;
+ /* System instructions. */
+ else if (insn_bits24_27 == 0x05 && insn_bits22_23 == 0x00)
+ {
+ record_buf[0] = AARCH64_CPSR_REGNUM;
+ record_buf[1] = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ aarch64_insn_r->reg_rec_count = 2;
+ }
+ else if((insn_bits24_27 & 0x0e) == 0x06)
+ {
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
+ if (bits (aarch64_insn_r->aarch64_insn, 21, 22) == 0x01)
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_LR_REGNUM;
+ }
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+ }
+ else if ((insn_bits28_31 & 0x07) == 0x01 && (insn_bits24_27 & 0x0c) == 0x04)
+ {
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
+ if (bit (aarch64_insn_r->aarch64_insn, 31))
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_LR_REGNUM;
+ }
+ else
+ /* All other types of branch instructions. */
+ record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
+
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+
+/* Record handler for load and store instructions. */
+static unsigned int
+aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
+{
+ uint8_t insn_bits24_27, insn_bits28_29, insn_bits10_11;
+ uint8_t insn_bit23, insn_bit21;
+ uint8_t opc, size_bits, ld_flag, vector_flag;
+ uint32_t reg_rn, reg_rt, reg_rt2;
+ uint64_t datasize, offset;
+ uint32_t record_buf[8];
+ uint64_t record_buf_mem[8];
+ CORE_ADDR address;
+
+ insn_bits10_11 = bits (aarch64_insn_r->aarch64_insn, 10, 11);
+ insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
+ insn_bits28_29 = bits (aarch64_insn_r->aarch64_insn, 28, 29);
+ insn_bit21 = bit (aarch64_insn_r->aarch64_insn, 21);
+ insn_bit23 = bit (aarch64_insn_r->aarch64_insn, 23);
+ ld_flag = bit (aarch64_insn_r->aarch64_insn, 22);
+ vector_flag = bit (aarch64_insn_r->aarch64_insn, 26);
+ reg_rt = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ reg_rn = bits (aarch64_insn_r->aarch64_insn, 5, 9);
+ reg_rt2 = bits (aarch64_insn_r->aarch64_insn, 10, 14);
+ size_bits = bits (aarch64_insn_r->aarch64_insn, 30, 31);
+
+ /* Load/store exclusive instructions decoding. */
+ if (insn_bits24_27 == 0x08 && insn_bits28_29 == 0x00)
+ {
+ if (ld_flag)
+ {
+ record_buf[0] = reg_rt;
+ aarch64_insn_r->reg_rec_count = 1;
+ if (insn_bit21)
+ {
+ record_buf[1] = reg_rt2;
+ aarch64_insn_r->reg_rec_count = 2;
+ }
+ }
+ else
+ {
+ if (insn_bit21)
+ datasize = (8 << size_bits) * 2;
+ else
+ datasize = (8 << size_bits);
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
+ &address);
+ record_buf_mem[0] = datasize / 8;
+ record_buf_mem[1] = address;
+ aarch64_insn_r->mem_rec_count = 1;
+ if (!insn_bit23)
+ {
+ /* Save register rs. */
+ record_buf[0] = bits (aarch64_insn_r->aarch64_insn, 16, 20);
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ }
+ }
+ /* Load register (literal) instructions decoding. */
+ else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x01)
+ {
+ if (vector_flag)
+ record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
+ else
+ record_buf[0] = reg_rt;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ /* All types of load/store pair instructions decoding. */
+ else if ((insn_bits24_27 & 0x0a) == 0x08 && insn_bits28_29 == 0x02)
+ {
+ if (ld_flag)
+ {
+ if (vector_flag)
+ {
+ record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
+ record_buf[1] = reg_rt2 + AARCH64_V0_REGNUM;
+ }
+ else
+ {
+ record_buf[0] = reg_rt;
+ record_buf[1] = reg_rt2;
+ }
+ aarch64_insn_r->reg_rec_count = 2;
+ }
+ else
+ {
+ uint16_t imm7_off;
+ imm7_off = bits (aarch64_insn_r->aarch64_insn, 15, 21);
+ if (!vector_flag)
+ size_bits = size_bits >> 1;
+ datasize = 8 << (2 + size_bits);
+ offset = (imm7_off & 0x40) ? (~imm7_off & 0x007f) + 1 : imm7_off;
+ offset = offset << (2 + size_bits);
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
+ &address);
+ if (!((insn_bits24_27 & 0x0b) == 0x08 && insn_bit23))
+ {
+ if (imm7_off & 0x40)
+ address = address - offset;
+ else
+ address = address + offset;
+ }
+
+ record_buf_mem[0] = datasize / 8;
+ record_buf_mem[1] = address;
+ record_buf_mem[2] = datasize / 8;
+ record_buf_mem[3] = address + (datasize / 8);
+ aarch64_insn_r->mem_rec_count = 2;
+ }
+ if (bit (aarch64_insn_r->aarch64_insn, 23))
+ record_buf[aarch64_insn_r->reg_rec_count++] = reg_rn;
+ }
+ /* Load/store register (unsigned immediate) instructions. */
+ else if ((insn_bits24_27 & 0x0b) == 0x09 && insn_bits28_29 == 0x03)
+ {
+ opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
+ if (!(opc >> 1))
+ if (opc & 0x01)
+ ld_flag = 0x01;
+ else
+ ld_flag = 0x0;
+ else
+ if (size_bits != 0x03)
+ ld_flag = 0x01;
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+
+ if (!ld_flag)
+ {
+ offset = bits (aarch64_insn_r->aarch64_insn, 10, 21);
+ datasize = 8 << size_bits;
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
+ &address);
+ offset = offset << size_bits;
+ address = address + offset;
+
+ record_buf_mem[0] = datasize >> 3;
+ record_buf_mem[1] = address;
+ aarch64_insn_r->mem_rec_count = 1;
+ }
+ else
+ {
+ if (vector_flag)
+ record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
+ else
+ record_buf[0] = reg_rt;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ }
+ /* Load/store register (register offset) instructions. */
+ else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 &&
+ insn_bits10_11 == 0x02 && insn_bit21)
+ {
+ opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
+ if (!(opc >> 1))
+ if (opc & 0x01)
+ ld_flag = 0x01;
+ else
+ ld_flag = 0x0;
+ else
+ if (size_bits != 0x03)
+ ld_flag = 0x01;
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+
+ if (!ld_flag)
+ {
+ uint64_t reg_rm_val;
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache,
+ bits (aarch64_insn_r->aarch64_insn, 16, 20), ®_rm_val);
+ if (bit (aarch64_insn_r->aarch64_insn, 12))
+ offset = reg_rm_val << size_bits;
+ else
+ offset = reg_rm_val;
+ datasize = 8 << size_bits;
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
+ &address);
+ address = address + offset;
+ record_buf_mem[0] = datasize >> 3;
+ record_buf_mem[1] = address;
+ aarch64_insn_r->mem_rec_count = 1;
+ }
+ else
+ {
+ if (vector_flag)
+ record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
+ else
+ record_buf[0] = reg_rt;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ }
+ /* Load/store register (immediate) instructions. */
+ else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 &&
+ !insn_bit21)
+ {
+ opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
+ if (!(opc >> 1))
+ if (opc & 0x01)
+ ld_flag = 0x01;
+ else
+ ld_flag = 0x0;
+ else
+ if (size_bits != 0x03)
+ ld_flag = 0x01;
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+
+ if (!ld_flag)
+ {
+ uint16_t imm9_off;
+ imm9_off = bits (aarch64_insn_r->aarch64_insn, 12, 20);
+ offset = (imm9_off & 0x0100) ? (((~imm9_off) & 0x01ff) + 1) : imm9_off;
+ datasize = 8 << size_bits;
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
+ &address);
+ if (insn_bits10_11 != 0x01)
+ {
+ if (imm9_off & 0x0100)
+ address = address - offset;
+ else
+ address = address + offset;
+ }
+ record_buf_mem[0] = datasize >> 3;
+ record_buf_mem[1] = address;
+ aarch64_insn_r->mem_rec_count = 1;
+ }
+ else
+ {
+ if (vector_flag)
+ record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
+ else
+ record_buf[0] = reg_rt;
+ aarch64_insn_r->reg_rec_count = 1;
+ }
+ if (insn_bits10_11 == 0x01 || insn_bits10_11 == 0x03)
+ record_buf[aarch64_insn_r->reg_rec_count++] = reg_rn;
+ }
+ /* Advanced SIMD load/store instructions. */
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+
+ MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count,
+ record_buf_mem);
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+/* Decodes insns type and invokes its record handler. */
+
+static unsigned int
+aarch64_record_decode_insn_handler (insn_decode_record *aarch64_insn_r)
+{
+ uint32_t ins_bit25, ins_bit26, ins_bit27, ins_bit28;
+
+ ins_bit25 = bit (aarch64_insn_r->aarch64_insn, 25);
+ ins_bit26 = bit (aarch64_insn_r->aarch64_insn, 26);
+ ins_bit27 = bit (aarch64_insn_r->aarch64_insn, 27);
+ ins_bit28 = bit (aarch64_insn_r->aarch64_insn, 28);
+
+ /* Data processing - immediate instructions. */
+ if (!ins_bit26 && !ins_bit27 && ins_bit28)
+ return aarch64_record_data_proc_imm (aarch64_insn_r);
+
+ /* Branch, exception generation and system instructions. */
+ if (ins_bit26 && !ins_bit27 && ins_bit28)
+ return aarch64_record_branch_except_sys (aarch64_insn_r);
+
+ /* Load and store instructions. */
+ if (!ins_bit25 && ins_bit27)
+ return aarch64_record_load_store (aarch64_insn_r);
+
+ /* Data processing - register instructions. */
+ if (ins_bit25 && !ins_bit26 && ins_bit27)
+ return aarch64_record_data_proc_reg (aarch64_insn_r);
+
+ /* Data processing - SIMD and floating point instructions. */
+ if (ins_bit25 && ins_bit26 && ins_bit27)
+ return AARCH64_RECORD_UNSUPPORTED;
+
+ return AARCH64_RECORD_UNSUPPORTED;
+}
+
+/* Cleans up local record registers and memory allocations. */
+
+static void
+deallocate_reg_mem (insn_decode_record *record)
+{
+ xfree (record->aarch64_regs);
+ xfree (record->aarch64_mems);
+}
+
+/* Parse the current instruction and record the values of the registers and
+ memory that will be changed in current instruction to record_arch_list
+ return -1 if something is wrong. */
+
+int
+aarch64_process_record (struct gdbarch *gdbarch, struct regcache *regcache,
+ CORE_ADDR insn_addr)
+{
+ uint32_t rec_no = 0;
+ uint8_t insn_size = 4;
+ uint32_t ret = 0;
+ ULONGEST t_bit = 0, insn_id = 0;
+ gdb_byte buf[insn_size];
+ insn_decode_record aarch64_record;
+
+ memset (&buf[0], 0, insn_size);
+ memset (&aarch64_record, 0, sizeof (insn_decode_record));
+ target_read_memory (insn_addr, &buf[0], insn_size);
+ aarch64_record.aarch64_insn = (uint32_t) extract_unsigned_integer (&buf[0],
+ insn_size, gdbarch_byte_order (gdbarch));
+ aarch64_record.regcache = regcache;
+ aarch64_record.this_addr = insn_addr;
+ aarch64_record.gdbarch = gdbarch;
+
+ ret = aarch64_record_decode_insn_handler (&aarch64_record);
+ if (ret == AARCH64_RECORD_UNSUPPORTED)
+ {
+ printf_unfiltered (_("Process record does not support instruction "
+ "0x%0x at address %s.\n"),aarch64_record.aarch64_insn,
+ paddress (gdbarch, insn_addr));
+ ret = -1;
+ }
+
+ if (0 == ret)
+ {
+ /* Record registers. */
+ record_full_arch_list_add_reg (aarch64_record.regcache, AARCH64_PC_REGNUM);
+ if (aarch64_record.aarch64_regs)
+ for (rec_no = 0; rec_no < aarch64_record.reg_rec_count; rec_no++)
+ if (record_full_arch_list_add_reg (aarch64_record.regcache,
+ aarch64_record.aarch64_regs[rec_no]))
+ ret = -1;
+
+ /* Record memories. */
+ if (aarch64_record.aarch64_mems)
+ for (rec_no = 0; rec_no < aarch64_record.mem_rec_count; rec_no++)
+ if (record_full_arch_list_add_mem
+ ((CORE_ADDR)aarch64_record.aarch64_mems[rec_no].addr,
+ aarch64_record.aarch64_mems[rec_no].len))
+ ret = -1;
+
+ if (record_full_arch_list_add_end ())
+ ret = -1;
+ }
+
+ deallocate_reg_mem (&aarch64_record);
+ return ret;
+}
diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
index 78fb779..3dd3dcc 100644
--- a/gdb/aarch64-tdep.h
+++ b/gdb/aarch64-tdep.h
@@ -90,4 +90,7 @@ struct gdbarch_tdep
struct type *vnb_type;
};
+extern int aarch64_process_record (struct gdbarch *gdbarch,
+ struct regcache *regcache, CORE_ADDR addr);
+
#endif /* aarch64-tdep.h */
--
1.9.1
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 4/7] Implements aarch64 process record and reverse debugging support
2014-09-18 0:09 ` Omair Javaid
@ 2014-09-18 22:29 ` Omair Javaid
2014-10-14 12:48 ` Omair Javaid
0 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-09-18 22:29 UTC (permalink / raw)
To: gdb-patches, Pedro Alves
On 18 September 2014 05:09, Omair Javaid <omair.javaid@linaro.org> wrote:
> 2014-09-18 Omair Javaid <omair.javaid@linaro.org>
>
> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Install AArch64
> process record handler.
> * aarch64-tdep.c (record.h): Include.
> (record-full.h): Include.
> (submask): New macro.
> (bit): New macro.
> (bits): New macro.
> (REG_ALLOC): New macro.
> (MEM_ALLOC): New macro.
> (struct aarch64_mem_r): Define.
> (aarch64_record_result): New enum.
> (struct insn_decode_record): Define.
> (insn_decode_record): New typedef.
> (aarch64_record_data_proc_reg): Add record handler for data processing
> register insns.
> (aarch64_record_data_proc_imm): Add record handler for data processing
> immediate insns.
> (aarch64_record_branch_except_sys): Add record handler for branch,
> exception and system insns.
> (aarch64_record_load_store): Add record handler for load/store insns.
> (aarch64_record_decode_insn_handler): Add record insn decoding function.
> (deallocate_reg_mem): Add memory cleanup function for record data.
> (aarch64_process_record): Add gdbarch handler for AArch64 process
> record.
> * aarch64-tdep.h (aarch64_process_record): New extern declaration.
> ---
> gdb/aarch64-linux-tdep.c | 3 +
> gdb/aarch64-tdep.c | 578 +++++++++++++++++++++++++++++++++++++++++++++++
> gdb/aarch64-tdep.h | 3 +
> 3 files changed, 584 insertions(+)
>
> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
> index e5565a8..5ab7b37 100644
> --- a/gdb/aarch64-linux-tdep.c
> +++ b/gdb/aarch64-linux-tdep.c
> @@ -401,6 +401,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
> set_gdbarch_stap_is_single_operand (gdbarch, aarch64_stap_is_single_operand);
> set_gdbarch_stap_parse_special_token (gdbarch,
> aarch64_stap_parse_special_token);
> +
> + /* Reversible debugging, process record. */
> + set_gdbarch_process_record (gdbarch, aarch64_process_record);
> }
>
> /* Provide a prototype to silence -Wmissing-prototypes. */
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index 1898f6b..ed28f68 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -50,6 +50,9 @@
>
> #include "vec.h"
>
> +#include "record.h"
> +#include "record-full.h"
> +
> #include "features/aarch64.c"
>
> /* Pseudo register base numbers. */
> @@ -2804,3 +2807,578 @@ When on, AArch64 specific debugging is enabled."),
> show_aarch64_debug,
> &setdebuglist, &showdebuglist);
> }
> +
> +/* AArch64 process record-replay related structures, defines etc. */
> +
> +#define submask(x) ((1L << ((x) + 1)) - 1)
> +#define bit(obj,st) (((obj) >> (st)) & 1)
> +#define bits(obj,st,fn) (((obj) >> (st)) & submask ((fn) - (st)))
> +
> +#define REG_ALLOC(REGS, LENGTH, RECORD_BUF) \
> + do \
> + { \
> + unsigned int reg_len = LENGTH; \
> + if (reg_len) \
> + { \
> + REGS = XNEWVEC (uint32_t, reg_len); \
> + memcpy(®S[0], &RECORD_BUF[0], sizeof(uint32_t)*LENGTH); \
> + } \
> + } \
> + while (0)
> +
> +#define MEM_ALLOC(MEMS, LENGTH, RECORD_BUF) \
> + do \
> + { \
> + unsigned int mem_len = LENGTH; \
> + if (mem_len) \
> + { \
> + MEMS = XNEWVEC (struct aarch64_mem_r, mem_len); \
> + memcpy(&MEMS->len, &RECORD_BUF[0], \
> + sizeof(struct aarch64_mem_r) * LENGTH); \
> + } \
> + } \
> + while (0)
> +
> +/* AArch64 memory record structure. */
> +struct aarch64_mem_r
> +{
> + uint64_t len; /* Record length. */
> + uint64_t addr; /* Memory address. */
> +};
> +
> +enum aarch64_record_result
> +{
> + AARCH64_RECORD_SUCCESS,
> + AARCH64_RECORD_FAILURE,
> + AARCH64_RECORD_UNSUPPORTED
> +};
> +
> +/* AArch64 instruction record contains opcode of current insn and execution
> + state (before entry to decode_insn()), contains list of to-be-modified
> + registers and memory blocks (on return from decode_insn()). */
> +
> +typedef struct insn_decode_record_t
> +{
> + struct gdbarch *gdbarch;
> + struct regcache *regcache;
> + CORE_ADDR this_addr;
> + uint32_t aarch64_insn;
> + uint32_t mem_rec_count;
> + uint32_t reg_rec_count;
> + uint32_t *aarch64_regs;
> + struct aarch64_mem_r *aarch64_mems;
> +} insn_decode_record;
> +
> +/* Record handler for data processing - register instructions. */
> +static unsigned int
> +aarch64_record_data_proc_reg (insn_decode_record *aarch64_insn_r)
> +{
> + uint8_t reg_rd, insn_bits24_27, insn_bits21_23, setflags;
> + uint32_t record_buf[4];
> +
> + reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
> + insn_bits21_23 = bits (aarch64_insn_r->aarch64_insn, 21, 23);
> +
> + if (!bit (aarch64_insn_r->aarch64_insn, 28))
> + {
> + /* Logical (shifted register). */
> + if (insn_bits24_27 == 0x0a)
> + setflags = (bits (aarch64_insn_r->aarch64_insn, 29, 30) == 0x03);
> + /* Add/subtract. */
> + else if (insn_bits24_27 == 0x0b)
> + setflags = bit (aarch64_insn_r->aarch64_insn, 29);
> + else
> + return AARCH64_RECORD_UNSUPPORTED;
> +
> + record_buf[0] = reg_rd;
> + aarch64_insn_r->reg_rec_count = 1;
> + if (setflags)
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
> + }
> + else
> + {
> + if (insn_bits24_27 == 0x0b)
> + {
> + /* Data-processing (3 source). */
> + record_buf[0] = reg_rd;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + else if (insn_bits24_27 == 0x0a)
> + {
> + if (insn_bits21_23 == 0x00)
> + {
> + /* Add/subtract (with carry). */
> + record_buf[0] = reg_rd;
> + aarch64_insn_r->reg_rec_count = 1;
> + if (bit (aarch64_insn_r->aarch64_insn, 29))
> + {
> + record_buf[1] = AARCH64_CPSR_REGNUM;
> + aarch64_insn_r->reg_rec_count = 2;
> + }
> + }
> + else if (insn_bits21_23 == 0x02)
> + {
> + /* Conditional compare (register) / Conditional compare (immediate). */
> + record_buf[0] = AARCH64_CPSR_REGNUM;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + else if (insn_bits21_23 == 0x04 || insn_bits21_23 == 0x06)
> + {
> + /* CConditional select. */
> + /* Data-processing (2 source). */
> + /* Data-processing (1 source). */
> + record_buf[0] = reg_rd;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + else
> + return AARCH64_RECORD_UNSUPPORTED;
> + }
> + }
> +
> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
> + record_buf);
> + return AARCH64_RECORD_SUCCESS;
> +}
> +
> +/* Record handler for data processing - immediate instructions. */
> +static unsigned int
> +aarch64_record_data_proc_imm (insn_decode_record *aarch64_insn_r)
> +{
> + uint8_t reg_rd, insn_bit28, insn_bit23, insn_bits24_27, setflags;
> + uint32_t record_buf[4];
> +
> + reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
> + insn_bit28 = bit (aarch64_insn_r->aarch64_insn, 28);
> + insn_bit23 = bit (aarch64_insn_r->aarch64_insn, 23);
> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
> +
> + /* PC rel addressing / Move wide immediate / BitField / Extract. */
> + if (insn_bits24_27 == 0x00 || insn_bits24_27 == 0x03 ||
> + (insn_bits24_27 == 0x02 && insn_bit23))
> + {
> + record_buf[0] = reg_rd;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + else if (insn_bits24_27 == 0x01)
> + {
> + /* Add/Subtract (immediate). */
> + setflags = bit (aarch64_insn_r->aarch64_insn, 29);
> + record_buf[0] = reg_rd;
> + aarch64_insn_r->reg_rec_count = 1;
> + if (setflags)
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
> + }
> + else if (insn_bits24_27 == 0x02 && !insn_bit23)
> + {
> + /* Logical (immediate). */
> + setflags = bits (aarch64_insn_r->aarch64_insn, 29, 30) == 0x03;
> + record_buf[0] = reg_rd;
> + aarch64_insn_r->reg_rec_count = 1;
> + if (setflags)
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
> + }
> + else
> + return AARCH64_RECORD_UNSUPPORTED;
> +
> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
> + record_buf);
> + return AARCH64_RECORD_SUCCESS;
> +}
> +
> +/* Record handler for branch, exception generation and system instructions. */
> +static unsigned int
> +aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
> +{
> + struct gdbarch_tdep *tdep = gdbarch_tdep (aarch64_insn_r->gdbarch);
> + uint8_t insn_bits24_27, insn_bits28_31, insn_bits22_23;
> + uint32_t record_buf[4];
> +
> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
> + insn_bits28_31 = bits (aarch64_insn_r->aarch64_insn, 28, 31);
> + insn_bits22_23 = bits (aarch64_insn_r->aarch64_insn, 22, 23);
> +
> + if (insn_bits28_31 == 0x0d)
> + {
> + /* Exception generation instructions. */
> + if (insn_bits24_27 == 0x04)
> + return AARCH64_RECORD_UNSUPPORTED;
> + /* System instructions. */
> + else if (insn_bits24_27 == 0x05 && insn_bits22_23 == 0x00)
> + {
> + record_buf[0] = AARCH64_CPSR_REGNUM;
> + record_buf[1] = bits (aarch64_insn_r->aarch64_insn, 0, 4);
> + aarch64_insn_r->reg_rec_count = 2;
> + }
> + else if((insn_bits24_27 & 0x0e) == 0x06)
> + {
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
> + if (bits (aarch64_insn_r->aarch64_insn, 21, 22) == 0x01)
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_LR_REGNUM;
> + }
> + else
> + return AARCH64_RECORD_UNSUPPORTED;
> + }
> + else if ((insn_bits28_31 & 0x07) == 0x01 && (insn_bits24_27 & 0x0c) == 0x04)
> + {
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
> + if (bit (aarch64_insn_r->aarch64_insn, 31))
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_LR_REGNUM;
> + }
> + else
> + /* All other types of branch instructions. */
> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
> +
> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
> + record_buf);
> + return AARCH64_RECORD_SUCCESS;
> +}
> +
> +/* Record handler for load and store instructions. */
> +static unsigned int
> +aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
> +{
> + uint8_t insn_bits24_27, insn_bits28_29, insn_bits10_11;
> + uint8_t insn_bit23, insn_bit21;
> + uint8_t opc, size_bits, ld_flag, vector_flag;
> + uint32_t reg_rn, reg_rt, reg_rt2;
> + uint64_t datasize, offset;
> + uint32_t record_buf[8];
> + uint64_t record_buf_mem[8];
> + CORE_ADDR address;
> +
> + insn_bits10_11 = bits (aarch64_insn_r->aarch64_insn, 10, 11);
> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
> + insn_bits28_29 = bits (aarch64_insn_r->aarch64_insn, 28, 29);
> + insn_bit21 = bit (aarch64_insn_r->aarch64_insn, 21);
> + insn_bit23 = bit (aarch64_insn_r->aarch64_insn, 23);
> + ld_flag = bit (aarch64_insn_r->aarch64_insn, 22);
> + vector_flag = bit (aarch64_insn_r->aarch64_insn, 26);
> + reg_rt = bits (aarch64_insn_r->aarch64_insn, 0, 4);
> + reg_rn = bits (aarch64_insn_r->aarch64_insn, 5, 9);
> + reg_rt2 = bits (aarch64_insn_r->aarch64_insn, 10, 14);
> + size_bits = bits (aarch64_insn_r->aarch64_insn, 30, 31);
> +
> + /* Load/store exclusive instructions decoding. */
> + if (insn_bits24_27 == 0x08 && insn_bits28_29 == 0x00)
> + {
> + if (ld_flag)
> + {
> + record_buf[0] = reg_rt;
> + aarch64_insn_r->reg_rec_count = 1;
> + if (insn_bit21)
> + {
> + record_buf[1] = reg_rt2;
> + aarch64_insn_r->reg_rec_count = 2;
> + }
> + }
> + else
> + {
> + if (insn_bit21)
> + datasize = (8 << size_bits) * 2;
> + else
> + datasize = (8 << size_bits);
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
> + &address);
> + record_buf_mem[0] = datasize / 8;
> + record_buf_mem[1] = address;
> + aarch64_insn_r->mem_rec_count = 1;
> + if (!insn_bit23)
> + {
> + /* Save register rs. */
> + record_buf[0] = bits (aarch64_insn_r->aarch64_insn, 16, 20);
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + }
> + }
> + /* Load register (literal) instructions decoding. */
> + else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x01)
> + {
> + if (vector_flag)
> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
> + else
> + record_buf[0] = reg_rt;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + /* All types of load/store pair instructions decoding. */
> + else if ((insn_bits24_27 & 0x0a) == 0x08 && insn_bits28_29 == 0x02)
> + {
> + if (ld_flag)
> + {
> + if (vector_flag)
> + {
> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
> + record_buf[1] = reg_rt2 + AARCH64_V0_REGNUM;
> + }
> + else
> + {
> + record_buf[0] = reg_rt;
> + record_buf[1] = reg_rt2;
> + }
> + aarch64_insn_r->reg_rec_count = 2;
> + }
> + else
> + {
> + uint16_t imm7_off;
> + imm7_off = bits (aarch64_insn_r->aarch64_insn, 15, 21);
> + if (!vector_flag)
> + size_bits = size_bits >> 1;
> + datasize = 8 << (2 + size_bits);
> + offset = (imm7_off & 0x40) ? (~imm7_off & 0x007f) + 1 : imm7_off;
> + offset = offset << (2 + size_bits);
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
> + &address);
> + if (!((insn_bits24_27 & 0x0b) == 0x08 && insn_bit23))
> + {
> + if (imm7_off & 0x40)
> + address = address - offset;
> + else
> + address = address + offset;
> + }
> +
> + record_buf_mem[0] = datasize / 8;
> + record_buf_mem[1] = address;
> + record_buf_mem[2] = datasize / 8;
> + record_buf_mem[3] = address + (datasize / 8);
> + aarch64_insn_r->mem_rec_count = 2;
> + }
> + if (bit (aarch64_insn_r->aarch64_insn, 23))
> + record_buf[aarch64_insn_r->reg_rec_count++] = reg_rn;
> + }
> + /* Load/store register (unsigned immediate) instructions. */
> + else if ((insn_bits24_27 & 0x0b) == 0x09 && insn_bits28_29 == 0x03)
> + {
> + opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
> + if (!(opc >> 1))
> + if (opc & 0x01)
> + ld_flag = 0x01;
> + else
> + ld_flag = 0x0;
> + else
> + if (size_bits != 0x03)
> + ld_flag = 0x01;
> + else
> + return AARCH64_RECORD_UNSUPPORTED;
> +
> + if (!ld_flag)
> + {
> + offset = bits (aarch64_insn_r->aarch64_insn, 10, 21);
> + datasize = 8 << size_bits;
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
> + &address);
> + offset = offset << size_bits;
> + address = address + offset;
> +
> + record_buf_mem[0] = datasize >> 3;
> + record_buf_mem[1] = address;
> + aarch64_insn_r->mem_rec_count = 1;
> + }
> + else
> + {
> + if (vector_flag)
> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
> + else
> + record_buf[0] = reg_rt;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + }
> + /* Load/store register (register offset) instructions. */
> + else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 &&
> + insn_bits10_11 == 0x02 && insn_bit21)
> + {
> + opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
> + if (!(opc >> 1))
> + if (opc & 0x01)
> + ld_flag = 0x01;
> + else
> + ld_flag = 0x0;
> + else
> + if (size_bits != 0x03)
> + ld_flag = 0x01;
> + else
> + return AARCH64_RECORD_UNSUPPORTED;
> +
> + if (!ld_flag)
> + {
> + uint64_t reg_rm_val;
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache,
> + bits (aarch64_insn_r->aarch64_insn, 16, 20), ®_rm_val);
> + if (bit (aarch64_insn_r->aarch64_insn, 12))
> + offset = reg_rm_val << size_bits;
> + else
> + offset = reg_rm_val;
> + datasize = 8 << size_bits;
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
> + &address);
> + address = address + offset;
> + record_buf_mem[0] = datasize >> 3;
> + record_buf_mem[1] = address;
> + aarch64_insn_r->mem_rec_count = 1;
> + }
> + else
> + {
> + if (vector_flag)
> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
> + else
> + record_buf[0] = reg_rt;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + }
> + /* Load/store register (immediate) instructions. */
> + else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 &&
> + !insn_bit21)
> + {
> + opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
> + if (!(opc >> 1))
> + if (opc & 0x01)
> + ld_flag = 0x01;
> + else
> + ld_flag = 0x0;
> + else
> + if (size_bits != 0x03)
> + ld_flag = 0x01;
> + else
> + return AARCH64_RECORD_UNSUPPORTED;
> +
> + if (!ld_flag)
> + {
> + uint16_t imm9_off;
> + imm9_off = bits (aarch64_insn_r->aarch64_insn, 12, 20);
> + offset = (imm9_off & 0x0100) ? (((~imm9_off) & 0x01ff) + 1) : imm9_off;
> + datasize = 8 << size_bits;
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
> + &address);
> + if (insn_bits10_11 != 0x01)
> + {
> + if (imm9_off & 0x0100)
> + address = address - offset;
> + else
> + address = address + offset;
> + }
> + record_buf_mem[0] = datasize >> 3;
> + record_buf_mem[1] = address;
> + aarch64_insn_r->mem_rec_count = 1;
> + }
> + else
> + {
> + if (vector_flag)
> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
> + else
> + record_buf[0] = reg_rt;
> + aarch64_insn_r->reg_rec_count = 1;
> + }
> + if (insn_bits10_11 == 0x01 || insn_bits10_11 == 0x03)
> + record_buf[aarch64_insn_r->reg_rec_count++] = reg_rn;
> + }
> + /* Advanced SIMD load/store instructions. */
> + else
> + return AARCH64_RECORD_UNSUPPORTED;
> +
> + MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count,
> + record_buf_mem);
> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
> + record_buf);
> + return AARCH64_RECORD_SUCCESS;
> +}
> +/* Decodes insns type and invokes its record handler. */
> +
> +static unsigned int
> +aarch64_record_decode_insn_handler (insn_decode_record *aarch64_insn_r)
> +{
> + uint32_t ins_bit25, ins_bit26, ins_bit27, ins_bit28;
> +
> + ins_bit25 = bit (aarch64_insn_r->aarch64_insn, 25);
> + ins_bit26 = bit (aarch64_insn_r->aarch64_insn, 26);
> + ins_bit27 = bit (aarch64_insn_r->aarch64_insn, 27);
> + ins_bit28 = bit (aarch64_insn_r->aarch64_insn, 28);
> +
> + /* Data processing - immediate instructions. */
> + if (!ins_bit26 && !ins_bit27 && ins_bit28)
> + return aarch64_record_data_proc_imm (aarch64_insn_r);
> +
> + /* Branch, exception generation and system instructions. */
> + if (ins_bit26 && !ins_bit27 && ins_bit28)
> + return aarch64_record_branch_except_sys (aarch64_insn_r);
> +
> + /* Load and store instructions. */
> + if (!ins_bit25 && ins_bit27)
> + return aarch64_record_load_store (aarch64_insn_r);
> +
> + /* Data processing - register instructions. */
> + if (ins_bit25 && !ins_bit26 && ins_bit27)
> + return aarch64_record_data_proc_reg (aarch64_insn_r);
> +
> + /* Data processing - SIMD and floating point instructions. */
> + if (ins_bit25 && ins_bit26 && ins_bit27)
> + return AARCH64_RECORD_UNSUPPORTED;
> +
> + return AARCH64_RECORD_UNSUPPORTED;
> +}
> +
> +/* Cleans up local record registers and memory allocations. */
> +
> +static void
> +deallocate_reg_mem (insn_decode_record *record)
> +{
> + xfree (record->aarch64_regs);
> + xfree (record->aarch64_mems);
> +}
> +
> +/* Parse the current instruction and record the values of the registers and
> + memory that will be changed in current instruction to record_arch_list
> + return -1 if something is wrong. */
> +
> +int
> +aarch64_process_record (struct gdbarch *gdbarch, struct regcache *regcache,
> + CORE_ADDR insn_addr)
> +{
> + uint32_t rec_no = 0;
> + uint8_t insn_size = 4;
> + uint32_t ret = 0;
> + ULONGEST t_bit = 0, insn_id = 0;
> + gdb_byte buf[insn_size];
> + insn_decode_record aarch64_record;
> +
> + memset (&buf[0], 0, insn_size);
> + memset (&aarch64_record, 0, sizeof (insn_decode_record));
> + target_read_memory (insn_addr, &buf[0], insn_size);
> + aarch64_record.aarch64_insn = (uint32_t) extract_unsigned_integer (&buf[0],
> + insn_size, gdbarch_byte_order (gdbarch));
> + aarch64_record.regcache = regcache;
> + aarch64_record.this_addr = insn_addr;
> + aarch64_record.gdbarch = gdbarch;
> +
> + ret = aarch64_record_decode_insn_handler (&aarch64_record);
> + if (ret == AARCH64_RECORD_UNSUPPORTED)
> + {
> + printf_unfiltered (_("Process record does not support instruction "
> + "0x%0x at address %s.\n"),aarch64_record.aarch64_insn,
> + paddress (gdbarch, insn_addr));
> + ret = -1;
> + }
> +
> + if (0 == ret)
> + {
> + /* Record registers. */
> + record_full_arch_list_add_reg (aarch64_record.regcache, AARCH64_PC_REGNUM);
> + if (aarch64_record.aarch64_regs)
> + for (rec_no = 0; rec_no < aarch64_record.reg_rec_count; rec_no++)
> + if (record_full_arch_list_add_reg (aarch64_record.regcache,
> + aarch64_record.aarch64_regs[rec_no]))
> + ret = -1;
> +
> + /* Record memories. */
> + if (aarch64_record.aarch64_mems)
> + for (rec_no = 0; rec_no < aarch64_record.mem_rec_count; rec_no++)
> + if (record_full_arch_list_add_mem
> + ((CORE_ADDR)aarch64_record.aarch64_mems[rec_no].addr,
> + aarch64_record.aarch64_mems[rec_no].len))
> + ret = -1;
> +
> + if (record_full_arch_list_add_end ())
> + ret = -1;
> + }
> +
> + deallocate_reg_mem (&aarch64_record);
> + return ret;
> +}
> diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
> index 78fb779..3dd3dcc 100644
> --- a/gdb/aarch64-tdep.h
> +++ b/gdb/aarch64-tdep.h
> @@ -90,4 +90,7 @@ struct gdbarch_tdep
> struct type *vnb_type;
> };
>
> +extern int aarch64_process_record (struct gdbarch *gdbarch,
> + struct regcache *regcache, CORE_ADDR addr);
> +
> #endif /* aarch64-tdep.h */
> --
> 1.9.1
>
Ping! Kindly help me approve this patch series.
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 4/7] Implements aarch64 process record and reverse debugging support
2014-09-18 22:29 ` Omair Javaid
@ 2014-10-14 12:48 ` Omair Javaid
2014-10-21 9:08 ` Omair Javaid
0 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-10-14 12:48 UTC (permalink / raw)
To: gdb-patches, Pedro Alves
On 19 September 2014 03:28, Omair Javaid <omair.javaid@linaro.org> wrote:
> On 18 September 2014 05:09, Omair Javaid <omair.javaid@linaro.org> wrote:
>> 2014-09-18 Omair Javaid <omair.javaid@linaro.org>
>>
>> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Install AArch64
>> process record handler.
>> * aarch64-tdep.c (record.h): Include.
>> (record-full.h): Include.
>> (submask): New macro.
>> (bit): New macro.
>> (bits): New macro.
>> (REG_ALLOC): New macro.
>> (MEM_ALLOC): New macro.
>> (struct aarch64_mem_r): Define.
>> (aarch64_record_result): New enum.
>> (struct insn_decode_record): Define.
>> (insn_decode_record): New typedef.
>> (aarch64_record_data_proc_reg): Add record handler for data processing
>> register insns.
>> (aarch64_record_data_proc_imm): Add record handler for data processing
>> immediate insns.
>> (aarch64_record_branch_except_sys): Add record handler for branch,
>> exception and system insns.
>> (aarch64_record_load_store): Add record handler for load/store insns.
>> (aarch64_record_decode_insn_handler): Add record insn decoding function.
>> (deallocate_reg_mem): Add memory cleanup function for record data.
>> (aarch64_process_record): Add gdbarch handler for AArch64 process
>> record.
>> * aarch64-tdep.h (aarch64_process_record): New extern declaration.
>> ---
>> gdb/aarch64-linux-tdep.c | 3 +
>> gdb/aarch64-tdep.c | 578 +++++++++++++++++++++++++++++++++++++++++++++++
>> gdb/aarch64-tdep.h | 3 +
>> 3 files changed, 584 insertions(+)
>>
>> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
>> index e5565a8..5ab7b37 100644
>> --- a/gdb/aarch64-linux-tdep.c
>> +++ b/gdb/aarch64-linux-tdep.c
>> @@ -401,6 +401,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>> set_gdbarch_stap_is_single_operand (gdbarch, aarch64_stap_is_single_operand);
>> set_gdbarch_stap_parse_special_token (gdbarch,
>> aarch64_stap_parse_special_token);
>> +
>> + /* Reversible debugging, process record. */
>> + set_gdbarch_process_record (gdbarch, aarch64_process_record);
>> }
>>
>> /* Provide a prototype to silence -Wmissing-prototypes. */
>> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
>> index 1898f6b..ed28f68 100644
>> --- a/gdb/aarch64-tdep.c
>> +++ b/gdb/aarch64-tdep.c
>> @@ -50,6 +50,9 @@
>>
>> #include "vec.h"
>>
>> +#include "record.h"
>> +#include "record-full.h"
>> +
>> #include "features/aarch64.c"
>>
>> /* Pseudo register base numbers. */
>> @@ -2804,3 +2807,578 @@ When on, AArch64 specific debugging is enabled."),
>> show_aarch64_debug,
>> &setdebuglist, &showdebuglist);
>> }
>> +
>> +/* AArch64 process record-replay related structures, defines etc. */
>> +
>> +#define submask(x) ((1L << ((x) + 1)) - 1)
>> +#define bit(obj,st) (((obj) >> (st)) & 1)
>> +#define bits(obj,st,fn) (((obj) >> (st)) & submask ((fn) - (st)))
>> +
>> +#define REG_ALLOC(REGS, LENGTH, RECORD_BUF) \
>> + do \
>> + { \
>> + unsigned int reg_len = LENGTH; \
>> + if (reg_len) \
>> + { \
>> + REGS = XNEWVEC (uint32_t, reg_len); \
>> + memcpy(®S[0], &RECORD_BUF[0], sizeof(uint32_t)*LENGTH); \
>> + } \
>> + } \
>> + while (0)
>> +
>> +#define MEM_ALLOC(MEMS, LENGTH, RECORD_BUF) \
>> + do \
>> + { \
>> + unsigned int mem_len = LENGTH; \
>> + if (mem_len) \
>> + { \
>> + MEMS = XNEWVEC (struct aarch64_mem_r, mem_len); \
>> + memcpy(&MEMS->len, &RECORD_BUF[0], \
>> + sizeof(struct aarch64_mem_r) * LENGTH); \
>> + } \
>> + } \
>> + while (0)
>> +
>> +/* AArch64 memory record structure. */
>> +struct aarch64_mem_r
>> +{
>> + uint64_t len; /* Record length. */
>> + uint64_t addr; /* Memory address. */
>> +};
>> +
>> +enum aarch64_record_result
>> +{
>> + AARCH64_RECORD_SUCCESS,
>> + AARCH64_RECORD_FAILURE,
>> + AARCH64_RECORD_UNSUPPORTED
>> +};
>> +
>> +/* AArch64 instruction record contains opcode of current insn and execution
>> + state (before entry to decode_insn()), contains list of to-be-modified
>> + registers and memory blocks (on return from decode_insn()). */
>> +
>> +typedef struct insn_decode_record_t
>> +{
>> + struct gdbarch *gdbarch;
>> + struct regcache *regcache;
>> + CORE_ADDR this_addr;
>> + uint32_t aarch64_insn;
>> + uint32_t mem_rec_count;
>> + uint32_t reg_rec_count;
>> + uint32_t *aarch64_regs;
>> + struct aarch64_mem_r *aarch64_mems;
>> +} insn_decode_record;
>> +
>> +/* Record handler for data processing - register instructions. */
>> +static unsigned int
>> +aarch64_record_data_proc_reg (insn_decode_record *aarch64_insn_r)
>> +{
>> + uint8_t reg_rd, insn_bits24_27, insn_bits21_23, setflags;
>> + uint32_t record_buf[4];
>> +
>> + reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
>> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
>> + insn_bits21_23 = bits (aarch64_insn_r->aarch64_insn, 21, 23);
>> +
>> + if (!bit (aarch64_insn_r->aarch64_insn, 28))
>> + {
>> + /* Logical (shifted register). */
>> + if (insn_bits24_27 == 0x0a)
>> + setflags = (bits (aarch64_insn_r->aarch64_insn, 29, 30) == 0x03);
>> + /* Add/subtract. */
>> + else if (insn_bits24_27 == 0x0b)
>> + setflags = bit (aarch64_insn_r->aarch64_insn, 29);
>> + else
>> + return AARCH64_RECORD_UNSUPPORTED;
>> +
>> + record_buf[0] = reg_rd;
>> + aarch64_insn_r->reg_rec_count = 1;
>> + if (setflags)
>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
>> + }
>> + else
>> + {
>> + if (insn_bits24_27 == 0x0b)
>> + {
>> + /* Data-processing (3 source). */
>> + record_buf[0] = reg_rd;
>> + aarch64_insn_r->reg_rec_count = 1;
>> + }
>> + else if (insn_bits24_27 == 0x0a)
>> + {
>> + if (insn_bits21_23 == 0x00)
>> + {
>> + /* Add/subtract (with carry). */
>> + record_buf[0] = reg_rd;
>> + aarch64_insn_r->reg_rec_count = 1;
>> + if (bit (aarch64_insn_r->aarch64_insn, 29))
>> + {
>> + record_buf[1] = AARCH64_CPSR_REGNUM;
>> + aarch64_insn_r->reg_rec_count = 2;
>> + }
>> + }
>> + else if (insn_bits21_23 == 0x02)
>> + {
>> + /* Conditional compare (register) / Conditional compare (immediate). */
>> + record_buf[0] = AARCH64_CPSR_REGNUM;
>> + aarch64_insn_r->reg_rec_count = 1;
>> + }
>> + else if (insn_bits21_23 == 0x04 || insn_bits21_23 == 0x06)
>> + {
>> + /* CConditional select. */
>> + /* Data-processing (2 source). */
>> + /* Data-processing (1 source). */
>> + record_buf[0] = reg_rd;
>> + aarch64_insn_r->reg_rec_count = 1;
>> + }
>> + else
>> + return AARCH64_RECORD_UNSUPPORTED;
>> + }
>> + }
>> +
>> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
>> + record_buf);
>> + return AARCH64_RECORD_SUCCESS;
>> +}
>> +
>> +/* Record handler for data processing - immediate instructions. */
>> +static unsigned int
>> +aarch64_record_data_proc_imm (insn_decode_record *aarch64_insn_r)
>> +{
>> + uint8_t reg_rd, insn_bit28, insn_bit23, insn_bits24_27, setflags;
>> + uint32_t record_buf[4];
>> +
>> + reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
>> + insn_bit28 = bit (aarch64_insn_r->aarch64_insn, 28);
>> + insn_bit23 = bit (aarch64_insn_r->aarch64_insn, 23);
>> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
>> +
>> + /* PC rel addressing / Move wide immediate / BitField / Extract. */
>> + if (insn_bits24_27 == 0x00 || insn_bits24_27 == 0x03 ||
>> + (insn_bits24_27 == 0x02 && insn_bit23))
>> + {
>> + record_buf[0] = reg_rd;
>> + aarch64_insn_r->reg_rec_count = 1;
>> + }
>> + else if (insn_bits24_27 == 0x01)
>> + {
>> + /* Add/Subtract (immediate). */
>> + setflags = bit (aarch64_insn_r->aarch64_insn, 29);
>> + record_buf[0] = reg_rd;
>> + aarch64_insn_r->reg_rec_count = 1;
>> + if (setflags)
>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
>> + }
>> + else if (insn_bits24_27 == 0x02 && !insn_bit23)
>> + {
>> + /* Logical (immediate). */
>> + setflags = bits (aarch64_insn_r->aarch64_insn, 29, 30) == 0x03;
>> + record_buf[0] = reg_rd;
>> + aarch64_insn_r->reg_rec_count = 1;
>> + if (setflags)
>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
>> + }
>> + else
>> + return AARCH64_RECORD_UNSUPPORTED;
>> +
>> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
>> + record_buf);
>> + return AARCH64_RECORD_SUCCESS;
>> +}
>> +
>> +/* Record handler for branch, exception generation and system instructions. */
>> +static unsigned int
>> +aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
>> +{
>> + struct gdbarch_tdep *tdep = gdbarch_tdep (aarch64_insn_r->gdbarch);
>> + uint8_t insn_bits24_27, insn_bits28_31, insn_bits22_23;
>> + uint32_t record_buf[4];
>> +
>> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
>> + insn_bits28_31 = bits (aarch64_insn_r->aarch64_insn, 28, 31);
>> + insn_bits22_23 = bits (aarch64_insn_r->aarch64_insn, 22, 23);
>> +
>> + if (insn_bits28_31 == 0x0d)
>> + {
>> + /* Exception generation instructions. */
>> + if (insn_bits24_27 == 0x04)
>> + return AARCH64_RECORD_UNSUPPORTED;
>> + /* System instructions. */
>> + else if (insn_bits24_27 == 0x05 && insn_bits22_23 == 0x00)
>> + {
>> + record_buf[0] = AARCH64_CPSR_REGNUM;
>> + record_buf[1] = bits (aarch64_insn_r->aarch64_insn, 0, 4);
>> + aarch64_insn_r->reg_rec_count = 2;
>> + }
>> + else if((insn_bits24_27 & 0x0e) == 0x06)
>> + {
>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
>> + if (bits (aarch64_insn_r->aarch64_insn, 21, 22) == 0x01)
>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_LR_REGNUM;
>> + }
>> + else
>> + return AARCH64_RECORD_UNSUPPORTED;
>> + }
>> + else if ((insn_bits28_31 & 0x07) == 0x01 && (insn_bits24_27 & 0x0c) == 0x04)
>> + {
>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
>> + if (bit (aarch64_insn_r->aarch64_insn, 31))
>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_LR_REGNUM;
>> + }
>> + else
>> + /* All other types of branch instructions. */
>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
>> +
>> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
>> + record_buf);
>> + return AARCH64_RECORD_SUCCESS;
>> +}
>> +
>> +/* Record handler for load and store instructions. */
>> +static unsigned int
>> +aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
>> +{
>> + uint8_t insn_bits24_27, insn_bits28_29, insn_bits10_11;
>> + uint8_t insn_bit23, insn_bit21;
>> + uint8_t opc, size_bits, ld_flag, vector_flag;
>> + uint32_t reg_rn, reg_rt, reg_rt2;
>> + uint64_t datasize, offset;
>> + uint32_t record_buf[8];
>> + uint64_t record_buf_mem[8];
>> + CORE_ADDR address;
>> +
>> + insn_bits10_11 = bits (aarch64_insn_r->aarch64_insn, 10, 11);
>> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
>> + insn_bits28_29 = bits (aarch64_insn_r->aarch64_insn, 28, 29);
>> + insn_bit21 = bit (aarch64_insn_r->aarch64_insn, 21);
>> + insn_bit23 = bit (aarch64_insn_r->aarch64_insn, 23);
>> + ld_flag = bit (aarch64_insn_r->aarch64_insn, 22);
>> + vector_flag = bit (aarch64_insn_r->aarch64_insn, 26);
>> + reg_rt = bits (aarch64_insn_r->aarch64_insn, 0, 4);
>> + reg_rn = bits (aarch64_insn_r->aarch64_insn, 5, 9);
>> + reg_rt2 = bits (aarch64_insn_r->aarch64_insn, 10, 14);
>> + size_bits = bits (aarch64_insn_r->aarch64_insn, 30, 31);
>> +
>> + /* Load/store exclusive instructions decoding. */
>> + if (insn_bits24_27 == 0x08 && insn_bits28_29 == 0x00)
>> + {
>> + if (ld_flag)
>> + {
>> + record_buf[0] = reg_rt;
>> + aarch64_insn_r->reg_rec_count = 1;
>> + if (insn_bit21)
>> + {
>> + record_buf[1] = reg_rt2;
>> + aarch64_insn_r->reg_rec_count = 2;
>> + }
>> + }
>> + else
>> + {
>> + if (insn_bit21)
>> + datasize = (8 << size_bits) * 2;
>> + else
>> + datasize = (8 << size_bits);
>> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
>> + &address);
>> + record_buf_mem[0] = datasize / 8;
>> + record_buf_mem[1] = address;
>> + aarch64_insn_r->mem_rec_count = 1;
>> + if (!insn_bit23)
>> + {
>> + /* Save register rs. */
>> + record_buf[0] = bits (aarch64_insn_r->aarch64_insn, 16, 20);
>> + aarch64_insn_r->reg_rec_count = 1;
>> + }
>> + }
>> + }
>> + /* Load register (literal) instructions decoding. */
>> + else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x01)
>> + {
>> + if (vector_flag)
>> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
>> + else
>> + record_buf[0] = reg_rt;
>> + aarch64_insn_r->reg_rec_count = 1;
>> + }
>> + /* All types of load/store pair instructions decoding. */
>> + else if ((insn_bits24_27 & 0x0a) == 0x08 && insn_bits28_29 == 0x02)
>> + {
>> + if (ld_flag)
>> + {
>> + if (vector_flag)
>> + {
>> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
>> + record_buf[1] = reg_rt2 + AARCH64_V0_REGNUM;
>> + }
>> + else
>> + {
>> + record_buf[0] = reg_rt;
>> + record_buf[1] = reg_rt2;
>> + }
>> + aarch64_insn_r->reg_rec_count = 2;
>> + }
>> + else
>> + {
>> + uint16_t imm7_off;
>> + imm7_off = bits (aarch64_insn_r->aarch64_insn, 15, 21);
>> + if (!vector_flag)
>> + size_bits = size_bits >> 1;
>> + datasize = 8 << (2 + size_bits);
>> + offset = (imm7_off & 0x40) ? (~imm7_off & 0x007f) + 1 : imm7_off;
>> + offset = offset << (2 + size_bits);
>> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
>> + &address);
>> + if (!((insn_bits24_27 & 0x0b) == 0x08 && insn_bit23))
>> + {
>> + if (imm7_off & 0x40)
>> + address = address - offset;
>> + else
>> + address = address + offset;
>> + }
>> +
>> + record_buf_mem[0] = datasize / 8;
>> + record_buf_mem[1] = address;
>> + record_buf_mem[2] = datasize / 8;
>> + record_buf_mem[3] = address + (datasize / 8);
>> + aarch64_insn_r->mem_rec_count = 2;
>> + }
>> + if (bit (aarch64_insn_r->aarch64_insn, 23))
>> + record_buf[aarch64_insn_r->reg_rec_count++] = reg_rn;
>> + }
>> + /* Load/store register (unsigned immediate) instructions. */
>> + else if ((insn_bits24_27 & 0x0b) == 0x09 && insn_bits28_29 == 0x03)
>> + {
>> + opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
>> + if (!(opc >> 1))
>> + if (opc & 0x01)
>> + ld_flag = 0x01;
>> + else
>> + ld_flag = 0x0;
>> + else
>> + if (size_bits != 0x03)
>> + ld_flag = 0x01;
>> + else
>> + return AARCH64_RECORD_UNSUPPORTED;
>> +
>> + if (!ld_flag)
>> + {
>> + offset = bits (aarch64_insn_r->aarch64_insn, 10, 21);
>> + datasize = 8 << size_bits;
>> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
>> + &address);
>> + offset = offset << size_bits;
>> + address = address + offset;
>> +
>> + record_buf_mem[0] = datasize >> 3;
>> + record_buf_mem[1] = address;
>> + aarch64_insn_r->mem_rec_count = 1;
>> + }
>> + else
>> + {
>> + if (vector_flag)
>> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
>> + else
>> + record_buf[0] = reg_rt;
>> + aarch64_insn_r->reg_rec_count = 1;
>> + }
>> + }
>> + /* Load/store register (register offset) instructions. */
>> + else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 &&
>> + insn_bits10_11 == 0x02 && insn_bit21)
>> + {
>> + opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
>> + if (!(opc >> 1))
>> + if (opc & 0x01)
>> + ld_flag = 0x01;
>> + else
>> + ld_flag = 0x0;
>> + else
>> + if (size_bits != 0x03)
>> + ld_flag = 0x01;
>> + else
>> + return AARCH64_RECORD_UNSUPPORTED;
>> +
>> + if (!ld_flag)
>> + {
>> + uint64_t reg_rm_val;
>> + regcache_raw_read_unsigned (aarch64_insn_r->regcache,
>> + bits (aarch64_insn_r->aarch64_insn, 16, 20), ®_rm_val);
>> + if (bit (aarch64_insn_r->aarch64_insn, 12))
>> + offset = reg_rm_val << size_bits;
>> + else
>> + offset = reg_rm_val;
>> + datasize = 8 << size_bits;
>> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
>> + &address);
>> + address = address + offset;
>> + record_buf_mem[0] = datasize >> 3;
>> + record_buf_mem[1] = address;
>> + aarch64_insn_r->mem_rec_count = 1;
>> + }
>> + else
>> + {
>> + if (vector_flag)
>> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
>> + else
>> + record_buf[0] = reg_rt;
>> + aarch64_insn_r->reg_rec_count = 1;
>> + }
>> + }
>> + /* Load/store register (immediate) instructions. */
>> + else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 &&
>> + !insn_bit21)
>> + {
>> + opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
>> + if (!(opc >> 1))
>> + if (opc & 0x01)
>> + ld_flag = 0x01;
>> + else
>> + ld_flag = 0x0;
>> + else
>> + if (size_bits != 0x03)
>> + ld_flag = 0x01;
>> + else
>> + return AARCH64_RECORD_UNSUPPORTED;
>> +
>> + if (!ld_flag)
>> + {
>> + uint16_t imm9_off;
>> + imm9_off = bits (aarch64_insn_r->aarch64_insn, 12, 20);
>> + offset = (imm9_off & 0x0100) ? (((~imm9_off) & 0x01ff) + 1) : imm9_off;
>> + datasize = 8 << size_bits;
>> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
>> + &address);
>> + if (insn_bits10_11 != 0x01)
>> + {
>> + if (imm9_off & 0x0100)
>> + address = address - offset;
>> + else
>> + address = address + offset;
>> + }
>> + record_buf_mem[0] = datasize >> 3;
>> + record_buf_mem[1] = address;
>> + aarch64_insn_r->mem_rec_count = 1;
>> + }
>> + else
>> + {
>> + if (vector_flag)
>> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
>> + else
>> + record_buf[0] = reg_rt;
>> + aarch64_insn_r->reg_rec_count = 1;
>> + }
>> + if (insn_bits10_11 == 0x01 || insn_bits10_11 == 0x03)
>> + record_buf[aarch64_insn_r->reg_rec_count++] = reg_rn;
>> + }
>> + /* Advanced SIMD load/store instructions. */
>> + else
>> + return AARCH64_RECORD_UNSUPPORTED;
>> +
>> + MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count,
>> + record_buf_mem);
>> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
>> + record_buf);
>> + return AARCH64_RECORD_SUCCESS;
>> +}
>> +/* Decodes insns type and invokes its record handler. */
>> +
>> +static unsigned int
>> +aarch64_record_decode_insn_handler (insn_decode_record *aarch64_insn_r)
>> +{
>> + uint32_t ins_bit25, ins_bit26, ins_bit27, ins_bit28;
>> +
>> + ins_bit25 = bit (aarch64_insn_r->aarch64_insn, 25);
>> + ins_bit26 = bit (aarch64_insn_r->aarch64_insn, 26);
>> + ins_bit27 = bit (aarch64_insn_r->aarch64_insn, 27);
>> + ins_bit28 = bit (aarch64_insn_r->aarch64_insn, 28);
>> +
>> + /* Data processing - immediate instructions. */
>> + if (!ins_bit26 && !ins_bit27 && ins_bit28)
>> + return aarch64_record_data_proc_imm (aarch64_insn_r);
>> +
>> + /* Branch, exception generation and system instructions. */
>> + if (ins_bit26 && !ins_bit27 && ins_bit28)
>> + return aarch64_record_branch_except_sys (aarch64_insn_r);
>> +
>> + /* Load and store instructions. */
>> + if (!ins_bit25 && ins_bit27)
>> + return aarch64_record_load_store (aarch64_insn_r);
>> +
>> + /* Data processing - register instructions. */
>> + if (ins_bit25 && !ins_bit26 && ins_bit27)
>> + return aarch64_record_data_proc_reg (aarch64_insn_r);
>> +
>> + /* Data processing - SIMD and floating point instructions. */
>> + if (ins_bit25 && ins_bit26 && ins_bit27)
>> + return AARCH64_RECORD_UNSUPPORTED;
>> +
>> + return AARCH64_RECORD_UNSUPPORTED;
>> +}
>> +
>> +/* Cleans up local record registers and memory allocations. */
>> +
>> +static void
>> +deallocate_reg_mem (insn_decode_record *record)
>> +{
>> + xfree (record->aarch64_regs);
>> + xfree (record->aarch64_mems);
>> +}
>> +
>> +/* Parse the current instruction and record the values of the registers and
>> + memory that will be changed in current instruction to record_arch_list
>> + return -1 if something is wrong. */
>> +
>> +int
>> +aarch64_process_record (struct gdbarch *gdbarch, struct regcache *regcache,
>> + CORE_ADDR insn_addr)
>> +{
>> + uint32_t rec_no = 0;
>> + uint8_t insn_size = 4;
>> + uint32_t ret = 0;
>> + ULONGEST t_bit = 0, insn_id = 0;
>> + gdb_byte buf[insn_size];
>> + insn_decode_record aarch64_record;
>> +
>> + memset (&buf[0], 0, insn_size);
>> + memset (&aarch64_record, 0, sizeof (insn_decode_record));
>> + target_read_memory (insn_addr, &buf[0], insn_size);
>> + aarch64_record.aarch64_insn = (uint32_t) extract_unsigned_integer (&buf[0],
>> + insn_size, gdbarch_byte_order (gdbarch));
>> + aarch64_record.regcache = regcache;
>> + aarch64_record.this_addr = insn_addr;
>> + aarch64_record.gdbarch = gdbarch;
>> +
>> + ret = aarch64_record_decode_insn_handler (&aarch64_record);
>> + if (ret == AARCH64_RECORD_UNSUPPORTED)
>> + {
>> + printf_unfiltered (_("Process record does not support instruction "
>> + "0x%0x at address %s.\n"),aarch64_record.aarch64_insn,
>> + paddress (gdbarch, insn_addr));
>> + ret = -1;
>> + }
>> +
>> + if (0 == ret)
>> + {
>> + /* Record registers. */
>> + record_full_arch_list_add_reg (aarch64_record.regcache, AARCH64_PC_REGNUM);
>> + if (aarch64_record.aarch64_regs)
>> + for (rec_no = 0; rec_no < aarch64_record.reg_rec_count; rec_no++)
>> + if (record_full_arch_list_add_reg (aarch64_record.regcache,
>> + aarch64_record.aarch64_regs[rec_no]))
>> + ret = -1;
>> +
>> + /* Record memories. */
>> + if (aarch64_record.aarch64_mems)
>> + for (rec_no = 0; rec_no < aarch64_record.mem_rec_count; rec_no++)
>> + if (record_full_arch_list_add_mem
>> + ((CORE_ADDR)aarch64_record.aarch64_mems[rec_no].addr,
>> + aarch64_record.aarch64_mems[rec_no].len))
>> + ret = -1;
>> +
>> + if (record_full_arch_list_add_end ())
>> + ret = -1;
>> + }
>> +
>> + deallocate_reg_mem (&aarch64_record);
>> + return ret;
>> +}
>> diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
>> index 78fb779..3dd3dcc 100644
>> --- a/gdb/aarch64-tdep.h
>> +++ b/gdb/aarch64-tdep.h
>> @@ -90,4 +90,7 @@ struct gdbarch_tdep
>> struct type *vnb_type;
>> };
>>
>> +extern int aarch64_process_record (struct gdbarch *gdbarch,
>> + struct regcache *regcache, CORE_ADDR addr);
>> +
>> #endif /* aarch64-tdep.h */
>> --
>> 1.9.1
>>
>
> Ping! Kindly help me approve this patch series.
ping!
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 4/7] Implements aarch64 process record and reverse debugging support
2014-10-14 12:48 ` Omair Javaid
@ 2014-10-21 9:08 ` Omair Javaid
0 siblings, 0 replies; 53+ messages in thread
From: Omair Javaid @ 2014-10-21 9:08 UTC (permalink / raw)
To: gdb-patches, Pedro Alves
On 14/10/2014 17:47, Omair Javaid wrote:
> On 19 September 2014 03:28, Omair Javaid <omair.javaid@linaro.org> wrote:
>> On 18 September 2014 05:09, Omair Javaid <omair.javaid@linaro.org> wrote:
>>> 2014-09-18 Omair Javaid <omair.javaid@linaro.org>
>>>
>>> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Install AArch64
>>> process record handler.
>>> * aarch64-tdep.c (record.h): Include.
>>> (record-full.h): Include.
>>> (submask): New macro.
>>> (bit): New macro.
>>> (bits): New macro.
>>> (REG_ALLOC): New macro.
>>> (MEM_ALLOC): New macro.
>>> (struct aarch64_mem_r): Define.
>>> (aarch64_record_result): New enum.
>>> (struct insn_decode_record): Define.
>>> (insn_decode_record): New typedef.
>>> (aarch64_record_data_proc_reg): Add record handler for data processing
>>> register insns.
>>> (aarch64_record_data_proc_imm): Add record handler for data processing
>>> immediate insns.
>>> (aarch64_record_branch_except_sys): Add record handler for branch,
>>> exception and system insns.
>>> (aarch64_record_load_store): Add record handler for load/store insns.
>>> (aarch64_record_decode_insn_handler): Add record insn decoding function.
>>> (deallocate_reg_mem): Add memory cleanup function for record data.
>>> (aarch64_process_record): Add gdbarch handler for AArch64 process
>>> record.
>>> * aarch64-tdep.h (aarch64_process_record): New extern declaration.
>>> ---
>>> gdb/aarch64-linux-tdep.c | 3 +
>>> gdb/aarch64-tdep.c | 578 +++++++++++++++++++++++++++++++++++++++++++++++
>>> gdb/aarch64-tdep.h | 3 +
>>> 3 files changed, 584 insertions(+)
>>>
>>> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
>>> index e5565a8..5ab7b37 100644
>>> --- a/gdb/aarch64-linux-tdep.c
>>> +++ b/gdb/aarch64-linux-tdep.c
>>> @@ -401,6 +401,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>>> set_gdbarch_stap_is_single_operand (gdbarch, aarch64_stap_is_single_operand);
>>> set_gdbarch_stap_parse_special_token (gdbarch,
>>> aarch64_stap_parse_special_token);
>>> +
>>> + /* Reversible debugging, process record. */
>>> + set_gdbarch_process_record (gdbarch, aarch64_process_record);
>>> }
>>>
>>> /* Provide a prototype to silence -Wmissing-prototypes. */
>>> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
>>> index 1898f6b..ed28f68 100644
>>> --- a/gdb/aarch64-tdep.c
>>> +++ b/gdb/aarch64-tdep.c
>>> @@ -50,6 +50,9 @@
>>>
>>> #include "vec.h"
>>>
>>> +#include "record.h"
>>> +#include "record-full.h"
>>> +
>>> #include "features/aarch64.c"
>>>
>>> /* Pseudo register base numbers. */
>>> @@ -2804,3 +2807,578 @@ When on, AArch64 specific debugging is enabled."),
>>> show_aarch64_debug,
>>> &setdebuglist, &showdebuglist);
>>> }
>>> +
>>> +/* AArch64 process record-replay related structures, defines etc. */
>>> +
>>> +#define submask(x) ((1L << ((x) + 1)) - 1)
>>> +#define bit(obj,st) (((obj) >> (st)) & 1)
>>> +#define bits(obj,st,fn) (((obj) >> (st)) & submask ((fn) - (st)))
>>> +
>>> +#define REG_ALLOC(REGS, LENGTH, RECORD_BUF) \
>>> + do \
>>> + { \
>>> + unsigned int reg_len = LENGTH; \
>>> + if (reg_len) \
>>> + { \
>>> + REGS = XNEWVEC (uint32_t, reg_len); \
>>> + memcpy(®S[0], &RECORD_BUF[0], sizeof(uint32_t)*LENGTH); \
>>> + } \
>>> + } \
>>> + while (0)
>>> +
>>> +#define MEM_ALLOC(MEMS, LENGTH, RECORD_BUF) \
>>> + do \
>>> + { \
>>> + unsigned int mem_len = LENGTH; \
>>> + if (mem_len) \
>>> + { \
>>> + MEMS = XNEWVEC (struct aarch64_mem_r, mem_len); \
>>> + memcpy(&MEMS->len, &RECORD_BUF[0], \
>>> + sizeof(struct aarch64_mem_r) * LENGTH); \
>>> + } \
>>> + } \
>>> + while (0)
>>> +
>>> +/* AArch64 memory record structure. */
>>> +struct aarch64_mem_r
>>> +{
>>> + uint64_t len; /* Record length. */
>>> + uint64_t addr; /* Memory address. */
>>> +};
>>> +
>>> +enum aarch64_record_result
>>> +{
>>> + AARCH64_RECORD_SUCCESS,
>>> + AARCH64_RECORD_FAILURE,
>>> + AARCH64_RECORD_UNSUPPORTED
>>> +};
>>> +
>>> +/* AArch64 instruction record contains opcode of current insn and execution
>>> + state (before entry to decode_insn()), contains list of to-be-modified
>>> + registers and memory blocks (on return from decode_insn()). */
>>> +
>>> +typedef struct insn_decode_record_t
>>> +{
>>> + struct gdbarch *gdbarch;
>>> + struct regcache *regcache;
>>> + CORE_ADDR this_addr;
>>> + uint32_t aarch64_insn;
>>> + uint32_t mem_rec_count;
>>> + uint32_t reg_rec_count;
>>> + uint32_t *aarch64_regs;
>>> + struct aarch64_mem_r *aarch64_mems;
>>> +} insn_decode_record;
>>> +
>>> +/* Record handler for data processing - register instructions. */
>>> +static unsigned int
>>> +aarch64_record_data_proc_reg (insn_decode_record *aarch64_insn_r)
>>> +{
>>> + uint8_t reg_rd, insn_bits24_27, insn_bits21_23, setflags;
>>> + uint32_t record_buf[4];
>>> +
>>> + reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
>>> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
>>> + insn_bits21_23 = bits (aarch64_insn_r->aarch64_insn, 21, 23);
>>> +
>>> + if (!bit (aarch64_insn_r->aarch64_insn, 28))
>>> + {
>>> + /* Logical (shifted register). */
>>> + if (insn_bits24_27 == 0x0a)
>>> + setflags = (bits (aarch64_insn_r->aarch64_insn, 29, 30) == 0x03);
>>> + /* Add/subtract. */
>>> + else if (insn_bits24_27 == 0x0b)
>>> + setflags = bit (aarch64_insn_r->aarch64_insn, 29);
>>> + else
>>> + return AARCH64_RECORD_UNSUPPORTED;
>>> +
>>> + record_buf[0] = reg_rd;
>>> + aarch64_insn_r->reg_rec_count = 1;
>>> + if (setflags)
>>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
>>> + }
>>> + else
>>> + {
>>> + if (insn_bits24_27 == 0x0b)
>>> + {
>>> + /* Data-processing (3 source). */
>>> + record_buf[0] = reg_rd;
>>> + aarch64_insn_r->reg_rec_count = 1;
>>> + }
>>> + else if (insn_bits24_27 == 0x0a)
>>> + {
>>> + if (insn_bits21_23 == 0x00)
>>> + {
>>> + /* Add/subtract (with carry). */
>>> + record_buf[0] = reg_rd;
>>> + aarch64_insn_r->reg_rec_count = 1;
>>> + if (bit (aarch64_insn_r->aarch64_insn, 29))
>>> + {
>>> + record_buf[1] = AARCH64_CPSR_REGNUM;
>>> + aarch64_insn_r->reg_rec_count = 2;
>>> + }
>>> + }
>>> + else if (insn_bits21_23 == 0x02)
>>> + {
>>> + /* Conditional compare (register) / Conditional compare (immediate). */
>>> + record_buf[0] = AARCH64_CPSR_REGNUM;
>>> + aarch64_insn_r->reg_rec_count = 1;
>>> + }
>>> + else if (insn_bits21_23 == 0x04 || insn_bits21_23 == 0x06)
>>> + {
>>> + /* CConditional select. */
>>> + /* Data-processing (2 source). */
>>> + /* Data-processing (1 source). */
>>> + record_buf[0] = reg_rd;
>>> + aarch64_insn_r->reg_rec_count = 1;
>>> + }
>>> + else
>>> + return AARCH64_RECORD_UNSUPPORTED;
>>> + }
>>> + }
>>> +
>>> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
>>> + record_buf);
>>> + return AARCH64_RECORD_SUCCESS;
>>> +}
>>> +
>>> +/* Record handler for data processing - immediate instructions. */
>>> +static unsigned int
>>> +aarch64_record_data_proc_imm (insn_decode_record *aarch64_insn_r)
>>> +{
>>> + uint8_t reg_rd, insn_bit28, insn_bit23, insn_bits24_27, setflags;
>>> + uint32_t record_buf[4];
>>> +
>>> + reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
>>> + insn_bit28 = bit (aarch64_insn_r->aarch64_insn, 28);
>>> + insn_bit23 = bit (aarch64_insn_r->aarch64_insn, 23);
>>> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
>>> +
>>> + /* PC rel addressing / Move wide immediate / BitField / Extract. */
>>> + if (insn_bits24_27 == 0x00 || insn_bits24_27 == 0x03 ||
>>> + (insn_bits24_27 == 0x02 && insn_bit23))
>>> + {
>>> + record_buf[0] = reg_rd;
>>> + aarch64_insn_r->reg_rec_count = 1;
>>> + }
>>> + else if (insn_bits24_27 == 0x01)
>>> + {
>>> + /* Add/Subtract (immediate). */
>>> + setflags = bit (aarch64_insn_r->aarch64_insn, 29);
>>> + record_buf[0] = reg_rd;
>>> + aarch64_insn_r->reg_rec_count = 1;
>>> + if (setflags)
>>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
>>> + }
>>> + else if (insn_bits24_27 == 0x02 && !insn_bit23)
>>> + {
>>> + /* Logical (immediate). */
>>> + setflags = bits (aarch64_insn_r->aarch64_insn, 29, 30) == 0x03;
>>> + record_buf[0] = reg_rd;
>>> + aarch64_insn_r->reg_rec_count = 1;
>>> + if (setflags)
>>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_CPSR_REGNUM;
>>> + }
>>> + else
>>> + return AARCH64_RECORD_UNSUPPORTED;
>>> +
>>> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
>>> + record_buf);
>>> + return AARCH64_RECORD_SUCCESS;
>>> +}
>>> +
>>> +/* Record handler for branch, exception generation and system instructions. */
>>> +static unsigned int
>>> +aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
>>> +{
>>> + struct gdbarch_tdep *tdep = gdbarch_tdep (aarch64_insn_r->gdbarch);
>>> + uint8_t insn_bits24_27, insn_bits28_31, insn_bits22_23;
>>> + uint32_t record_buf[4];
>>> +
>>> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
>>> + insn_bits28_31 = bits (aarch64_insn_r->aarch64_insn, 28, 31);
>>> + insn_bits22_23 = bits (aarch64_insn_r->aarch64_insn, 22, 23);
>>> +
>>> + if (insn_bits28_31 == 0x0d)
>>> + {
>>> + /* Exception generation instructions. */
>>> + if (insn_bits24_27 == 0x04)
>>> + return AARCH64_RECORD_UNSUPPORTED;
>>> + /* System instructions. */
>>> + else if (insn_bits24_27 == 0x05 && insn_bits22_23 == 0x00)
>>> + {
>>> + record_buf[0] = AARCH64_CPSR_REGNUM;
>>> + record_buf[1] = bits (aarch64_insn_r->aarch64_insn, 0, 4);
>>> + aarch64_insn_r->reg_rec_count = 2;
>>> + }
>>> + else if((insn_bits24_27 & 0x0e) == 0x06)
>>> + {
>>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
>>> + if (bits (aarch64_insn_r->aarch64_insn, 21, 22) == 0x01)
>>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_LR_REGNUM;
>>> + }
>>> + else
>>> + return AARCH64_RECORD_UNSUPPORTED;
>>> + }
>>> + else if ((insn_bits28_31 & 0x07) == 0x01 && (insn_bits24_27 & 0x0c) == 0x04)
>>> + {
>>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
>>> + if (bit (aarch64_insn_r->aarch64_insn, 31))
>>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_LR_REGNUM;
>>> + }
>>> + else
>>> + /* All other types of branch instructions. */
>>> + record_buf[aarch64_insn_r->reg_rec_count++] = AARCH64_PC_REGNUM;
>>> +
>>> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
>>> + record_buf);
>>> + return AARCH64_RECORD_SUCCESS;
>>> +}
>>> +
>>> +/* Record handler for load and store instructions. */
>>> +static unsigned int
>>> +aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
>>> +{
>>> + uint8_t insn_bits24_27, insn_bits28_29, insn_bits10_11;
>>> + uint8_t insn_bit23, insn_bit21;
>>> + uint8_t opc, size_bits, ld_flag, vector_flag;
>>> + uint32_t reg_rn, reg_rt, reg_rt2;
>>> + uint64_t datasize, offset;
>>> + uint32_t record_buf[8];
>>> + uint64_t record_buf_mem[8];
>>> + CORE_ADDR address;
>>> +
>>> + insn_bits10_11 = bits (aarch64_insn_r->aarch64_insn, 10, 11);
>>> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
>>> + insn_bits28_29 = bits (aarch64_insn_r->aarch64_insn, 28, 29);
>>> + insn_bit21 = bit (aarch64_insn_r->aarch64_insn, 21);
>>> + insn_bit23 = bit (aarch64_insn_r->aarch64_insn, 23);
>>> + ld_flag = bit (aarch64_insn_r->aarch64_insn, 22);
>>> + vector_flag = bit (aarch64_insn_r->aarch64_insn, 26);
>>> + reg_rt = bits (aarch64_insn_r->aarch64_insn, 0, 4);
>>> + reg_rn = bits (aarch64_insn_r->aarch64_insn, 5, 9);
>>> + reg_rt2 = bits (aarch64_insn_r->aarch64_insn, 10, 14);
>>> + size_bits = bits (aarch64_insn_r->aarch64_insn, 30, 31);
>>> +
>>> + /* Load/store exclusive instructions decoding. */
>>> + if (insn_bits24_27 == 0x08 && insn_bits28_29 == 0x00)
>>> + {
>>> + if (ld_flag)
>>> + {
>>> + record_buf[0] = reg_rt;
>>> + aarch64_insn_r->reg_rec_count = 1;
>>> + if (insn_bit21)
>>> + {
>>> + record_buf[1] = reg_rt2;
>>> + aarch64_insn_r->reg_rec_count = 2;
>>> + }
>>> + }
>>> + else
>>> + {
>>> + if (insn_bit21)
>>> + datasize = (8 << size_bits) * 2;
>>> + else
>>> + datasize = (8 << size_bits);
>>> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
>>> + &address);
>>> + record_buf_mem[0] = datasize / 8;
>>> + record_buf_mem[1] = address;
>>> + aarch64_insn_r->mem_rec_count = 1;
>>> + if (!insn_bit23)
>>> + {
>>> + /* Save register rs. */
>>> + record_buf[0] = bits (aarch64_insn_r->aarch64_insn, 16, 20);
>>> + aarch64_insn_r->reg_rec_count = 1;
>>> + }
>>> + }
>>> + }
>>> + /* Load register (literal) instructions decoding. */
>>> + else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x01)
>>> + {
>>> + if (vector_flag)
>>> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
>>> + else
>>> + record_buf[0] = reg_rt;
>>> + aarch64_insn_r->reg_rec_count = 1;
>>> + }
>>> + /* All types of load/store pair instructions decoding. */
>>> + else if ((insn_bits24_27 & 0x0a) == 0x08 && insn_bits28_29 == 0x02)
>>> + {
>>> + if (ld_flag)
>>> + {
>>> + if (vector_flag)
>>> + {
>>> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
>>> + record_buf[1] = reg_rt2 + AARCH64_V0_REGNUM;
>>> + }
>>> + else
>>> + {
>>> + record_buf[0] = reg_rt;
>>> + record_buf[1] = reg_rt2;
>>> + }
>>> + aarch64_insn_r->reg_rec_count = 2;
>>> + }
>>> + else
>>> + {
>>> + uint16_t imm7_off;
>>> + imm7_off = bits (aarch64_insn_r->aarch64_insn, 15, 21);
>>> + if (!vector_flag)
>>> + size_bits = size_bits >> 1;
>>> + datasize = 8 << (2 + size_bits);
>>> + offset = (imm7_off & 0x40) ? (~imm7_off & 0x007f) + 1 : imm7_off;
>>> + offset = offset << (2 + size_bits);
>>> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
>>> + &address);
>>> + if (!((insn_bits24_27 & 0x0b) == 0x08 && insn_bit23))
>>> + {
>>> + if (imm7_off & 0x40)
>>> + address = address - offset;
>>> + else
>>> + address = address + offset;
>>> + }
>>> +
>>> + record_buf_mem[0] = datasize / 8;
>>> + record_buf_mem[1] = address;
>>> + record_buf_mem[2] = datasize / 8;
>>> + record_buf_mem[3] = address + (datasize / 8);
>>> + aarch64_insn_r->mem_rec_count = 2;
>>> + }
>>> + if (bit (aarch64_insn_r->aarch64_insn, 23))
>>> + record_buf[aarch64_insn_r->reg_rec_count++] = reg_rn;
>>> + }
>>> + /* Load/store register (unsigned immediate) instructions. */
>>> + else if ((insn_bits24_27 & 0x0b) == 0x09 && insn_bits28_29 == 0x03)
>>> + {
>>> + opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
>>> + if (!(opc >> 1))
>>> + if (opc & 0x01)
>>> + ld_flag = 0x01;
>>> + else
>>> + ld_flag = 0x0;
>>> + else
>>> + if (size_bits != 0x03)
>>> + ld_flag = 0x01;
>>> + else
>>> + return AARCH64_RECORD_UNSUPPORTED;
>>> +
>>> + if (!ld_flag)
>>> + {
>>> + offset = bits (aarch64_insn_r->aarch64_insn, 10, 21);
>>> + datasize = 8 << size_bits;
>>> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
>>> + &address);
>>> + offset = offset << size_bits;
>>> + address = address + offset;
>>> +
>>> + record_buf_mem[0] = datasize >> 3;
>>> + record_buf_mem[1] = address;
>>> + aarch64_insn_r->mem_rec_count = 1;
>>> + }
>>> + else
>>> + {
>>> + if (vector_flag)
>>> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
>>> + else
>>> + record_buf[0] = reg_rt;
>>> + aarch64_insn_r->reg_rec_count = 1;
>>> + }
>>> + }
>>> + /* Load/store register (register offset) instructions. */
>>> + else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 &&
>>> + insn_bits10_11 == 0x02 && insn_bit21)
>>> + {
>>> + opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
>>> + if (!(opc >> 1))
>>> + if (opc & 0x01)
>>> + ld_flag = 0x01;
>>> + else
>>> + ld_flag = 0x0;
>>> + else
>>> + if (size_bits != 0x03)
>>> + ld_flag = 0x01;
>>> + else
>>> + return AARCH64_RECORD_UNSUPPORTED;
>>> +
>>> + if (!ld_flag)
>>> + {
>>> + uint64_t reg_rm_val;
>>> + regcache_raw_read_unsigned (aarch64_insn_r->regcache,
>>> + bits (aarch64_insn_r->aarch64_insn, 16, 20), ®_rm_val);
>>> + if (bit (aarch64_insn_r->aarch64_insn, 12))
>>> + offset = reg_rm_val << size_bits;
>>> + else
>>> + offset = reg_rm_val;
>>> + datasize = 8 << size_bits;
>>> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
>>> + &address);
>>> + address = address + offset;
>>> + record_buf_mem[0] = datasize >> 3;
>>> + record_buf_mem[1] = address;
>>> + aarch64_insn_r->mem_rec_count = 1;
>>> + }
>>> + else
>>> + {
>>> + if (vector_flag)
>>> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
>>> + else
>>> + record_buf[0] = reg_rt;
>>> + aarch64_insn_r->reg_rec_count = 1;
>>> + }
>>> + }
>>> + /* Load/store register (immediate) instructions. */
>>> + else if ((insn_bits24_27 & 0x0b) == 0x08 && insn_bits28_29 == 0x03 &&
>>> + !insn_bit21)
>>> + {
>>> + opc = bits (aarch64_insn_r->aarch64_insn, 22, 23);
>>> + if (!(opc >> 1))
>>> + if (opc & 0x01)
>>> + ld_flag = 0x01;
>>> + else
>>> + ld_flag = 0x0;
>>> + else
>>> + if (size_bits != 0x03)
>>> + ld_flag = 0x01;
>>> + else
>>> + return AARCH64_RECORD_UNSUPPORTED;
>>> +
>>> + if (!ld_flag)
>>> + {
>>> + uint16_t imm9_off;
>>> + imm9_off = bits (aarch64_insn_r->aarch64_insn, 12, 20);
>>> + offset = (imm9_off & 0x0100) ? (((~imm9_off) & 0x01ff) + 1) : imm9_off;
>>> + datasize = 8 << size_bits;
>>> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn,
>>> + &address);
>>> + if (insn_bits10_11 != 0x01)
>>> + {
>>> + if (imm9_off & 0x0100)
>>> + address = address - offset;
>>> + else
>>> + address = address + offset;
>>> + }
>>> + record_buf_mem[0] = datasize >> 3;
>>> + record_buf_mem[1] = address;
>>> + aarch64_insn_r->mem_rec_count = 1;
>>> + }
>>> + else
>>> + {
>>> + if (vector_flag)
>>> + record_buf[0] = reg_rt + AARCH64_V0_REGNUM;
>>> + else
>>> + record_buf[0] = reg_rt;
>>> + aarch64_insn_r->reg_rec_count = 1;
>>> + }
>>> + if (insn_bits10_11 == 0x01 || insn_bits10_11 == 0x03)
>>> + record_buf[aarch64_insn_r->reg_rec_count++] = reg_rn;
>>> + }
>>> + /* Advanced SIMD load/store instructions. */
>>> + else
>>> + return AARCH64_RECORD_UNSUPPORTED;
>>> +
>>> + MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count,
>>> + record_buf_mem);
>>> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
>>> + record_buf);
>>> + return AARCH64_RECORD_SUCCESS;
>>> +}
>>> +/* Decodes insns type and invokes its record handler. */
>>> +
>>> +static unsigned int
>>> +aarch64_record_decode_insn_handler (insn_decode_record *aarch64_insn_r)
>>> +{
>>> + uint32_t ins_bit25, ins_bit26, ins_bit27, ins_bit28;
>>> +
>>> + ins_bit25 = bit (aarch64_insn_r->aarch64_insn, 25);
>>> + ins_bit26 = bit (aarch64_insn_r->aarch64_insn, 26);
>>> + ins_bit27 = bit (aarch64_insn_r->aarch64_insn, 27);
>>> + ins_bit28 = bit (aarch64_insn_r->aarch64_insn, 28);
>>> +
>>> + /* Data processing - immediate instructions. */
>>> + if (!ins_bit26 && !ins_bit27 && ins_bit28)
>>> + return aarch64_record_data_proc_imm (aarch64_insn_r);
>>> +
>>> + /* Branch, exception generation and system instructions. */
>>> + if (ins_bit26 && !ins_bit27 && ins_bit28)
>>> + return aarch64_record_branch_except_sys (aarch64_insn_r);
>>> +
>>> + /* Load and store instructions. */
>>> + if (!ins_bit25 && ins_bit27)
>>> + return aarch64_record_load_store (aarch64_insn_r);
>>> +
>>> + /* Data processing - register instructions. */
>>> + if (ins_bit25 && !ins_bit26 && ins_bit27)
>>> + return aarch64_record_data_proc_reg (aarch64_insn_r);
>>> +
>>> + /* Data processing - SIMD and floating point instructions. */
>>> + if (ins_bit25 && ins_bit26 && ins_bit27)
>>> + return AARCH64_RECORD_UNSUPPORTED;
>>> +
>>> + return AARCH64_RECORD_UNSUPPORTED;
>>> +}
>>> +
>>> +/* Cleans up local record registers and memory allocations. */
>>> +
>>> +static void
>>> +deallocate_reg_mem (insn_decode_record *record)
>>> +{
>>> + xfree (record->aarch64_regs);
>>> + xfree (record->aarch64_mems);
>>> +}
>>> +
>>> +/* Parse the current instruction and record the values of the registers and
>>> + memory that will be changed in current instruction to record_arch_list
>>> + return -1 if something is wrong. */
>>> +
>>> +int
>>> +aarch64_process_record (struct gdbarch *gdbarch, struct regcache *regcache,
>>> + CORE_ADDR insn_addr)
>>> +{
>>> + uint32_t rec_no = 0;
>>> + uint8_t insn_size = 4;
>>> + uint32_t ret = 0;
>>> + ULONGEST t_bit = 0, insn_id = 0;
>>> + gdb_byte buf[insn_size];
>>> + insn_decode_record aarch64_record;
>>> +
>>> + memset (&buf[0], 0, insn_size);
>>> + memset (&aarch64_record, 0, sizeof (insn_decode_record));
>>> + target_read_memory (insn_addr, &buf[0], insn_size);
>>> + aarch64_record.aarch64_insn = (uint32_t) extract_unsigned_integer (&buf[0],
>>> + insn_size, gdbarch_byte_order (gdbarch));
>>> + aarch64_record.regcache = regcache;
>>> + aarch64_record.this_addr = insn_addr;
>>> + aarch64_record.gdbarch = gdbarch;
>>> +
>>> + ret = aarch64_record_decode_insn_handler (&aarch64_record);
>>> + if (ret == AARCH64_RECORD_UNSUPPORTED)
>>> + {
>>> + printf_unfiltered (_("Process record does not support instruction "
>>> + "0x%0x at address %s.\n"),aarch64_record.aarch64_insn,
>>> + paddress (gdbarch, insn_addr));
>>> + ret = -1;
>>> + }
>>> +
>>> + if (0 == ret)
>>> + {
>>> + /* Record registers. */
>>> + record_full_arch_list_add_reg (aarch64_record.regcache, AARCH64_PC_REGNUM);
>>> + if (aarch64_record.aarch64_regs)
>>> + for (rec_no = 0; rec_no < aarch64_record.reg_rec_count; rec_no++)
>>> + if (record_full_arch_list_add_reg (aarch64_record.regcache,
>>> + aarch64_record.aarch64_regs[rec_no]))
>>> + ret = -1;
>>> +
>>> + /* Record memories. */
>>> + if (aarch64_record.aarch64_mems)
>>> + for (rec_no = 0; rec_no < aarch64_record.mem_rec_count; rec_no++)
>>> + if (record_full_arch_list_add_mem
>>> + ((CORE_ADDR)aarch64_record.aarch64_mems[rec_no].addr,
>>> + aarch64_record.aarch64_mems[rec_no].len))
>>> + ret = -1;
>>> +
>>> + if (record_full_arch_list_add_end ())
>>> + ret = -1;
>>> + }
>>> +
>>> + deallocate_reg_mem (&aarch64_record);
>>> + return ret;
>>> +}
>>> diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
>>> index 78fb779..3dd3dcc 100644
>>> --- a/gdb/aarch64-tdep.h
>>> +++ b/gdb/aarch64-tdep.h
>>> @@ -90,4 +90,7 @@ struct gdbarch_tdep
>>> struct type *vnb_type;
>>> };
>>>
>>> +extern int aarch64_process_record (struct gdbarch *gdbarch,
>>> + struct regcache *regcache, CORE_ADDR addr);
>>> +
>>> #endif /* aarch64-tdep.h */
>>> --
>>> 1.9.1
>>>
>>
>> Ping! Kindly help me approve this patch series.
>
> ping!
>
ping!
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH 1/7] NEWS entry about aarch64-linux record/replay support
2014-06-04 16:21 [PATCH 0/7] Process record and reverse debugging support on aarch64-linux Omair Javaid
2014-06-04 16:21 ` [PATCH 7/7] Enables gdb.reverse testsuite for aarch64*-linux targets Omair Javaid
2014-06-04 16:21 ` [PATCH 4/7] Implements aarch64 process record and reverse debugging support Omair Javaid
@ 2014-06-04 16:21 ` Omair Javaid
2014-06-04 16:24 ` Eli Zaretskii
2014-08-30 2:40 ` Yao Qi
2014-06-04 16:21 ` [PATCH 2/7] Fixes for aarch64-linux gdb core file support Omair Javaid
` (5 subsequent siblings)
8 siblings, 2 replies; 53+ messages in thread
From: Omair Javaid @ 2014-06-04 16:21 UTC (permalink / raw)
To: gdb-patches; +Cc: Omair Javaid
gdb:
2014-06-04 Omair Javaid <omair.javaid@linaro.org>
* NEWS: Add a note on process record-replay support on aarch64*-linux*
targets.
---
gdb/NEWS | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/gdb/NEWS b/gdb/NEWS
index 1397e8b..55d3df7 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -3,6 +3,10 @@
*** Changes since GDB 7.7
+* Support for process record-replay and reverse debugging on aarch64*-linux*
+ targets has been added. GDB now supports recording of A64 instruction set
+ including advance simd instructions.
+
* New command line options
-D data-directory
--
1.9.1
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 1/7] NEWS entry about aarch64-linux record/replay support
2014-06-04 16:21 ` [PATCH 1/7] NEWS entry about aarch64-linux record/replay support Omair Javaid
@ 2014-06-04 16:24 ` Eli Zaretskii
2014-08-30 2:40 ` Yao Qi
1 sibling, 0 replies; 53+ messages in thread
From: Eli Zaretskii @ 2014-06-04 16:24 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches, omair.javaid
> From: Omair Javaid <omair.javaid@linaro.org>
> Cc: Omair Javaid <omair.javaid@linaro.org>
> Date: Wed, 4 Jun 2014 21:21:05 +0500
>
> *** Changes since GDB 7.7
>
> +* Support for process record-replay and reverse debugging on aarch64*-linux*
> + targets has been added. GDB now supports recording of A64 instruction set
> + including advance simd instructions.
OK, but please spell "SIMD" in all caps.
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH 1/7] NEWS entry about aarch64-linux record/replay support
2014-06-04 16:21 ` [PATCH 1/7] NEWS entry about aarch64-linux record/replay support Omair Javaid
2014-06-04 16:24 ` Eli Zaretskii
@ 2014-08-30 2:40 ` Yao Qi
2014-09-01 14:51 ` Marcus Shawcroft
1 sibling, 1 reply; 53+ messages in thread
From: Yao Qi @ 2014-08-30 2:40 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
Omair Javaid <omair.javaid@linaro.org> writes:
> +* Support for process record-replay and reverse debugging on aarch64*-linux*
> + targets has been added. GDB now supports recording of A64 instruction set
^^^
s/A64/AArch64/?
> + including advance simd instructions.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 1/7] NEWS entry about aarch64-linux record/replay support
2014-08-30 2:40 ` Yao Qi
@ 2014-09-01 14:51 ` Marcus Shawcroft
2014-09-02 1:01 ` Yao Qi
0 siblings, 1 reply; 53+ messages in thread
From: Marcus Shawcroft @ 2014-09-01 14:51 UTC (permalink / raw)
To: Yao Qi; +Cc: Omair Javaid, gdb-patches
On 30 August 2014 03:36, Yao Qi <yao@codesourcery.com> wrote:
> Omair Javaid <omair.javaid@linaro.org> writes:
>
>> +* Support for process record-replay and reverse debugging on aarch64*-linux*
>> + targets has been added. GDB now supports recording of A64 instruction set
> ^^^
> s/A64/AArch64/?
>
A64 is the name of the instruction set currently defined within the
AArch64 execution state. Therefore, in this context, I think the use
of A64 is appropriate.
/Marcus
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH 1/7] NEWS entry about aarch64-linux record/replay support
2014-09-01 14:51 ` Marcus Shawcroft
@ 2014-09-02 1:01 ` Yao Qi
2014-09-17 23:30 ` [PATCH] " Omair Javaid
0 siblings, 1 reply; 53+ messages in thread
From: Yao Qi @ 2014-09-02 1:01 UTC (permalink / raw)
To: Marcus Shawcroft; +Cc: Omair Javaid, gdb-patches
Marcus Shawcroft <marcus.shawcroft@gmail.com> writes:
> A64 is the name of the instruction set currently defined within the
> AArch64 execution state. Therefore, in this context, I think the use
> of A64 is appropriate.
OK, I have no question then.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH] NEWS entry about aarch64-linux record/replay support
2014-09-02 1:01 ` Yao Qi
@ 2014-09-17 23:30 ` Omair Javaid
2014-09-18 2:53 ` Eli Zaretskii
0 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-09-17 23:30 UTC (permalink / raw)
To: gdb-patches
gdb:
2014-09-18 Omair Javaid <omair.javaid@linaro.org>
* NEWS: Add a note on process record-replay support on aarch64*-linux*
targets.
---
gdb/NEWS | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/gdb/NEWS b/gdb/NEWS
index 343ee49..a9eeded 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -3,6 +3,10 @@
*** Changes since GDB 7.8
+* Support for process record-replay and reverse debugging on aarch64*-linux*
+ targets has been added. GDB now supports recording of A64 instruction set
+ including advance SIMD instructions.
+
* GDB now supports hardware watchpoints on x86 GNU Hurd.
* Python Scripting
--
1.9.1
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH] NEWS entry about aarch64-linux record/replay support
2014-09-17 23:30 ` [PATCH] " Omair Javaid
@ 2014-09-18 2:53 ` Eli Zaretskii
0 siblings, 0 replies; 53+ messages in thread
From: Eli Zaretskii @ 2014-09-18 2:53 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
> From: Omair Javaid <omair.javaid@linaro.org>
> Date: Thu, 18 Sep 2014 04:30:42 +0500
>
> gdb:
>
> 2014-09-18 Omair Javaid <omair.javaid@linaro.org>
>
> * NEWS: Add a note on process record-replay support on aarch64*-linux*
> targets.
>
> ---
> gdb/NEWS | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 343ee49..a9eeded 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,10 @@
>
> *** Changes since GDB 7.8
>
> +* Support for process record-replay and reverse debugging on aarch64*-linux*
> + targets has been added. GDB now supports recording of A64 instruction set
> + including advance SIMD instructions.
> +
This is OK, thanks.
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH 2/7] Fixes for aarch64-linux gdb core file support
2014-06-04 16:21 [PATCH 0/7] Process record and reverse debugging support on aarch64-linux Omair Javaid
` (2 preceding siblings ...)
2014-06-04 16:21 ` [PATCH 1/7] NEWS entry about aarch64-linux record/replay support Omair Javaid
@ 2014-06-04 16:21 ` Omair Javaid
2014-06-04 17:11 ` Andreas Arnez
2014-06-05 9:07 ` [PATCH 2/7] Fixes for aarch64-linux gdb " Will Newton
2014-06-04 16:21 ` [PATCH 3/7] Enable gdb process record on aarch64-linux targets Omair Javaid
` (4 subsequent siblings)
8 siblings, 2 replies; 53+ messages in thread
From: Omair Javaid @ 2014-06-04 16:21 UTC (permalink / raw)
To: gdb-patches; +Cc: Omair Javaid
This patch fixes aarch64 linux core file support by adding/updating
aarch64-linux supply/collect methods for aarch64 register set.
gdb:
2014-06-04 Omair Javaid <omair.javaid@linaro.org>
* aarch64-linux-tdep.c (aarch64_linux_supply_gregset): Updated.
(aarch64_linux_supply_fpregset): Updated.
(supply_gregset_from_core): Removed.
(aarch64_linux_collect_gregset): New function.
(supply_fpregset_from_core): Removed.
(aarch64_linux_collect_fpregset): New function.
(struct regset aarch64_linux_gregset): Updated.
(struct core_regset_section aarch64_linux_regset_sections[]): Declared.
* aarch64-linux-tdep.h (aarch64_linux_supply_gregset): Updated extern.
(aarch64_linux_supply_fpregset): New extern declaration.
(aarch64_linux_collect_gregset): New extern declaration.
(aarch64_linux_collect_fpregset): New extern declaration.
* aarch64-linux-nat.c (aarch64_linux_supply_gregset): Updated.
(aarch64_linux_supply_fpregset): Updated.
---
gdb/aarch64-linux-nat.c | 4 +--
gdb/aarch64-linux-tdep.c | 91 +++++++++++++++++++++++++++++++++---------------
gdb/aarch64-linux-tdep.h | 22 +++++++++---
3 files changed, 83 insertions(+), 34 deletions(-)
diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
index 877e702..f631d9e 100644
--- a/gdb/aarch64-linux-nat.c
+++ b/gdb/aarch64-linux-nat.c
@@ -632,7 +632,7 @@ fill_gregset (const struct regcache *regcache,
void
supply_gregset (struct regcache *regcache, const gdb_gregset_t *gregsetp)
{
- aarch64_linux_supply_gregset (regcache, (const gdb_byte *) gregsetp);
+ aarch64_linux_supply_gregset (NULL, regcache, -1, gregsetp, 0);
}
/* Fill register REGNO (if it is a floating-point register) in
@@ -667,7 +667,7 @@ fill_fpregset (const struct regcache *regcache,
void
supply_fpregset (struct regcache *regcache, const gdb_fpregset_t *fpregsetp)
{
- aarch64_linux_supply_fpregset (regcache, (const gdb_byte *) fpregsetp);
+ aarch64_linux_supply_fpregset (NULL, regcache, -1, fpregsetp, 0);
}
/* Called when resuming a thread.
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index 30ed73f..b285818 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -191,70 +191,93 @@ static const struct tramp_frame aarch64_linux_rt_sigframe =
};
/* Fill GDB's register array with the general-purpose register values
- in the buffer pointed by GREGS_BUF. */
+ in the buffer pointed by gregs_buf. */
void
-aarch64_linux_supply_gregset (struct regcache *regcache,
- const gdb_byte *gregs_buf)
+aarch64_linux_supply_gregset (const struct regset *regset,
+ struct regcache *regcache, int regnum,
+ const void *gregs_buf, size_t len)
{
+ gdb_byte *gregs_bufp = (gdb_byte *) gregs_buf;
int regno;
for (regno = AARCH64_X0_REGNUM; regno <= AARCH64_CPSR_REGNUM; regno++)
regcache_raw_supply (regcache, regno,
- gregs_buf + X_REGISTER_SIZE
+ gregs_bufp + X_REGISTER_SIZE
* (regno - AARCH64_X0_REGNUM));
}
-/* The "supply_regset" function for the general-purpose register set. */
+/* Fill registers in *gregs_buf with the values in GDB's register cache. */
-static void
-supply_gregset_from_core (const struct regset *regset,
- struct regcache *regcache,
- int regnum, const void *regbuf, size_t len)
+void
+aarch64_linux_collect_gregset (const struct regset *regset,
+ const struct regcache *regcache, int regnum,
+ void *gregs_buf, size_t len)
{
- aarch64_linux_supply_gregset (regcache, (const gdb_byte *) regbuf);
+ gdb_byte *gregs_bufp = (gdb_byte *) gregs_buf;
+ int regno;
+
+ for (regno = AARCH64_X0_REGNUM; regno <= AARCH64_CPSR_REGNUM; regno++)
+ if (regnum == -1 || regnum == regno)
+ regcache_raw_collect (regcache, regno, gregs_bufp + X_REGISTER_SIZE *
+ (regno - AARCH64_X0_REGNUM));
}
/* Fill GDB's register array with the floating-point register values
- in the buffer pointed by FPREGS_BUF. */
+ in the buffer pointed by fpregs_buf. */
void
-aarch64_linux_supply_fpregset (struct regcache *regcache,
- const gdb_byte *fpregs_buf)
+aarch64_linux_supply_fpregset (const struct regset *regset,
+ struct regcache *regcache, int regnum,
+ const void *fpregs_buf, size_t len)
{
+ gdb_byte *fpregs_bufp = (gdb_byte *) fpregs_buf;
int regno;
for (regno = AARCH64_V0_REGNUM; regno <= AARCH64_V31_REGNUM; regno++)
- regcache_raw_supply (regcache, regno,
- fpregs_buf + V_REGISTER_SIZE
- * (regno - AARCH64_V0_REGNUM));
+ regcache_raw_supply (regcache, regno, fpregs_bufp + V_REGISTER_SIZE *
+ (regno - AARCH64_V0_REGNUM));
- regcache_raw_supply (regcache, AARCH64_FPSR_REGNUM,
- fpregs_buf + V_REGISTER_SIZE * 32);
- regcache_raw_supply (regcache, AARCH64_FPCR_REGNUM,
- fpregs_buf + V_REGISTER_SIZE * 32 + 4);
+ regcache_raw_supply (regcache, AARCH64_FPSR_REGNUM, fpregs_bufp +
+ V_REGISTER_SIZE * 32);
+ regcache_raw_supply (regcache, AARCH64_FPCR_REGNUM, fpregs_bufp +
+ V_REGISTER_SIZE * 32 + 4);
}
-/* The "supply_regset" function for the floating-point register set. */
+/* Fill registers in *fpregs_buf with the values in GDB's register cache. */
-static void
-supply_fpregset_from_core (const struct regset *regset,
- struct regcache *regcache,
- int regnum, const void *regbuf, size_t len)
+void
+aarch64_linux_collect_fpregset (const struct regset *regset,
+ const struct regcache *regcache, int regnum,
+ void *fpregs_buf, size_t len)
{
- aarch64_linux_supply_fpregset (regcache, (const gdb_byte *) regbuf);
+ gdb_byte *fpregs_bufp = (gdb_byte *) fpregs_buf;
+ int regno;
+
+ for (regno = AARCH64_V0_REGNUM; regno <= AARCH64_V31_REGNUM; regno++)
+ if (regnum == -1 || regnum == regno)
+ regcache_raw_collect (regcache, regno, fpregs_bufp + V_REGISTER_SIZE *
+ (regno - AARCH64_V0_REGNUM));
+
+ if (regnum == -1 || regnum == AARCH64_FPSR_REGNUM)
+ regcache_raw_collect (regcache, AARCH64_FPSR_REGNUM, fpregs_bufp +
+ V_REGISTER_SIZE * 32);
+
+ if (regnum == -1 || regnum == AARCH64_FPCR_REGNUM)
+ regcache_raw_collect (regcache, AARCH64_FPCR_REGNUM, fpregs_bufp +
+ V_REGISTER_SIZE * 32 + 4);
}
/* Register set definitions. */
static const struct regset aarch64_linux_gregset =
{
- NULL, supply_gregset_from_core, NULL
+ NULL, aarch64_linux_supply_gregset, aarch64_linux_collect_gregset
};
static const struct regset aarch64_linux_fpregset =
{
- NULL, supply_fpregset_from_core, NULL
+ NULL, aarch64_linux_supply_fpregset, aarch64_linux_collect_fpregset
};
/* Implement the "regset_from_core_section" gdbarch method. */
@@ -275,6 +298,15 @@ aarch64_linux_regset_from_core_section (struct gdbarch *gdbarch,
return NULL;
}
+/* Core file register set sections. */
+
+static struct core_regset_section aarch64_linux_regset_sections[] =
+{
+ { ".reg", AARCH64_LINUX_SIZEOF_GREGSET, "general-purpose" },
+ { ".reg2", AARCH64_LINUX_SIZEOF_FPREGSET, "floating-point" },
+ { NULL, 0}
+};
+
/* Implementation of `gdbarch_stap_is_single_operand', as defined in
gdbarch.h. */
@@ -420,6 +452,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
/* Enable longjmp. */
tdep->jb_pc = 11;
+ /* Install supported register note sections. */
+ set_gdbarch_core_regset_sections (gdbarch, aarch64_linux_regset_sections);
+
set_gdbarch_regset_from_core_section (gdbarch,
aarch64_linux_regset_from_core_section);
diff --git a/gdb/aarch64-linux-tdep.h b/gdb/aarch64-linux-tdep.h
index 48c7092..e3d7ed7 100644
--- a/gdb/aarch64-linux-tdep.h
+++ b/gdb/aarch64-linux-tdep.h
@@ -20,7 +20,21 @@
struct regcache;
-extern void aarch64_linux_supply_gregset (struct regcache *regcache,
- const gdb_byte *gregs_buf);
-extern void aarch64_linux_supply_fpregset (struct regcache *regcache,
- const gdb_byte *fpregs_buf);
+/* Function prototypes for function transferring the general-purpose
+ registers between GDB, inferiors and core files. */
+
+/* Fill GDB's register array with the general-purpose register values
+ in *gregs_buf. */
+
+extern void aarch64_linux_supply_gregset (const struct regset *regset,
+ struct regcache *regcache, int regnum,
+ const void *gregs_buf, size_t len);
+extern void aarch64_linux_collect_gregset (const struct regset *regset,
+ const struct regcache *regcache,
+ int regnum, void *gregs_buf, size_t len);
+extern void aarch64_linux_supply_fpregset (const struct regset *regset,
+ struct regcache *regcache, int regnum,
+ const void *fpregs_buf, size_t len);
+extern void aarch64_linux_collect_fpregset (const struct regset *regset,
+ const struct regcache *regcache,
+ int regnum, void *fpregs_buf, size_t len);
--
1.9.1
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 2/7] Fixes for aarch64-linux gdb core file support
2014-06-04 16:21 ` [PATCH 2/7] Fixes for aarch64-linux gdb core file support Omair Javaid
@ 2014-06-04 17:11 ` Andreas Arnez
2014-06-05 17:09 ` Omair Javaid
2014-06-05 9:07 ` [PATCH 2/7] Fixes for aarch64-linux gdb " Will Newton
1 sibling, 1 reply; 53+ messages in thread
From: Andreas Arnez @ 2014-06-04 17:11 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
On Wed, Jun 04 2014, Omair Javaid wrote:
> This patch fixes aarch64 linux core file support by adding/updating
> aarch64-linux supply/collect methods for aarch64 register set.
Have you looked at that patch?
https://sourceware.org/ml/gdb-patches/2014-05/msg00637.html
Apart from 'core_regset_sections', I believe it provides the same
functionality as this patch, right?
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH 2/7] Fixes for aarch64-linux gdb core file support
2014-06-04 17:11 ` Andreas Arnez
@ 2014-06-05 17:09 ` Omair Javaid
2014-08-28 13:49 ` [PATCH 2/7] Fixes for aarch64-linux " Omair Javaid
0 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-06-05 17:09 UTC (permalink / raw)
To: Andreas Arnez; +Cc: gdb-patches
On 4 June 2014 22:11, Andreas Arnez <arnez@linux.vnet.ibm.com> wrote:
> On Wed, Jun 04 2014, Omair Javaid wrote:
>
>> This patch fixes aarch64 linux core file support by adding/updating
>> aarch64-linux supply/collect methods for aarch64 register set.
>
> Have you looked at that patch?
>
> https://sourceware.org/ml/gdb-patches/2014-05/msg00637.html
>
> Apart from 'core_regset_sections', I believe it provides the same
> functionality as this patch, right?
>
Agreed!. I wrote this patch when I started work on aarch64 record
replay in april and corefile support wasnt working. I guess once
regset rework patches gets pushed then we may have to rework this
patch to extract corefile related changes only.
Thanks Andreas for bringing this up.
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH 2/7] Fixes for aarch64-linux core file support
2014-06-05 17:09 ` Omair Javaid
@ 2014-08-28 13:49 ` Omair Javaid
2014-08-30 3:00 ` Yao Qi
2014-10-21 13:28 ` Yao Qi
0 siblings, 2 replies; 53+ messages in thread
From: Omair Javaid @ 2014-08-28 13:49 UTC (permalink / raw)
To: gdb-patches
Updated after regset rework pushed upstream.
gdb:
2014-08-28 Omair Javaid <omair.javaid@linaro.org>
* aarch64-linux-tdep.c (aarch64_linux_init_abi): Install AArch64
register note sections.
(struct core_regset_section aarch64_linux_regset_sections[]): Declare
AArch64 register note sections.
---
gdb/aarch64-linux-tdep.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index 6377977..e5565a8 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -231,6 +231,15 @@ aarch64_linux_regset_from_core_section (struct gdbarch *gdbarch,
return NULL;
}
+/* Core file register set sections. */
+
+static struct core_regset_section aarch64_linux_regset_sections[] =
+{
+ { ".reg", AARCH64_LINUX_SIZEOF_GREGSET, "general-purpose" },
+ { ".reg2", AARCH64_LINUX_SIZEOF_FPREGSET, "floating-point" },
+ { NULL, 0}
+};
+
/* Implementation of `gdbarch_stap_is_single_operand', as defined in
gdbarch.h. */
@@ -376,6 +385,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
/* Enable longjmp. */
tdep->jb_pc = 11;
+ /* Install supported register note sections. */
+ set_gdbarch_core_regset_sections (gdbarch, aarch64_linux_regset_sections);
+
set_gdbarch_regset_from_core_section (gdbarch,
aarch64_linux_regset_from_core_section);
--
1.9.1
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 2/7] Fixes for aarch64-linux core file support
2014-08-28 13:49 ` [PATCH 2/7] Fixes for aarch64-linux " Omair Javaid
@ 2014-08-30 3:00 ` Yao Qi
2014-09-01 19:38 ` Omair Javaid
2014-10-21 13:28 ` Yao Qi
1 sibling, 1 reply; 53+ messages in thread
From: Yao Qi @ 2014-08-30 3:00 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
Omair Javaid <omair.javaid@linaro.org> writes:
> 2014-08-28 Omair Javaid <omair.javaid@linaro.org>
>
> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Install AArch64
^^
One redundant space.
> register note sections.
> (struct core_regset_section aarch64_linux_regset_sections[]): Declare
> AArch64 register note sections.
I don't understand how does this patch relate to your whole patch
series, which is about process record and reverse debugging for
aarch64. If it is not related, please submit separately with a NEWS
entry for it.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 2/7] Fixes for aarch64-linux core file support
2014-08-30 3:00 ` Yao Qi
@ 2014-09-01 19:38 ` Omair Javaid
2014-09-17 23:37 ` Re " Omair Javaid
0 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-09-01 19:38 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
On 30 August 2014 07:56, Yao Qi <yao@codesourcery.com> wrote:
> Omair Javaid <omair.javaid@linaro.org> writes:
>
>> 2014-08-28 Omair Javaid <omair.javaid@linaro.org>
>>
>> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Install AArch64
> ^^
> One redundant space.
OK.
>
>> register note sections.
>> (struct core_regset_section aarch64_linux_regset_sections[]): Declare
>> AArch64 register note sections.
>
> I don't understand how does this patch relate to your whole patch
> series, which is about process record and reverse debugging for
> aarch64. If it is not related, please submit separately with a NEWS
> entry for it.
Record/Replay requires corefiles support as pre-req, record data is
stored in the form of core files.
>
> --
> Yao (齐尧)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re [PATCH 2/7] Fixes for aarch64-linux core file support
2014-09-01 19:38 ` Omair Javaid
@ 2014-09-17 23:37 ` Omair Javaid
2014-10-14 12:49 ` Omair Javaid
0 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-09-17 23:37 UTC (permalink / raw)
To: gdb-patches
Updated after regset rework pushed upstream.
gdb:
2014-09-18 Omair Javaid <omair.javaid@linaro.org>
* aarch64-linux-tdep.c (aarch64_linux_init_abi): Install AArch64
register note sections.
(struct core_regset_section aarch64_linux_regset_sections[]): Declare
AArch64 register note sections.
---
gdb/aarch64-linux-tdep.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index 6377977..e5565a8 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -231,6 +231,15 @@ aarch64_linux_regset_from_core_section (struct gdbarch *gdbarch,
return NULL;
}
+/* Core file register set sections. */
+
+static struct core_regset_section aarch64_linux_regset_sections[] =
+{
+ { ".reg", AARCH64_LINUX_SIZEOF_GREGSET, "general-purpose" },
+ { ".reg2", AARCH64_LINUX_SIZEOF_FPREGSET, "floating-point" },
+ { NULL, 0}
+};
+
/* Implementation of `gdbarch_stap_is_single_operand', as defined in
gdbarch.h. */
@@ -376,6 +385,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
/* Enable longjmp. */
tdep->jb_pc = 11;
+ /* Install supported register note sections. */
+ set_gdbarch_core_regset_sections (gdbarch, aarch64_linux_regset_sections);
+
set_gdbarch_regset_from_core_section (gdbarch,
aarch64_linux_regset_from_core_section);
--
1.9.1
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: Re [PATCH 2/7] Fixes for aarch64-linux core file support
2014-09-17 23:37 ` Re " Omair Javaid
@ 2014-10-14 12:49 ` Omair Javaid
2014-10-21 9:07 ` Omair Javaid
0 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-10-14 12:49 UTC (permalink / raw)
To: gdb-patches
On 18 September 2014 04:36, Omair Javaid <omair.javaid@linaro.org> wrote:
> Updated after regset rework pushed upstream.
>
> gdb:
>
> 2014-09-18 Omair Javaid <omair.javaid@linaro.org>
>
> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Install AArch64
> register note sections.
> (struct core_regset_section aarch64_linux_regset_sections[]): Declare
> AArch64 register note sections.
> ---
> gdb/aarch64-linux-tdep.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
> index 6377977..e5565a8 100644
> --- a/gdb/aarch64-linux-tdep.c
> +++ b/gdb/aarch64-linux-tdep.c
> @@ -231,6 +231,15 @@ aarch64_linux_regset_from_core_section (struct gdbarch *gdbarch,
> return NULL;
> }
>
> +/* Core file register set sections. */
> +
> +static struct core_regset_section aarch64_linux_regset_sections[] =
> +{
> + { ".reg", AARCH64_LINUX_SIZEOF_GREGSET, "general-purpose" },
> + { ".reg2", AARCH64_LINUX_SIZEOF_FPREGSET, "floating-point" },
> + { NULL, 0}
> +};
> +
> /* Implementation of `gdbarch_stap_is_single_operand', as defined in
> gdbarch.h. */
>
> @@ -376,6 +385,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
> /* Enable longjmp. */
> tdep->jb_pc = 11;
>
> + /* Install supported register note sections. */
> + set_gdbarch_core_regset_sections (gdbarch, aarch64_linux_regset_sections);
> +
> set_gdbarch_regset_from_core_section (gdbarch,
> aarch64_linux_regset_from_core_section);
>
> --
> 1.9.1
>
ping!
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: Re [PATCH 2/7] Fixes for aarch64-linux core file support
2014-10-14 12:49 ` Omair Javaid
@ 2014-10-21 9:07 ` Omair Javaid
0 siblings, 0 replies; 53+ messages in thread
From: Omair Javaid @ 2014-10-21 9:07 UTC (permalink / raw)
To: gdb-patches
On 14/10/2014 17:49, Omair Javaid wrote:
> On 18 September 2014 04:36, Omair Javaid <omair.javaid@linaro.org> wrote:
>> Updated after regset rework pushed upstream.
>>
>> gdb:
>>
>> 2014-09-18 Omair Javaid <omair.javaid@linaro.org>
>>
>> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Install AArch64
>> register note sections.
>> (struct core_regset_section aarch64_linux_regset_sections[]): Declare
>> AArch64 register note sections.
>> ---
>> gdb/aarch64-linux-tdep.c | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
>> index 6377977..e5565a8 100644
>> --- a/gdb/aarch64-linux-tdep.c
>> +++ b/gdb/aarch64-linux-tdep.c
>> @@ -231,6 +231,15 @@ aarch64_linux_regset_from_core_section (struct gdbarch *gdbarch,
>> return NULL;
>> }
>>
>> +/* Core file register set sections. */
>> +
>> +static struct core_regset_section aarch64_linux_regset_sections[] =
>> +{
>> + { ".reg", AARCH64_LINUX_SIZEOF_GREGSET, "general-purpose" },
>> + { ".reg2", AARCH64_LINUX_SIZEOF_FPREGSET, "floating-point" },
>> + { NULL, 0}
>> +};
>> +
>> /* Implementation of `gdbarch_stap_is_single_operand', as defined in
>> gdbarch.h. */
>>
>> @@ -376,6 +385,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>> /* Enable longjmp. */
>> tdep->jb_pc = 11;
>>
>> + /* Install supported register note sections. */
>> + set_gdbarch_core_regset_sections (gdbarch, aarch64_linux_regset_sections);
>> +
>> set_gdbarch_regset_from_core_section (gdbarch,
>> aarch64_linux_regset_from_core_section);
>>
>> --
>> 1.9.1
>>
>
> ping!
>
ping!
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH 2/7] Fixes for aarch64-linux core file support
2014-08-28 13:49 ` [PATCH 2/7] Fixes for aarch64-linux " Omair Javaid
2014-08-30 3:00 ` Yao Qi
@ 2014-10-21 13:28 ` Yao Qi
2014-10-27 12:33 ` Omair Javaid
1 sibling, 1 reply; 53+ messages in thread
From: Yao Qi @ 2014-10-21 13:28 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
Omair Javaid <omair.javaid@linaro.org> writes:
> @@ -376,6 +385,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
> /* Enable longjmp. */
> tdep->jb_pc = 11;
>
> + /* Install supported register note sections. */
> + set_gdbarch_core_regset_sections (gdbarch, aarch64_linux_regset_sections);
> +
> set_gdbarch_regset_from_core_section (gdbarch,
> aarch64_linux_regset_from_core_section);
Is this patch stale? I don't see the definition of
set_gdbarch_core_regset_sections. On the other hand, I see
aarch64-linux-tdep.c already has:
/* Implement the "regset_from_core_section" gdbarch method. */
static void
aarch64_linux_iterate_over_regset_sections (struct gdbarch *gdbarch,
iterate_over_regset_sections_cb *cb,
void *cb_data,
const struct regcache *regcache)
{
cb (".reg", AARCH64_LINUX_SIZEOF_GREGSET, &aarch64_linux_gregset,
NULL, cb_data);
cb (".reg2", AARCH64_LINUX_SIZEOF_FPREGSET, &aarch64_linux_fpregset,
NULL, cb_data);
}
...
set_gdbarch_iterate_over_regset_sections
(gdbarch, aarch64_linux_iterate_over_regset_sections);
I assume this patch is no longer needed.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 2/7] Fixes for aarch64-linux core file support
2014-10-21 13:28 ` Yao Qi
@ 2014-10-27 12:33 ` Omair Javaid
0 siblings, 0 replies; 53+ messages in thread
From: Omair Javaid @ 2014-10-27 12:33 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
On 21 October 2014 18:24, Yao Qi <yao@codesourcery.com> wrote:
> Omair Javaid <omair.javaid@linaro.org> writes:
>
>> @@ -376,6 +385,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>> /* Enable longjmp. */
>> tdep->jb_pc = 11;
>>
>> + /* Install supported register note sections. */
>> + set_gdbarch_core_regset_sections (gdbarch, aarch64_linux_regset_sections);
>> +
>> set_gdbarch_regset_from_core_section (gdbarch,
>> aarch64_linux_regset_from_core_section);
>
> Is this patch stale? I don't see the definition of
> set_gdbarch_core_regset_sections. On the other hand, I see
> aarch64-linux-tdep.c already has:
>
> /* Implement the "regset_from_core_section" gdbarch method. */
>
> static void
> aarch64_linux_iterate_over_regset_sections (struct gdbarch *gdbarch,
> iterate_over_regset_sections_cb *cb,
> void *cb_data,
> const struct regcache *regcache)
> {
> cb (".reg", AARCH64_LINUX_SIZEOF_GREGSET, &aarch64_linux_gregset,
> NULL, cb_data);
> cb (".reg2", AARCH64_LINUX_SIZEOF_FPREGSET, &aarch64_linux_fpregset,
> NULL, cb_data);
> }
>
> ...
> set_gdbarch_iterate_over_regset_sections
> (gdbarch, aarch64_linux_iterate_over_regset_sections);
>
> I assume this patch is no longer needed.
Agreed!
>
> --
> Yao (齐尧)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH 2/7] Fixes for aarch64-linux gdb core file support
2014-06-04 16:21 ` [PATCH 2/7] Fixes for aarch64-linux gdb core file support Omair Javaid
2014-06-04 17:11 ` Andreas Arnez
@ 2014-06-05 9:07 ` Will Newton
1 sibling, 0 replies; 53+ messages in thread
From: Will Newton @ 2014-06-05 9:07 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
On 4 June 2014 17:21, Omair Javaid <omair.javaid@linaro.org> wrote:
> This patch fixes aarch64 linux core file support by adding/updating
> aarch64-linux supply/collect methods for aarch64 register set.
>
> gdb:
>
> 2014-06-04 Omair Javaid <omair.javaid@linaro.org>
>
> * aarch64-linux-tdep.c (aarch64_linux_supply_gregset): Updated.
> (aarch64_linux_supply_fpregset): Updated.
> (supply_gregset_from_core): Removed.
> (aarch64_linux_collect_gregset): New function.
> (supply_fpregset_from_core): Removed.
> (aarch64_linux_collect_fpregset): New function.
> (struct regset aarch64_linux_gregset): Updated.
> (struct core_regset_section aarch64_linux_regset_sections[]): Declared.
> * aarch64-linux-tdep.h (aarch64_linux_supply_gregset): Updated extern.
> (aarch64_linux_supply_fpregset): New extern declaration.
> (aarch64_linux_collect_gregset): New extern declaration.
> (aarch64_linux_collect_fpregset): New extern declaration.
> * aarch64-linux-nat.c (aarch64_linux_supply_gregset): Updated.
> (aarch64_linux_supply_fpregset): Updated.
>
> ---
> gdb/aarch64-linux-nat.c | 4 +--
> gdb/aarch64-linux-tdep.c | 91 +++++++++++++++++++++++++++++++++---------------
> gdb/aarch64-linux-tdep.h | 22 +++++++++---
> 3 files changed, 83 insertions(+), 34 deletions(-)
>
> diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
> index 877e702..f631d9e 100644
> --- a/gdb/aarch64-linux-nat.c
> +++ b/gdb/aarch64-linux-nat.c
> @@ -632,7 +632,7 @@ fill_gregset (const struct regcache *regcache,
> void
> supply_gregset (struct regcache *regcache, const gdb_gregset_t *gregsetp)
> {
> - aarch64_linux_supply_gregset (regcache, (const gdb_byte *) gregsetp);
> + aarch64_linux_supply_gregset (NULL, regcache, -1, gregsetp, 0);
> }
>
> /* Fill register REGNO (if it is a floating-point register) in
> @@ -667,7 +667,7 @@ fill_fpregset (const struct regcache *regcache,
> void
> supply_fpregset (struct regcache *regcache, const gdb_fpregset_t *fpregsetp)
> {
> - aarch64_linux_supply_fpregset (regcache, (const gdb_byte *) fpregsetp);
> + aarch64_linux_supply_fpregset (NULL, regcache, -1, fpregsetp, 0);
> }
>
> /* Called when resuming a thread.
> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
> index 30ed73f..b285818 100644
> --- a/gdb/aarch64-linux-tdep.c
> +++ b/gdb/aarch64-linux-tdep.c
> @@ -191,70 +191,93 @@ static const struct tramp_frame aarch64_linux_rt_sigframe =
> };
>
> /* Fill GDB's register array with the general-purpose register values
> - in the buffer pointed by GREGS_BUF. */
> + in the buffer pointed by gregs_buf. */
I believe upper casing parameter names in comments is actually correct
per the GNU coding style.
>
> void
> -aarch64_linux_supply_gregset (struct regcache *regcache,
> - const gdb_byte *gregs_buf)
> +aarch64_linux_supply_gregset (const struct regset *regset,
> + struct regcache *regcache, int regnum,
> + const void *gregs_buf, size_t len)
> {
> + gdb_byte *gregs_bufp = (gdb_byte *) gregs_buf;
> int regno;
>
> for (regno = AARCH64_X0_REGNUM; regno <= AARCH64_CPSR_REGNUM; regno++)
> regcache_raw_supply (regcache, regno,
> - gregs_buf + X_REGISTER_SIZE
> + gregs_bufp + X_REGISTER_SIZE
> * (regno - AARCH64_X0_REGNUM));
> }
>
> -/* The "supply_regset" function for the general-purpose register set. */
> +/* Fill registers in *gregs_buf with the values in GDB's register cache. */
>
> -static void
> -supply_gregset_from_core (const struct regset *regset,
> - struct regcache *regcache,
> - int regnum, const void *regbuf, size_t len)
> +void
> +aarch64_linux_collect_gregset (const struct regset *regset,
> + const struct regcache *regcache, int regnum,
> + void *gregs_buf, size_t len)
> {
> - aarch64_linux_supply_gregset (regcache, (const gdb_byte *) regbuf);
> + gdb_byte *gregs_bufp = (gdb_byte *) gregs_buf;
> + int regno;
> +
> + for (regno = AARCH64_X0_REGNUM; regno <= AARCH64_CPSR_REGNUM; regno++)
> + if (regnum == -1 || regnum == regno)
> + regcache_raw_collect (regcache, regno, gregs_bufp + X_REGISTER_SIZE *
> + (regno - AARCH64_X0_REGNUM));
> }
>
> /* Fill GDB's register array with the floating-point register values
> - in the buffer pointed by FPREGS_BUF. */
> + in the buffer pointed by fpregs_buf. */
>
> void
> -aarch64_linux_supply_fpregset (struct regcache *regcache,
> - const gdb_byte *fpregs_buf)
> +aarch64_linux_supply_fpregset (const struct regset *regset,
> + struct regcache *regcache, int regnum,
> + const void *fpregs_buf, size_t len)
> {
> + gdb_byte *fpregs_bufp = (gdb_byte *) fpregs_buf;
> int regno;
>
> for (regno = AARCH64_V0_REGNUM; regno <= AARCH64_V31_REGNUM; regno++)
> - regcache_raw_supply (regcache, regno,
> - fpregs_buf + V_REGISTER_SIZE
> - * (regno - AARCH64_V0_REGNUM));
> + regcache_raw_supply (regcache, regno, fpregs_bufp + V_REGISTER_SIZE *
> + (regno - AARCH64_V0_REGNUM));
>
> - regcache_raw_supply (regcache, AARCH64_FPSR_REGNUM,
> - fpregs_buf + V_REGISTER_SIZE * 32);
> - regcache_raw_supply (regcache, AARCH64_FPCR_REGNUM,
> - fpregs_buf + V_REGISTER_SIZE * 32 + 4);
> + regcache_raw_supply (regcache, AARCH64_FPSR_REGNUM, fpregs_bufp +
> + V_REGISTER_SIZE * 32);
> + regcache_raw_supply (regcache, AARCH64_FPCR_REGNUM, fpregs_bufp +
> + V_REGISTER_SIZE * 32 + 4);
> }
>
> -/* The "supply_regset" function for the floating-point register set. */
> +/* Fill registers in *fpregs_buf with the values in GDB's register cache. */
>
> -static void
> -supply_fpregset_from_core (const struct regset *regset,
> - struct regcache *regcache,
> - int regnum, const void *regbuf, size_t len)
> +void
> +aarch64_linux_collect_fpregset (const struct regset *regset,
> + const struct regcache *regcache, int regnum,
> + void *fpregs_buf, size_t len)
> {
> - aarch64_linux_supply_fpregset (regcache, (const gdb_byte *) regbuf);
> + gdb_byte *fpregs_bufp = (gdb_byte *) fpregs_buf;
> + int regno;
> +
> + for (regno = AARCH64_V0_REGNUM; regno <= AARCH64_V31_REGNUM; regno++)
> + if (regnum == -1 || regnum == regno)
> + regcache_raw_collect (regcache, regno, fpregs_bufp + V_REGISTER_SIZE *
> + (regno - AARCH64_V0_REGNUM));
> +
> + if (regnum == -1 || regnum == AARCH64_FPSR_REGNUM)
> + regcache_raw_collect (regcache, AARCH64_FPSR_REGNUM, fpregs_bufp +
> + V_REGISTER_SIZE * 32);
> +
> + if (regnum == -1 || regnum == AARCH64_FPCR_REGNUM)
> + regcache_raw_collect (regcache, AARCH64_FPCR_REGNUM, fpregs_bufp +
> + V_REGISTER_SIZE * 32 + 4);
> }
>
> /* Register set definitions. */
>
> static const struct regset aarch64_linux_gregset =
> {
> - NULL, supply_gregset_from_core, NULL
> + NULL, aarch64_linux_supply_gregset, aarch64_linux_collect_gregset
> };
>
> static const struct regset aarch64_linux_fpregset =
> {
> - NULL, supply_fpregset_from_core, NULL
> + NULL, aarch64_linux_supply_fpregset, aarch64_linux_collect_fpregset
> };
>
> /* Implement the "regset_from_core_section" gdbarch method. */
> @@ -275,6 +298,15 @@ aarch64_linux_regset_from_core_section (struct gdbarch *gdbarch,
> return NULL;
> }
>
> +/* Core file register set sections. */
> +
> +static struct core_regset_section aarch64_linux_regset_sections[] =
> +{
> + { ".reg", AARCH64_LINUX_SIZEOF_GREGSET, "general-purpose" },
> + { ".reg2", AARCH64_LINUX_SIZEOF_FPREGSET, "floating-point" },
> + { NULL, 0}
> +};
> +
> /* Implementation of `gdbarch_stap_is_single_operand', as defined in
> gdbarch.h. */
>
> @@ -420,6 +452,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
> /* Enable longjmp. */
> tdep->jb_pc = 11;
>
> + /* Install supported register note sections. */
> + set_gdbarch_core_regset_sections (gdbarch, aarch64_linux_regset_sections);
> +
> set_gdbarch_regset_from_core_section (gdbarch,
> aarch64_linux_regset_from_core_section);
>
> diff --git a/gdb/aarch64-linux-tdep.h b/gdb/aarch64-linux-tdep.h
> index 48c7092..e3d7ed7 100644
> --- a/gdb/aarch64-linux-tdep.h
> +++ b/gdb/aarch64-linux-tdep.h
> @@ -20,7 +20,21 @@
>
> struct regcache;
>
> -extern void aarch64_linux_supply_gregset (struct regcache *regcache,
> - const gdb_byte *gregs_buf);
> -extern void aarch64_linux_supply_fpregset (struct regcache *regcache,
> - const gdb_byte *fpregs_buf);
> +/* Function prototypes for function transferring the general-purpose
> + registers between GDB, inferiors and core files. */
> +
> +/* Fill GDB's register array with the general-purpose register values
> + in *gregs_buf. */
> +
> +extern void aarch64_linux_supply_gregset (const struct regset *regset,
> + struct regcache *regcache, int regnum,
> + const void *gregs_buf, size_t len);
> +extern void aarch64_linux_collect_gregset (const struct regset *regset,
> + const struct regcache *regcache,
> + int regnum, void *gregs_buf, size_t len);
> +extern void aarch64_linux_supply_fpregset (const struct regset *regset,
> + struct regcache *regcache, int regnum,
> + const void *fpregs_buf, size_t len);
> +extern void aarch64_linux_collect_fpregset (const struct regset *regset,
> + const struct regcache *regcache,
> + int regnum, void *fpregs_buf, size_t len);
> --
> 1.9.1
>
--
Will Newton
Toolchain Working Group, Linaro
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH 3/7] Enable gdb process record on aarch64-linux targets
2014-06-04 16:21 [PATCH 0/7] Process record and reverse debugging support on aarch64-linux Omair Javaid
` (3 preceding siblings ...)
2014-06-04 16:21 ` [PATCH 2/7] Fixes for aarch64-linux gdb core file support Omair Javaid
@ 2014-06-04 16:21 ` Omair Javaid
2014-06-05 9:00 ` Will Newton
2014-08-30 3:35 ` Yao Qi
2014-06-04 16:21 ` [PATCH 5/7] Support for recording syscall on aarch64-linux Omair Javaid
` (3 subsequent siblings)
8 siblings, 2 replies; 53+ messages in thread
From: Omair Javaid @ 2014-06-04 16:21 UTC (permalink / raw)
To: gdb-patches; +Cc: Omair Javaid
This patch adds linux-record.o to gdb_target_obs in configure.tgt for
aarch64*-linux* targets.
gdb:
2014-06-04 Omair Javaid <omair.javaid@linaro.org>
* configure.tgt: Add linux-record.o to gdb_target_obs.
---
gdb/configure.tgt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/configure.tgt b/gdb/configure.tgt
index 01311b2..e9b906f 100644
--- a/gdb/configure.tgt
+++ b/gdb/configure.tgt
@@ -41,7 +41,7 @@ aarch64*-*-linux*)
# Target: AArch64 linux
gdb_target_obs="aarch64-tdep.o aarch64-linux-tdep.o \
glibc-tdep.o linux-tdep.o solib-svr4.o \
- symfile-mem.o"
+ symfile-mem.o linux-record.o"
build_gdbserver=yes
;;
--
1.9.1
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 3/7] Enable gdb process record on aarch64-linux targets
2014-06-04 16:21 ` [PATCH 3/7] Enable gdb process record on aarch64-linux targets Omair Javaid
@ 2014-06-05 9:00 ` Will Newton
2014-08-30 3:35 ` Yao Qi
1 sibling, 0 replies; 53+ messages in thread
From: Will Newton @ 2014-06-05 9:00 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
On 4 June 2014 17:21, Omair Javaid <omair.javaid@linaro.org> wrote:
> This patch adds linux-record.o to gdb_target_obs in configure.tgt for
> aarch64*-linux* targets.
>
> gdb:
>
> 2014-06-04 Omair Javaid <omair.javaid@linaro.org>
>
> * configure.tgt: Add linux-record.o to gdb_target_obs.
>
> ---
> gdb/configure.tgt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks OK to me.
> diff --git a/gdb/configure.tgt b/gdb/configure.tgt
> index 01311b2..e9b906f 100644
> --- a/gdb/configure.tgt
> +++ b/gdb/configure.tgt
> @@ -41,7 +41,7 @@ aarch64*-*-linux*)
> # Target: AArch64 linux
> gdb_target_obs="aarch64-tdep.o aarch64-linux-tdep.o \
> glibc-tdep.o linux-tdep.o solib-svr4.o \
> - symfile-mem.o"
> + symfile-mem.o linux-record.o"
> build_gdbserver=yes
> ;;
>
> --
> 1.9.1
>
--
Will Newton
Toolchain Working Group, Linaro
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH 3/7] Enable gdb process record on aarch64-linux targets
2014-06-04 16:21 ` [PATCH 3/7] Enable gdb process record on aarch64-linux targets Omair Javaid
2014-06-05 9:00 ` Will Newton
@ 2014-08-30 3:35 ` Yao Qi
2014-09-01 19:50 ` Omair Javaid
1 sibling, 1 reply; 53+ messages in thread
From: Yao Qi @ 2014-08-30 3:35 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
Omair Javaid <omair.javaid@linaro.org> writes:
> This patch adds linux-record.o to gdb_target_obs in configure.tgt for
> aarch64*-linux* targets.
>
> gdb:
>
> 2014-06-04 Omair Javaid <omair.javaid@linaro.org>
>
> * configure.tgt: Add linux-record.o to gdb_target_obs.
IIUC, linux-record.o provides the linux syscall support in process
record. However, I don't see aarch64-linux syscall record is supported
in 4/7. If so, do we still need this patch?
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH 3/7] Enable gdb process record on aarch64-linux targets
2014-08-30 3:35 ` Yao Qi
@ 2014-09-01 19:50 ` Omair Javaid
0 siblings, 0 replies; 53+ messages in thread
From: Omair Javaid @ 2014-09-01 19:50 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
On 30 August 2014 08:30, Yao Qi <yao@codesourcery.com> wrote:
> Omair Javaid <omair.javaid@linaro.org> writes:
>
>> This patch adds linux-record.o to gdb_target_obs in configure.tgt for
>> aarch64*-linux* targets.
>>
>> gdb:
>>
>> 2014-06-04 Omair Javaid <omair.javaid@linaro.org>
>>
>> * configure.tgt: Add linux-record.o to gdb_target_obs.
>
> IIUC, linux-record.o provides the linux syscall support in process
> record. However, I don't see aarch64-linux syscall record is supported
> in 4/7. If so, do we still need this patch?
Here is aarch64 syscall record patch:
https://sourceware.org/ml/gdb-patches/2014-08/msg00636.html
>
> --
> Yao (齐尧)
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH 5/7] Support for recording syscall on aarch64-linux
2014-06-04 16:21 [PATCH 0/7] Process record and reverse debugging support on aarch64-linux Omair Javaid
` (4 preceding siblings ...)
2014-06-04 16:21 ` [PATCH 3/7] Enable gdb process record on aarch64-linux targets Omair Javaid
@ 2014-06-04 16:21 ` Omair Javaid
2014-06-05 8:52 ` Will Newton
2014-06-06 15:58 ` Andreas Arnez
2014-06-04 16:21 ` [PATCH 6/7] Support for recording aarch64 advance simd instructions Omair Javaid
` (2 subsequent siblings)
8 siblings, 2 replies; 53+ messages in thread
From: Omair Javaid @ 2014-06-04 16:21 UTC (permalink / raw)
To: gdb-patches; +Cc: Omair Javaid
This patch adds support for recording system call instruction on aarch64-linux
targets.
gdb:
2014-06-04 Omair Javaid <omair.javaid@linaro.org>
* aarch64-linux-tdep.c (record.h): Include.
(record-full.h): Include.
(struct linux_record_tdep aarch64_linux_record_tdep): Declared.
(aarch64_canonicalize_syscall): New function.
(aarch64_all_but_pc_registers_record): New function.
(aarch64_linux_syscall_record): New function.
(aarch64_linux_init_abi): Updated.
* aarch64-linux-tdep.h (aarch64_syscall): New enum.
* aarch64-tdep.c (aarch64_record_branch_except_sys): Updated.
* aarch64-tdep.h
(struct gdbarch_tdep) <aarch64_syscall_record>: Defined.
---
gdb/aarch64-linux-tdep.c | 924 +++++++++++++++++++++++++++++++++++++++++++++++
gdb/aarch64-linux-tdep.h | 266 ++++++++++++++
gdb/aarch64-tdep.c | 15 +-
gdb/aarch64-tdep.h | 3 +
4 files changed, 1207 insertions(+), 1 deletion(-)
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index dece0c3..6d9a3bf 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -41,6 +41,9 @@
#include "user-regs.h"
#include <ctype.h>
+#include "record-full.h"
+#include "linux-record.h"
+
/* The general-purpose regset consists of 31 X registers, plus SP, PC,
and PSTATE registers, as defined in the AArch64 port of the Linux
kernel. */
@@ -421,6 +424,769 @@ aarch64_stap_parse_special_token (struct gdbarch *gdbarch,
return 1;
}
+/* Aarch64 process record-replay constructs: syscall, signal etc. */
+
+struct linux_record_tdep aarch64_linux_record_tdep;
+
+/* aarch64_canonicalize_syscall maps syscall ids from the native aarch64
+ linux set of syscall ids into a canonical set of syscall ids used by
+ process record. */
+
+static enum gdb_syscall
+aarch64_canonicalize_syscall (enum aarch64_syscall syscall_number)
+{
+ switch (syscall_number) {
+ case aarch64_sys_read:
+ return gdb_sys_read;
+
+ case aarch64_sys_write:
+ return gdb_sys_write;
+
+ case aarch64_sys_open:
+ return gdb_sys_open;
+
+ case aarch64_sys_close:
+ return gdb_sys_close;
+
+ case aarch64_sys_lseek:
+ return gdb_sys_lseek;
+
+ case aarch64_sys_mmap:
+ return gdb_sys_mmap2;
+
+ case aarch64_sys_mprotect:
+ return gdb_sys_mprotect;
+
+ case aarch64_sys_munmap:
+ return gdb_sys_munmap;
+
+ case aarch64_sys_brk:
+ return gdb_sys_brk;
+
+ case aarch64_sys_rt_sigaction:
+ return gdb_sys_rt_sigaction;
+
+ case aarch64_sys_rt_sigprocmask:
+ return gdb_sys_rt_sigprocmask;
+
+ case aarch64_sys_rt_sigreturn:
+ return gdb_sys_rt_sigreturn;
+
+ case aarch64_sys_ioctl:
+ return gdb_sys_ioctl;
+
+ case aarch64_sys_pread64:
+ return gdb_sys_pread64;
+
+ case aarch64_sys_pwrite64:
+ return gdb_sys_pwrite64;
+
+ case aarch64_sys_readv:
+ return gdb_sys_readv;
+
+ case aarch64_sys_writev:
+ return gdb_sys_writev;
+
+ case aarch64_sys_sched_yield:
+ return gdb_sys_sched_yield;
+
+ case aarch64_sys_mremap:
+ return gdb_sys_mremap;
+
+ case aarch64_sys_msync:
+ return gdb_sys_msync;
+
+ case aarch64_sys_mincore:
+ return gdb_sys_mincore;
+
+ case aarch64_sys_madvise:
+ return gdb_sys_madvise;
+
+ case aarch64_sys_shmget:
+ return gdb_sys_shmget;
+
+ case aarch64_sys_shmat:
+ return gdb_sys_shmat;
+
+ case aarch64_sys_shmctl:
+ return gdb_sys_shmctl;
+
+ case aarch64_sys_dup:
+ return gdb_sys_dup;
+
+ case aarch64_sys_dup3:
+ return gdb_sys_dup2;
+
+ case aarch64_sys_nanosleep:
+ return gdb_sys_nanosleep;
+
+ case aarch64_sys_getitimer:
+ return gdb_sys_getitimer;
+
+ case aarch64_sys_setitimer:
+ return gdb_sys_setitimer;
+
+ case aarch64_sys_getpid:
+ return gdb_sys_getpid;
+
+ case aarch64_sys_sendfile:
+ return gdb_sys_sendfile64;
+
+ case aarch64_sys_socket:
+ return gdb_sys_socket;
+
+ case aarch64_sys_connect:
+ return gdb_sys_connect;
+
+ case aarch64_sys_accept:
+ return gdb_sys_accept;
+
+ case aarch64_sys_sendto:
+ return gdb_sys_sendto;
+
+ case aarch64_sys_recvfrom:
+ return gdb_sys_recvfrom;
+
+ case aarch64_sys_sendmsg:
+ return gdb_sys_sendmsg;
+
+ case aarch64_sys_recvmsg:
+ return gdb_sys_recvmsg;
+
+ case aarch64_sys_shutdown:
+ return gdb_sys_shutdown;
+
+ case aarch64_sys_bind:
+ return gdb_sys_bind;
+
+ case aarch64_sys_listen:
+ return gdb_sys_listen;
+
+ case aarch64_sys_getsockname:
+ return gdb_sys_getsockname;
+
+ case aarch64_sys_getpeername:
+ return gdb_sys_getpeername;
+
+ case aarch64_sys_socketpair:
+ return gdb_sys_socketpair;
+
+ case aarch64_sys_setsockopt:
+ return gdb_sys_setsockopt;
+
+ case aarch64_sys_getsockopt:
+ return gdb_sys_getsockopt;
+
+ case aarch64_sys_clone:
+ return gdb_sys_clone;
+
+ case aarch64_sys_execve:
+ return gdb_sys_execve;
+
+ case aarch64_sys_exit:
+ return gdb_sys_exit;
+
+ case aarch64_sys_wait4:
+ return gdb_sys_wait4;
+
+ case aarch64_sys_kill:
+ return gdb_sys_kill;
+
+ case aarch64_sys_uname:
+ return gdb_sys_uname;
+
+ case aarch64_sys_semget:
+ return gdb_sys_semget;
+
+ case aarch64_sys_semop:
+ return gdb_sys_semop;
+
+ case aarch64_sys_semctl:
+ return gdb_sys_semctl;
+
+ case aarch64_sys_shmdt:
+ return gdb_sys_shmdt;
+
+ case aarch64_sys_msgget:
+ return gdb_sys_msgget;
+
+ case aarch64_sys_msgsnd:
+ return gdb_sys_msgsnd;
+
+ case aarch64_sys_msgrcv:
+ return gdb_sys_msgrcv;
+
+ case aarch64_sys_msgctl:
+ return gdb_sys_msgctl;
+
+ case aarch64_sys_fcntl:
+ return gdb_sys_fcntl;
+
+ case aarch64_sys_flock:
+ return gdb_sys_flock;
+
+ case aarch64_sys_fsync:
+ return gdb_sys_fsync;
+
+ case aarch64_sys_fdatasync:
+ return gdb_sys_fdatasync;
+
+ case aarch64_sys_truncate:
+ return gdb_sys_truncate;
+
+ case aarch64_sys_ftruncate:
+ return gdb_sys_ftruncate;
+
+ case aarch64_sys_getcwd:
+ return gdb_sys_getcwd;
+
+ case aarch64_sys_chdir:
+ return gdb_sys_chdir;
+
+ case aarch64_sys_fchdir:
+ return gdb_sys_fchdir;
+
+ case aarch64_sys_rename:
+ return gdb_sys_rename;
+
+ case aarch64_sys_mkdir:
+ return gdb_sys_mkdir;
+
+ case aarch64_sys_link:
+ return gdb_sys_link;
+
+ case aarch64_sys_unlink:
+ return gdb_sys_unlink;
+
+ case aarch64_sys_symlink:
+ return gdb_sys_symlink;
+
+ case aarch64_sys_readlink:
+ return gdb_sys_readlink;
+
+ case aarch64_sys_fchmodat:
+ return gdb_sys_chmod;
+
+ case aarch64_sys_fchmod:
+ return gdb_sys_fchmod;
+
+ case aarch64_sys_fchownat:
+ return gdb_sys_chown;
+
+ case aarch64_sys_fchown:
+ return gdb_sys_fchown;
+
+ case aarch64_sys_umask:
+ return gdb_sys_umask;
+
+ case aarch64_sys_gettimeofday:
+ return gdb_sys_gettimeofday;
+
+ case aarch64_sys_getrlimit:
+ return gdb_sys_getrlimit;
+
+ case aarch64_sys_getrusage:
+ return gdb_sys_getrusage;
+
+ case aarch64_sys_sysinfo:
+ return gdb_sys_sysinfo;
+
+ case aarch64_sys_ptrace:
+ return gdb_sys_ptrace;
+
+ case aarch64_sys_getuid:
+ return gdb_sys_getuid;
+
+ case aarch64_sys_syslog:
+ return gdb_sys_syslog;
+
+ case aarch64_sys_getgid:
+ return gdb_sys_getgid;
+
+ case aarch64_sys_setuid:
+ return gdb_sys_setuid;
+
+ case aarch64_sys_setgid:
+ return gdb_sys_setgid;
+
+ case aarch64_sys_geteuid:
+ return gdb_sys_geteuid;
+
+ case aarch64_sys_getegid:
+ return gdb_sys_getegid;
+
+ case aarch64_sys_setpgid:
+ return gdb_sys_setpgid;
+
+ case aarch64_sys_getppid:
+ return gdb_sys_getppid;
+
+ case aarch64_sys_setsid:
+ return gdb_sys_setsid;
+
+ case aarch64_sys_setreuid:
+ return gdb_sys_setreuid;
+
+ case aarch64_sys_setregid:
+ return gdb_sys_setregid;
+
+ case aarch64_sys_getgroups:
+ return gdb_sys_getgroups;
+
+ case aarch64_sys_setgroups:
+ return gdb_sys_setgroups;
+
+ case aarch64_sys_setresuid:
+ return gdb_sys_setresuid;
+
+ case aarch64_sys_getresuid:
+ return gdb_sys_getresuid;
+
+ case aarch64_sys_setresgid:
+ return gdb_sys_setresgid;
+
+ case aarch64_sys_getresgid:
+ return gdb_sys_getresgid;
+
+ case aarch64_sys_getpgid:
+ return gdb_sys_getpgid;
+
+ case aarch64_sys_setfsuid:
+ return gdb_sys_setfsuid;
+
+ case aarch64_sys_setfsgid:
+ return gdb_sys_setfsgid;
+
+ case aarch64_sys_getsid:
+ return gdb_sys_getsid;
+
+ case aarch64_sys_capget:
+ return gdb_sys_capget;
+
+ case aarch64_sys_capset:
+ return gdb_sys_capset;
+
+ case aarch64_sys_rt_sigpending:
+ return gdb_sys_rt_sigpending;
+
+ case aarch64_sys_rt_sigtimedwait:
+ return gdb_sys_rt_sigtimedwait;
+
+ case aarch64_sys_rt_sigqueueinfo:
+ return gdb_sys_rt_sigqueueinfo;
+
+ case aarch64_sys_rt_sigsuspend:
+ return gdb_sys_rt_sigsuspend;
+
+ case aarch64_sys_sigaltstack:
+ return gdb_sys_sigaltstack;
+
+ case aarch64_sys_mknod:
+ return gdb_sys_mknod;
+
+ case aarch64_sys_personality:
+ return gdb_sys_personality;
+
+ case aarch64_sys_statfs:
+ return gdb_sys_statfs;
+
+ case aarch64_sys_fstat:
+ return gdb_sys_fstat;
+
+ case aarch64_sys_fstatfs:
+ return gdb_sys_fstatfs;
+
+ case aarch64_sys_getpriority:
+ return gdb_sys_getpriority;
+
+ case aarch64_sys_setpriority:
+ return gdb_sys_setpriority;
+
+ case aarch64_sys_sched_setparam:
+ return gdb_sys_sched_setparam;
+
+ case aarch64_sys_sched_getparam:
+ return gdb_sys_sched_getparam;
+
+ case aarch64_sys_sched_setscheduler:
+ return gdb_sys_sched_setscheduler;
+
+ case aarch64_sys_sched_getscheduler:
+ return gdb_sys_sched_getscheduler;
+
+ case aarch64_sys_sched_get_priority_max:
+ return gdb_sys_sched_get_priority_max;
+
+ case aarch64_sys_sched_get_priority_min:
+ return gdb_sys_sched_get_priority_min;
+
+ case aarch64_sys_sched_rr_get_interval:
+ return gdb_sys_sched_rr_get_interval;
+
+ case aarch64_sys_mlock:
+ return gdb_sys_mlock;
+
+ case aarch64_sys_munlock:
+ return gdb_sys_munlock;
+
+ case aarch64_sys_mlockall:
+ return gdb_sys_mlockall;
+
+ case aarch64_sys_munlockall:
+ return gdb_sys_munlockall;
+
+ case aarch64_sys_vhangup:
+ return gdb_sys_vhangup;
+
+ case aarch64_sys_prctl:
+ return gdb_sys_prctl;
+
+ case aarch64_sys_adjtimex:
+ return gdb_sys_adjtimex;
+
+ case aarch64_sys_setrlimit:
+ return gdb_sys_setrlimit;
+
+ case aarch64_sys_chroot:
+ return gdb_sys_chroot;
+
+ case aarch64_sys_sync:
+ return gdb_sys_sync;
+
+ case aarch64_sys_acct:
+ return gdb_sys_acct;
+
+ case aarch64_sys_settimeofday:
+ return gdb_sys_settimeofday;
+
+ case aarch64_sys_mount:
+ return gdb_sys_mount;
+
+ case aarch64_sys_umount2:
+ return gdb_sys_umount;
+
+ case aarch64_sys_swapon:
+ return gdb_sys_swapon;
+
+ case aarch64_sys_swapoff:
+ return gdb_sys_swapoff;
+
+ case aarch64_sys_reboot:
+ return gdb_sys_reboot;
+
+ case aarch64_sys_sethostname:
+ return gdb_sys_sethostname;
+
+ case aarch64_sys_setdomainname:
+ return gdb_sys_setdomainname;
+
+ case aarch64_sys_init_module:
+ return gdb_sys_init_module;
+
+ case aarch64_sys_delete_module:
+ return gdb_sys_delete_module;
+
+ case aarch64_sys_quotactl:
+ return gdb_sys_quotactl;
+
+ case aarch64_sys_nfsservctl:
+ return gdb_sys_nfsservctl;
+
+ case aarch64_sys_gettid:
+ return gdb_sys_gettid;
+
+ case aarch64_sys_readahead:
+ return gdb_sys_readahead;
+
+ case aarch64_sys_setxattr:
+ return gdb_sys_setxattr;
+
+ case aarch64_sys_lsetxattr:
+ return gdb_sys_lsetxattr;
+
+ case aarch64_sys_fsetxattr:
+ return gdb_sys_fsetxattr;
+
+ case aarch64_sys_getxattr:
+ return gdb_sys_getxattr;
+
+ case aarch64_sys_lgetxattr:
+ return gdb_sys_lgetxattr;
+
+ case aarch64_sys_fgetxattr:
+ return gdb_sys_fgetxattr;
+
+ case aarch64_sys_listxattr:
+ return gdb_sys_listxattr;
+
+ case aarch64_sys_llistxattr:
+ return gdb_sys_llistxattr;
+
+ case aarch64_sys_flistxattr:
+ return gdb_sys_flistxattr;
+
+ case aarch64_sys_removexattr:
+ return gdb_sys_removexattr;
+
+ case aarch64_sys_lremovexattr:
+ return gdb_sys_lremovexattr;
+
+ case aarch64_sys_fremovexattr:
+ return gdb_sys_fremovexattr;
+
+ case aarch64_sys_tkill:
+ return gdb_sys_tkill;
+
+ case aarch64_sys_times:
+ return gdb_sys_time;
+
+ case aarch64_sys_futex:
+ return gdb_sys_futex;
+
+ case aarch64_sys_sched_setaffinity:
+ return gdb_sys_sched_setaffinity;
+
+ case aarch64_sys_sched_getaffinity:
+ return gdb_sys_sched_getaffinity;
+
+ case aarch64_sys_io_setup:
+ return gdb_sys_io_setup;
+
+ case aarch64_sys_io_destroy:
+ return gdb_sys_io_destroy;
+
+ case aarch64_sys_io_getevents:
+ return gdb_sys_io_getevents;
+
+ case aarch64_sys_io_submit:
+ return gdb_sys_io_submit;
+
+ case aarch64_sys_io_cancel:
+ return gdb_sys_io_cancel;
+
+ case aarch64_sys_lookup_dcookie:
+ return gdb_sys_lookup_dcookie;
+
+ case aarch64_sys_epoll_create1:
+ return gdb_sys_epoll_create;
+
+ case aarch64_sys_remap_file_pages:
+ return gdb_sys_remap_file_pages;
+
+ case aarch64_sys_getdents64:
+ return gdb_sys_getdents64;
+
+ case aarch64_sys_set_tid_address:
+ return gdb_sys_set_tid_address;
+
+ case aarch64_sys_semtimedop:
+ return gdb_sys_semtimedop;
+
+ case aarch64_sys_fadvise64:
+ return gdb_sys_fadvise64;
+
+ case aarch64_sys_timer_create:
+ return gdb_sys_timer_create;
+
+ case aarch64_sys_timer_settime:
+ return gdb_sys_timer_settime;
+
+ case aarch64_sys_timer_gettime:
+ return gdb_sys_timer_gettime;
+
+ case aarch64_sys_timer_getoverrun:
+ return gdb_sys_timer_getoverrun;
+
+ case aarch64_sys_timer_delete:
+ return gdb_sys_timer_delete;
+
+ case aarch64_sys_clock_settime:
+ return gdb_sys_clock_settime;
+
+ case aarch64_sys_clock_gettime:
+ return gdb_sys_clock_gettime;
+
+ case aarch64_sys_clock_getres:
+ return gdb_sys_clock_getres;
+
+ case aarch64_sys_clock_nanosleep:
+ return gdb_sys_clock_nanosleep;
+
+ case aarch64_sys_exit_group:
+ return gdb_sys_exit_group;
+
+ case aarch64_sys_epoll_pwait:
+ return gdb_sys_epoll_wait;
+
+ case aarch64_sys_epoll_ctl:
+ return gdb_sys_epoll_ctl;
+
+ case aarch64_sys_tgkill:
+ return gdb_sys_tgkill;
+
+ case aarch64_sys_utimensat:
+ return gdb_sys_utimes;
+
+ case aarch64_sys_mbind:
+ return gdb_sys_mbind;
+
+ case aarch64_sys_set_mempolicy:
+ return gdb_sys_set_mempolicy;
+
+ case aarch64_sys_get_mempolicy:
+ return gdb_sys_get_mempolicy;
+
+ case aarch64_sys_mq_open:
+ return gdb_sys_mq_open;
+
+ case aarch64_sys_mq_unlink:
+ return gdb_sys_mq_unlink;
+
+ case aarch64_sys_mq_timedsend:
+ return gdb_sys_mq_timedsend;
+
+ case aarch64_sys_mq_timedreceive:
+ return gdb_sys_mq_timedreceive;
+
+ case aarch64_sys_mq_notify:
+ return gdb_sys_mq_notify;
+
+ case aarch64_sys_mq_getsetattr:
+ return gdb_sys_mq_getsetattr;
+
+ case aarch64_sys_kexec_load:
+ return gdb_sys_kexec_load;
+
+ case aarch64_sys_waitid:
+ return gdb_sys_waitid;
+
+ case aarch64_sys_add_key:
+ return gdb_sys_add_key;
+
+ case aarch64_sys_request_key:
+ return gdb_sys_request_key;
+
+ case aarch64_sys_keyctl:
+ return gdb_sys_keyctl;
+
+ case aarch64_sys_ioprio_set:
+ return gdb_sys_ioprio_set;
+
+ case aarch64_sys_ioprio_get:
+ return gdb_sys_ioprio_get;
+
+ case aarch64_sys_fanotify_init:
+ return gdb_sys_inotify_init;
+
+ case aarch64_sys_inotify_add_watch:
+ return gdb_sys_inotify_add_watch;
+
+ case aarch64_sys_inotify_rm_watch:
+ return gdb_sys_inotify_rm_watch;
+
+ case aarch64_sys_migrate_pages:
+ return gdb_sys_migrate_pages;
+
+ case aarch64_sys_pselect6:
+ return gdb_sys_pselect6;
+
+ case aarch64_sys_ppoll:
+ return gdb_sys_ppoll;
+
+ case aarch64_sys_unshare:
+ return gdb_sys_unshare;
+
+ case aarch64_sys_set_robust_list:
+ return gdb_sys_set_robust_list;
+
+ case aarch64_sys_get_robust_list:
+ return gdb_sys_get_robust_list;
+
+ case aarch64_sys_splice:
+ return gdb_sys_splice;
+
+ case aarch64_sys_tee:
+ return gdb_sys_tee;
+
+ case aarch64_sys_sync_file_range:
+ return gdb_sys_sync_file_range;
+
+ case aarch64_sys_vmsplice:
+ return gdb_sys_vmsplice;
+
+ case aarch64_sys_move_pages:
+ return gdb_sys_move_pages;
+
+ default:
+ return -1;
+ }
+}
+
+/* Record all registers but PC register for process-record. */
+
+static int
+aarch64_all_but_pc_registers_record (struct regcache *regcache)
+{
+ int i;
+
+ for (i = 0; i < AARCH64_PC_REGNUM; i++)
+ {
+ if (record_full_arch_list_add_reg (regcache, AARCH64_X0_REGNUM + i))
+ return -1;
+ }
+
+ if (record_full_arch_list_add_reg (regcache, AARCH64_CPSR_REGNUM))
+ return -1;
+
+ return 0;
+}
+
+/* Handler for arm system call instruction recording. */
+
+static int
+aarch64_linux_syscall_record (struct regcache *regcache, unsigned long svc_number)
+{
+ int ret = 0;
+ enum gdb_syscall syscall_gdb;
+
+ printf_unfiltered (_("syscall number %s\n"),
+ plongest (svc_number));
+ syscall_gdb = aarch64_canonicalize_syscall (svc_number);
+
+ if (syscall_gdb < 0)
+ {
+ printf_unfiltered (_("Process record and replay target doesn't "
+ "support syscall number %s\n"),
+ plongest (svc_number));
+ return -1;
+ }
+
+ if (syscall_gdb == gdb_sys_sigreturn
+ || syscall_gdb == gdb_sys_rt_sigreturn)
+ {
+ if (aarch64_all_but_pc_registers_record (regcache))
+ return -1;
+ return 0;
+ }
+
+ ret = record_linux_system_call (syscall_gdb, regcache,
+ &aarch64_linux_record_tdep);
+ if (ret != 0)
+ return ret;
+
+ /* Record the return value of the system call. */
+ if (record_full_arch_list_add_reg (regcache, AARCH64_X0_REGNUM))
+ return -1;
+ /* Record LR. */
+ if (record_full_arch_list_add_reg (regcache, AARCH64_LR_REGNUM))
+ return -1;
+ /* Record CPSR. */
+ if (record_full_arch_list_add_reg (regcache, AARCH64_CPSR_REGNUM))
+ return -1;
+
+ return 0;
+}
+
static void
aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
{
@@ -471,6 +1237,164 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
/* Reversible debugging, process record. */
set_gdbarch_process_record (gdbarch, aarch64_process_record);
+ /* Syscall record. */
+ tdep->aarch64_syscall_record = aarch64_linux_syscall_record;
+
+ /* Initialize the aarch64_linux_record_tdep. */
+ /* These values are the size of the type that will be used in a system
+ call. They are obtained from Linux Kernel source. */
+ aarch64_linux_record_tdep.size_pointer
+ = gdbarch_ptr_bit (gdbarch) / TARGET_CHAR_BIT;
+ aarch64_linux_record_tdep.size__old_kernel_stat = 32;
+ aarch64_linux_record_tdep.size_tms = 32;
+ aarch64_linux_record_tdep.size_loff_t = 8;
+ aarch64_linux_record_tdep.size_flock = 32;
+ aarch64_linux_record_tdep.size_oldold_utsname = 45;
+ aarch64_linux_record_tdep.size_ustat = 32;
+ aarch64_linux_record_tdep.size_old_sigaction = 152;
+ aarch64_linux_record_tdep.size_old_sigset_t = 128;
+ aarch64_linux_record_tdep.size_rlimit = 16;
+ aarch64_linux_record_tdep.size_rusage = 144;
+ aarch64_linux_record_tdep.size_timeval = 16;
+ aarch64_linux_record_tdep.size_timezone = 8;
+ aarch64_linux_record_tdep.size_old_gid_t = 2;
+ aarch64_linux_record_tdep.size_old_uid_t = 2;
+ aarch64_linux_record_tdep.size_fd_set = 128;
+ aarch64_linux_record_tdep.size_dirent = 280;
+ aarch64_linux_record_tdep.size_dirent64 = 280;
+ aarch64_linux_record_tdep.size_statfs = 120;
+ aarch64_linux_record_tdep.size_statfs64 = 120;
+ aarch64_linux_record_tdep.size_sockaddr = 16;
+ aarch64_linux_record_tdep.size_int
+ = gdbarch_int_bit (gdbarch) / TARGET_CHAR_BIT;
+ aarch64_linux_record_tdep.size_long
+ = gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
+ aarch64_linux_record_tdep.size_ulong
+ = gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
+ aarch64_linux_record_tdep.size_msghdr = 56;
+ aarch64_linux_record_tdep.size_itimerval = 32;
+ aarch64_linux_record_tdep.size_stat = 144;
+ aarch64_linux_record_tdep.size_old_utsname = 325;
+ aarch64_linux_record_tdep.size_sysinfo = 112;
+ aarch64_linux_record_tdep.size_msqid_ds = 120;
+ aarch64_linux_record_tdep.size_shmid_ds = 112;
+ aarch64_linux_record_tdep.size_new_utsname = 390;
+ aarch64_linux_record_tdep.size_timex = 208;
+ aarch64_linux_record_tdep.size_mem_dqinfo = 24;
+ aarch64_linux_record_tdep.size_if_dqblk = 72;
+ aarch64_linux_record_tdep.size_fs_quota_stat = 80;
+ aarch64_linux_record_tdep.size_timespec = 16;
+ aarch64_linux_record_tdep.size_pollfd = 8;
+ aarch64_linux_record_tdep.size_NFS_FHSIZE = 32;
+ aarch64_linux_record_tdep.size_knfsd_fh = 132;
+ aarch64_linux_record_tdep.size_TASK_COMM_LEN = 16;
+ aarch64_linux_record_tdep.size_sigaction = 152;
+ aarch64_linux_record_tdep.size_sigset_t = 128;
+ aarch64_linux_record_tdep.size_siginfo_t = 128;
+ aarch64_linux_record_tdep.size_cap_user_data_t = 8;
+ aarch64_linux_record_tdep.size_stack_t = 24;
+ aarch64_linux_record_tdep.size_off_t = 8;
+ aarch64_linux_record_tdep.size_stat64 = 144;
+ aarch64_linux_record_tdep.size_gid_t = 4;
+ aarch64_linux_record_tdep.size_uid_t = 4;
+ aarch64_linux_record_tdep.size_PAGE_SIZE = 4096;
+ aarch64_linux_record_tdep.size_flock64 = 32;
+ aarch64_linux_record_tdep.size_user_desc = 16;
+ aarch64_linux_record_tdep.size_io_event = 32;
+ aarch64_linux_record_tdep.size_iocb = 64;
+ aarch64_linux_record_tdep.size_epoll_event = 12;
+ aarch64_linux_record_tdep.size_itimerspec = 32;
+ aarch64_linux_record_tdep.size_mq_attr = 64;
+ aarch64_linux_record_tdep.size_siginfo = 128;
+ aarch64_linux_record_tdep.size_termios = 60;
+ aarch64_linux_record_tdep.size_termios2 = 44;
+ aarch64_linux_record_tdep.size_pid_t = 4;
+ aarch64_linux_record_tdep.size_winsize = 8;
+ aarch64_linux_record_tdep.size_serial_struct = 72;
+ aarch64_linux_record_tdep.size_serial_icounter_struct = 80;
+ aarch64_linux_record_tdep.size_hayes_esp_config = 12;
+ aarch64_linux_record_tdep.size_size_t = 8;
+ aarch64_linux_record_tdep.size_iovec = 16;
+
+ /* These values are the second argument of system call "sys_ioctl".
+ They are obtained from Linux Kernel source. */
+ aarch64_linux_record_tdep.ioctl_TCGETS = 0x5401;
+ aarch64_linux_record_tdep.ioctl_TCSETS = 0x5402;
+ aarch64_linux_record_tdep.ioctl_TCSETSW = 0x5403;
+ aarch64_linux_record_tdep.ioctl_TCSETSF = 0x5404;
+ aarch64_linux_record_tdep.ioctl_TCGETA = 0x5405;
+ aarch64_linux_record_tdep.ioctl_TCSETA = 0x5406;
+ aarch64_linux_record_tdep.ioctl_TCSETAW = 0x5407;
+ aarch64_linux_record_tdep.ioctl_TCSETAF = 0x5408;
+ aarch64_linux_record_tdep.ioctl_TCSBRK = 0x5409;
+ aarch64_linux_record_tdep.ioctl_TCXONC = 0x540a;
+ aarch64_linux_record_tdep.ioctl_TCFLSH = 0x540b;
+ aarch64_linux_record_tdep.ioctl_TIOCEXCL = 0x540c;
+ aarch64_linux_record_tdep.ioctl_TIOCNXCL = 0x540d;
+ aarch64_linux_record_tdep.ioctl_TIOCSCTTY = 0x540e;
+ aarch64_linux_record_tdep.ioctl_TIOCGPGRP = 0x540f;
+ aarch64_linux_record_tdep.ioctl_TIOCSPGRP = 0x5410;
+ aarch64_linux_record_tdep.ioctl_TIOCOUTQ = 0x5411;
+ aarch64_linux_record_tdep.ioctl_TIOCSTI = 0x5412;
+ aarch64_linux_record_tdep.ioctl_TIOCGWINSZ = 0x5413;
+ aarch64_linux_record_tdep.ioctl_TIOCSWINSZ = 0x5414;
+ aarch64_linux_record_tdep.ioctl_TIOCMGET = 0x5415;
+ aarch64_linux_record_tdep.ioctl_TIOCMBIS = 0x5416;
+ aarch64_linux_record_tdep.ioctl_TIOCMBIC = 0x5417;
+ aarch64_linux_record_tdep.ioctl_TIOCMSET = 0x5418;
+ aarch64_linux_record_tdep.ioctl_TIOCGSOFTCAR = 0x5419;
+ aarch64_linux_record_tdep.ioctl_TIOCSSOFTCAR = 0x541a;
+ aarch64_linux_record_tdep.ioctl_FIONREAD = 0x541b;
+ aarch64_linux_record_tdep.ioctl_TIOCINQ = 0x541b;
+ aarch64_linux_record_tdep.ioctl_TIOCLINUX = 0x541c;
+ aarch64_linux_record_tdep.ioctl_TIOCCONS = 0x541d;
+ aarch64_linux_record_tdep.ioctl_TIOCGSERIAL = 0x541e;
+ aarch64_linux_record_tdep.ioctl_TIOCSSERIAL = 0x541f;
+ aarch64_linux_record_tdep.ioctl_TIOCPKT = 0x5420;
+ aarch64_linux_record_tdep.ioctl_FIONBIO = 0x5421;
+ aarch64_linux_record_tdep.ioctl_TIOCNOTTY = 0x5422;
+ aarch64_linux_record_tdep.ioctl_TIOCSETD = 0x5423;
+ aarch64_linux_record_tdep.ioctl_TIOCGETD = 0x5424;
+ aarch64_linux_record_tdep.ioctl_TCSBRKP = 0x5425;
+ aarch64_linux_record_tdep.ioctl_TIOCTTYGSTRUCT = 0x5426;
+ aarch64_linux_record_tdep.ioctl_TIOCSBRK = 0x5427;
+ aarch64_linux_record_tdep.ioctl_TIOCCBRK = 0x5428;
+ aarch64_linux_record_tdep.ioctl_TIOCGSID = 0x5429;
+ aarch64_linux_record_tdep.ioctl_TCGETS2 = 0x802c542a;
+ aarch64_linux_record_tdep.ioctl_TCSETS2 = 0x402c542b;
+ aarch64_linux_record_tdep.ioctl_TCSETSW2 = 0x402c542c;
+ aarch64_linux_record_tdep.ioctl_TCSETSF2 = 0x402c542d;
+ aarch64_linux_record_tdep.ioctl_TIOCGPTN = 0x80045430;
+ aarch64_linux_record_tdep.ioctl_TIOCSPTLCK = 0x40045431;
+ aarch64_linux_record_tdep.ioctl_FIONCLEX = 0x5450;
+ aarch64_linux_record_tdep.ioctl_FIOCLEX = 0x5451;
+ aarch64_linux_record_tdep.ioctl_FIOASYNC = 0x5452;
+ aarch64_linux_record_tdep.ioctl_TIOCSERCONFIG = 0x5453;
+ aarch64_linux_record_tdep.ioctl_TIOCSERGWILD = 0x5454;
+ aarch64_linux_record_tdep.ioctl_TIOCSERSWILD = 0x5455;
+ aarch64_linux_record_tdep.ioctl_TIOCGLCKTRMIOS = 0x5456;
+ aarch64_linux_record_tdep.ioctl_TIOCSLCKTRMIOS = 0x5457;
+ aarch64_linux_record_tdep.ioctl_TIOCSERGSTRUCT = 0x5458;
+ aarch64_linux_record_tdep.ioctl_TIOCSERGETLSR = 0x5459;
+ aarch64_linux_record_tdep.ioctl_TIOCSERGETMULTI = 0x545a;
+ aarch64_linux_record_tdep.ioctl_TIOCSERSETMULTI = 0x545b;
+ aarch64_linux_record_tdep.ioctl_TIOCMIWAIT = 0x545c;
+ aarch64_linux_record_tdep.ioctl_TIOCGICOUNT = 0x545d;
+ aarch64_linux_record_tdep.ioctl_TIOCGHAYESESP = 0x545e;
+ aarch64_linux_record_tdep.ioctl_TIOCSHAYESESP = 0x545f;
+ aarch64_linux_record_tdep.ioctl_FIOQSIZE = 0x5460;
+
+ /* These values are the second argument of system call "sys_fcntl"
+ and "sys_fcntl64". They are obtained from Linux Kernel source. */
+ aarch64_linux_record_tdep.fcntl_F_GETLK = 5;
+ aarch64_linux_record_tdep.fcntl_F_GETLK64 = 12;
+ aarch64_linux_record_tdep.fcntl_F_SETLK64 = 13;
+ aarch64_linux_record_tdep.fcntl_F_SETLKW64 = 14;
+
+ aarch64_linux_record_tdep.arg1 = AARCH64_X0_REGNUM + 1;
+ aarch64_linux_record_tdep.arg2 = AARCH64_X0_REGNUM + 2;
+ aarch64_linux_record_tdep.arg3 = AARCH64_X0_REGNUM + 3;
+ aarch64_linux_record_tdep.arg4 = AARCH64_X0_REGNUM + 3;
}
/* Provide a prototype to silence -Wmissing-prototypes. */
diff --git a/gdb/aarch64-linux-tdep.h b/gdb/aarch64-linux-tdep.h
index e3d7ed7..b199726 100644
--- a/gdb/aarch64-linux-tdep.h
+++ b/gdb/aarch64-linux-tdep.h
@@ -38,3 +38,269 @@ extern void aarch64_linux_supply_fpregset (const struct regset *regset,
extern void aarch64_linux_collect_fpregset (const struct regset *regset,
const struct regcache *regcache,
int regnum, void *fpregs_buf, size_t len);
+
+/* Enum that defines the aarch64 linux specific syscall identifiers used for
+ process record/replay. */
+
+enum aarch64_syscall {
+ aarch64_sys_io_setup = 0,
+ aarch64_sys_io_destroy = 1,
+ aarch64_sys_io_submit = 2,
+ aarch64_sys_io_cancel = 3,
+ aarch64_sys_io_getevents = 4,
+ aarch64_sys_setxattr = 5,
+ aarch64_sys_lsetxattr = 6,
+ aarch64_sys_fsetxattr = 7,
+ aarch64_sys_getxattr = 8,
+ aarch64_sys_lgetxattr = 9,
+ aarch64_sys_fgetxattr = 10,
+ aarch64_sys_listxattr = 11,
+ aarch64_sys_llistxattr = 12,
+ aarch64_sys_flistxattr = 13,
+ aarch64_sys_removexattr = 14,
+ aarch64_sys_lremovexattr = 15,
+ aarch64_sys_fremovexattr = 16,
+ aarch64_sys_getcwd = 17,
+ aarch64_sys_lookup_dcookie = 18,
+ aarch64_sys_eventfd2 = 19,
+ aarch64_sys_epoll_create1 = 20,
+ aarch64_sys_epoll_ctl = 21,
+ aarch64_sys_epoll_pwait = 22,
+ aarch64_sys_dup = 23,
+ aarch64_sys_dup3 = 24,
+ aarch64_sys_fcntl = 25,
+ aarch64_sys_inotify_init1 = 26,
+ aarch64_sys_inotify_add_watch = 27,
+ aarch64_sys_inotify_rm_watch = 28,
+ aarch64_sys_ioctl = 29,
+ aarch64_sys_ioprio_set = 30,
+ aarch64_sys_ioprio_get = 31,
+ aarch64_sys_flock = 32,
+ aarch64_sys_mknod = 33,
+ aarch64_sys_mkdir = 34,
+ aarch64_sys_unlink = 35,
+ aarch64_sys_symlink = 36,
+ aarch64_sys_link = 37,
+ aarch64_sys_rename = 38,
+ aarch64_sys_umount2 = 39,
+ aarch64_sys_mount = 40,
+ aarch64_sys_pivot_root = 41,
+ aarch64_sys_nfsservctl = 42,
+ aarch64_sys_statfs = 43,
+ aarch64_sys_fstatfs = 44,
+ aarch64_sys_truncate = 45,
+ aarch64_sys_ftruncate = 46,
+ aarch64_sys_fallocate = 47,
+ aarch64_sys_faccess = 48,
+ aarch64_sys_chdir = 49,
+ aarch64_sys_fchdir = 50,
+ aarch64_sys_chroot = 51,
+ aarch64_sys_fchmod = 52,
+ aarch64_sys_fchmodat = 53,
+ aarch64_sys_fchownat = 54,
+ aarch64_sys_fchown = 55,
+ aarch64_sys_open = 56,
+ aarch64_sys_close = 57,
+ aarch64_sys_vhangup = 58,
+ aarch64_sys_pipe2 = 59,
+ aarch64_sys_quotactl = 60,
+ aarch64_sys_getdents64 = 61,
+ aarch64_sys_lseek = 62,
+ aarch64_sys_read = 63,
+ aarch64_sys_write = 64,
+ aarch64_sys_readv = 65,
+ aarch64_sys_writev = 66,
+ aarch64_sys_pread64 = 67,
+ aarch64_sys_pwrite64 = 68,
+ aarch64_sys_preadv = 69,
+ aarch64_sys_pwritev = 70,
+ aarch64_sys_sendfile = 71,
+ aarch64_sys_pselect6 = 72,
+ aarch64_sys_ppoll = 73,
+ aarch64_sys_signalfd4 = 74,
+ aarch64_sys_vmsplice = 75,
+ aarch64_sys_splice = 76,
+ aarch64_sys_tee = 77,
+ aarch64_sys_readlink = 78,
+ aarch64_sys_fstatat = 79,
+ aarch64_sys_fstat = 80,
+ aarch64_sys_sync = 81,
+ aarch64_sys_fsync = 82,
+ aarch64_sys_fdatasync = 83,
+ aarch64_sys_sync_file_range2 = 84,
+ aarch64_sys_sync_file_range = 84,
+ aarch64_sys_timerfd_create = 85,
+ aarch64_sys_timerfd_settime = 86,
+ aarch64_sys_timerfd_gettime = 87,
+ aarch64_sys_utimensat = 88,
+ aarch64_sys_acct = 89,
+ aarch64_sys_capget = 90,
+ aarch64_sys_capset = 91,
+ aarch64_sys_personality = 92,
+ aarch64_sys_exit = 93,
+ aarch64_sys_exit_group = 94,
+ aarch64_sys_waitid = 95,
+ aarch64_sys_set_tid_address = 96,
+ aarch64_sys_unshare = 97,
+ aarch64_sys_futex = 98,
+ aarch64_sys_set_robust_list = 99,
+ aarch64_sys_get_robust_list = 100,
+ aarch64_sys_nanosleep = 101,
+ aarch64_sys_getitimer = 102,
+ aarch64_sys_setitimer = 103,
+ aarch64_sys_kexec_load = 104,
+ aarch64_sys_init_module = 105,
+ aarch64_sys_delete_module = 106,
+ aarch64_sys_timer_create = 107,
+ aarch64_sys_timer_gettime = 108,
+ aarch64_sys_timer_getoverrun = 109,
+ aarch64_sys_timer_settime = 110,
+ aarch64_sys_timer_delete = 111,
+ aarch64_sys_clock_settime = 112,
+ aarch64_sys_clock_gettime = 113,
+ aarch64_sys_clock_getres = 114,
+ aarch64_sys_clock_nanosleep = 115,
+ aarch64_sys_syslog = 116,
+ aarch64_sys_ptrace = 117,
+ aarch64_sys_sched_setparam = 118,
+ aarch64_sys_sched_setscheduler = 119,
+ aarch64_sys_sched_getscheduler = 120,
+ aarch64_sys_sched_getparam = 121,
+ aarch64_sys_sched_setaffinity = 122,
+ aarch64_sys_sched_getaffinity = 123,
+ aarch64_sys_sched_yield = 124,
+ aarch64_sys_sched_get_priority_max = 125,
+ aarch64_sys_sched_get_priority_min = 126,
+ aarch64_sys_sched_rr_get_interval = 127,
+ aarch64_sys_kill = 129,
+ aarch64_sys_tkill = 130,
+ aarch64_sys_tgkill = 131,
+ aarch64_sys_sigaltstack = 132,
+ aarch64_sys_rt_sigsuspend = 133,
+ aarch64_sys_rt_sigaction = 134,
+ aarch64_sys_rt_sigprocmask = 135,
+ aarch64_sys_rt_sigpending = 136,
+ aarch64_sys_rt_sigtimedwait = 137,
+ aarch64_sys_rt_sigqueueinfo = 138,
+ aarch64_sys_rt_sigreturn = 139,
+ aarch64_sys_setpriority = 140,
+ aarch64_sys_getpriority = 141,
+ aarch64_sys_reboot = 142,
+ aarch64_sys_setregid = 143,
+ aarch64_sys_setgid = 144,
+ aarch64_sys_setreuid = 145,
+ aarch64_sys_setuid = 146,
+ aarch64_sys_setresuid = 147,
+ aarch64_sys_getresuid = 148,
+ aarch64_sys_setresgid = 149,
+ aarch64_sys_getresgid = 150,
+ aarch64_sys_setfsuid = 151,
+ aarch64_sys_setfsgid = 152,
+ aarch64_sys_times = 153,
+ aarch64_sys_setpgid = 154,
+ aarch64_sys_getpgid = 155,
+ aarch64_sys_getsid = 156,
+ aarch64_sys_setsid = 157,
+ aarch64_sys_getgroups = 158,
+ aarch64_sys_setgroups = 159,
+ aarch64_sys_uname = 160,
+ aarch64_sys_sethostname = 161,
+ aarch64_sys_setdomainname = 162,
+ aarch64_sys_getrlimit = 163,
+ aarch64_sys_setrlimit = 164,
+ aarch64_sys_getrusage = 165,
+ aarch64_sys_umask = 166,
+ aarch64_sys_prctl = 167,
+ aarch64_sys_getcpu = 168,
+ aarch64_sys_gettimeofday = 169,
+ aarch64_sys_settimeofday = 170,
+ aarch64_sys_adjtimex = 171,
+ aarch64_sys_getpid = 172,
+ aarch64_sys_getppid = 173,
+ aarch64_sys_getuid = 174,
+ aarch64_sys_geteuid = 175,
+ aarch64_sys_getgid = 176,
+ aarch64_sys_getegid = 177,
+ aarch64_sys_gettid = 178,
+ aarch64_sys_sysinfo = 179,
+ aarch64_sys_mq_open = 180,
+ aarch64_sys_mq_unlink = 181,
+ aarch64_sys_mq_timedsend = 182,
+ aarch64_sys_mq_timedreceive = 183,
+ aarch64_sys_mq_notify = 184,
+ aarch64_sys_mq_getsetattr = 185,
+ aarch64_sys_msgget = 186,
+ aarch64_sys_msgctl = 187,
+ aarch64_sys_msgrcv = 188,
+ aarch64_sys_msgsnd = 189,
+ aarch64_sys_semget = 190,
+ aarch64_sys_semctl = 191,
+ aarch64_sys_semtimedop = 192,
+ aarch64_sys_semop = 193,
+ aarch64_sys_shmget = 194,
+ aarch64_sys_shmctl = 195,
+ aarch64_sys_shmat = 196,
+ aarch64_sys_shmdt = 197,
+ aarch64_sys_socket = 198,
+ aarch64_sys_socketpair = 199,
+ aarch64_sys_bind = 200,
+ aarch64_sys_listen = 201,
+ aarch64_sys_accept = 202,
+ aarch64_sys_connect = 203,
+ aarch64_sys_getsockname = 204,
+ aarch64_sys_getpeername = 205,
+ aarch64_sys_sendto = 206,
+ aarch64_sys_recvfrom = 207,
+ aarch64_sys_setsockopt = 208,
+ aarch64_sys_getsockopt = 209,
+ aarch64_sys_shutdown = 210,
+ aarch64_sys_sendmsg = 211,
+ aarch64_sys_recvmsg = 212,
+ aarch64_sys_readahead = 213,
+ aarch64_sys_brk = 214,
+ aarch64_sys_munmap = 215,
+ aarch64_sys_mremap = 216,
+ aarch64_sys_add_key = 217,
+ aarch64_sys_request_key = 218,
+ aarch64_sys_keyctl = 219,
+ aarch64_sys_clone = 220,
+ aarch64_sys_execve = 221,
+ aarch64_sys_mmap = 222,
+ aarch64_sys_fadvise64 = 223,
+ aarch64_sys_swapon = 224,
+ aarch64_sys_swapoff = 225,
+ aarch64_sys_mprotect = 226,
+ aarch64_sys_msync = 227,
+ aarch64_sys_mlock = 228,
+ aarch64_sys_munlock = 229,
+ aarch64_sys_mlockall = 230,
+ aarch64_sys_munlockall = 231,
+ aarch64_sys_mincore = 232,
+ aarch64_sys_madvise = 233,
+ aarch64_sys_remap_file_pages = 234,
+ aarch64_sys_mbind = 235,
+ aarch64_sys_get_mempolicy = 236,
+ aarch64_sys_set_mempolicy = 237,
+ aarch64_sys_migrate_pages = 238,
+ aarch64_sys_move_pages = 239,
+ aarch64_sys_rt_tgsigqueueinfo = 240,
+ aarch64_sys_perf_event_open = 241,
+ aarch64_sys_accept4 = 242,
+ aarch64_sys_recvmmsg = 243,
+ aarch64_sys_wait4 = 260,
+ aarch64_sys_prlimit64 = 261,
+ aarch64_sys_fanotify_init = 262,
+ aarch64_sys_fanotify_mark = 263,
+ aarch64_sys_name_to_handle_at = 264,
+ aarch64_sys_open_by_handle_at = 265,
+ aarch64_sys_clock_adjtime = 266,
+ aarch64_sys_syncfs = 267,
+ aarch64_sys_setns = 268,
+ aarch64_sys_sendmmsg = 269,
+ aarch64_sys_process_vm_readv = 270,
+ aarch64_sys_process_vm_writev = 271,
+ aarch64_sys_kcmp = 272,
+ aarch64_sys_finit_module = 273,
+ aarch64_sys_sched_setattr = 274,
+ aarch64_sys_sched_getattr = 275,
+};
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index bb533b2..2e2dc15 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -2943,7 +2943,20 @@ aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
{
/* Exception generation instructions. */
if (insn_bits24_27 == 0x04)
- return AARCH64_RECORD_USUPPORTED;
+ {
+ if (!bits (aarch64_insn_r->aarch64_insn, 2, 4) &&
+ !bits (aarch64_insn_r->aarch64_insn, 21, 23) &&
+ bits (aarch64_insn_r->aarch64_insn, 0, 1) == 0x01)
+ {
+ ULONGEST svc_number;
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, 8,
+ &svc_number);
+ return tdep->aarch64_syscall_record (aarch64_insn_r->regcache,
+ svc_number);
+ }
+ else
+ return AARCH64_RECORD_USUPPORTED;
+ }
/* System instructions. */
else if (insn_bits24_27 == 0x05 && insn_bits22_23 == 0x00)
{
diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
index 8a193f4..21c3bd3 100644
--- a/gdb/aarch64-tdep.h
+++ b/gdb/aarch64-tdep.h
@@ -88,6 +88,9 @@ struct gdbarch_tdep
struct type *vns_type;
struct type *vnh_type;
struct type *vnb_type;
+
+ /* syscall record. */
+ int (*aarch64_syscall_record) (struct regcache *regcache, unsigned long svc_number);
};
/* aarch64 process record-replay related structures, defines etc. */
--
1.9.1
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 5/7] Support for recording syscall on aarch64-linux
2014-06-04 16:21 ` [PATCH 5/7] Support for recording syscall on aarch64-linux Omair Javaid
@ 2014-06-05 8:52 ` Will Newton
2014-06-06 15:58 ` Andreas Arnez
1 sibling, 0 replies; 53+ messages in thread
From: Will Newton @ 2014-06-05 8:52 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
On 4 June 2014 17:21, Omair Javaid <omair.javaid@linaro.org> wrote:
> This patch adds support for recording system call instruction on aarch64-linux
> targets.
>
> gdb:
>
> 2014-06-04 Omair Javaid <omair.javaid@linaro.org>
>
> * aarch64-linux-tdep.c (record.h): Include.
> (record-full.h): Include.
> (struct linux_record_tdep aarch64_linux_record_tdep): Declared.
> (aarch64_canonicalize_syscall): New function.
> (aarch64_all_but_pc_registers_record): New function.
> (aarch64_linux_syscall_record): New function.
> (aarch64_linux_init_abi): Updated.
> * aarch64-linux-tdep.h (aarch64_syscall): New enum.
> * aarch64-tdep.c (aarch64_record_branch_except_sys): Updated.
> * aarch64-tdep.h
> (struct gdbarch_tdep) <aarch64_syscall_record>: Defined.
>
> ---
> gdb/aarch64-linux-tdep.c | 924 +++++++++++++++++++++++++++++++++++++++++++++++
> gdb/aarch64-linux-tdep.h | 266 ++++++++++++++
> gdb/aarch64-tdep.c | 15 +-
> gdb/aarch64-tdep.h | 3 +
> 4 files changed, 1207 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
> index dece0c3..6d9a3bf 100644
> --- a/gdb/aarch64-linux-tdep.c
> +++ b/gdb/aarch64-linux-tdep.c
> @@ -41,6 +41,9 @@
> #include "user-regs.h"
> #include <ctype.h>
>
> +#include "record-full.h"
> +#include "linux-record.h"
> +
> /* The general-purpose regset consists of 31 X registers, plus SP, PC,
> and PSTATE registers, as defined in the AArch64 port of the Linux
> kernel. */
> @@ -421,6 +424,769 @@ aarch64_stap_parse_special_token (struct gdbarch *gdbarch,
> return 1;
> }
>
> +/* Aarch64 process record-replay constructs: syscall, signal etc. */
To be precise it is "AArch64".
> +
> +struct linux_record_tdep aarch64_linux_record_tdep;
> +
> +/* aarch64_canonicalize_syscall maps syscall ids from the native aarch64
> + linux set of syscall ids into a canonical set of syscall ids used by
> + process record. */
> +
> +static enum gdb_syscall
> +aarch64_canonicalize_syscall (enum aarch64_syscall syscall_number)
> +{
> + switch (syscall_number) {
> + case aarch64_sys_read:
> + return gdb_sys_read;
> +
> + case aarch64_sys_write:
> + return gdb_sys_write;
> +
> + case aarch64_sys_open:
> + return gdb_sys_open;
> +
> + case aarch64_sys_close:
> + return gdb_sys_close;
> +
> + case aarch64_sys_lseek:
> + return gdb_sys_lseek;
> +
> + case aarch64_sys_mmap:
> + return gdb_sys_mmap2;
> +
> + case aarch64_sys_mprotect:
> + return gdb_sys_mprotect;
> +
> + case aarch64_sys_munmap:
> + return gdb_sys_munmap;
> +
> + case aarch64_sys_brk:
> + return gdb_sys_brk;
> +
> + case aarch64_sys_rt_sigaction:
> + return gdb_sys_rt_sigaction;
> +
> + case aarch64_sys_rt_sigprocmask:
> + return gdb_sys_rt_sigprocmask;
> +
> + case aarch64_sys_rt_sigreturn:
> + return gdb_sys_rt_sigreturn;
> +
> + case aarch64_sys_ioctl:
> + return gdb_sys_ioctl;
> +
> + case aarch64_sys_pread64:
> + return gdb_sys_pread64;
> +
> + case aarch64_sys_pwrite64:
> + return gdb_sys_pwrite64;
> +
> + case aarch64_sys_readv:
> + return gdb_sys_readv;
> +
> + case aarch64_sys_writev:
> + return gdb_sys_writev;
> +
> + case aarch64_sys_sched_yield:
> + return gdb_sys_sched_yield;
> +
> + case aarch64_sys_mremap:
> + return gdb_sys_mremap;
> +
> + case aarch64_sys_msync:
> + return gdb_sys_msync;
> +
> + case aarch64_sys_mincore:
> + return gdb_sys_mincore;
> +
> + case aarch64_sys_madvise:
> + return gdb_sys_madvise;
> +
> + case aarch64_sys_shmget:
> + return gdb_sys_shmget;
> +
> + case aarch64_sys_shmat:
> + return gdb_sys_shmat;
> +
> + case aarch64_sys_shmctl:
> + return gdb_sys_shmctl;
> +
> + case aarch64_sys_dup:
> + return gdb_sys_dup;
> +
> + case aarch64_sys_dup3:
> + return gdb_sys_dup2;
> +
> + case aarch64_sys_nanosleep:
> + return gdb_sys_nanosleep;
> +
> + case aarch64_sys_getitimer:
> + return gdb_sys_getitimer;
> +
> + case aarch64_sys_setitimer:
> + return gdb_sys_setitimer;
> +
> + case aarch64_sys_getpid:
> + return gdb_sys_getpid;
> +
> + case aarch64_sys_sendfile:
> + return gdb_sys_sendfile64;
> +
> + case aarch64_sys_socket:
> + return gdb_sys_socket;
> +
> + case aarch64_sys_connect:
> + return gdb_sys_connect;
> +
> + case aarch64_sys_accept:
> + return gdb_sys_accept;
> +
> + case aarch64_sys_sendto:
> + return gdb_sys_sendto;
> +
> + case aarch64_sys_recvfrom:
> + return gdb_sys_recvfrom;
> +
> + case aarch64_sys_sendmsg:
> + return gdb_sys_sendmsg;
> +
> + case aarch64_sys_recvmsg:
> + return gdb_sys_recvmsg;
> +
> + case aarch64_sys_shutdown:
> + return gdb_sys_shutdown;
> +
> + case aarch64_sys_bind:
> + return gdb_sys_bind;
> +
> + case aarch64_sys_listen:
> + return gdb_sys_listen;
> +
> + case aarch64_sys_getsockname:
> + return gdb_sys_getsockname;
> +
> + case aarch64_sys_getpeername:
> + return gdb_sys_getpeername;
> +
> + case aarch64_sys_socketpair:
> + return gdb_sys_socketpair;
> +
> + case aarch64_sys_setsockopt:
> + return gdb_sys_setsockopt;
> +
> + case aarch64_sys_getsockopt:
> + return gdb_sys_getsockopt;
> +
> + case aarch64_sys_clone:
> + return gdb_sys_clone;
> +
> + case aarch64_sys_execve:
> + return gdb_sys_execve;
> +
> + case aarch64_sys_exit:
> + return gdb_sys_exit;
> +
> + case aarch64_sys_wait4:
> + return gdb_sys_wait4;
> +
> + case aarch64_sys_kill:
> + return gdb_sys_kill;
> +
> + case aarch64_sys_uname:
> + return gdb_sys_uname;
> +
> + case aarch64_sys_semget:
> + return gdb_sys_semget;
> +
> + case aarch64_sys_semop:
> + return gdb_sys_semop;
> +
> + case aarch64_sys_semctl:
> + return gdb_sys_semctl;
> +
> + case aarch64_sys_shmdt:
> + return gdb_sys_shmdt;
> +
> + case aarch64_sys_msgget:
> + return gdb_sys_msgget;
> +
> + case aarch64_sys_msgsnd:
> + return gdb_sys_msgsnd;
> +
> + case aarch64_sys_msgrcv:
> + return gdb_sys_msgrcv;
> +
> + case aarch64_sys_msgctl:
> + return gdb_sys_msgctl;
> +
> + case aarch64_sys_fcntl:
> + return gdb_sys_fcntl;
> +
> + case aarch64_sys_flock:
> + return gdb_sys_flock;
> +
> + case aarch64_sys_fsync:
> + return gdb_sys_fsync;
> +
> + case aarch64_sys_fdatasync:
> + return gdb_sys_fdatasync;
> +
> + case aarch64_sys_truncate:
> + return gdb_sys_truncate;
> +
> + case aarch64_sys_ftruncate:
> + return gdb_sys_ftruncate;
> +
> + case aarch64_sys_getcwd:
> + return gdb_sys_getcwd;
> +
> + case aarch64_sys_chdir:
> + return gdb_sys_chdir;
> +
> + case aarch64_sys_fchdir:
> + return gdb_sys_fchdir;
> +
> + case aarch64_sys_rename:
> + return gdb_sys_rename;
> +
> + case aarch64_sys_mkdir:
> + return gdb_sys_mkdir;
> +
> + case aarch64_sys_link:
> + return gdb_sys_link;
> +
> + case aarch64_sys_unlink:
> + return gdb_sys_unlink;
> +
> + case aarch64_sys_symlink:
> + return gdb_sys_symlink;
> +
> + case aarch64_sys_readlink:
> + return gdb_sys_readlink;
> +
> + case aarch64_sys_fchmodat:
> + return gdb_sys_chmod;
> +
> + case aarch64_sys_fchmod:
> + return gdb_sys_fchmod;
> +
> + case aarch64_sys_fchownat:
> + return gdb_sys_chown;
> +
> + case aarch64_sys_fchown:
> + return gdb_sys_fchown;
> +
> + case aarch64_sys_umask:
> + return gdb_sys_umask;
> +
> + case aarch64_sys_gettimeofday:
> + return gdb_sys_gettimeofday;
> +
> + case aarch64_sys_getrlimit:
> + return gdb_sys_getrlimit;
> +
> + case aarch64_sys_getrusage:
> + return gdb_sys_getrusage;
> +
> + case aarch64_sys_sysinfo:
> + return gdb_sys_sysinfo;
> +
> + case aarch64_sys_ptrace:
> + return gdb_sys_ptrace;
> +
> + case aarch64_sys_getuid:
> + return gdb_sys_getuid;
> +
> + case aarch64_sys_syslog:
> + return gdb_sys_syslog;
> +
> + case aarch64_sys_getgid:
> + return gdb_sys_getgid;
> +
> + case aarch64_sys_setuid:
> + return gdb_sys_setuid;
> +
> + case aarch64_sys_setgid:
> + return gdb_sys_setgid;
> +
> + case aarch64_sys_geteuid:
> + return gdb_sys_geteuid;
> +
> + case aarch64_sys_getegid:
> + return gdb_sys_getegid;
> +
> + case aarch64_sys_setpgid:
> + return gdb_sys_setpgid;
> +
> + case aarch64_sys_getppid:
> + return gdb_sys_getppid;
> +
> + case aarch64_sys_setsid:
> + return gdb_sys_setsid;
> +
> + case aarch64_sys_setreuid:
> + return gdb_sys_setreuid;
> +
> + case aarch64_sys_setregid:
> + return gdb_sys_setregid;
> +
> + case aarch64_sys_getgroups:
> + return gdb_sys_getgroups;
> +
> + case aarch64_sys_setgroups:
> + return gdb_sys_setgroups;
> +
> + case aarch64_sys_setresuid:
> + return gdb_sys_setresuid;
> +
> + case aarch64_sys_getresuid:
> + return gdb_sys_getresuid;
> +
> + case aarch64_sys_setresgid:
> + return gdb_sys_setresgid;
> +
> + case aarch64_sys_getresgid:
> + return gdb_sys_getresgid;
> +
> + case aarch64_sys_getpgid:
> + return gdb_sys_getpgid;
> +
> + case aarch64_sys_setfsuid:
> + return gdb_sys_setfsuid;
> +
> + case aarch64_sys_setfsgid:
> + return gdb_sys_setfsgid;
> +
> + case aarch64_sys_getsid:
> + return gdb_sys_getsid;
> +
> + case aarch64_sys_capget:
> + return gdb_sys_capget;
> +
> + case aarch64_sys_capset:
> + return gdb_sys_capset;
> +
> + case aarch64_sys_rt_sigpending:
> + return gdb_sys_rt_sigpending;
> +
> + case aarch64_sys_rt_sigtimedwait:
> + return gdb_sys_rt_sigtimedwait;
> +
> + case aarch64_sys_rt_sigqueueinfo:
> + return gdb_sys_rt_sigqueueinfo;
> +
> + case aarch64_sys_rt_sigsuspend:
> + return gdb_sys_rt_sigsuspend;
> +
> + case aarch64_sys_sigaltstack:
> + return gdb_sys_sigaltstack;
> +
> + case aarch64_sys_mknod:
> + return gdb_sys_mknod;
> +
> + case aarch64_sys_personality:
> + return gdb_sys_personality;
> +
> + case aarch64_sys_statfs:
> + return gdb_sys_statfs;
> +
> + case aarch64_sys_fstat:
> + return gdb_sys_fstat;
> +
> + case aarch64_sys_fstatfs:
> + return gdb_sys_fstatfs;
> +
> + case aarch64_sys_getpriority:
> + return gdb_sys_getpriority;
> +
> + case aarch64_sys_setpriority:
> + return gdb_sys_setpriority;
> +
> + case aarch64_sys_sched_setparam:
> + return gdb_sys_sched_setparam;
> +
> + case aarch64_sys_sched_getparam:
> + return gdb_sys_sched_getparam;
> +
> + case aarch64_sys_sched_setscheduler:
> + return gdb_sys_sched_setscheduler;
> +
> + case aarch64_sys_sched_getscheduler:
> + return gdb_sys_sched_getscheduler;
> +
> + case aarch64_sys_sched_get_priority_max:
> + return gdb_sys_sched_get_priority_max;
> +
> + case aarch64_sys_sched_get_priority_min:
> + return gdb_sys_sched_get_priority_min;
> +
> + case aarch64_sys_sched_rr_get_interval:
> + return gdb_sys_sched_rr_get_interval;
> +
> + case aarch64_sys_mlock:
> + return gdb_sys_mlock;
> +
> + case aarch64_sys_munlock:
> + return gdb_sys_munlock;
> +
> + case aarch64_sys_mlockall:
> + return gdb_sys_mlockall;
> +
> + case aarch64_sys_munlockall:
> + return gdb_sys_munlockall;
> +
> + case aarch64_sys_vhangup:
> + return gdb_sys_vhangup;
> +
> + case aarch64_sys_prctl:
> + return gdb_sys_prctl;
> +
> + case aarch64_sys_adjtimex:
> + return gdb_sys_adjtimex;
> +
> + case aarch64_sys_setrlimit:
> + return gdb_sys_setrlimit;
> +
> + case aarch64_sys_chroot:
> + return gdb_sys_chroot;
> +
> + case aarch64_sys_sync:
> + return gdb_sys_sync;
> +
> + case aarch64_sys_acct:
> + return gdb_sys_acct;
> +
> + case aarch64_sys_settimeofday:
> + return gdb_sys_settimeofday;
> +
> + case aarch64_sys_mount:
> + return gdb_sys_mount;
> +
> + case aarch64_sys_umount2:
> + return gdb_sys_umount;
> +
> + case aarch64_sys_swapon:
> + return gdb_sys_swapon;
> +
> + case aarch64_sys_swapoff:
> + return gdb_sys_swapoff;
> +
> + case aarch64_sys_reboot:
> + return gdb_sys_reboot;
> +
> + case aarch64_sys_sethostname:
> + return gdb_sys_sethostname;
> +
> + case aarch64_sys_setdomainname:
> + return gdb_sys_setdomainname;
> +
> + case aarch64_sys_init_module:
> + return gdb_sys_init_module;
> +
> + case aarch64_sys_delete_module:
> + return gdb_sys_delete_module;
> +
> + case aarch64_sys_quotactl:
> + return gdb_sys_quotactl;
> +
> + case aarch64_sys_nfsservctl:
> + return gdb_sys_nfsservctl;
> +
> + case aarch64_sys_gettid:
> + return gdb_sys_gettid;
> +
> + case aarch64_sys_readahead:
> + return gdb_sys_readahead;
> +
> + case aarch64_sys_setxattr:
> + return gdb_sys_setxattr;
> +
> + case aarch64_sys_lsetxattr:
> + return gdb_sys_lsetxattr;
> +
> + case aarch64_sys_fsetxattr:
> + return gdb_sys_fsetxattr;
> +
> + case aarch64_sys_getxattr:
> + return gdb_sys_getxattr;
> +
> + case aarch64_sys_lgetxattr:
> + return gdb_sys_lgetxattr;
> +
> + case aarch64_sys_fgetxattr:
> + return gdb_sys_fgetxattr;
> +
> + case aarch64_sys_listxattr:
> + return gdb_sys_listxattr;
> +
> + case aarch64_sys_llistxattr:
> + return gdb_sys_llistxattr;
> +
> + case aarch64_sys_flistxattr:
> + return gdb_sys_flistxattr;
> +
> + case aarch64_sys_removexattr:
> + return gdb_sys_removexattr;
> +
> + case aarch64_sys_lremovexattr:
> + return gdb_sys_lremovexattr;
> +
> + case aarch64_sys_fremovexattr:
> + return gdb_sys_fremovexattr;
> +
> + case aarch64_sys_tkill:
> + return gdb_sys_tkill;
> +
> + case aarch64_sys_times:
> + return gdb_sys_time;
Should this be gdb_sys_times?
> +
> + case aarch64_sys_futex:
> + return gdb_sys_futex;
> +
> + case aarch64_sys_sched_setaffinity:
> + return gdb_sys_sched_setaffinity;
> +
> + case aarch64_sys_sched_getaffinity:
> + return gdb_sys_sched_getaffinity;
> +
> + case aarch64_sys_io_setup:
> + return gdb_sys_io_setup;
> +
> + case aarch64_sys_io_destroy:
> + return gdb_sys_io_destroy;
> +
> + case aarch64_sys_io_getevents:
> + return gdb_sys_io_getevents;
> +
> + case aarch64_sys_io_submit:
> + return gdb_sys_io_submit;
> +
> + case aarch64_sys_io_cancel:
> + return gdb_sys_io_cancel;
> +
> + case aarch64_sys_lookup_dcookie:
> + return gdb_sys_lookup_dcookie;
> +
> + case aarch64_sys_epoll_create1:
> + return gdb_sys_epoll_create;
> +
> + case aarch64_sys_remap_file_pages:
> + return gdb_sys_remap_file_pages;
> +
> + case aarch64_sys_getdents64:
> + return gdb_sys_getdents64;
> +
> + case aarch64_sys_set_tid_address:
> + return gdb_sys_set_tid_address;
> +
> + case aarch64_sys_semtimedop:
> + return gdb_sys_semtimedop;
> +
> + case aarch64_sys_fadvise64:
> + return gdb_sys_fadvise64;
> +
> + case aarch64_sys_timer_create:
> + return gdb_sys_timer_create;
> +
> + case aarch64_sys_timer_settime:
> + return gdb_sys_timer_settime;
> +
> + case aarch64_sys_timer_gettime:
> + return gdb_sys_timer_gettime;
> +
> + case aarch64_sys_timer_getoverrun:
> + return gdb_sys_timer_getoverrun;
> +
> + case aarch64_sys_timer_delete:
> + return gdb_sys_timer_delete;
> +
> + case aarch64_sys_clock_settime:
> + return gdb_sys_clock_settime;
> +
> + case aarch64_sys_clock_gettime:
> + return gdb_sys_clock_gettime;
> +
> + case aarch64_sys_clock_getres:
> + return gdb_sys_clock_getres;
> +
> + case aarch64_sys_clock_nanosleep:
> + return gdb_sys_clock_nanosleep;
> +
> + case aarch64_sys_exit_group:
> + return gdb_sys_exit_group;
> +
> + case aarch64_sys_epoll_pwait:
> + return gdb_sys_epoll_wait;
> +
> + case aarch64_sys_epoll_ctl:
> + return gdb_sys_epoll_ctl;
> +
> + case aarch64_sys_tgkill:
> + return gdb_sys_tgkill;
> +
> + case aarch64_sys_utimensat:
> + return gdb_sys_utimes;
> +
> + case aarch64_sys_mbind:
> + return gdb_sys_mbind;
> +
> + case aarch64_sys_set_mempolicy:
> + return gdb_sys_set_mempolicy;
> +
> + case aarch64_sys_get_mempolicy:
> + return gdb_sys_get_mempolicy;
> +
> + case aarch64_sys_mq_open:
> + return gdb_sys_mq_open;
> +
> + case aarch64_sys_mq_unlink:
> + return gdb_sys_mq_unlink;
> +
> + case aarch64_sys_mq_timedsend:
> + return gdb_sys_mq_timedsend;
> +
> + case aarch64_sys_mq_timedreceive:
> + return gdb_sys_mq_timedreceive;
> +
> + case aarch64_sys_mq_notify:
> + return gdb_sys_mq_notify;
> +
> + case aarch64_sys_mq_getsetattr:
> + return gdb_sys_mq_getsetattr;
> +
> + case aarch64_sys_kexec_load:
> + return gdb_sys_kexec_load;
> +
> + case aarch64_sys_waitid:
> + return gdb_sys_waitid;
> +
> + case aarch64_sys_add_key:
> + return gdb_sys_add_key;
> +
> + case aarch64_sys_request_key:
> + return gdb_sys_request_key;
> +
> + case aarch64_sys_keyctl:
> + return gdb_sys_keyctl;
> +
> + case aarch64_sys_ioprio_set:
> + return gdb_sys_ioprio_set;
> +
> + case aarch64_sys_ioprio_get:
> + return gdb_sys_ioprio_get;
> +
> + case aarch64_sys_fanotify_init:
> + return gdb_sys_inotify_init;
> +
> + case aarch64_sys_inotify_add_watch:
> + return gdb_sys_inotify_add_watch;
> +
> + case aarch64_sys_inotify_rm_watch:
> + return gdb_sys_inotify_rm_watch;
> +
> + case aarch64_sys_migrate_pages:
> + return gdb_sys_migrate_pages;
> +
> + case aarch64_sys_pselect6:
> + return gdb_sys_pselect6;
> +
> + case aarch64_sys_ppoll:
> + return gdb_sys_ppoll;
> +
> + case aarch64_sys_unshare:
> + return gdb_sys_unshare;
> +
> + case aarch64_sys_set_robust_list:
> + return gdb_sys_set_robust_list;
> +
> + case aarch64_sys_get_robust_list:
> + return gdb_sys_get_robust_list;
> +
> + case aarch64_sys_splice:
> + return gdb_sys_splice;
> +
> + case aarch64_sys_tee:
> + return gdb_sys_tee;
> +
> + case aarch64_sys_sync_file_range:
> + return gdb_sys_sync_file_range;
> +
> + case aarch64_sys_vmsplice:
> + return gdb_sys_vmsplice;
> +
> + case aarch64_sys_move_pages:
> + return gdb_sys_move_pages;
> +
> + default:
> + return -1;
> + }
> +}
> +
> +/* Record all registers but PC register for process-record. */
> +
> +static int
> +aarch64_all_but_pc_registers_record (struct regcache *regcache)
> +{
> + int i;
> +
> + for (i = 0; i < AARCH64_PC_REGNUM; i++)
> + {
> + if (record_full_arch_list_add_reg (regcache, AARCH64_X0_REGNUM + i))
> + return -1;
> + }
> +
> + if (record_full_arch_list_add_reg (regcache, AARCH64_CPSR_REGNUM))
> + return -1;
> +
> + return 0;
> +}
> +
> +/* Handler for arm system call instruction recording. */
Comment needs updating.
> +
> +static int
> +aarch64_linux_syscall_record (struct regcache *regcache, unsigned long svc_number)
> +{
> + int ret = 0;
> + enum gdb_syscall syscall_gdb;
> +
> + printf_unfiltered (_("syscall number %s\n"),
> + plongest (svc_number));
> + syscall_gdb = aarch64_canonicalize_syscall (svc_number);
> +
> + if (syscall_gdb < 0)
> + {
> + printf_unfiltered (_("Process record and replay target doesn't "
> + "support syscall number %s\n"),
> + plongest (svc_number));
> + return -1;
> + }
> +
> + if (syscall_gdb == gdb_sys_sigreturn
> + || syscall_gdb == gdb_sys_rt_sigreturn)
> + {
> + if (aarch64_all_but_pc_registers_record (regcache))
> + return -1;
> + return 0;
> + }
> +
> + ret = record_linux_system_call (syscall_gdb, regcache,
> + &aarch64_linux_record_tdep);
> + if (ret != 0)
> + return ret;
> +
> + /* Record the return value of the system call. */
> + if (record_full_arch_list_add_reg (regcache, AARCH64_X0_REGNUM))
> + return -1;
> + /* Record LR. */
> + if (record_full_arch_list_add_reg (regcache, AARCH64_LR_REGNUM))
> + return -1;
> + /* Record CPSR. */
> + if (record_full_arch_list_add_reg (regcache, AARCH64_CPSR_REGNUM))
> + return -1;
> +
> + return 0;
> +}
> +
> static void
> aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
> {
> @@ -471,6 +1237,164 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>
> /* Reversible debugging, process record. */
> set_gdbarch_process_record (gdbarch, aarch64_process_record);
> + /* Syscall record. */
> + tdep->aarch64_syscall_record = aarch64_linux_syscall_record;
> +
> + /* Initialize the aarch64_linux_record_tdep. */
> + /* These values are the size of the type that will be used in a system
> + call. They are obtained from Linux Kernel source. */
> + aarch64_linux_record_tdep.size_pointer
> + = gdbarch_ptr_bit (gdbarch) / TARGET_CHAR_BIT;
> + aarch64_linux_record_tdep.size__old_kernel_stat = 32;
> + aarch64_linux_record_tdep.size_tms = 32;
> + aarch64_linux_record_tdep.size_loff_t = 8;
> + aarch64_linux_record_tdep.size_flock = 32;
> + aarch64_linux_record_tdep.size_oldold_utsname = 45;
> + aarch64_linux_record_tdep.size_ustat = 32;
> + aarch64_linux_record_tdep.size_old_sigaction = 152;
> + aarch64_linux_record_tdep.size_old_sigset_t = 128;
> + aarch64_linux_record_tdep.size_rlimit = 16;
> + aarch64_linux_record_tdep.size_rusage = 144;
> + aarch64_linux_record_tdep.size_timeval = 16;
> + aarch64_linux_record_tdep.size_timezone = 8;
> + aarch64_linux_record_tdep.size_old_gid_t = 2;
> + aarch64_linux_record_tdep.size_old_uid_t = 2;
> + aarch64_linux_record_tdep.size_fd_set = 128;
> + aarch64_linux_record_tdep.size_dirent = 280;
> + aarch64_linux_record_tdep.size_dirent64 = 280;
> + aarch64_linux_record_tdep.size_statfs = 120;
> + aarch64_linux_record_tdep.size_statfs64 = 120;
> + aarch64_linux_record_tdep.size_sockaddr = 16;
> + aarch64_linux_record_tdep.size_int
> + = gdbarch_int_bit (gdbarch) / TARGET_CHAR_BIT;
> + aarch64_linux_record_tdep.size_long
> + = gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
> + aarch64_linux_record_tdep.size_ulong
> + = gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
> + aarch64_linux_record_tdep.size_msghdr = 56;
> + aarch64_linux_record_tdep.size_itimerval = 32;
> + aarch64_linux_record_tdep.size_stat = 144;
> + aarch64_linux_record_tdep.size_old_utsname = 325;
> + aarch64_linux_record_tdep.size_sysinfo = 112;
> + aarch64_linux_record_tdep.size_msqid_ds = 120;
> + aarch64_linux_record_tdep.size_shmid_ds = 112;
> + aarch64_linux_record_tdep.size_new_utsname = 390;
> + aarch64_linux_record_tdep.size_timex = 208;
> + aarch64_linux_record_tdep.size_mem_dqinfo = 24;
> + aarch64_linux_record_tdep.size_if_dqblk = 72;
> + aarch64_linux_record_tdep.size_fs_quota_stat = 80;
> + aarch64_linux_record_tdep.size_timespec = 16;
> + aarch64_linux_record_tdep.size_pollfd = 8;
> + aarch64_linux_record_tdep.size_NFS_FHSIZE = 32;
> + aarch64_linux_record_tdep.size_knfsd_fh = 132;
> + aarch64_linux_record_tdep.size_TASK_COMM_LEN = 16;
> + aarch64_linux_record_tdep.size_sigaction = 152;
> + aarch64_linux_record_tdep.size_sigset_t = 128;
> + aarch64_linux_record_tdep.size_siginfo_t = 128;
> + aarch64_linux_record_tdep.size_cap_user_data_t = 8;
> + aarch64_linux_record_tdep.size_stack_t = 24;
> + aarch64_linux_record_tdep.size_off_t = 8;
> + aarch64_linux_record_tdep.size_stat64 = 144;
> + aarch64_linux_record_tdep.size_gid_t = 4;
> + aarch64_linux_record_tdep.size_uid_t = 4;
> + aarch64_linux_record_tdep.size_PAGE_SIZE = 4096;
> + aarch64_linux_record_tdep.size_flock64 = 32;
> + aarch64_linux_record_tdep.size_user_desc = 16;
> + aarch64_linux_record_tdep.size_io_event = 32;
> + aarch64_linux_record_tdep.size_iocb = 64;
> + aarch64_linux_record_tdep.size_epoll_event = 12;
> + aarch64_linux_record_tdep.size_itimerspec = 32;
> + aarch64_linux_record_tdep.size_mq_attr = 64;
> + aarch64_linux_record_tdep.size_siginfo = 128;
> + aarch64_linux_record_tdep.size_termios = 60;
> + aarch64_linux_record_tdep.size_termios2 = 44;
> + aarch64_linux_record_tdep.size_pid_t = 4;
> + aarch64_linux_record_tdep.size_winsize = 8;
> + aarch64_linux_record_tdep.size_serial_struct = 72;
> + aarch64_linux_record_tdep.size_serial_icounter_struct = 80;
> + aarch64_linux_record_tdep.size_hayes_esp_config = 12;
> + aarch64_linux_record_tdep.size_size_t = 8;
> + aarch64_linux_record_tdep.size_iovec = 16;
> +
> + /* These values are the second argument of system call "sys_ioctl".
> + They are obtained from Linux Kernel source. */
> + aarch64_linux_record_tdep.ioctl_TCGETS = 0x5401;
> + aarch64_linux_record_tdep.ioctl_TCSETS = 0x5402;
> + aarch64_linux_record_tdep.ioctl_TCSETSW = 0x5403;
> + aarch64_linux_record_tdep.ioctl_TCSETSF = 0x5404;
> + aarch64_linux_record_tdep.ioctl_TCGETA = 0x5405;
> + aarch64_linux_record_tdep.ioctl_TCSETA = 0x5406;
> + aarch64_linux_record_tdep.ioctl_TCSETAW = 0x5407;
> + aarch64_linux_record_tdep.ioctl_TCSETAF = 0x5408;
> + aarch64_linux_record_tdep.ioctl_TCSBRK = 0x5409;
> + aarch64_linux_record_tdep.ioctl_TCXONC = 0x540a;
> + aarch64_linux_record_tdep.ioctl_TCFLSH = 0x540b;
> + aarch64_linux_record_tdep.ioctl_TIOCEXCL = 0x540c;
> + aarch64_linux_record_tdep.ioctl_TIOCNXCL = 0x540d;
> + aarch64_linux_record_tdep.ioctl_TIOCSCTTY = 0x540e;
> + aarch64_linux_record_tdep.ioctl_TIOCGPGRP = 0x540f;
> + aarch64_linux_record_tdep.ioctl_TIOCSPGRP = 0x5410;
> + aarch64_linux_record_tdep.ioctl_TIOCOUTQ = 0x5411;
> + aarch64_linux_record_tdep.ioctl_TIOCSTI = 0x5412;
> + aarch64_linux_record_tdep.ioctl_TIOCGWINSZ = 0x5413;
> + aarch64_linux_record_tdep.ioctl_TIOCSWINSZ = 0x5414;
> + aarch64_linux_record_tdep.ioctl_TIOCMGET = 0x5415;
> + aarch64_linux_record_tdep.ioctl_TIOCMBIS = 0x5416;
> + aarch64_linux_record_tdep.ioctl_TIOCMBIC = 0x5417;
> + aarch64_linux_record_tdep.ioctl_TIOCMSET = 0x5418;
> + aarch64_linux_record_tdep.ioctl_TIOCGSOFTCAR = 0x5419;
> + aarch64_linux_record_tdep.ioctl_TIOCSSOFTCAR = 0x541a;
> + aarch64_linux_record_tdep.ioctl_FIONREAD = 0x541b;
> + aarch64_linux_record_tdep.ioctl_TIOCINQ = 0x541b;
> + aarch64_linux_record_tdep.ioctl_TIOCLINUX = 0x541c;
> + aarch64_linux_record_tdep.ioctl_TIOCCONS = 0x541d;
> + aarch64_linux_record_tdep.ioctl_TIOCGSERIAL = 0x541e;
> + aarch64_linux_record_tdep.ioctl_TIOCSSERIAL = 0x541f;
> + aarch64_linux_record_tdep.ioctl_TIOCPKT = 0x5420;
> + aarch64_linux_record_tdep.ioctl_FIONBIO = 0x5421;
> + aarch64_linux_record_tdep.ioctl_TIOCNOTTY = 0x5422;
> + aarch64_linux_record_tdep.ioctl_TIOCSETD = 0x5423;
> + aarch64_linux_record_tdep.ioctl_TIOCGETD = 0x5424;
> + aarch64_linux_record_tdep.ioctl_TCSBRKP = 0x5425;
> + aarch64_linux_record_tdep.ioctl_TIOCTTYGSTRUCT = 0x5426;
> + aarch64_linux_record_tdep.ioctl_TIOCSBRK = 0x5427;
> + aarch64_linux_record_tdep.ioctl_TIOCCBRK = 0x5428;
> + aarch64_linux_record_tdep.ioctl_TIOCGSID = 0x5429;
> + aarch64_linux_record_tdep.ioctl_TCGETS2 = 0x802c542a;
> + aarch64_linux_record_tdep.ioctl_TCSETS2 = 0x402c542b;
> + aarch64_linux_record_tdep.ioctl_TCSETSW2 = 0x402c542c;
> + aarch64_linux_record_tdep.ioctl_TCSETSF2 = 0x402c542d;
> + aarch64_linux_record_tdep.ioctl_TIOCGPTN = 0x80045430;
> + aarch64_linux_record_tdep.ioctl_TIOCSPTLCK = 0x40045431;
> + aarch64_linux_record_tdep.ioctl_FIONCLEX = 0x5450;
> + aarch64_linux_record_tdep.ioctl_FIOCLEX = 0x5451;
> + aarch64_linux_record_tdep.ioctl_FIOASYNC = 0x5452;
> + aarch64_linux_record_tdep.ioctl_TIOCSERCONFIG = 0x5453;
> + aarch64_linux_record_tdep.ioctl_TIOCSERGWILD = 0x5454;
> + aarch64_linux_record_tdep.ioctl_TIOCSERSWILD = 0x5455;
> + aarch64_linux_record_tdep.ioctl_TIOCGLCKTRMIOS = 0x5456;
> + aarch64_linux_record_tdep.ioctl_TIOCSLCKTRMIOS = 0x5457;
> + aarch64_linux_record_tdep.ioctl_TIOCSERGSTRUCT = 0x5458;
> + aarch64_linux_record_tdep.ioctl_TIOCSERGETLSR = 0x5459;
> + aarch64_linux_record_tdep.ioctl_TIOCSERGETMULTI = 0x545a;
> + aarch64_linux_record_tdep.ioctl_TIOCSERSETMULTI = 0x545b;
> + aarch64_linux_record_tdep.ioctl_TIOCMIWAIT = 0x545c;
> + aarch64_linux_record_tdep.ioctl_TIOCGICOUNT = 0x545d;
> + aarch64_linux_record_tdep.ioctl_TIOCGHAYESESP = 0x545e;
> + aarch64_linux_record_tdep.ioctl_TIOCSHAYESESP = 0x545f;
> + aarch64_linux_record_tdep.ioctl_FIOQSIZE = 0x5460;
> +
> + /* These values are the second argument of system call "sys_fcntl"
> + and "sys_fcntl64". They are obtained from Linux Kernel source. */
> + aarch64_linux_record_tdep.fcntl_F_GETLK = 5;
> + aarch64_linux_record_tdep.fcntl_F_GETLK64 = 12;
> + aarch64_linux_record_tdep.fcntl_F_SETLK64 = 13;
> + aarch64_linux_record_tdep.fcntl_F_SETLKW64 = 14;
> +
> + aarch64_linux_record_tdep.arg1 = AARCH64_X0_REGNUM + 1;
> + aarch64_linux_record_tdep.arg2 = AARCH64_X0_REGNUM + 2;
> + aarch64_linux_record_tdep.arg3 = AARCH64_X0_REGNUM + 3;
> + aarch64_linux_record_tdep.arg4 = AARCH64_X0_REGNUM + 3;
Should there be arg5 and arg6 here too?
> }
>
> /* Provide a prototype to silence -Wmissing-prototypes. */
> diff --git a/gdb/aarch64-linux-tdep.h b/gdb/aarch64-linux-tdep.h
> index e3d7ed7..b199726 100644
> --- a/gdb/aarch64-linux-tdep.h
> +++ b/gdb/aarch64-linux-tdep.h
> @@ -38,3 +38,269 @@ extern void aarch64_linux_supply_fpregset (const struct regset *regset,
> extern void aarch64_linux_collect_fpregset (const struct regset *regset,
> const struct regcache *regcache,
> int regnum, void *fpregs_buf, size_t len);
> +
> +/* Enum that defines the aarch64 linux specific syscall identifiers used for
> + process record/replay. */
> +
> +enum aarch64_syscall {
> + aarch64_sys_io_setup = 0,
> + aarch64_sys_io_destroy = 1,
> + aarch64_sys_io_submit = 2,
> + aarch64_sys_io_cancel = 3,
> + aarch64_sys_io_getevents = 4,
> + aarch64_sys_setxattr = 5,
> + aarch64_sys_lsetxattr = 6,
> + aarch64_sys_fsetxattr = 7,
> + aarch64_sys_getxattr = 8,
> + aarch64_sys_lgetxattr = 9,
> + aarch64_sys_fgetxattr = 10,
> + aarch64_sys_listxattr = 11,
> + aarch64_sys_llistxattr = 12,
> + aarch64_sys_flistxattr = 13,
> + aarch64_sys_removexattr = 14,
> + aarch64_sys_lremovexattr = 15,
> + aarch64_sys_fremovexattr = 16,
> + aarch64_sys_getcwd = 17,
> + aarch64_sys_lookup_dcookie = 18,
> + aarch64_sys_eventfd2 = 19,
> + aarch64_sys_epoll_create1 = 20,
> + aarch64_sys_epoll_ctl = 21,
> + aarch64_sys_epoll_pwait = 22,
> + aarch64_sys_dup = 23,
> + aarch64_sys_dup3 = 24,
> + aarch64_sys_fcntl = 25,
> + aarch64_sys_inotify_init1 = 26,
> + aarch64_sys_inotify_add_watch = 27,
> + aarch64_sys_inotify_rm_watch = 28,
> + aarch64_sys_ioctl = 29,
> + aarch64_sys_ioprio_set = 30,
> + aarch64_sys_ioprio_get = 31,
> + aarch64_sys_flock = 32,
> + aarch64_sys_mknod = 33,
> + aarch64_sys_mkdir = 34,
> + aarch64_sys_unlink = 35,
> + aarch64_sys_symlink = 36,
> + aarch64_sys_link = 37,
> + aarch64_sys_rename = 38,
> + aarch64_sys_umount2 = 39,
> + aarch64_sys_mount = 40,
> + aarch64_sys_pivot_root = 41,
> + aarch64_sys_nfsservctl = 42,
> + aarch64_sys_statfs = 43,
> + aarch64_sys_fstatfs = 44,
> + aarch64_sys_truncate = 45,
> + aarch64_sys_ftruncate = 46,
> + aarch64_sys_fallocate = 47,
> + aarch64_sys_faccess = 48,
> + aarch64_sys_chdir = 49,
> + aarch64_sys_fchdir = 50,
> + aarch64_sys_chroot = 51,
> + aarch64_sys_fchmod = 52,
> + aarch64_sys_fchmodat = 53,
> + aarch64_sys_fchownat = 54,
> + aarch64_sys_fchown = 55,
> + aarch64_sys_open = 56,
> + aarch64_sys_close = 57,
> + aarch64_sys_vhangup = 58,
> + aarch64_sys_pipe2 = 59,
> + aarch64_sys_quotactl = 60,
> + aarch64_sys_getdents64 = 61,
> + aarch64_sys_lseek = 62,
> + aarch64_sys_read = 63,
> + aarch64_sys_write = 64,
> + aarch64_sys_readv = 65,
> + aarch64_sys_writev = 66,
> + aarch64_sys_pread64 = 67,
> + aarch64_sys_pwrite64 = 68,
> + aarch64_sys_preadv = 69,
> + aarch64_sys_pwritev = 70,
> + aarch64_sys_sendfile = 71,
> + aarch64_sys_pselect6 = 72,
> + aarch64_sys_ppoll = 73,
> + aarch64_sys_signalfd4 = 74,
> + aarch64_sys_vmsplice = 75,
> + aarch64_sys_splice = 76,
> + aarch64_sys_tee = 77,
> + aarch64_sys_readlink = 78,
> + aarch64_sys_fstatat = 79,
> + aarch64_sys_fstat = 80,
> + aarch64_sys_sync = 81,
> + aarch64_sys_fsync = 82,
> + aarch64_sys_fdatasync = 83,
> + aarch64_sys_sync_file_range2 = 84,
> + aarch64_sys_sync_file_range = 84,
> + aarch64_sys_timerfd_create = 85,
> + aarch64_sys_timerfd_settime = 86,
> + aarch64_sys_timerfd_gettime = 87,
> + aarch64_sys_utimensat = 88,
> + aarch64_sys_acct = 89,
> + aarch64_sys_capget = 90,
> + aarch64_sys_capset = 91,
> + aarch64_sys_personality = 92,
> + aarch64_sys_exit = 93,
> + aarch64_sys_exit_group = 94,
> + aarch64_sys_waitid = 95,
> + aarch64_sys_set_tid_address = 96,
> + aarch64_sys_unshare = 97,
> + aarch64_sys_futex = 98,
> + aarch64_sys_set_robust_list = 99,
> + aarch64_sys_get_robust_list = 100,
> + aarch64_sys_nanosleep = 101,
> + aarch64_sys_getitimer = 102,
> + aarch64_sys_setitimer = 103,
> + aarch64_sys_kexec_load = 104,
> + aarch64_sys_init_module = 105,
> + aarch64_sys_delete_module = 106,
> + aarch64_sys_timer_create = 107,
> + aarch64_sys_timer_gettime = 108,
> + aarch64_sys_timer_getoverrun = 109,
> + aarch64_sys_timer_settime = 110,
> + aarch64_sys_timer_delete = 111,
> + aarch64_sys_clock_settime = 112,
> + aarch64_sys_clock_gettime = 113,
> + aarch64_sys_clock_getres = 114,
> + aarch64_sys_clock_nanosleep = 115,
> + aarch64_sys_syslog = 116,
> + aarch64_sys_ptrace = 117,
> + aarch64_sys_sched_setparam = 118,
> + aarch64_sys_sched_setscheduler = 119,
> + aarch64_sys_sched_getscheduler = 120,
> + aarch64_sys_sched_getparam = 121,
> + aarch64_sys_sched_setaffinity = 122,
> + aarch64_sys_sched_getaffinity = 123,
> + aarch64_sys_sched_yield = 124,
> + aarch64_sys_sched_get_priority_max = 125,
> + aarch64_sys_sched_get_priority_min = 126,
> + aarch64_sys_sched_rr_get_interval = 127,
> + aarch64_sys_kill = 129,
> + aarch64_sys_tkill = 130,
> + aarch64_sys_tgkill = 131,
> + aarch64_sys_sigaltstack = 132,
> + aarch64_sys_rt_sigsuspend = 133,
> + aarch64_sys_rt_sigaction = 134,
> + aarch64_sys_rt_sigprocmask = 135,
> + aarch64_sys_rt_sigpending = 136,
> + aarch64_sys_rt_sigtimedwait = 137,
> + aarch64_sys_rt_sigqueueinfo = 138,
> + aarch64_sys_rt_sigreturn = 139,
> + aarch64_sys_setpriority = 140,
> + aarch64_sys_getpriority = 141,
> + aarch64_sys_reboot = 142,
> + aarch64_sys_setregid = 143,
> + aarch64_sys_setgid = 144,
> + aarch64_sys_setreuid = 145,
> + aarch64_sys_setuid = 146,
> + aarch64_sys_setresuid = 147,
> + aarch64_sys_getresuid = 148,
> + aarch64_sys_setresgid = 149,
> + aarch64_sys_getresgid = 150,
> + aarch64_sys_setfsuid = 151,
> + aarch64_sys_setfsgid = 152,
> + aarch64_sys_times = 153,
> + aarch64_sys_setpgid = 154,
> + aarch64_sys_getpgid = 155,
> + aarch64_sys_getsid = 156,
> + aarch64_sys_setsid = 157,
> + aarch64_sys_getgroups = 158,
> + aarch64_sys_setgroups = 159,
> + aarch64_sys_uname = 160,
> + aarch64_sys_sethostname = 161,
> + aarch64_sys_setdomainname = 162,
> + aarch64_sys_getrlimit = 163,
> + aarch64_sys_setrlimit = 164,
> + aarch64_sys_getrusage = 165,
> + aarch64_sys_umask = 166,
> + aarch64_sys_prctl = 167,
> + aarch64_sys_getcpu = 168,
> + aarch64_sys_gettimeofday = 169,
> + aarch64_sys_settimeofday = 170,
> + aarch64_sys_adjtimex = 171,
> + aarch64_sys_getpid = 172,
> + aarch64_sys_getppid = 173,
> + aarch64_sys_getuid = 174,
> + aarch64_sys_geteuid = 175,
> + aarch64_sys_getgid = 176,
> + aarch64_sys_getegid = 177,
> + aarch64_sys_gettid = 178,
> + aarch64_sys_sysinfo = 179,
> + aarch64_sys_mq_open = 180,
> + aarch64_sys_mq_unlink = 181,
> + aarch64_sys_mq_timedsend = 182,
> + aarch64_sys_mq_timedreceive = 183,
> + aarch64_sys_mq_notify = 184,
> + aarch64_sys_mq_getsetattr = 185,
> + aarch64_sys_msgget = 186,
> + aarch64_sys_msgctl = 187,
> + aarch64_sys_msgrcv = 188,
> + aarch64_sys_msgsnd = 189,
> + aarch64_sys_semget = 190,
> + aarch64_sys_semctl = 191,
> + aarch64_sys_semtimedop = 192,
> + aarch64_sys_semop = 193,
> + aarch64_sys_shmget = 194,
> + aarch64_sys_shmctl = 195,
> + aarch64_sys_shmat = 196,
> + aarch64_sys_shmdt = 197,
> + aarch64_sys_socket = 198,
> + aarch64_sys_socketpair = 199,
> + aarch64_sys_bind = 200,
> + aarch64_sys_listen = 201,
> + aarch64_sys_accept = 202,
> + aarch64_sys_connect = 203,
> + aarch64_sys_getsockname = 204,
> + aarch64_sys_getpeername = 205,
> + aarch64_sys_sendto = 206,
> + aarch64_sys_recvfrom = 207,
> + aarch64_sys_setsockopt = 208,
> + aarch64_sys_getsockopt = 209,
> + aarch64_sys_shutdown = 210,
> + aarch64_sys_sendmsg = 211,
> + aarch64_sys_recvmsg = 212,
> + aarch64_sys_readahead = 213,
> + aarch64_sys_brk = 214,
> + aarch64_sys_munmap = 215,
> + aarch64_sys_mremap = 216,
> + aarch64_sys_add_key = 217,
> + aarch64_sys_request_key = 218,
> + aarch64_sys_keyctl = 219,
> + aarch64_sys_clone = 220,
> + aarch64_sys_execve = 221,
> + aarch64_sys_mmap = 222,
> + aarch64_sys_fadvise64 = 223,
> + aarch64_sys_swapon = 224,
> + aarch64_sys_swapoff = 225,
> + aarch64_sys_mprotect = 226,
> + aarch64_sys_msync = 227,
> + aarch64_sys_mlock = 228,
> + aarch64_sys_munlock = 229,
> + aarch64_sys_mlockall = 230,
> + aarch64_sys_munlockall = 231,
> + aarch64_sys_mincore = 232,
> + aarch64_sys_madvise = 233,
> + aarch64_sys_remap_file_pages = 234,
> + aarch64_sys_mbind = 235,
> + aarch64_sys_get_mempolicy = 236,
> + aarch64_sys_set_mempolicy = 237,
> + aarch64_sys_migrate_pages = 238,
> + aarch64_sys_move_pages = 239,
> + aarch64_sys_rt_tgsigqueueinfo = 240,
> + aarch64_sys_perf_event_open = 241,
> + aarch64_sys_accept4 = 242,
> + aarch64_sys_recvmmsg = 243,
> + aarch64_sys_wait4 = 260,
> + aarch64_sys_prlimit64 = 261,
> + aarch64_sys_fanotify_init = 262,
> + aarch64_sys_fanotify_mark = 263,
> + aarch64_sys_name_to_handle_at = 264,
> + aarch64_sys_open_by_handle_at = 265,
> + aarch64_sys_clock_adjtime = 266,
> + aarch64_sys_syncfs = 267,
> + aarch64_sys_setns = 268,
> + aarch64_sys_sendmmsg = 269,
> + aarch64_sys_process_vm_readv = 270,
> + aarch64_sys_process_vm_writev = 271,
> + aarch64_sys_kcmp = 272,
> + aarch64_sys_finit_module = 273,
> + aarch64_sys_sched_setattr = 274,
> + aarch64_sys_sched_getattr = 275,
> +};
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index bb533b2..2e2dc15 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -2943,7 +2943,20 @@ aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
> {
> /* Exception generation instructions. */
> if (insn_bits24_27 == 0x04)
> - return AARCH64_RECORD_USUPPORTED;
> + {
> + if (!bits (aarch64_insn_r->aarch64_insn, 2, 4) &&
> + !bits (aarch64_insn_r->aarch64_insn, 21, 23) &&
> + bits (aarch64_insn_r->aarch64_insn, 0, 1) == 0x01)
> + {
> + ULONGEST svc_number;
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, 8,
> + &svc_number);
> + return tdep->aarch64_syscall_record (aarch64_insn_r->regcache,
> + svc_number);
> + }
> + else
> + return AARCH64_RECORD_USUPPORTED;
> + }
> /* System instructions. */
> else if (insn_bits24_27 == 0x05 && insn_bits22_23 == 0x00)
> {
> diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
> index 8a193f4..21c3bd3 100644
> --- a/gdb/aarch64-tdep.h
> +++ b/gdb/aarch64-tdep.h
> @@ -88,6 +88,9 @@ struct gdbarch_tdep
> struct type *vns_type;
> struct type *vnh_type;
> struct type *vnb_type;
> +
> + /* syscall record. */
> + int (*aarch64_syscall_record) (struct regcache *regcache, unsigned long svc_number);
Should this use ULONGEST instead of unsigned long? On 32bit
architectures they are different sizes.
--
Will Newton
Toolchain Working Group, Linaro
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 5/7] Support for recording syscall on aarch64-linux
2014-06-04 16:21 ` [PATCH 5/7] Support for recording syscall on aarch64-linux Omair Javaid
2014-06-05 8:52 ` Will Newton
@ 2014-06-06 15:58 ` Andreas Arnez
2014-06-11 7:11 ` Omair Javaid
1 sibling, 1 reply; 53+ messages in thread
From: Andreas Arnez @ 2014-06-06 15:58 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
On Wed, Jun 04 2014, Omair Javaid wrote:
> This patch adds support for recording system call instruction on aarch64-linux
> targets.
>
> [...]
> @@ -471,6 +1237,164 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
> [...]
> +
> + aarch64_linux_record_tdep.arg1 = AARCH64_X0_REGNUM + 1;
> + aarch64_linux_record_tdep.arg2 = AARCH64_X0_REGNUM + 2;
> + aarch64_linux_record_tdep.arg3 = AARCH64_X0_REGNUM + 3;
> + aarch64_linux_record_tdep.arg4 = AARCH64_X0_REGNUM + 3;
Is this a typo? Otherwise the reason for this specialty should be
documented in a comment here, IMO.
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH 5/7] Support for recording syscall on aarch64-linux
2014-06-06 15:58 ` Andreas Arnez
@ 2014-06-11 7:11 ` Omair Javaid
2014-08-29 11:53 ` Omair Javaid
0 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-06-11 7:11 UTC (permalink / raw)
To: Andreas Arnez; +Cc: gdb-patches
On 6 June 2014 20:58, Andreas Arnez <arnez@linux.vnet.ibm.com> wrote:
> On Wed, Jun 04 2014, Omair Javaid wrote:
>
>> This patch adds support for recording system call instruction on aarch64-linux
>> targets.
>>
>> [...]
>> @@ -471,6 +1237,164 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>> [...]
>> +
>> + aarch64_linux_record_tdep.arg1 = AARCH64_X0_REGNUM + 1;
>> + aarch64_linux_record_tdep.arg2 = AARCH64_X0_REGNUM + 2;
>> + aarch64_linux_record_tdep.arg3 = AARCH64_X0_REGNUM + 3;
>> + aarch64_linux_record_tdep.arg4 = AARCH64_X0_REGNUM + 3;
>
> Is this a typo? Otherwise the reason for this specialty should be
> documented in a comment here, IMO.
>
After a bit of digging up found out that AArch64 system calls take
between 0 and 7 arguments in register x1 to x7. I will update this
change with comment in upcoming update to this patch.
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH 5/7] Support for recording syscall on aarch64-linux
2014-06-11 7:11 ` Omair Javaid
@ 2014-08-29 11:53 ` Omair Javaid
2014-09-18 0:23 ` Will Newton
0 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-08-29 11:53 UTC (permalink / raw)
To: gdb-patches
Suggestion have been incorporated and updated patch is given below.
gdb:
2014-08-28 Omair Javaid <omair.javaid@linaro.org>
* aarch64-linux-tdep.c (record.h): Include.
(record-full.h): Include.
(struct linux_record_tdep aarch64_linux_record_tdep): Declare.
(aarch64_canonicalize_syscall): New function to translate syscall
numbers from aarch64 to canonical.
(aarch64_all_but_pc_registers_record): New function.
(aarch64_linux_syscall_record): New function.
(aarch64_linux_init_abi): Update to handle syscall recording.
* aarch64-linux-tdep.h (aarch64_syscall): New enum.
* aarch64-tdep.c (aarch64_record_branch_except_sys): Add code to
handle recording of syscalls.
* aarch64-tdep.h
(struct gdbarch_tdep) <aarch64_syscall_record>: Defined.
* linux-record.h (struct linux_record_tdep): Add two more syscall
argument fields.
---
gdb/aarch64-linux-tdep.c | 913 +++++++++++++++++++++++++++++++++++++++++++++++
gdb/aarch64-linux-tdep.h | 266 ++++++++++++++
gdb/aarch64-tdep.c | 15 +-
gdb/aarch64-tdep.h | 3 +
gdb/linux-record.h | 2 +
5 files changed, 1198 insertions(+), 1 deletion(-)
diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
index 5ab7b37..82b55b6 100644
--- a/gdb/aarch64-linux-tdep.c
+++ b/gdb/aarch64-linux-tdep.c
@@ -41,6 +41,9 @@
#include "user-regs.h"
#include <ctype.h>
+#include "record-full.h"
+#include "linux-record.h"
+
/* Signal frame handling.
+------------+ ^
@@ -354,6 +357,752 @@ aarch64_stap_parse_special_token (struct gdbarch *gdbarch,
return 1;
}
+/* AArch64 process record-replay constructs: syscall, signal etc. */
+
+struct linux_record_tdep aarch64_linux_record_tdep;
+
+/* aarch64_canonicalize_syscall maps syscall ids from the native AArch64
+ linux set of syscall ids into a canonical set of syscall ids used by
+ process record. */
+
+static enum gdb_syscall
+aarch64_canonicalize_syscall (enum aarch64_syscall syscall_number)
+{
+ switch (syscall_number) {
+ case aarch64_sys_read:
+ return gdb_sys_read;
+
+ case aarch64_sys_write:
+ return gdb_sys_write;
+
+ case aarch64_sys_open:
+ return gdb_sys_open;
+
+ case aarch64_sys_close:
+ return gdb_sys_close;
+
+ case aarch64_sys_lseek:
+ return gdb_sys_lseek;
+
+ case aarch64_sys_mprotect:
+ return gdb_sys_mprotect;
+
+ case aarch64_sys_munmap:
+ return gdb_sys_munmap;
+
+ case aarch64_sys_brk:
+ return gdb_sys_brk;
+
+ case aarch64_sys_rt_sigaction:
+ return gdb_sys_rt_sigaction;
+
+ case aarch64_sys_rt_sigprocmask:
+ return gdb_sys_rt_sigprocmask;
+
+ case aarch64_sys_rt_sigreturn:
+ return gdb_sys_rt_sigreturn;
+
+ case aarch64_sys_ioctl:
+ return gdb_sys_ioctl;
+
+ case aarch64_sys_pread64:
+ return gdb_sys_pread64;
+
+ case aarch64_sys_pwrite64:
+ return gdb_sys_pwrite64;
+
+ case aarch64_sys_readv:
+ return gdb_sys_readv;
+
+ case aarch64_sys_writev:
+ return gdb_sys_writev;
+
+ case aarch64_sys_sched_yield:
+ return gdb_sys_sched_yield;
+
+ case aarch64_sys_mremap:
+ return gdb_sys_mremap;
+
+ case aarch64_sys_msync:
+ return gdb_sys_msync;
+
+ case aarch64_sys_mincore:
+ return gdb_sys_mincore;
+
+ case aarch64_sys_madvise:
+ return gdb_sys_madvise;
+
+ case aarch64_sys_shmget:
+ return gdb_sys_shmget;
+
+ case aarch64_sys_shmat:
+ return gdb_sys_shmat;
+
+ case aarch64_sys_shmctl:
+ return gdb_sys_shmctl;
+
+ case aarch64_sys_dup:
+ return gdb_sys_dup;
+
+ case aarch64_sys_nanosleep:
+ return gdb_sys_nanosleep;
+
+ case aarch64_sys_getitimer:
+ return gdb_sys_getitimer;
+
+ case aarch64_sys_setitimer:
+ return gdb_sys_setitimer;
+
+ case aarch64_sys_getpid:
+ return gdb_sys_getpid;
+
+ case aarch64_sys_sendfile:
+ return gdb_sys_sendfile;
+
+ case aarch64_sys_socket:
+ return gdb_sys_socket;
+
+ case aarch64_sys_connect:
+ return gdb_sys_connect;
+
+ case aarch64_sys_accept:
+ return gdb_sys_accept;
+
+ case aarch64_sys_sendto:
+ return gdb_sys_sendto;
+
+ case aarch64_sys_recvfrom:
+ return gdb_sys_recvfrom;
+
+ case aarch64_sys_sendmsg:
+ return gdb_sys_sendmsg;
+
+ case aarch64_sys_recvmsg:
+ return gdb_sys_recvmsg;
+
+ case aarch64_sys_shutdown:
+ return gdb_sys_shutdown;
+
+ case aarch64_sys_bind:
+ return gdb_sys_bind;
+
+ case aarch64_sys_listen:
+ return gdb_sys_listen;
+
+ case aarch64_sys_getsockname:
+ return gdb_sys_getsockname;
+
+ case aarch64_sys_getpeername:
+ return gdb_sys_getpeername;
+
+ case aarch64_sys_socketpair:
+ return gdb_sys_socketpair;
+
+ case aarch64_sys_setsockopt:
+ return gdb_sys_setsockopt;
+
+ case aarch64_sys_getsockopt:
+ return gdb_sys_getsockopt;
+
+ case aarch64_sys_clone:
+ return gdb_sys_clone;
+
+ case aarch64_sys_execve:
+ return gdb_sys_execve;
+
+ case aarch64_sys_exit:
+ return gdb_sys_exit;
+
+ case aarch64_sys_wait4:
+ return gdb_sys_wait4;
+
+ case aarch64_sys_kill:
+ return gdb_sys_kill;
+
+ case aarch64_sys_uname:
+ return gdb_sys_uname;
+
+ case aarch64_sys_semget:
+ return gdb_sys_semget;
+
+ case aarch64_sys_semop:
+ return gdb_sys_semop;
+
+ case aarch64_sys_semctl:
+ return gdb_sys_semctl;
+
+ case aarch64_sys_shmdt:
+ return gdb_sys_shmdt;
+
+ case aarch64_sys_msgget:
+ return gdb_sys_msgget;
+
+ case aarch64_sys_msgsnd:
+ return gdb_sys_msgsnd;
+
+ case aarch64_sys_msgrcv:
+ return gdb_sys_msgrcv;
+
+ case aarch64_sys_msgctl:
+ return gdb_sys_msgctl;
+
+ case aarch64_sys_fcntl:
+ return gdb_sys_fcntl;
+
+ case aarch64_sys_flock:
+ return gdb_sys_flock;
+
+ case aarch64_sys_fsync:
+ return gdb_sys_fsync;
+
+ case aarch64_sys_fdatasync:
+ return gdb_sys_fdatasync;
+
+ case aarch64_sys_truncate:
+ return gdb_sys_truncate;
+
+ case aarch64_sys_ftruncate:
+ return gdb_sys_ftruncate;
+
+ case aarch64_sys_getcwd:
+ return gdb_sys_getcwd;
+
+ case aarch64_sys_chdir:
+ return gdb_sys_chdir;
+
+ case aarch64_sys_fchdir:
+ return gdb_sys_fchdir;
+
+ case aarch64_sys_rename:
+ return gdb_sys_rename;
+
+ case aarch64_sys_mkdir:
+ return gdb_sys_mkdir;
+
+ case aarch64_sys_link:
+ return gdb_sys_link;
+
+ case aarch64_sys_unlink:
+ return gdb_sys_unlink;
+
+ case aarch64_sys_symlink:
+ return gdb_sys_symlink;
+
+ case aarch64_sys_readlink:
+ return gdb_sys_readlink;
+
+ case aarch64_sys_fchmodat:
+ return gdb_sys_fchmodat;
+
+ case aarch64_sys_fchmod:
+ return gdb_sys_fchmod;
+
+ case aarch64_sys_fchownat:
+ return gdb_sys_fchownat;
+
+ case aarch64_sys_fchown:
+ return gdb_sys_fchown;
+
+ case aarch64_sys_umask:
+ return gdb_sys_umask;
+
+ case aarch64_sys_gettimeofday:
+ return gdb_sys_gettimeofday;
+
+ case aarch64_sys_getrlimit:
+ return gdb_sys_getrlimit;
+
+ case aarch64_sys_getrusage:
+ return gdb_sys_getrusage;
+
+ case aarch64_sys_sysinfo:
+ return gdb_sys_sysinfo;
+
+ case aarch64_sys_ptrace:
+ return gdb_sys_ptrace;
+
+ case aarch64_sys_getuid:
+ return gdb_sys_getuid;
+
+ case aarch64_sys_syslog:
+ return gdb_sys_syslog;
+
+ case aarch64_sys_getgid:
+ return gdb_sys_getgid;
+
+ case aarch64_sys_setuid:
+ return gdb_sys_setuid;
+
+ case aarch64_sys_setgid:
+ return gdb_sys_setgid;
+
+ case aarch64_sys_geteuid:
+ return gdb_sys_geteuid;
+
+ case aarch64_sys_getegid:
+ return gdb_sys_getegid;
+
+ case aarch64_sys_setpgid:
+ return gdb_sys_setpgid;
+
+ case aarch64_sys_getppid:
+ return gdb_sys_getppid;
+
+ case aarch64_sys_setsid:
+ return gdb_sys_setsid;
+
+ case aarch64_sys_setreuid:
+ return gdb_sys_setreuid;
+
+ case aarch64_sys_setregid:
+ return gdb_sys_setregid;
+
+ case aarch64_sys_getgroups:
+ return gdb_sys_getgroups;
+
+ case aarch64_sys_setgroups:
+ return gdb_sys_setgroups;
+
+ case aarch64_sys_setresuid:
+ return gdb_sys_setresuid;
+
+ case aarch64_sys_getresuid:
+ return gdb_sys_getresuid;
+
+ case aarch64_sys_setresgid:
+ return gdb_sys_setresgid;
+
+ case aarch64_sys_getresgid:
+ return gdb_sys_getresgid;
+
+ case aarch64_sys_getpgid:
+ return gdb_sys_getpgid;
+
+ case aarch64_sys_setfsuid:
+ return gdb_sys_setfsuid;
+
+ case aarch64_sys_setfsgid:
+ return gdb_sys_setfsgid;
+
+ case aarch64_sys_getsid:
+ return gdb_sys_getsid;
+
+ case aarch64_sys_capget:
+ return gdb_sys_capget;
+
+ case aarch64_sys_capset:
+ return gdb_sys_capset;
+
+ case aarch64_sys_rt_sigpending:
+ return gdb_sys_rt_sigpending;
+
+ case aarch64_sys_rt_sigtimedwait:
+ return gdb_sys_rt_sigtimedwait;
+
+ case aarch64_sys_rt_sigqueueinfo:
+ return gdb_sys_rt_sigqueueinfo;
+
+ case aarch64_sys_rt_sigsuspend:
+ return gdb_sys_rt_sigsuspend;
+
+ case aarch64_sys_sigaltstack:
+ return gdb_sys_sigaltstack;
+
+ case aarch64_sys_mknod:
+ return gdb_sys_mknod;
+
+ case aarch64_sys_personality:
+ return gdb_sys_personality;
+
+ case aarch64_sys_statfs:
+ return gdb_sys_statfs;
+
+ case aarch64_sys_fstat:
+ return gdb_sys_fstat;
+
+ case aarch64_sys_fstatfs:
+ return gdb_sys_fstatfs;
+
+ case aarch64_sys_getpriority:
+ return gdb_sys_getpriority;
+
+ case aarch64_sys_setpriority:
+ return gdb_sys_setpriority;
+
+ case aarch64_sys_sched_setparam:
+ return gdb_sys_sched_setparam;
+
+ case aarch64_sys_sched_getparam:
+ return gdb_sys_sched_getparam;
+
+ case aarch64_sys_sched_setscheduler:
+ return gdb_sys_sched_setscheduler;
+
+ case aarch64_sys_sched_getscheduler:
+ return gdb_sys_sched_getscheduler;
+
+ case aarch64_sys_sched_get_priority_max:
+ return gdb_sys_sched_get_priority_max;
+
+ case aarch64_sys_sched_get_priority_min:
+ return gdb_sys_sched_get_priority_min;
+
+ case aarch64_sys_sched_rr_get_interval:
+ return gdb_sys_sched_rr_get_interval;
+
+ case aarch64_sys_mlock:
+ return gdb_sys_mlock;
+
+ case aarch64_sys_munlock:
+ return gdb_sys_munlock;
+
+ case aarch64_sys_mlockall:
+ return gdb_sys_mlockall;
+
+ case aarch64_sys_munlockall:
+ return gdb_sys_munlockall;
+
+ case aarch64_sys_vhangup:
+ return gdb_sys_vhangup;
+
+ case aarch64_sys_prctl:
+ return gdb_sys_prctl;
+
+ case aarch64_sys_adjtimex:
+ return gdb_sys_adjtimex;
+
+ case aarch64_sys_setrlimit:
+ return gdb_sys_setrlimit;
+
+ case aarch64_sys_chroot:
+ return gdb_sys_chroot;
+
+ case aarch64_sys_sync:
+ return gdb_sys_sync;
+
+ case aarch64_sys_acct:
+ return gdb_sys_acct;
+
+ case aarch64_sys_settimeofday:
+ return gdb_sys_settimeofday;
+
+ case aarch64_sys_mount:
+ return gdb_sys_mount;
+
+ case aarch64_sys_swapon:
+ return gdb_sys_swapon;
+
+ case aarch64_sys_swapoff:
+ return gdb_sys_swapoff;
+
+ case aarch64_sys_reboot:
+ return gdb_sys_reboot;
+
+ case aarch64_sys_sethostname:
+ return gdb_sys_sethostname;
+
+ case aarch64_sys_setdomainname:
+ return gdb_sys_setdomainname;
+
+ case aarch64_sys_init_module:
+ return gdb_sys_init_module;
+
+ case aarch64_sys_delete_module:
+ return gdb_sys_delete_module;
+
+ case aarch64_sys_quotactl:
+ return gdb_sys_quotactl;
+
+ case aarch64_sys_nfsservctl:
+ return gdb_sys_nfsservctl;
+
+ case aarch64_sys_gettid:
+ return gdb_sys_gettid;
+
+ case aarch64_sys_readahead:
+ return gdb_sys_readahead;
+
+ case aarch64_sys_setxattr:
+ return gdb_sys_setxattr;
+
+ case aarch64_sys_lsetxattr:
+ return gdb_sys_lsetxattr;
+
+ case aarch64_sys_fsetxattr:
+ return gdb_sys_fsetxattr;
+
+ case aarch64_sys_getxattr:
+ return gdb_sys_getxattr;
+
+ case aarch64_sys_lgetxattr:
+ return gdb_sys_lgetxattr;
+
+ case aarch64_sys_fgetxattr:
+ return gdb_sys_fgetxattr;
+
+ case aarch64_sys_listxattr:
+ return gdb_sys_listxattr;
+
+ case aarch64_sys_llistxattr:
+ return gdb_sys_llistxattr;
+
+ case aarch64_sys_flistxattr:
+ return gdb_sys_flistxattr;
+
+ case aarch64_sys_removexattr:
+ return gdb_sys_removexattr;
+
+ case aarch64_sys_lremovexattr:
+ return gdb_sys_lremovexattr;
+
+ case aarch64_sys_fremovexattr:
+ return gdb_sys_fremovexattr;
+
+ case aarch64_sys_tkill:
+ return gdb_sys_tkill;
+
+ case aarch64_sys_times:
+ return gdb_sys_times;
+
+ case aarch64_sys_futex:
+ return gdb_sys_futex;
+
+ case aarch64_sys_sched_setaffinity:
+ return gdb_sys_sched_setaffinity;
+
+ case aarch64_sys_sched_getaffinity:
+ return gdb_sys_sched_getaffinity;
+
+ case aarch64_sys_io_setup:
+ return gdb_sys_io_setup;
+
+ case aarch64_sys_io_destroy:
+ return gdb_sys_io_destroy;
+
+ case aarch64_sys_io_getevents:
+ return gdb_sys_io_getevents;
+
+ case aarch64_sys_io_submit:
+ return gdb_sys_io_submit;
+
+ case aarch64_sys_io_cancel:
+ return gdb_sys_io_cancel;
+
+ case aarch64_sys_lookup_dcookie:
+ return gdb_sys_lookup_dcookie;
+
+ case aarch64_sys_epoll_create1:
+ return gdb_sys_epoll_create;
+
+ case aarch64_sys_remap_file_pages:
+ return gdb_sys_remap_file_pages;
+
+ case aarch64_sys_getdents64:
+ return gdb_sys_getdents64;
+
+ case aarch64_sys_set_tid_address:
+ return gdb_sys_set_tid_address;
+
+ case aarch64_sys_semtimedop:
+ return gdb_sys_semtimedop;
+
+ case aarch64_sys_fadvise64:
+ return gdb_sys_fadvise64;
+
+ case aarch64_sys_timer_create:
+ return gdb_sys_timer_create;
+
+ case aarch64_sys_timer_settime:
+ return gdb_sys_timer_settime;
+
+ case aarch64_sys_timer_gettime:
+ return gdb_sys_timer_gettime;
+
+ case aarch64_sys_timer_getoverrun:
+ return gdb_sys_timer_getoverrun;
+
+ case aarch64_sys_timer_delete:
+ return gdb_sys_timer_delete;
+
+ case aarch64_sys_clock_settime:
+ return gdb_sys_clock_settime;
+
+ case aarch64_sys_clock_gettime:
+ return gdb_sys_clock_gettime;
+
+ case aarch64_sys_clock_getres:
+ return gdb_sys_clock_getres;
+
+ case aarch64_sys_clock_nanosleep:
+ return gdb_sys_clock_nanosleep;
+
+ case aarch64_sys_exit_group:
+ return gdb_sys_exit_group;
+
+ case aarch64_sys_epoll_pwait:
+ return gdb_sys_epoll_pwait;
+
+ case aarch64_sys_epoll_ctl:
+ return gdb_sys_epoll_ctl;
+
+ case aarch64_sys_tgkill:
+ return gdb_sys_tgkill;
+
+ case aarch64_sys_mbind:
+ return gdb_sys_mbind;
+
+ case aarch64_sys_set_mempolicy:
+ return gdb_sys_set_mempolicy;
+
+ case aarch64_sys_get_mempolicy:
+ return gdb_sys_get_mempolicy;
+
+ case aarch64_sys_mq_open:
+ return gdb_sys_mq_open;
+
+ case aarch64_sys_mq_unlink:
+ return gdb_sys_mq_unlink;
+
+ case aarch64_sys_mq_timedsend:
+ return gdb_sys_mq_timedsend;
+
+ case aarch64_sys_mq_timedreceive:
+ return gdb_sys_mq_timedreceive;
+
+ case aarch64_sys_mq_notify:
+ return gdb_sys_mq_notify;
+
+ case aarch64_sys_mq_getsetattr:
+ return gdb_sys_mq_getsetattr;
+
+ case aarch64_sys_kexec_load:
+ return gdb_sys_kexec_load;
+
+ case aarch64_sys_waitid:
+ return gdb_sys_waitid;
+
+ case aarch64_sys_add_key:
+ return gdb_sys_add_key;
+
+ case aarch64_sys_request_key:
+ return gdb_sys_request_key;
+
+ case aarch64_sys_keyctl:
+ return gdb_sys_keyctl;
+
+ case aarch64_sys_ioprio_set:
+ return gdb_sys_ioprio_set;
+
+ case aarch64_sys_ioprio_get:
+ return gdb_sys_ioprio_get;
+
+ case aarch64_sys_inotify_add_watch:
+ return gdb_sys_inotify_add_watch;
+
+ case aarch64_sys_inotify_rm_watch:
+ return gdb_sys_inotify_rm_watch;
+
+ case aarch64_sys_migrate_pages:
+ return gdb_sys_migrate_pages;
+
+ case aarch64_sys_pselect6:
+ return gdb_sys_pselect6;
+
+ case aarch64_sys_ppoll:
+ return gdb_sys_ppoll;
+
+ case aarch64_sys_unshare:
+ return gdb_sys_unshare;
+
+ case aarch64_sys_set_robust_list:
+ return gdb_sys_set_robust_list;
+
+ case aarch64_sys_get_robust_list:
+ return gdb_sys_get_robust_list;
+
+ case aarch64_sys_splice:
+ return gdb_sys_splice;
+
+ case aarch64_sys_tee:
+ return gdb_sys_tee;
+
+ case aarch64_sys_sync_file_range:
+ return gdb_sys_sync_file_range;
+
+ case aarch64_sys_vmsplice:
+ return gdb_sys_vmsplice;
+
+ case aarch64_sys_move_pages:
+ return gdb_sys_move_pages;
+
+ default:
+ return -1;
+ }
+}
+
+/* Record all registers but PC register for process-record. */
+
+static int
+aarch64_all_but_pc_registers_record (struct regcache *regcache)
+{
+ int i;
+
+ for (i = 0; i < AARCH64_PC_REGNUM; i++)
+ if (record_full_arch_list_add_reg (regcache, AARCH64_X0_REGNUM + i))
+ return -1;
+
+ if (record_full_arch_list_add_reg (regcache, AARCH64_CPSR_REGNUM))
+ return -1;
+
+ return 0;
+}
+
+/* Handler for arm system call instruction recording. */
+
+static int
+aarch64_linux_syscall_record (struct regcache *regcache, unsigned long svc_number)
+{
+ int ret = 0;
+ enum gdb_syscall syscall_gdb;
+
+ printf_unfiltered (_("syscall number %s\n"),
+ plongest (svc_number));
+ syscall_gdb = aarch64_canonicalize_syscall (svc_number);
+
+ if (syscall_gdb < 0)
+ {
+ printf_unfiltered (_("Process record and replay target doesn't "
+ "support syscall number %s\n"),
+ plongest (svc_number));
+ return -1;
+ }
+
+ if (syscall_gdb == gdb_sys_sigreturn
+ || syscall_gdb == gdb_sys_rt_sigreturn)
+ {
+ if (aarch64_all_but_pc_registers_record (regcache))
+ return -1;
+ return 0;
+ }
+
+ ret = record_linux_system_call (syscall_gdb, regcache,
+ &aarch64_linux_record_tdep);
+ if (ret != 0)
+ return ret;
+
+ /* Record the return value of the system call. */
+ if (record_full_arch_list_add_reg (regcache, AARCH64_X0_REGNUM))
+ return -1;
+ /* Record LR. */
+ if (record_full_arch_list_add_reg (regcache, AARCH64_LR_REGNUM))
+ return -1;
+ /* Record CPSR. */
+ if (record_full_arch_list_add_reg (regcache, AARCH64_CPSR_REGNUM))
+ return -1;
+
+ return 0;
+}
+
static void
aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
{
@@ -404,6 +1153,170 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
/* Reversible debugging, process record. */
set_gdbarch_process_record (gdbarch, aarch64_process_record);
+ /* Syscall record. */
+ tdep->aarch64_syscall_record = aarch64_linux_syscall_record;
+
+ /* Initialize the aarch64_linux_record_tdep. */
+ /* These values are the size of the type that will be used in a system
+ call. They are obtained from Linux Kernel source. */
+ aarch64_linux_record_tdep.size_pointer
+ = gdbarch_ptr_bit (gdbarch) / TARGET_CHAR_BIT;
+ aarch64_linux_record_tdep.size__old_kernel_stat = 32;
+ aarch64_linux_record_tdep.size_tms = 32;
+ aarch64_linux_record_tdep.size_loff_t = 8;
+ aarch64_linux_record_tdep.size_flock = 32;
+ aarch64_linux_record_tdep.size_oldold_utsname = 45;
+ aarch64_linux_record_tdep.size_ustat = 32;
+ aarch64_linux_record_tdep.size_old_sigaction = 152;
+ aarch64_linux_record_tdep.size_old_sigset_t = 128;
+ aarch64_linux_record_tdep.size_rlimit = 16;
+ aarch64_linux_record_tdep.size_rusage = 144;
+ aarch64_linux_record_tdep.size_timeval = 16;
+ aarch64_linux_record_tdep.size_timezone = 8;
+ aarch64_linux_record_tdep.size_old_gid_t = 2;
+ aarch64_linux_record_tdep.size_old_uid_t = 2;
+ aarch64_linux_record_tdep.size_fd_set = 128;
+ aarch64_linux_record_tdep.size_dirent = 280;
+ aarch64_linux_record_tdep.size_dirent64 = 280;
+ aarch64_linux_record_tdep.size_statfs = 120;
+ aarch64_linux_record_tdep.size_statfs64 = 120;
+ aarch64_linux_record_tdep.size_sockaddr = 16;
+ aarch64_linux_record_tdep.size_int
+ = gdbarch_int_bit (gdbarch) / TARGET_CHAR_BIT;
+ aarch64_linux_record_tdep.size_long
+ = gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
+ aarch64_linux_record_tdep.size_ulong
+ = gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
+ aarch64_linux_record_tdep.size_msghdr = 56;
+ aarch64_linux_record_tdep.size_itimerval = 32;
+ aarch64_linux_record_tdep.size_stat = 144;
+ aarch64_linux_record_tdep.size_old_utsname = 325;
+ aarch64_linux_record_tdep.size_sysinfo = 112;
+ aarch64_linux_record_tdep.size_msqid_ds = 120;
+ aarch64_linux_record_tdep.size_shmid_ds = 112;
+ aarch64_linux_record_tdep.size_new_utsname = 390;
+ aarch64_linux_record_tdep.size_timex = 208;
+ aarch64_linux_record_tdep.size_mem_dqinfo = 24;
+ aarch64_linux_record_tdep.size_if_dqblk = 72;
+ aarch64_linux_record_tdep.size_fs_quota_stat = 80;
+ aarch64_linux_record_tdep.size_timespec = 16;
+ aarch64_linux_record_tdep.size_pollfd = 8;
+ aarch64_linux_record_tdep.size_NFS_FHSIZE = 32;
+ aarch64_linux_record_tdep.size_knfsd_fh = 132;
+ aarch64_linux_record_tdep.size_TASK_COMM_LEN = 16;
+ aarch64_linux_record_tdep.size_sigaction = 152;
+ aarch64_linux_record_tdep.size_sigset_t = 128;
+ aarch64_linux_record_tdep.size_siginfo_t = 128;
+ aarch64_linux_record_tdep.size_cap_user_data_t = 8;
+ aarch64_linux_record_tdep.size_stack_t = 24;
+ aarch64_linux_record_tdep.size_off_t = 8;
+ aarch64_linux_record_tdep.size_stat64 = 144;
+ aarch64_linux_record_tdep.size_gid_t = 4;
+ aarch64_linux_record_tdep.size_uid_t = 4;
+ aarch64_linux_record_tdep.size_PAGE_SIZE = 4096;
+ aarch64_linux_record_tdep.size_flock64 = 32;
+ aarch64_linux_record_tdep.size_user_desc = 16;
+ aarch64_linux_record_tdep.size_io_event = 32;
+ aarch64_linux_record_tdep.size_iocb = 64;
+ aarch64_linux_record_tdep.size_epoll_event = 12;
+ aarch64_linux_record_tdep.size_itimerspec = 32;
+ aarch64_linux_record_tdep.size_mq_attr = 64;
+ aarch64_linux_record_tdep.size_siginfo = 128;
+ aarch64_linux_record_tdep.size_termios = 60;
+ aarch64_linux_record_tdep.size_termios2 = 44;
+ aarch64_linux_record_tdep.size_pid_t = 4;
+ aarch64_linux_record_tdep.size_winsize = 8;
+ aarch64_linux_record_tdep.size_serial_struct = 72;
+ aarch64_linux_record_tdep.size_serial_icounter_struct = 80;
+ aarch64_linux_record_tdep.size_hayes_esp_config = 12;
+ aarch64_linux_record_tdep.size_size_t = 8;
+ aarch64_linux_record_tdep.size_iovec = 16;
+
+ /* These values are the second argument of system call "sys_ioctl".
+ They are obtained from Linux Kernel source. */
+ aarch64_linux_record_tdep.ioctl_TCGETS = 0x5401;
+ aarch64_linux_record_tdep.ioctl_TCSETS = 0x5402;
+ aarch64_linux_record_tdep.ioctl_TCSETSW = 0x5403;
+ aarch64_linux_record_tdep.ioctl_TCSETSF = 0x5404;
+ aarch64_linux_record_tdep.ioctl_TCGETA = 0x5405;
+ aarch64_linux_record_tdep.ioctl_TCSETA = 0x5406;
+ aarch64_linux_record_tdep.ioctl_TCSETAW = 0x5407;
+ aarch64_linux_record_tdep.ioctl_TCSETAF = 0x5408;
+ aarch64_linux_record_tdep.ioctl_TCSBRK = 0x5409;
+ aarch64_linux_record_tdep.ioctl_TCXONC = 0x540a;
+ aarch64_linux_record_tdep.ioctl_TCFLSH = 0x540b;
+ aarch64_linux_record_tdep.ioctl_TIOCEXCL = 0x540c;
+ aarch64_linux_record_tdep.ioctl_TIOCNXCL = 0x540d;
+ aarch64_linux_record_tdep.ioctl_TIOCSCTTY = 0x540e;
+ aarch64_linux_record_tdep.ioctl_TIOCGPGRP = 0x540f;
+ aarch64_linux_record_tdep.ioctl_TIOCSPGRP = 0x5410;
+ aarch64_linux_record_tdep.ioctl_TIOCOUTQ = 0x5411;
+ aarch64_linux_record_tdep.ioctl_TIOCSTI = 0x5412;
+ aarch64_linux_record_tdep.ioctl_TIOCGWINSZ = 0x5413;
+ aarch64_linux_record_tdep.ioctl_TIOCSWINSZ = 0x5414;
+ aarch64_linux_record_tdep.ioctl_TIOCMGET = 0x5415;
+ aarch64_linux_record_tdep.ioctl_TIOCMBIS = 0x5416;
+ aarch64_linux_record_tdep.ioctl_TIOCMBIC = 0x5417;
+ aarch64_linux_record_tdep.ioctl_TIOCMSET = 0x5418;
+ aarch64_linux_record_tdep.ioctl_TIOCGSOFTCAR = 0x5419;
+ aarch64_linux_record_tdep.ioctl_TIOCSSOFTCAR = 0x541a;
+ aarch64_linux_record_tdep.ioctl_FIONREAD = 0x541b;
+ aarch64_linux_record_tdep.ioctl_TIOCINQ = 0x541b;
+ aarch64_linux_record_tdep.ioctl_TIOCLINUX = 0x541c;
+ aarch64_linux_record_tdep.ioctl_TIOCCONS = 0x541d;
+ aarch64_linux_record_tdep.ioctl_TIOCGSERIAL = 0x541e;
+ aarch64_linux_record_tdep.ioctl_TIOCSSERIAL = 0x541f;
+ aarch64_linux_record_tdep.ioctl_TIOCPKT = 0x5420;
+ aarch64_linux_record_tdep.ioctl_FIONBIO = 0x5421;
+ aarch64_linux_record_tdep.ioctl_TIOCNOTTY = 0x5422;
+ aarch64_linux_record_tdep.ioctl_TIOCSETD = 0x5423;
+ aarch64_linux_record_tdep.ioctl_TIOCGETD = 0x5424;
+ aarch64_linux_record_tdep.ioctl_TCSBRKP = 0x5425;
+ aarch64_linux_record_tdep.ioctl_TIOCTTYGSTRUCT = 0x5426;
+ aarch64_linux_record_tdep.ioctl_TIOCSBRK = 0x5427;
+ aarch64_linux_record_tdep.ioctl_TIOCCBRK = 0x5428;
+ aarch64_linux_record_tdep.ioctl_TIOCGSID = 0x5429;
+ aarch64_linux_record_tdep.ioctl_TCGETS2 = 0x802c542a;
+ aarch64_linux_record_tdep.ioctl_TCSETS2 = 0x402c542b;
+ aarch64_linux_record_tdep.ioctl_TCSETSW2 = 0x402c542c;
+ aarch64_linux_record_tdep.ioctl_TCSETSF2 = 0x402c542d;
+ aarch64_linux_record_tdep.ioctl_TIOCGPTN = 0x80045430;
+ aarch64_linux_record_tdep.ioctl_TIOCSPTLCK = 0x40045431;
+ aarch64_linux_record_tdep.ioctl_FIONCLEX = 0x5450;
+ aarch64_linux_record_tdep.ioctl_FIOCLEX = 0x5451;
+ aarch64_linux_record_tdep.ioctl_FIOASYNC = 0x5452;
+ aarch64_linux_record_tdep.ioctl_TIOCSERCONFIG = 0x5453;
+ aarch64_linux_record_tdep.ioctl_TIOCSERGWILD = 0x5454;
+ aarch64_linux_record_tdep.ioctl_TIOCSERSWILD = 0x5455;
+ aarch64_linux_record_tdep.ioctl_TIOCGLCKTRMIOS = 0x5456;
+ aarch64_linux_record_tdep.ioctl_TIOCSLCKTRMIOS = 0x5457;
+ aarch64_linux_record_tdep.ioctl_TIOCSERGSTRUCT = 0x5458;
+ aarch64_linux_record_tdep.ioctl_TIOCSERGETLSR = 0x5459;
+ aarch64_linux_record_tdep.ioctl_TIOCSERGETMULTI = 0x545a;
+ aarch64_linux_record_tdep.ioctl_TIOCSERSETMULTI = 0x545b;
+ aarch64_linux_record_tdep.ioctl_TIOCMIWAIT = 0x545c;
+ aarch64_linux_record_tdep.ioctl_TIOCGICOUNT = 0x545d;
+ aarch64_linux_record_tdep.ioctl_TIOCGHAYESESP = 0x545e;
+ aarch64_linux_record_tdep.ioctl_TIOCSHAYESESP = 0x545f;
+ aarch64_linux_record_tdep.ioctl_FIOQSIZE = 0x5460;
+
+ /* These values are the second argument of system call "sys_fcntl"
+ and "sys_fcntl64". They are obtained from Linux Kernel source. */
+ aarch64_linux_record_tdep.fcntl_F_GETLK = 5;
+ aarch64_linux_record_tdep.fcntl_F_GETLK64 = 12;
+ aarch64_linux_record_tdep.fcntl_F_SETLK64 = 13;
+ aarch64_linux_record_tdep.fcntl_F_SETLKW64 = 14;
+
+ /* The AArch64 syscall calling convention: reg x0-x7 for arguments,
+ reg x8 for syscall number and return value in reg x0. */
+ aarch64_linux_record_tdep.arg1 = AARCH64_X0_REGNUM + 0;
+ aarch64_linux_record_tdep.arg2 = AARCH64_X0_REGNUM + 1;
+ aarch64_linux_record_tdep.arg3 = AARCH64_X0_REGNUM + 2;
+ aarch64_linux_record_tdep.arg4 = AARCH64_X0_REGNUM + 3;
+ aarch64_linux_record_tdep.arg5 = AARCH64_X0_REGNUM + 4;
+ aarch64_linux_record_tdep.arg6 = AARCH64_X0_REGNUM + 5;
+ aarch64_linux_record_tdep.arg7 = AARCH64_X0_REGNUM + 6;
+ aarch64_linux_record_tdep.arg8 = AARCH64_X0_REGNUM + 7;
}
/* Provide a prototype to silence -Wmissing-prototypes. */
diff --git a/gdb/aarch64-linux-tdep.h b/gdb/aarch64-linux-tdep.h
index 2e1de60..1ae3786 100644
--- a/gdb/aarch64-linux-tdep.h
+++ b/gdb/aarch64-linux-tdep.h
@@ -32,3 +32,269 @@
extern const struct regset aarch64_linux_gregset;
extern const struct regset aarch64_linux_fpregset;
+
+/* Enum that defines the AArch64 linux specific syscall identifiers used for
+ process record/replay. */
+
+enum aarch64_syscall {
+ aarch64_sys_io_setup = 0,
+ aarch64_sys_io_destroy = 1,
+ aarch64_sys_io_submit = 2,
+ aarch64_sys_io_cancel = 3,
+ aarch64_sys_io_getevents = 4,
+ aarch64_sys_setxattr = 5,
+ aarch64_sys_lsetxattr = 6,
+ aarch64_sys_fsetxattr = 7,
+ aarch64_sys_getxattr = 8,
+ aarch64_sys_lgetxattr = 9,
+ aarch64_sys_fgetxattr = 10,
+ aarch64_sys_listxattr = 11,
+ aarch64_sys_llistxattr = 12,
+ aarch64_sys_flistxattr = 13,
+ aarch64_sys_removexattr = 14,
+ aarch64_sys_lremovexattr = 15,
+ aarch64_sys_fremovexattr = 16,
+ aarch64_sys_getcwd = 17,
+ aarch64_sys_lookup_dcookie = 18,
+ aarch64_sys_eventfd2 = 19,
+ aarch64_sys_epoll_create1 = 20,
+ aarch64_sys_epoll_ctl = 21,
+ aarch64_sys_epoll_pwait = 22,
+ aarch64_sys_dup = 23,
+ aarch64_sys_dup3 = 24,
+ aarch64_sys_fcntl = 25,
+ aarch64_sys_inotify_init1 = 26,
+ aarch64_sys_inotify_add_watch = 27,
+ aarch64_sys_inotify_rm_watch = 28,
+ aarch64_sys_ioctl = 29,
+ aarch64_sys_ioprio_set = 30,
+ aarch64_sys_ioprio_get = 31,
+ aarch64_sys_flock = 32,
+ aarch64_sys_mknod = 33,
+ aarch64_sys_mkdir = 34,
+ aarch64_sys_unlink = 35,
+ aarch64_sys_symlink = 36,
+ aarch64_sys_link = 37,
+ aarch64_sys_rename = 38,
+ aarch64_sys_umount2 = 39,
+ aarch64_sys_mount = 40,
+ aarch64_sys_pivot_root = 41,
+ aarch64_sys_nfsservctl = 42,
+ aarch64_sys_statfs = 43,
+ aarch64_sys_fstatfs = 44,
+ aarch64_sys_truncate = 45,
+ aarch64_sys_ftruncate = 46,
+ aarch64_sys_fallocate = 47,
+ aarch64_sys_faccess = 48,
+ aarch64_sys_chdir = 49,
+ aarch64_sys_fchdir = 50,
+ aarch64_sys_chroot = 51,
+ aarch64_sys_fchmod = 52,
+ aarch64_sys_fchmodat = 53,
+ aarch64_sys_fchownat = 54,
+ aarch64_sys_fchown = 55,
+ aarch64_sys_open = 56,
+ aarch64_sys_close = 57,
+ aarch64_sys_vhangup = 58,
+ aarch64_sys_pipe2 = 59,
+ aarch64_sys_quotactl = 60,
+ aarch64_sys_getdents64 = 61,
+ aarch64_sys_lseek = 62,
+ aarch64_sys_read = 63,
+ aarch64_sys_write = 64,
+ aarch64_sys_readv = 65,
+ aarch64_sys_writev = 66,
+ aarch64_sys_pread64 = 67,
+ aarch64_sys_pwrite64 = 68,
+ aarch64_sys_preadv = 69,
+ aarch64_sys_pwritev = 70,
+ aarch64_sys_sendfile = 71,
+ aarch64_sys_pselect6 = 72,
+ aarch64_sys_ppoll = 73,
+ aarch64_sys_signalfd4 = 74,
+ aarch64_sys_vmsplice = 75,
+ aarch64_sys_splice = 76,
+ aarch64_sys_tee = 77,
+ aarch64_sys_readlink = 78,
+ aarch64_sys_fstatat = 79,
+ aarch64_sys_fstat = 80,
+ aarch64_sys_sync = 81,
+ aarch64_sys_fsync = 82,
+ aarch64_sys_fdatasync = 83,
+ aarch64_sys_sync_file_range2 = 84,
+ aarch64_sys_sync_file_range = 84,
+ aarch64_sys_timerfd_create = 85,
+ aarch64_sys_timerfd_settime = 86,
+ aarch64_sys_timerfd_gettime = 87,
+ aarch64_sys_utimensat = 88,
+ aarch64_sys_acct = 89,
+ aarch64_sys_capget = 90,
+ aarch64_sys_capset = 91,
+ aarch64_sys_personality = 92,
+ aarch64_sys_exit = 93,
+ aarch64_sys_exit_group = 94,
+ aarch64_sys_waitid = 95,
+ aarch64_sys_set_tid_address = 96,
+ aarch64_sys_unshare = 97,
+ aarch64_sys_futex = 98,
+ aarch64_sys_set_robust_list = 99,
+ aarch64_sys_get_robust_list = 100,
+ aarch64_sys_nanosleep = 101,
+ aarch64_sys_getitimer = 102,
+ aarch64_sys_setitimer = 103,
+ aarch64_sys_kexec_load = 104,
+ aarch64_sys_init_module = 105,
+ aarch64_sys_delete_module = 106,
+ aarch64_sys_timer_create = 107,
+ aarch64_sys_timer_gettime = 108,
+ aarch64_sys_timer_getoverrun = 109,
+ aarch64_sys_timer_settime = 110,
+ aarch64_sys_timer_delete = 111,
+ aarch64_sys_clock_settime = 112,
+ aarch64_sys_clock_gettime = 113,
+ aarch64_sys_clock_getres = 114,
+ aarch64_sys_clock_nanosleep = 115,
+ aarch64_sys_syslog = 116,
+ aarch64_sys_ptrace = 117,
+ aarch64_sys_sched_setparam = 118,
+ aarch64_sys_sched_setscheduler = 119,
+ aarch64_sys_sched_getscheduler = 120,
+ aarch64_sys_sched_getparam = 121,
+ aarch64_sys_sched_setaffinity = 122,
+ aarch64_sys_sched_getaffinity = 123,
+ aarch64_sys_sched_yield = 124,
+ aarch64_sys_sched_get_priority_max = 125,
+ aarch64_sys_sched_get_priority_min = 126,
+ aarch64_sys_sched_rr_get_interval = 127,
+ aarch64_sys_kill = 129,
+ aarch64_sys_tkill = 130,
+ aarch64_sys_tgkill = 131,
+ aarch64_sys_sigaltstack = 132,
+ aarch64_sys_rt_sigsuspend = 133,
+ aarch64_sys_rt_sigaction = 134,
+ aarch64_sys_rt_sigprocmask = 135,
+ aarch64_sys_rt_sigpending = 136,
+ aarch64_sys_rt_sigtimedwait = 137,
+ aarch64_sys_rt_sigqueueinfo = 138,
+ aarch64_sys_rt_sigreturn = 139,
+ aarch64_sys_setpriority = 140,
+ aarch64_sys_getpriority = 141,
+ aarch64_sys_reboot = 142,
+ aarch64_sys_setregid = 143,
+ aarch64_sys_setgid = 144,
+ aarch64_sys_setreuid = 145,
+ aarch64_sys_setuid = 146,
+ aarch64_sys_setresuid = 147,
+ aarch64_sys_getresuid = 148,
+ aarch64_sys_setresgid = 149,
+ aarch64_sys_getresgid = 150,
+ aarch64_sys_setfsuid = 151,
+ aarch64_sys_setfsgid = 152,
+ aarch64_sys_times = 153,
+ aarch64_sys_setpgid = 154,
+ aarch64_sys_getpgid = 155,
+ aarch64_sys_getsid = 156,
+ aarch64_sys_setsid = 157,
+ aarch64_sys_getgroups = 158,
+ aarch64_sys_setgroups = 159,
+ aarch64_sys_uname = 160,
+ aarch64_sys_sethostname = 161,
+ aarch64_sys_setdomainname = 162,
+ aarch64_sys_getrlimit = 163,
+ aarch64_sys_setrlimit = 164,
+ aarch64_sys_getrusage = 165,
+ aarch64_sys_umask = 166,
+ aarch64_sys_prctl = 167,
+ aarch64_sys_getcpu = 168,
+ aarch64_sys_gettimeofday = 169,
+ aarch64_sys_settimeofday = 170,
+ aarch64_sys_adjtimex = 171,
+ aarch64_sys_getpid = 172,
+ aarch64_sys_getppid = 173,
+ aarch64_sys_getuid = 174,
+ aarch64_sys_geteuid = 175,
+ aarch64_sys_getgid = 176,
+ aarch64_sys_getegid = 177,
+ aarch64_sys_gettid = 178,
+ aarch64_sys_sysinfo = 179,
+ aarch64_sys_mq_open = 180,
+ aarch64_sys_mq_unlink = 181,
+ aarch64_sys_mq_timedsend = 182,
+ aarch64_sys_mq_timedreceive = 183,
+ aarch64_sys_mq_notify = 184,
+ aarch64_sys_mq_getsetattr = 185,
+ aarch64_sys_msgget = 186,
+ aarch64_sys_msgctl = 187,
+ aarch64_sys_msgrcv = 188,
+ aarch64_sys_msgsnd = 189,
+ aarch64_sys_semget = 190,
+ aarch64_sys_semctl = 191,
+ aarch64_sys_semtimedop = 192,
+ aarch64_sys_semop = 193,
+ aarch64_sys_shmget = 194,
+ aarch64_sys_shmctl = 195,
+ aarch64_sys_shmat = 196,
+ aarch64_sys_shmdt = 197,
+ aarch64_sys_socket = 198,
+ aarch64_sys_socketpair = 199,
+ aarch64_sys_bind = 200,
+ aarch64_sys_listen = 201,
+ aarch64_sys_accept = 202,
+ aarch64_sys_connect = 203,
+ aarch64_sys_getsockname = 204,
+ aarch64_sys_getpeername = 205,
+ aarch64_sys_sendto = 206,
+ aarch64_sys_recvfrom = 207,
+ aarch64_sys_setsockopt = 208,
+ aarch64_sys_getsockopt = 209,
+ aarch64_sys_shutdown = 210,
+ aarch64_sys_sendmsg = 211,
+ aarch64_sys_recvmsg = 212,
+ aarch64_sys_readahead = 213,
+ aarch64_sys_brk = 214,
+ aarch64_sys_munmap = 215,
+ aarch64_sys_mremap = 216,
+ aarch64_sys_add_key = 217,
+ aarch64_sys_request_key = 218,
+ aarch64_sys_keyctl = 219,
+ aarch64_sys_clone = 220,
+ aarch64_sys_execve = 221,
+ aarch64_sys_mmap = 222,
+ aarch64_sys_fadvise64 = 223,
+ aarch64_sys_swapon = 224,
+ aarch64_sys_swapoff = 225,
+ aarch64_sys_mprotect = 226,
+ aarch64_sys_msync = 227,
+ aarch64_sys_mlock = 228,
+ aarch64_sys_munlock = 229,
+ aarch64_sys_mlockall = 230,
+ aarch64_sys_munlockall = 231,
+ aarch64_sys_mincore = 232,
+ aarch64_sys_madvise = 233,
+ aarch64_sys_remap_file_pages = 234,
+ aarch64_sys_mbind = 235,
+ aarch64_sys_get_mempolicy = 236,
+ aarch64_sys_set_mempolicy = 237,
+ aarch64_sys_migrate_pages = 238,
+ aarch64_sys_move_pages = 239,
+ aarch64_sys_rt_tgsigqueueinfo = 240,
+ aarch64_sys_perf_event_open = 241,
+ aarch64_sys_accept4 = 242,
+ aarch64_sys_recvmmsg = 243,
+ aarch64_sys_wait4 = 260,
+ aarch64_sys_prlimit64 = 261,
+ aarch64_sys_fanotify_init = 262,
+ aarch64_sys_fanotify_mark = 263,
+ aarch64_sys_name_to_handle_at = 264,
+ aarch64_sys_open_by_handle_at = 265,
+ aarch64_sys_clock_adjtime = 266,
+ aarch64_sys_syncfs = 267,
+ aarch64_sys_setns = 268,
+ aarch64_sys_sendmmsg = 269,
+ aarch64_sys_process_vm_readv = 270,
+ aarch64_sys_process_vm_writev = 271,
+ aarch64_sys_kcmp = 272,
+ aarch64_sys_finit_module = 273,
+ aarch64_sys_sched_setattr = 274,
+ aarch64_sys_sched_getattr = 275,
+};
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index 0847585..c6da25a 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -2941,7 +2941,20 @@ aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
{
/* Exception generation instructions. */
if (insn_bits24_27 == 0x04)
- return AARCH64_RECORD_UNSUPPORTED;
+ {
+ if (!bits (aarch64_insn_r->aarch64_insn, 2, 4) &&
+ !bits (aarch64_insn_r->aarch64_insn, 21, 23) &&
+ bits (aarch64_insn_r->aarch64_insn, 0, 1) == 0x01)
+ {
+ ULONGEST svc_number;
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, 8,
+ &svc_number);
+ return tdep->aarch64_syscall_record (aarch64_insn_r->regcache,
+ svc_number);
+ }
+ else
+ return AARCH64_RECORD_UNSUPPORTED;
+ }
/* System instructions. */
else if (insn_bits24_27 == 0x05 && insn_bits22_23 == 0x00)
{
diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
index 1d74ef8..25751fe 100644
--- a/gdb/aarch64-tdep.h
+++ b/gdb/aarch64-tdep.h
@@ -88,6 +88,9 @@ struct gdbarch_tdep
struct type *vns_type;
struct type *vnh_type;
struct type *vnb_type;
+
+ /* syscall record. */
+ int (*aarch64_syscall_record) (struct regcache *regcache, unsigned long svc_number);
};
/* AArch64 process record-replay related structures, defines etc. */
diff --git a/gdb/linux-record.h b/gdb/linux-record.h
index 7b5218e..2649ce5 100644
--- a/gdb/linux-record.h
+++ b/gdb/linux-record.h
@@ -174,6 +174,8 @@ struct linux_record_tdep
int arg4;
int arg5;
int arg6;
+ int arg7;
+ int arg8;
};
/* Enum that defines the gdb-canonical set of Linux syscall identifiers.
--
1.9.1
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 5/7] Support for recording syscall on aarch64-linux
2014-08-29 11:53 ` Omair Javaid
@ 2014-09-18 0:23 ` Will Newton
2014-09-18 22:28 ` Omair Javaid
0 siblings, 1 reply; 53+ messages in thread
From: Will Newton @ 2014-09-18 0:23 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
On 29 August 2014 04:53, Omair Javaid <omair.javaid@linaro.org> wrote:
> Suggestion have been incorporated and updated patch is given below.
>
> gdb:
>
> 2014-08-28 Omair Javaid <omair.javaid@linaro.org>
>
> * aarch64-linux-tdep.c (record.h): Include.
> (record-full.h): Include.
> (struct linux_record_tdep aarch64_linux_record_tdep): Declare.
> (aarch64_canonicalize_syscall): New function to translate syscall
> numbers from aarch64 to canonical.
> (aarch64_all_but_pc_registers_record): New function.
> (aarch64_linux_syscall_record): New function.
> (aarch64_linux_init_abi): Update to handle syscall recording.
> * aarch64-linux-tdep.h (aarch64_syscall): New enum.
> * aarch64-tdep.c (aarch64_record_branch_except_sys): Add code to
> handle recording of syscalls.
> * aarch64-tdep.h
> (struct gdbarch_tdep) <aarch64_syscall_record>: Defined.
> * linux-record.h (struct linux_record_tdep): Add two more syscall
> argument fields.
>
> ---
> gdb/aarch64-linux-tdep.c | 913 +++++++++++++++++++++++++++++++++++++++++++++++
> gdb/aarch64-linux-tdep.h | 266 ++++++++++++++
> gdb/aarch64-tdep.c | 15 +-
> gdb/aarch64-tdep.h | 3 +
> gdb/linux-record.h | 2 +
> 5 files changed, 1198 insertions(+), 1 deletion(-)
This one looks ok to me now.
> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
> index 5ab7b37..82b55b6 100644
> --- a/gdb/aarch64-linux-tdep.c
> +++ b/gdb/aarch64-linux-tdep.c
> @@ -41,6 +41,9 @@
> #include "user-regs.h"
> #include <ctype.h>
>
> +#include "record-full.h"
> +#include "linux-record.h"
> +
> /* Signal frame handling.
>
> +------------+ ^
> @@ -354,6 +357,752 @@ aarch64_stap_parse_special_token (struct gdbarch *gdbarch,
> return 1;
> }
>
> +/* AArch64 process record-replay constructs: syscall, signal etc. */
> +
> +struct linux_record_tdep aarch64_linux_record_tdep;
> +
> +/* aarch64_canonicalize_syscall maps syscall ids from the native AArch64
> + linux set of syscall ids into a canonical set of syscall ids used by
> + process record. */
> +
> +static enum gdb_syscall
> +aarch64_canonicalize_syscall (enum aarch64_syscall syscall_number)
> +{
> + switch (syscall_number) {
> + case aarch64_sys_read:
> + return gdb_sys_read;
> +
> + case aarch64_sys_write:
> + return gdb_sys_write;
> +
> + case aarch64_sys_open:
> + return gdb_sys_open;
> +
> + case aarch64_sys_close:
> + return gdb_sys_close;
> +
> + case aarch64_sys_lseek:
> + return gdb_sys_lseek;
> +
> + case aarch64_sys_mprotect:
> + return gdb_sys_mprotect;
> +
> + case aarch64_sys_munmap:
> + return gdb_sys_munmap;
> +
> + case aarch64_sys_brk:
> + return gdb_sys_brk;
> +
> + case aarch64_sys_rt_sigaction:
> + return gdb_sys_rt_sigaction;
> +
> + case aarch64_sys_rt_sigprocmask:
> + return gdb_sys_rt_sigprocmask;
> +
> + case aarch64_sys_rt_sigreturn:
> + return gdb_sys_rt_sigreturn;
> +
> + case aarch64_sys_ioctl:
> + return gdb_sys_ioctl;
> +
> + case aarch64_sys_pread64:
> + return gdb_sys_pread64;
> +
> + case aarch64_sys_pwrite64:
> + return gdb_sys_pwrite64;
> +
> + case aarch64_sys_readv:
> + return gdb_sys_readv;
> +
> + case aarch64_sys_writev:
> + return gdb_sys_writev;
> +
> + case aarch64_sys_sched_yield:
> + return gdb_sys_sched_yield;
> +
> + case aarch64_sys_mremap:
> + return gdb_sys_mremap;
> +
> + case aarch64_sys_msync:
> + return gdb_sys_msync;
> +
> + case aarch64_sys_mincore:
> + return gdb_sys_mincore;
> +
> + case aarch64_sys_madvise:
> + return gdb_sys_madvise;
> +
> + case aarch64_sys_shmget:
> + return gdb_sys_shmget;
> +
> + case aarch64_sys_shmat:
> + return gdb_sys_shmat;
> +
> + case aarch64_sys_shmctl:
> + return gdb_sys_shmctl;
> +
> + case aarch64_sys_dup:
> + return gdb_sys_dup;
> +
> + case aarch64_sys_nanosleep:
> + return gdb_sys_nanosleep;
> +
> + case aarch64_sys_getitimer:
> + return gdb_sys_getitimer;
> +
> + case aarch64_sys_setitimer:
> + return gdb_sys_setitimer;
> +
> + case aarch64_sys_getpid:
> + return gdb_sys_getpid;
> +
> + case aarch64_sys_sendfile:
> + return gdb_sys_sendfile;
> +
> + case aarch64_sys_socket:
> + return gdb_sys_socket;
> +
> + case aarch64_sys_connect:
> + return gdb_sys_connect;
> +
> + case aarch64_sys_accept:
> + return gdb_sys_accept;
> +
> + case aarch64_sys_sendto:
> + return gdb_sys_sendto;
> +
> + case aarch64_sys_recvfrom:
> + return gdb_sys_recvfrom;
> +
> + case aarch64_sys_sendmsg:
> + return gdb_sys_sendmsg;
> +
> + case aarch64_sys_recvmsg:
> + return gdb_sys_recvmsg;
> +
> + case aarch64_sys_shutdown:
> + return gdb_sys_shutdown;
> +
> + case aarch64_sys_bind:
> + return gdb_sys_bind;
> +
> + case aarch64_sys_listen:
> + return gdb_sys_listen;
> +
> + case aarch64_sys_getsockname:
> + return gdb_sys_getsockname;
> +
> + case aarch64_sys_getpeername:
> + return gdb_sys_getpeername;
> +
> + case aarch64_sys_socketpair:
> + return gdb_sys_socketpair;
> +
> + case aarch64_sys_setsockopt:
> + return gdb_sys_setsockopt;
> +
> + case aarch64_sys_getsockopt:
> + return gdb_sys_getsockopt;
> +
> + case aarch64_sys_clone:
> + return gdb_sys_clone;
> +
> + case aarch64_sys_execve:
> + return gdb_sys_execve;
> +
> + case aarch64_sys_exit:
> + return gdb_sys_exit;
> +
> + case aarch64_sys_wait4:
> + return gdb_sys_wait4;
> +
> + case aarch64_sys_kill:
> + return gdb_sys_kill;
> +
> + case aarch64_sys_uname:
> + return gdb_sys_uname;
> +
> + case aarch64_sys_semget:
> + return gdb_sys_semget;
> +
> + case aarch64_sys_semop:
> + return gdb_sys_semop;
> +
> + case aarch64_sys_semctl:
> + return gdb_sys_semctl;
> +
> + case aarch64_sys_shmdt:
> + return gdb_sys_shmdt;
> +
> + case aarch64_sys_msgget:
> + return gdb_sys_msgget;
> +
> + case aarch64_sys_msgsnd:
> + return gdb_sys_msgsnd;
> +
> + case aarch64_sys_msgrcv:
> + return gdb_sys_msgrcv;
> +
> + case aarch64_sys_msgctl:
> + return gdb_sys_msgctl;
> +
> + case aarch64_sys_fcntl:
> + return gdb_sys_fcntl;
> +
> + case aarch64_sys_flock:
> + return gdb_sys_flock;
> +
> + case aarch64_sys_fsync:
> + return gdb_sys_fsync;
> +
> + case aarch64_sys_fdatasync:
> + return gdb_sys_fdatasync;
> +
> + case aarch64_sys_truncate:
> + return gdb_sys_truncate;
> +
> + case aarch64_sys_ftruncate:
> + return gdb_sys_ftruncate;
> +
> + case aarch64_sys_getcwd:
> + return gdb_sys_getcwd;
> +
> + case aarch64_sys_chdir:
> + return gdb_sys_chdir;
> +
> + case aarch64_sys_fchdir:
> + return gdb_sys_fchdir;
> +
> + case aarch64_sys_rename:
> + return gdb_sys_rename;
> +
> + case aarch64_sys_mkdir:
> + return gdb_sys_mkdir;
> +
> + case aarch64_sys_link:
> + return gdb_sys_link;
> +
> + case aarch64_sys_unlink:
> + return gdb_sys_unlink;
> +
> + case aarch64_sys_symlink:
> + return gdb_sys_symlink;
> +
> + case aarch64_sys_readlink:
> + return gdb_sys_readlink;
> +
> + case aarch64_sys_fchmodat:
> + return gdb_sys_fchmodat;
> +
> + case aarch64_sys_fchmod:
> + return gdb_sys_fchmod;
> +
> + case aarch64_sys_fchownat:
> + return gdb_sys_fchownat;
> +
> + case aarch64_sys_fchown:
> + return gdb_sys_fchown;
> +
> + case aarch64_sys_umask:
> + return gdb_sys_umask;
> +
> + case aarch64_sys_gettimeofday:
> + return gdb_sys_gettimeofday;
> +
> + case aarch64_sys_getrlimit:
> + return gdb_sys_getrlimit;
> +
> + case aarch64_sys_getrusage:
> + return gdb_sys_getrusage;
> +
> + case aarch64_sys_sysinfo:
> + return gdb_sys_sysinfo;
> +
> + case aarch64_sys_ptrace:
> + return gdb_sys_ptrace;
> +
> + case aarch64_sys_getuid:
> + return gdb_sys_getuid;
> +
> + case aarch64_sys_syslog:
> + return gdb_sys_syslog;
> +
> + case aarch64_sys_getgid:
> + return gdb_sys_getgid;
> +
> + case aarch64_sys_setuid:
> + return gdb_sys_setuid;
> +
> + case aarch64_sys_setgid:
> + return gdb_sys_setgid;
> +
> + case aarch64_sys_geteuid:
> + return gdb_sys_geteuid;
> +
> + case aarch64_sys_getegid:
> + return gdb_sys_getegid;
> +
> + case aarch64_sys_setpgid:
> + return gdb_sys_setpgid;
> +
> + case aarch64_sys_getppid:
> + return gdb_sys_getppid;
> +
> + case aarch64_sys_setsid:
> + return gdb_sys_setsid;
> +
> + case aarch64_sys_setreuid:
> + return gdb_sys_setreuid;
> +
> + case aarch64_sys_setregid:
> + return gdb_sys_setregid;
> +
> + case aarch64_sys_getgroups:
> + return gdb_sys_getgroups;
> +
> + case aarch64_sys_setgroups:
> + return gdb_sys_setgroups;
> +
> + case aarch64_sys_setresuid:
> + return gdb_sys_setresuid;
> +
> + case aarch64_sys_getresuid:
> + return gdb_sys_getresuid;
> +
> + case aarch64_sys_setresgid:
> + return gdb_sys_setresgid;
> +
> + case aarch64_sys_getresgid:
> + return gdb_sys_getresgid;
> +
> + case aarch64_sys_getpgid:
> + return gdb_sys_getpgid;
> +
> + case aarch64_sys_setfsuid:
> + return gdb_sys_setfsuid;
> +
> + case aarch64_sys_setfsgid:
> + return gdb_sys_setfsgid;
> +
> + case aarch64_sys_getsid:
> + return gdb_sys_getsid;
> +
> + case aarch64_sys_capget:
> + return gdb_sys_capget;
> +
> + case aarch64_sys_capset:
> + return gdb_sys_capset;
> +
> + case aarch64_sys_rt_sigpending:
> + return gdb_sys_rt_sigpending;
> +
> + case aarch64_sys_rt_sigtimedwait:
> + return gdb_sys_rt_sigtimedwait;
> +
> + case aarch64_sys_rt_sigqueueinfo:
> + return gdb_sys_rt_sigqueueinfo;
> +
> + case aarch64_sys_rt_sigsuspend:
> + return gdb_sys_rt_sigsuspend;
> +
> + case aarch64_sys_sigaltstack:
> + return gdb_sys_sigaltstack;
> +
> + case aarch64_sys_mknod:
> + return gdb_sys_mknod;
> +
> + case aarch64_sys_personality:
> + return gdb_sys_personality;
> +
> + case aarch64_sys_statfs:
> + return gdb_sys_statfs;
> +
> + case aarch64_sys_fstat:
> + return gdb_sys_fstat;
> +
> + case aarch64_sys_fstatfs:
> + return gdb_sys_fstatfs;
> +
> + case aarch64_sys_getpriority:
> + return gdb_sys_getpriority;
> +
> + case aarch64_sys_setpriority:
> + return gdb_sys_setpriority;
> +
> + case aarch64_sys_sched_setparam:
> + return gdb_sys_sched_setparam;
> +
> + case aarch64_sys_sched_getparam:
> + return gdb_sys_sched_getparam;
> +
> + case aarch64_sys_sched_setscheduler:
> + return gdb_sys_sched_setscheduler;
> +
> + case aarch64_sys_sched_getscheduler:
> + return gdb_sys_sched_getscheduler;
> +
> + case aarch64_sys_sched_get_priority_max:
> + return gdb_sys_sched_get_priority_max;
> +
> + case aarch64_sys_sched_get_priority_min:
> + return gdb_sys_sched_get_priority_min;
> +
> + case aarch64_sys_sched_rr_get_interval:
> + return gdb_sys_sched_rr_get_interval;
> +
> + case aarch64_sys_mlock:
> + return gdb_sys_mlock;
> +
> + case aarch64_sys_munlock:
> + return gdb_sys_munlock;
> +
> + case aarch64_sys_mlockall:
> + return gdb_sys_mlockall;
> +
> + case aarch64_sys_munlockall:
> + return gdb_sys_munlockall;
> +
> + case aarch64_sys_vhangup:
> + return gdb_sys_vhangup;
> +
> + case aarch64_sys_prctl:
> + return gdb_sys_prctl;
> +
> + case aarch64_sys_adjtimex:
> + return gdb_sys_adjtimex;
> +
> + case aarch64_sys_setrlimit:
> + return gdb_sys_setrlimit;
> +
> + case aarch64_sys_chroot:
> + return gdb_sys_chroot;
> +
> + case aarch64_sys_sync:
> + return gdb_sys_sync;
> +
> + case aarch64_sys_acct:
> + return gdb_sys_acct;
> +
> + case aarch64_sys_settimeofday:
> + return gdb_sys_settimeofday;
> +
> + case aarch64_sys_mount:
> + return gdb_sys_mount;
> +
> + case aarch64_sys_swapon:
> + return gdb_sys_swapon;
> +
> + case aarch64_sys_swapoff:
> + return gdb_sys_swapoff;
> +
> + case aarch64_sys_reboot:
> + return gdb_sys_reboot;
> +
> + case aarch64_sys_sethostname:
> + return gdb_sys_sethostname;
> +
> + case aarch64_sys_setdomainname:
> + return gdb_sys_setdomainname;
> +
> + case aarch64_sys_init_module:
> + return gdb_sys_init_module;
> +
> + case aarch64_sys_delete_module:
> + return gdb_sys_delete_module;
> +
> + case aarch64_sys_quotactl:
> + return gdb_sys_quotactl;
> +
> + case aarch64_sys_nfsservctl:
> + return gdb_sys_nfsservctl;
> +
> + case aarch64_sys_gettid:
> + return gdb_sys_gettid;
> +
> + case aarch64_sys_readahead:
> + return gdb_sys_readahead;
> +
> + case aarch64_sys_setxattr:
> + return gdb_sys_setxattr;
> +
> + case aarch64_sys_lsetxattr:
> + return gdb_sys_lsetxattr;
> +
> + case aarch64_sys_fsetxattr:
> + return gdb_sys_fsetxattr;
> +
> + case aarch64_sys_getxattr:
> + return gdb_sys_getxattr;
> +
> + case aarch64_sys_lgetxattr:
> + return gdb_sys_lgetxattr;
> +
> + case aarch64_sys_fgetxattr:
> + return gdb_sys_fgetxattr;
> +
> + case aarch64_sys_listxattr:
> + return gdb_sys_listxattr;
> +
> + case aarch64_sys_llistxattr:
> + return gdb_sys_llistxattr;
> +
> + case aarch64_sys_flistxattr:
> + return gdb_sys_flistxattr;
> +
> + case aarch64_sys_removexattr:
> + return gdb_sys_removexattr;
> +
> + case aarch64_sys_lremovexattr:
> + return gdb_sys_lremovexattr;
> +
> + case aarch64_sys_fremovexattr:
> + return gdb_sys_fremovexattr;
> +
> + case aarch64_sys_tkill:
> + return gdb_sys_tkill;
> +
> + case aarch64_sys_times:
> + return gdb_sys_times;
> +
> + case aarch64_sys_futex:
> + return gdb_sys_futex;
> +
> + case aarch64_sys_sched_setaffinity:
> + return gdb_sys_sched_setaffinity;
> +
> + case aarch64_sys_sched_getaffinity:
> + return gdb_sys_sched_getaffinity;
> +
> + case aarch64_sys_io_setup:
> + return gdb_sys_io_setup;
> +
> + case aarch64_sys_io_destroy:
> + return gdb_sys_io_destroy;
> +
> + case aarch64_sys_io_getevents:
> + return gdb_sys_io_getevents;
> +
> + case aarch64_sys_io_submit:
> + return gdb_sys_io_submit;
> +
> + case aarch64_sys_io_cancel:
> + return gdb_sys_io_cancel;
> +
> + case aarch64_sys_lookup_dcookie:
> + return gdb_sys_lookup_dcookie;
> +
> + case aarch64_sys_epoll_create1:
> + return gdb_sys_epoll_create;
> +
> + case aarch64_sys_remap_file_pages:
> + return gdb_sys_remap_file_pages;
> +
> + case aarch64_sys_getdents64:
> + return gdb_sys_getdents64;
> +
> + case aarch64_sys_set_tid_address:
> + return gdb_sys_set_tid_address;
> +
> + case aarch64_sys_semtimedop:
> + return gdb_sys_semtimedop;
> +
> + case aarch64_sys_fadvise64:
> + return gdb_sys_fadvise64;
> +
> + case aarch64_sys_timer_create:
> + return gdb_sys_timer_create;
> +
> + case aarch64_sys_timer_settime:
> + return gdb_sys_timer_settime;
> +
> + case aarch64_sys_timer_gettime:
> + return gdb_sys_timer_gettime;
> +
> + case aarch64_sys_timer_getoverrun:
> + return gdb_sys_timer_getoverrun;
> +
> + case aarch64_sys_timer_delete:
> + return gdb_sys_timer_delete;
> +
> + case aarch64_sys_clock_settime:
> + return gdb_sys_clock_settime;
> +
> + case aarch64_sys_clock_gettime:
> + return gdb_sys_clock_gettime;
> +
> + case aarch64_sys_clock_getres:
> + return gdb_sys_clock_getres;
> +
> + case aarch64_sys_clock_nanosleep:
> + return gdb_sys_clock_nanosleep;
> +
> + case aarch64_sys_exit_group:
> + return gdb_sys_exit_group;
> +
> + case aarch64_sys_epoll_pwait:
> + return gdb_sys_epoll_pwait;
> +
> + case aarch64_sys_epoll_ctl:
> + return gdb_sys_epoll_ctl;
> +
> + case aarch64_sys_tgkill:
> + return gdb_sys_tgkill;
> +
> + case aarch64_sys_mbind:
> + return gdb_sys_mbind;
> +
> + case aarch64_sys_set_mempolicy:
> + return gdb_sys_set_mempolicy;
> +
> + case aarch64_sys_get_mempolicy:
> + return gdb_sys_get_mempolicy;
> +
> + case aarch64_sys_mq_open:
> + return gdb_sys_mq_open;
> +
> + case aarch64_sys_mq_unlink:
> + return gdb_sys_mq_unlink;
> +
> + case aarch64_sys_mq_timedsend:
> + return gdb_sys_mq_timedsend;
> +
> + case aarch64_sys_mq_timedreceive:
> + return gdb_sys_mq_timedreceive;
> +
> + case aarch64_sys_mq_notify:
> + return gdb_sys_mq_notify;
> +
> + case aarch64_sys_mq_getsetattr:
> + return gdb_sys_mq_getsetattr;
> +
> + case aarch64_sys_kexec_load:
> + return gdb_sys_kexec_load;
> +
> + case aarch64_sys_waitid:
> + return gdb_sys_waitid;
> +
> + case aarch64_sys_add_key:
> + return gdb_sys_add_key;
> +
> + case aarch64_sys_request_key:
> + return gdb_sys_request_key;
> +
> + case aarch64_sys_keyctl:
> + return gdb_sys_keyctl;
> +
> + case aarch64_sys_ioprio_set:
> + return gdb_sys_ioprio_set;
> +
> + case aarch64_sys_ioprio_get:
> + return gdb_sys_ioprio_get;
> +
> + case aarch64_sys_inotify_add_watch:
> + return gdb_sys_inotify_add_watch;
> +
> + case aarch64_sys_inotify_rm_watch:
> + return gdb_sys_inotify_rm_watch;
> +
> + case aarch64_sys_migrate_pages:
> + return gdb_sys_migrate_pages;
> +
> + case aarch64_sys_pselect6:
> + return gdb_sys_pselect6;
> +
> + case aarch64_sys_ppoll:
> + return gdb_sys_ppoll;
> +
> + case aarch64_sys_unshare:
> + return gdb_sys_unshare;
> +
> + case aarch64_sys_set_robust_list:
> + return gdb_sys_set_robust_list;
> +
> + case aarch64_sys_get_robust_list:
> + return gdb_sys_get_robust_list;
> +
> + case aarch64_sys_splice:
> + return gdb_sys_splice;
> +
> + case aarch64_sys_tee:
> + return gdb_sys_tee;
> +
> + case aarch64_sys_sync_file_range:
> + return gdb_sys_sync_file_range;
> +
> + case aarch64_sys_vmsplice:
> + return gdb_sys_vmsplice;
> +
> + case aarch64_sys_move_pages:
> + return gdb_sys_move_pages;
> +
> + default:
> + return -1;
> + }
> +}
> +
> +/* Record all registers but PC register for process-record. */
> +
> +static int
> +aarch64_all_but_pc_registers_record (struct regcache *regcache)
> +{
> + int i;
> +
> + for (i = 0; i < AARCH64_PC_REGNUM; i++)
> + if (record_full_arch_list_add_reg (regcache, AARCH64_X0_REGNUM + i))
> + return -1;
> +
> + if (record_full_arch_list_add_reg (regcache, AARCH64_CPSR_REGNUM))
> + return -1;
> +
> + return 0;
> +}
> +
> +/* Handler for arm system call instruction recording. */
> +
> +static int
> +aarch64_linux_syscall_record (struct regcache *regcache, unsigned long svc_number)
> +{
> + int ret = 0;
> + enum gdb_syscall syscall_gdb;
> +
> + printf_unfiltered (_("syscall number %s\n"),
> + plongest (svc_number));
> + syscall_gdb = aarch64_canonicalize_syscall (svc_number);
> +
> + if (syscall_gdb < 0)
> + {
> + printf_unfiltered (_("Process record and replay target doesn't "
> + "support syscall number %s\n"),
> + plongest (svc_number));
> + return -1;
> + }
> +
> + if (syscall_gdb == gdb_sys_sigreturn
> + || syscall_gdb == gdb_sys_rt_sigreturn)
> + {
> + if (aarch64_all_but_pc_registers_record (regcache))
> + return -1;
> + return 0;
> + }
> +
> + ret = record_linux_system_call (syscall_gdb, regcache,
> + &aarch64_linux_record_tdep);
> + if (ret != 0)
> + return ret;
> +
> + /* Record the return value of the system call. */
> + if (record_full_arch_list_add_reg (regcache, AARCH64_X0_REGNUM))
> + return -1;
> + /* Record LR. */
> + if (record_full_arch_list_add_reg (regcache, AARCH64_LR_REGNUM))
> + return -1;
> + /* Record CPSR. */
> + if (record_full_arch_list_add_reg (regcache, AARCH64_CPSR_REGNUM))
> + return -1;
> +
> + return 0;
> +}
> +
> static void
> aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
> {
> @@ -404,6 +1153,170 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>
> /* Reversible debugging, process record. */
> set_gdbarch_process_record (gdbarch, aarch64_process_record);
> + /* Syscall record. */
> + tdep->aarch64_syscall_record = aarch64_linux_syscall_record;
> +
> + /* Initialize the aarch64_linux_record_tdep. */
> + /* These values are the size of the type that will be used in a system
> + call. They are obtained from Linux Kernel source. */
> + aarch64_linux_record_tdep.size_pointer
> + = gdbarch_ptr_bit (gdbarch) / TARGET_CHAR_BIT;
> + aarch64_linux_record_tdep.size__old_kernel_stat = 32;
> + aarch64_linux_record_tdep.size_tms = 32;
> + aarch64_linux_record_tdep.size_loff_t = 8;
> + aarch64_linux_record_tdep.size_flock = 32;
> + aarch64_linux_record_tdep.size_oldold_utsname = 45;
> + aarch64_linux_record_tdep.size_ustat = 32;
> + aarch64_linux_record_tdep.size_old_sigaction = 152;
> + aarch64_linux_record_tdep.size_old_sigset_t = 128;
> + aarch64_linux_record_tdep.size_rlimit = 16;
> + aarch64_linux_record_tdep.size_rusage = 144;
> + aarch64_linux_record_tdep.size_timeval = 16;
> + aarch64_linux_record_tdep.size_timezone = 8;
> + aarch64_linux_record_tdep.size_old_gid_t = 2;
> + aarch64_linux_record_tdep.size_old_uid_t = 2;
> + aarch64_linux_record_tdep.size_fd_set = 128;
> + aarch64_linux_record_tdep.size_dirent = 280;
> + aarch64_linux_record_tdep.size_dirent64 = 280;
> + aarch64_linux_record_tdep.size_statfs = 120;
> + aarch64_linux_record_tdep.size_statfs64 = 120;
> + aarch64_linux_record_tdep.size_sockaddr = 16;
> + aarch64_linux_record_tdep.size_int
> + = gdbarch_int_bit (gdbarch) / TARGET_CHAR_BIT;
> + aarch64_linux_record_tdep.size_long
> + = gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
> + aarch64_linux_record_tdep.size_ulong
> + = gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
> + aarch64_linux_record_tdep.size_msghdr = 56;
> + aarch64_linux_record_tdep.size_itimerval = 32;
> + aarch64_linux_record_tdep.size_stat = 144;
> + aarch64_linux_record_tdep.size_old_utsname = 325;
> + aarch64_linux_record_tdep.size_sysinfo = 112;
> + aarch64_linux_record_tdep.size_msqid_ds = 120;
> + aarch64_linux_record_tdep.size_shmid_ds = 112;
> + aarch64_linux_record_tdep.size_new_utsname = 390;
> + aarch64_linux_record_tdep.size_timex = 208;
> + aarch64_linux_record_tdep.size_mem_dqinfo = 24;
> + aarch64_linux_record_tdep.size_if_dqblk = 72;
> + aarch64_linux_record_tdep.size_fs_quota_stat = 80;
> + aarch64_linux_record_tdep.size_timespec = 16;
> + aarch64_linux_record_tdep.size_pollfd = 8;
> + aarch64_linux_record_tdep.size_NFS_FHSIZE = 32;
> + aarch64_linux_record_tdep.size_knfsd_fh = 132;
> + aarch64_linux_record_tdep.size_TASK_COMM_LEN = 16;
> + aarch64_linux_record_tdep.size_sigaction = 152;
> + aarch64_linux_record_tdep.size_sigset_t = 128;
> + aarch64_linux_record_tdep.size_siginfo_t = 128;
> + aarch64_linux_record_tdep.size_cap_user_data_t = 8;
> + aarch64_linux_record_tdep.size_stack_t = 24;
> + aarch64_linux_record_tdep.size_off_t = 8;
> + aarch64_linux_record_tdep.size_stat64 = 144;
> + aarch64_linux_record_tdep.size_gid_t = 4;
> + aarch64_linux_record_tdep.size_uid_t = 4;
> + aarch64_linux_record_tdep.size_PAGE_SIZE = 4096;
> + aarch64_linux_record_tdep.size_flock64 = 32;
> + aarch64_linux_record_tdep.size_user_desc = 16;
> + aarch64_linux_record_tdep.size_io_event = 32;
> + aarch64_linux_record_tdep.size_iocb = 64;
> + aarch64_linux_record_tdep.size_epoll_event = 12;
> + aarch64_linux_record_tdep.size_itimerspec = 32;
> + aarch64_linux_record_tdep.size_mq_attr = 64;
> + aarch64_linux_record_tdep.size_siginfo = 128;
> + aarch64_linux_record_tdep.size_termios = 60;
> + aarch64_linux_record_tdep.size_termios2 = 44;
> + aarch64_linux_record_tdep.size_pid_t = 4;
> + aarch64_linux_record_tdep.size_winsize = 8;
> + aarch64_linux_record_tdep.size_serial_struct = 72;
> + aarch64_linux_record_tdep.size_serial_icounter_struct = 80;
> + aarch64_linux_record_tdep.size_hayes_esp_config = 12;
> + aarch64_linux_record_tdep.size_size_t = 8;
> + aarch64_linux_record_tdep.size_iovec = 16;
> +
> + /* These values are the second argument of system call "sys_ioctl".
> + They are obtained from Linux Kernel source. */
> + aarch64_linux_record_tdep.ioctl_TCGETS = 0x5401;
> + aarch64_linux_record_tdep.ioctl_TCSETS = 0x5402;
> + aarch64_linux_record_tdep.ioctl_TCSETSW = 0x5403;
> + aarch64_linux_record_tdep.ioctl_TCSETSF = 0x5404;
> + aarch64_linux_record_tdep.ioctl_TCGETA = 0x5405;
> + aarch64_linux_record_tdep.ioctl_TCSETA = 0x5406;
> + aarch64_linux_record_tdep.ioctl_TCSETAW = 0x5407;
> + aarch64_linux_record_tdep.ioctl_TCSETAF = 0x5408;
> + aarch64_linux_record_tdep.ioctl_TCSBRK = 0x5409;
> + aarch64_linux_record_tdep.ioctl_TCXONC = 0x540a;
> + aarch64_linux_record_tdep.ioctl_TCFLSH = 0x540b;
> + aarch64_linux_record_tdep.ioctl_TIOCEXCL = 0x540c;
> + aarch64_linux_record_tdep.ioctl_TIOCNXCL = 0x540d;
> + aarch64_linux_record_tdep.ioctl_TIOCSCTTY = 0x540e;
> + aarch64_linux_record_tdep.ioctl_TIOCGPGRP = 0x540f;
> + aarch64_linux_record_tdep.ioctl_TIOCSPGRP = 0x5410;
> + aarch64_linux_record_tdep.ioctl_TIOCOUTQ = 0x5411;
> + aarch64_linux_record_tdep.ioctl_TIOCSTI = 0x5412;
> + aarch64_linux_record_tdep.ioctl_TIOCGWINSZ = 0x5413;
> + aarch64_linux_record_tdep.ioctl_TIOCSWINSZ = 0x5414;
> + aarch64_linux_record_tdep.ioctl_TIOCMGET = 0x5415;
> + aarch64_linux_record_tdep.ioctl_TIOCMBIS = 0x5416;
> + aarch64_linux_record_tdep.ioctl_TIOCMBIC = 0x5417;
> + aarch64_linux_record_tdep.ioctl_TIOCMSET = 0x5418;
> + aarch64_linux_record_tdep.ioctl_TIOCGSOFTCAR = 0x5419;
> + aarch64_linux_record_tdep.ioctl_TIOCSSOFTCAR = 0x541a;
> + aarch64_linux_record_tdep.ioctl_FIONREAD = 0x541b;
> + aarch64_linux_record_tdep.ioctl_TIOCINQ = 0x541b;
> + aarch64_linux_record_tdep.ioctl_TIOCLINUX = 0x541c;
> + aarch64_linux_record_tdep.ioctl_TIOCCONS = 0x541d;
> + aarch64_linux_record_tdep.ioctl_TIOCGSERIAL = 0x541e;
> + aarch64_linux_record_tdep.ioctl_TIOCSSERIAL = 0x541f;
> + aarch64_linux_record_tdep.ioctl_TIOCPKT = 0x5420;
> + aarch64_linux_record_tdep.ioctl_FIONBIO = 0x5421;
> + aarch64_linux_record_tdep.ioctl_TIOCNOTTY = 0x5422;
> + aarch64_linux_record_tdep.ioctl_TIOCSETD = 0x5423;
> + aarch64_linux_record_tdep.ioctl_TIOCGETD = 0x5424;
> + aarch64_linux_record_tdep.ioctl_TCSBRKP = 0x5425;
> + aarch64_linux_record_tdep.ioctl_TIOCTTYGSTRUCT = 0x5426;
> + aarch64_linux_record_tdep.ioctl_TIOCSBRK = 0x5427;
> + aarch64_linux_record_tdep.ioctl_TIOCCBRK = 0x5428;
> + aarch64_linux_record_tdep.ioctl_TIOCGSID = 0x5429;
> + aarch64_linux_record_tdep.ioctl_TCGETS2 = 0x802c542a;
> + aarch64_linux_record_tdep.ioctl_TCSETS2 = 0x402c542b;
> + aarch64_linux_record_tdep.ioctl_TCSETSW2 = 0x402c542c;
> + aarch64_linux_record_tdep.ioctl_TCSETSF2 = 0x402c542d;
> + aarch64_linux_record_tdep.ioctl_TIOCGPTN = 0x80045430;
> + aarch64_linux_record_tdep.ioctl_TIOCSPTLCK = 0x40045431;
> + aarch64_linux_record_tdep.ioctl_FIONCLEX = 0x5450;
> + aarch64_linux_record_tdep.ioctl_FIOCLEX = 0x5451;
> + aarch64_linux_record_tdep.ioctl_FIOASYNC = 0x5452;
> + aarch64_linux_record_tdep.ioctl_TIOCSERCONFIG = 0x5453;
> + aarch64_linux_record_tdep.ioctl_TIOCSERGWILD = 0x5454;
> + aarch64_linux_record_tdep.ioctl_TIOCSERSWILD = 0x5455;
> + aarch64_linux_record_tdep.ioctl_TIOCGLCKTRMIOS = 0x5456;
> + aarch64_linux_record_tdep.ioctl_TIOCSLCKTRMIOS = 0x5457;
> + aarch64_linux_record_tdep.ioctl_TIOCSERGSTRUCT = 0x5458;
> + aarch64_linux_record_tdep.ioctl_TIOCSERGETLSR = 0x5459;
> + aarch64_linux_record_tdep.ioctl_TIOCSERGETMULTI = 0x545a;
> + aarch64_linux_record_tdep.ioctl_TIOCSERSETMULTI = 0x545b;
> + aarch64_linux_record_tdep.ioctl_TIOCMIWAIT = 0x545c;
> + aarch64_linux_record_tdep.ioctl_TIOCGICOUNT = 0x545d;
> + aarch64_linux_record_tdep.ioctl_TIOCGHAYESESP = 0x545e;
> + aarch64_linux_record_tdep.ioctl_TIOCSHAYESESP = 0x545f;
> + aarch64_linux_record_tdep.ioctl_FIOQSIZE = 0x5460;
> +
> + /* These values are the second argument of system call "sys_fcntl"
> + and "sys_fcntl64". They are obtained from Linux Kernel source. */
> + aarch64_linux_record_tdep.fcntl_F_GETLK = 5;
> + aarch64_linux_record_tdep.fcntl_F_GETLK64 = 12;
> + aarch64_linux_record_tdep.fcntl_F_SETLK64 = 13;
> + aarch64_linux_record_tdep.fcntl_F_SETLKW64 = 14;
> +
> + /* The AArch64 syscall calling convention: reg x0-x7 for arguments,
> + reg x8 for syscall number and return value in reg x0. */
> + aarch64_linux_record_tdep.arg1 = AARCH64_X0_REGNUM + 0;
> + aarch64_linux_record_tdep.arg2 = AARCH64_X0_REGNUM + 1;
> + aarch64_linux_record_tdep.arg3 = AARCH64_X0_REGNUM + 2;
> + aarch64_linux_record_tdep.arg4 = AARCH64_X0_REGNUM + 3;
> + aarch64_linux_record_tdep.arg5 = AARCH64_X0_REGNUM + 4;
> + aarch64_linux_record_tdep.arg6 = AARCH64_X0_REGNUM + 5;
> + aarch64_linux_record_tdep.arg7 = AARCH64_X0_REGNUM + 6;
> + aarch64_linux_record_tdep.arg8 = AARCH64_X0_REGNUM + 7;
> }
>
> /* Provide a prototype to silence -Wmissing-prototypes. */
> diff --git a/gdb/aarch64-linux-tdep.h b/gdb/aarch64-linux-tdep.h
> index 2e1de60..1ae3786 100644
> --- a/gdb/aarch64-linux-tdep.h
> +++ b/gdb/aarch64-linux-tdep.h
> @@ -32,3 +32,269 @@
>
> extern const struct regset aarch64_linux_gregset;
> extern const struct regset aarch64_linux_fpregset;
> +
> +/* Enum that defines the AArch64 linux specific syscall identifiers used for
> + process record/replay. */
> +
> +enum aarch64_syscall {
> + aarch64_sys_io_setup = 0,
> + aarch64_sys_io_destroy = 1,
> + aarch64_sys_io_submit = 2,
> + aarch64_sys_io_cancel = 3,
> + aarch64_sys_io_getevents = 4,
> + aarch64_sys_setxattr = 5,
> + aarch64_sys_lsetxattr = 6,
> + aarch64_sys_fsetxattr = 7,
> + aarch64_sys_getxattr = 8,
> + aarch64_sys_lgetxattr = 9,
> + aarch64_sys_fgetxattr = 10,
> + aarch64_sys_listxattr = 11,
> + aarch64_sys_llistxattr = 12,
> + aarch64_sys_flistxattr = 13,
> + aarch64_sys_removexattr = 14,
> + aarch64_sys_lremovexattr = 15,
> + aarch64_sys_fremovexattr = 16,
> + aarch64_sys_getcwd = 17,
> + aarch64_sys_lookup_dcookie = 18,
> + aarch64_sys_eventfd2 = 19,
> + aarch64_sys_epoll_create1 = 20,
> + aarch64_sys_epoll_ctl = 21,
> + aarch64_sys_epoll_pwait = 22,
> + aarch64_sys_dup = 23,
> + aarch64_sys_dup3 = 24,
> + aarch64_sys_fcntl = 25,
> + aarch64_sys_inotify_init1 = 26,
> + aarch64_sys_inotify_add_watch = 27,
> + aarch64_sys_inotify_rm_watch = 28,
> + aarch64_sys_ioctl = 29,
> + aarch64_sys_ioprio_set = 30,
> + aarch64_sys_ioprio_get = 31,
> + aarch64_sys_flock = 32,
> + aarch64_sys_mknod = 33,
> + aarch64_sys_mkdir = 34,
> + aarch64_sys_unlink = 35,
> + aarch64_sys_symlink = 36,
> + aarch64_sys_link = 37,
> + aarch64_sys_rename = 38,
> + aarch64_sys_umount2 = 39,
> + aarch64_sys_mount = 40,
> + aarch64_sys_pivot_root = 41,
> + aarch64_sys_nfsservctl = 42,
> + aarch64_sys_statfs = 43,
> + aarch64_sys_fstatfs = 44,
> + aarch64_sys_truncate = 45,
> + aarch64_sys_ftruncate = 46,
> + aarch64_sys_fallocate = 47,
> + aarch64_sys_faccess = 48,
> + aarch64_sys_chdir = 49,
> + aarch64_sys_fchdir = 50,
> + aarch64_sys_chroot = 51,
> + aarch64_sys_fchmod = 52,
> + aarch64_sys_fchmodat = 53,
> + aarch64_sys_fchownat = 54,
> + aarch64_sys_fchown = 55,
> + aarch64_sys_open = 56,
> + aarch64_sys_close = 57,
> + aarch64_sys_vhangup = 58,
> + aarch64_sys_pipe2 = 59,
> + aarch64_sys_quotactl = 60,
> + aarch64_sys_getdents64 = 61,
> + aarch64_sys_lseek = 62,
> + aarch64_sys_read = 63,
> + aarch64_sys_write = 64,
> + aarch64_sys_readv = 65,
> + aarch64_sys_writev = 66,
> + aarch64_sys_pread64 = 67,
> + aarch64_sys_pwrite64 = 68,
> + aarch64_sys_preadv = 69,
> + aarch64_sys_pwritev = 70,
> + aarch64_sys_sendfile = 71,
> + aarch64_sys_pselect6 = 72,
> + aarch64_sys_ppoll = 73,
> + aarch64_sys_signalfd4 = 74,
> + aarch64_sys_vmsplice = 75,
> + aarch64_sys_splice = 76,
> + aarch64_sys_tee = 77,
> + aarch64_sys_readlink = 78,
> + aarch64_sys_fstatat = 79,
> + aarch64_sys_fstat = 80,
> + aarch64_sys_sync = 81,
> + aarch64_sys_fsync = 82,
> + aarch64_sys_fdatasync = 83,
> + aarch64_sys_sync_file_range2 = 84,
> + aarch64_sys_sync_file_range = 84,
> + aarch64_sys_timerfd_create = 85,
> + aarch64_sys_timerfd_settime = 86,
> + aarch64_sys_timerfd_gettime = 87,
> + aarch64_sys_utimensat = 88,
> + aarch64_sys_acct = 89,
> + aarch64_sys_capget = 90,
> + aarch64_sys_capset = 91,
> + aarch64_sys_personality = 92,
> + aarch64_sys_exit = 93,
> + aarch64_sys_exit_group = 94,
> + aarch64_sys_waitid = 95,
> + aarch64_sys_set_tid_address = 96,
> + aarch64_sys_unshare = 97,
> + aarch64_sys_futex = 98,
> + aarch64_sys_set_robust_list = 99,
> + aarch64_sys_get_robust_list = 100,
> + aarch64_sys_nanosleep = 101,
> + aarch64_sys_getitimer = 102,
> + aarch64_sys_setitimer = 103,
> + aarch64_sys_kexec_load = 104,
> + aarch64_sys_init_module = 105,
> + aarch64_sys_delete_module = 106,
> + aarch64_sys_timer_create = 107,
> + aarch64_sys_timer_gettime = 108,
> + aarch64_sys_timer_getoverrun = 109,
> + aarch64_sys_timer_settime = 110,
> + aarch64_sys_timer_delete = 111,
> + aarch64_sys_clock_settime = 112,
> + aarch64_sys_clock_gettime = 113,
> + aarch64_sys_clock_getres = 114,
> + aarch64_sys_clock_nanosleep = 115,
> + aarch64_sys_syslog = 116,
> + aarch64_sys_ptrace = 117,
> + aarch64_sys_sched_setparam = 118,
> + aarch64_sys_sched_setscheduler = 119,
> + aarch64_sys_sched_getscheduler = 120,
> + aarch64_sys_sched_getparam = 121,
> + aarch64_sys_sched_setaffinity = 122,
> + aarch64_sys_sched_getaffinity = 123,
> + aarch64_sys_sched_yield = 124,
> + aarch64_sys_sched_get_priority_max = 125,
> + aarch64_sys_sched_get_priority_min = 126,
> + aarch64_sys_sched_rr_get_interval = 127,
> + aarch64_sys_kill = 129,
> + aarch64_sys_tkill = 130,
> + aarch64_sys_tgkill = 131,
> + aarch64_sys_sigaltstack = 132,
> + aarch64_sys_rt_sigsuspend = 133,
> + aarch64_sys_rt_sigaction = 134,
> + aarch64_sys_rt_sigprocmask = 135,
> + aarch64_sys_rt_sigpending = 136,
> + aarch64_sys_rt_sigtimedwait = 137,
> + aarch64_sys_rt_sigqueueinfo = 138,
> + aarch64_sys_rt_sigreturn = 139,
> + aarch64_sys_setpriority = 140,
> + aarch64_sys_getpriority = 141,
> + aarch64_sys_reboot = 142,
> + aarch64_sys_setregid = 143,
> + aarch64_sys_setgid = 144,
> + aarch64_sys_setreuid = 145,
> + aarch64_sys_setuid = 146,
> + aarch64_sys_setresuid = 147,
> + aarch64_sys_getresuid = 148,
> + aarch64_sys_setresgid = 149,
> + aarch64_sys_getresgid = 150,
> + aarch64_sys_setfsuid = 151,
> + aarch64_sys_setfsgid = 152,
> + aarch64_sys_times = 153,
> + aarch64_sys_setpgid = 154,
> + aarch64_sys_getpgid = 155,
> + aarch64_sys_getsid = 156,
> + aarch64_sys_setsid = 157,
> + aarch64_sys_getgroups = 158,
> + aarch64_sys_setgroups = 159,
> + aarch64_sys_uname = 160,
> + aarch64_sys_sethostname = 161,
> + aarch64_sys_setdomainname = 162,
> + aarch64_sys_getrlimit = 163,
> + aarch64_sys_setrlimit = 164,
> + aarch64_sys_getrusage = 165,
> + aarch64_sys_umask = 166,
> + aarch64_sys_prctl = 167,
> + aarch64_sys_getcpu = 168,
> + aarch64_sys_gettimeofday = 169,
> + aarch64_sys_settimeofday = 170,
> + aarch64_sys_adjtimex = 171,
> + aarch64_sys_getpid = 172,
> + aarch64_sys_getppid = 173,
> + aarch64_sys_getuid = 174,
> + aarch64_sys_geteuid = 175,
> + aarch64_sys_getgid = 176,
> + aarch64_sys_getegid = 177,
> + aarch64_sys_gettid = 178,
> + aarch64_sys_sysinfo = 179,
> + aarch64_sys_mq_open = 180,
> + aarch64_sys_mq_unlink = 181,
> + aarch64_sys_mq_timedsend = 182,
> + aarch64_sys_mq_timedreceive = 183,
> + aarch64_sys_mq_notify = 184,
> + aarch64_sys_mq_getsetattr = 185,
> + aarch64_sys_msgget = 186,
> + aarch64_sys_msgctl = 187,
> + aarch64_sys_msgrcv = 188,
> + aarch64_sys_msgsnd = 189,
> + aarch64_sys_semget = 190,
> + aarch64_sys_semctl = 191,
> + aarch64_sys_semtimedop = 192,
> + aarch64_sys_semop = 193,
> + aarch64_sys_shmget = 194,
> + aarch64_sys_shmctl = 195,
> + aarch64_sys_shmat = 196,
> + aarch64_sys_shmdt = 197,
> + aarch64_sys_socket = 198,
> + aarch64_sys_socketpair = 199,
> + aarch64_sys_bind = 200,
> + aarch64_sys_listen = 201,
> + aarch64_sys_accept = 202,
> + aarch64_sys_connect = 203,
> + aarch64_sys_getsockname = 204,
> + aarch64_sys_getpeername = 205,
> + aarch64_sys_sendto = 206,
> + aarch64_sys_recvfrom = 207,
> + aarch64_sys_setsockopt = 208,
> + aarch64_sys_getsockopt = 209,
> + aarch64_sys_shutdown = 210,
> + aarch64_sys_sendmsg = 211,
> + aarch64_sys_recvmsg = 212,
> + aarch64_sys_readahead = 213,
> + aarch64_sys_brk = 214,
> + aarch64_sys_munmap = 215,
> + aarch64_sys_mremap = 216,
> + aarch64_sys_add_key = 217,
> + aarch64_sys_request_key = 218,
> + aarch64_sys_keyctl = 219,
> + aarch64_sys_clone = 220,
> + aarch64_sys_execve = 221,
> + aarch64_sys_mmap = 222,
> + aarch64_sys_fadvise64 = 223,
> + aarch64_sys_swapon = 224,
> + aarch64_sys_swapoff = 225,
> + aarch64_sys_mprotect = 226,
> + aarch64_sys_msync = 227,
> + aarch64_sys_mlock = 228,
> + aarch64_sys_munlock = 229,
> + aarch64_sys_mlockall = 230,
> + aarch64_sys_munlockall = 231,
> + aarch64_sys_mincore = 232,
> + aarch64_sys_madvise = 233,
> + aarch64_sys_remap_file_pages = 234,
> + aarch64_sys_mbind = 235,
> + aarch64_sys_get_mempolicy = 236,
> + aarch64_sys_set_mempolicy = 237,
> + aarch64_sys_migrate_pages = 238,
> + aarch64_sys_move_pages = 239,
> + aarch64_sys_rt_tgsigqueueinfo = 240,
> + aarch64_sys_perf_event_open = 241,
> + aarch64_sys_accept4 = 242,
> + aarch64_sys_recvmmsg = 243,
> + aarch64_sys_wait4 = 260,
> + aarch64_sys_prlimit64 = 261,
> + aarch64_sys_fanotify_init = 262,
> + aarch64_sys_fanotify_mark = 263,
> + aarch64_sys_name_to_handle_at = 264,
> + aarch64_sys_open_by_handle_at = 265,
> + aarch64_sys_clock_adjtime = 266,
> + aarch64_sys_syncfs = 267,
> + aarch64_sys_setns = 268,
> + aarch64_sys_sendmmsg = 269,
> + aarch64_sys_process_vm_readv = 270,
> + aarch64_sys_process_vm_writev = 271,
> + aarch64_sys_kcmp = 272,
> + aarch64_sys_finit_module = 273,
> + aarch64_sys_sched_setattr = 274,
> + aarch64_sys_sched_getattr = 275,
> +};
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index 0847585..c6da25a 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -2941,7 +2941,20 @@ aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
> {
> /* Exception generation instructions. */
> if (insn_bits24_27 == 0x04)
> - return AARCH64_RECORD_UNSUPPORTED;
> + {
> + if (!bits (aarch64_insn_r->aarch64_insn, 2, 4) &&
> + !bits (aarch64_insn_r->aarch64_insn, 21, 23) &&
> + bits (aarch64_insn_r->aarch64_insn, 0, 1) == 0x01)
> + {
> + ULONGEST svc_number;
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, 8,
> + &svc_number);
> + return tdep->aarch64_syscall_record (aarch64_insn_r->regcache,
> + svc_number);
> + }
> + else
> + return AARCH64_RECORD_UNSUPPORTED;
> + }
> /* System instructions. */
> else if (insn_bits24_27 == 0x05 && insn_bits22_23 == 0x00)
> {
> diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
> index 1d74ef8..25751fe 100644
> --- a/gdb/aarch64-tdep.h
> +++ b/gdb/aarch64-tdep.h
> @@ -88,6 +88,9 @@ struct gdbarch_tdep
> struct type *vns_type;
> struct type *vnh_type;
> struct type *vnb_type;
> +
> + /* syscall record. */
> + int (*aarch64_syscall_record) (struct regcache *regcache, unsigned long svc_number);
> };
>
> /* AArch64 process record-replay related structures, defines etc. */
> diff --git a/gdb/linux-record.h b/gdb/linux-record.h
> index 7b5218e..2649ce5 100644
> --- a/gdb/linux-record.h
> +++ b/gdb/linux-record.h
> @@ -174,6 +174,8 @@ struct linux_record_tdep
> int arg4;
> int arg5;
> int arg6;
> + int arg7;
> + int arg8;
> };
>
> /* Enum that defines the gdb-canonical set of Linux syscall identifiers.
> --
> 1.9.1
>
--
Will Newton
Toolchain Working Group, Linaro
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 5/7] Support for recording syscall on aarch64-linux
2014-09-18 0:23 ` Will Newton
@ 2014-09-18 22:28 ` Omair Javaid
2014-10-14 12:47 ` Omair Javaid
0 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-09-18 22:28 UTC (permalink / raw)
To: Will Newton, Pedro Alves; +Cc: gdb-patches
On 18 September 2014 05:22, Will Newton <will.newton@linaro.org> wrote:
> On 29 August 2014 04:53, Omair Javaid <omair.javaid@linaro.org> wrote:
>> Suggestion have been incorporated and updated patch is given below.
>>
>> gdb:
>>
>> 2014-08-28 Omair Javaid <omair.javaid@linaro.org>
>>
>> * aarch64-linux-tdep.c (record.h): Include.
>> (record-full.h): Include.
>> (struct linux_record_tdep aarch64_linux_record_tdep): Declare.
>> (aarch64_canonicalize_syscall): New function to translate syscall
>> numbers from aarch64 to canonical.
>> (aarch64_all_but_pc_registers_record): New function.
>> (aarch64_linux_syscall_record): New function.
>> (aarch64_linux_init_abi): Update to handle syscall recording.
>> * aarch64-linux-tdep.h (aarch64_syscall): New enum.
>> * aarch64-tdep.c (aarch64_record_branch_except_sys): Add code to
>> handle recording of syscalls.
>> * aarch64-tdep.h
>> (struct gdbarch_tdep) <aarch64_syscall_record>: Defined.
>> * linux-record.h (struct linux_record_tdep): Add two more syscall
>> argument fields.
>>
>> ---
>> gdb/aarch64-linux-tdep.c | 913 +++++++++++++++++++++++++++++++++++++++++++++++
>> gdb/aarch64-linux-tdep.h | 266 ++++++++++++++
>> gdb/aarch64-tdep.c | 15 +-
>> gdb/aarch64-tdep.h | 3 +
>> gdb/linux-record.h | 2 +
>> 5 files changed, 1198 insertions(+), 1 deletion(-)
>
> This one looks ok to me now.
>
>> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
>> index 5ab7b37..82b55b6 100644
>> --- a/gdb/aarch64-linux-tdep.c
>> +++ b/gdb/aarch64-linux-tdep.c
>> @@ -41,6 +41,9 @@
>> #include "user-regs.h"
>> #include <ctype.h>
>>
>> +#include "record-full.h"
>> +#include "linux-record.h"
>> +
>> /* Signal frame handling.
>>
>> +------------+ ^
>> @@ -354,6 +357,752 @@ aarch64_stap_parse_special_token (struct gdbarch *gdbarch,
>> return 1;
>> }
>>
>> +/* AArch64 process record-replay constructs: syscall, signal etc. */
>> +
>> +struct linux_record_tdep aarch64_linux_record_tdep;
>> +
>> +/* aarch64_canonicalize_syscall maps syscall ids from the native AArch64
>> + linux set of syscall ids into a canonical set of syscall ids used by
>> + process record. */
>> +
>> +static enum gdb_syscall
>> +aarch64_canonicalize_syscall (enum aarch64_syscall syscall_number)
>> +{
>> + switch (syscall_number) {
>> + case aarch64_sys_read:
>> + return gdb_sys_read;
>> +
>> + case aarch64_sys_write:
>> + return gdb_sys_write;
>> +
>> + case aarch64_sys_open:
>> + return gdb_sys_open;
>> +
>> + case aarch64_sys_close:
>> + return gdb_sys_close;
>> +
>> + case aarch64_sys_lseek:
>> + return gdb_sys_lseek;
>> +
>> + case aarch64_sys_mprotect:
>> + return gdb_sys_mprotect;
>> +
>> + case aarch64_sys_munmap:
>> + return gdb_sys_munmap;
>> +
>> + case aarch64_sys_brk:
>> + return gdb_sys_brk;
>> +
>> + case aarch64_sys_rt_sigaction:
>> + return gdb_sys_rt_sigaction;
>> +
>> + case aarch64_sys_rt_sigprocmask:
>> + return gdb_sys_rt_sigprocmask;
>> +
>> + case aarch64_sys_rt_sigreturn:
>> + return gdb_sys_rt_sigreturn;
>> +
>> + case aarch64_sys_ioctl:
>> + return gdb_sys_ioctl;
>> +
>> + case aarch64_sys_pread64:
>> + return gdb_sys_pread64;
>> +
>> + case aarch64_sys_pwrite64:
>> + return gdb_sys_pwrite64;
>> +
>> + case aarch64_sys_readv:
>> + return gdb_sys_readv;
>> +
>> + case aarch64_sys_writev:
>> + return gdb_sys_writev;
>> +
>> + case aarch64_sys_sched_yield:
>> + return gdb_sys_sched_yield;
>> +
>> + case aarch64_sys_mremap:
>> + return gdb_sys_mremap;
>> +
>> + case aarch64_sys_msync:
>> + return gdb_sys_msync;
>> +
>> + case aarch64_sys_mincore:
>> + return gdb_sys_mincore;
>> +
>> + case aarch64_sys_madvise:
>> + return gdb_sys_madvise;
>> +
>> + case aarch64_sys_shmget:
>> + return gdb_sys_shmget;
>> +
>> + case aarch64_sys_shmat:
>> + return gdb_sys_shmat;
>> +
>> + case aarch64_sys_shmctl:
>> + return gdb_sys_shmctl;
>> +
>> + case aarch64_sys_dup:
>> + return gdb_sys_dup;
>> +
>> + case aarch64_sys_nanosleep:
>> + return gdb_sys_nanosleep;
>> +
>> + case aarch64_sys_getitimer:
>> + return gdb_sys_getitimer;
>> +
>> + case aarch64_sys_setitimer:
>> + return gdb_sys_setitimer;
>> +
>> + case aarch64_sys_getpid:
>> + return gdb_sys_getpid;
>> +
>> + case aarch64_sys_sendfile:
>> + return gdb_sys_sendfile;
>> +
>> + case aarch64_sys_socket:
>> + return gdb_sys_socket;
>> +
>> + case aarch64_sys_connect:
>> + return gdb_sys_connect;
>> +
>> + case aarch64_sys_accept:
>> + return gdb_sys_accept;
>> +
>> + case aarch64_sys_sendto:
>> + return gdb_sys_sendto;
>> +
>> + case aarch64_sys_recvfrom:
>> + return gdb_sys_recvfrom;
>> +
>> + case aarch64_sys_sendmsg:
>> + return gdb_sys_sendmsg;
>> +
>> + case aarch64_sys_recvmsg:
>> + return gdb_sys_recvmsg;
>> +
>> + case aarch64_sys_shutdown:
>> + return gdb_sys_shutdown;
>> +
>> + case aarch64_sys_bind:
>> + return gdb_sys_bind;
>> +
>> + case aarch64_sys_listen:
>> + return gdb_sys_listen;
>> +
>> + case aarch64_sys_getsockname:
>> + return gdb_sys_getsockname;
>> +
>> + case aarch64_sys_getpeername:
>> + return gdb_sys_getpeername;
>> +
>> + case aarch64_sys_socketpair:
>> + return gdb_sys_socketpair;
>> +
>> + case aarch64_sys_setsockopt:
>> + return gdb_sys_setsockopt;
>> +
>> + case aarch64_sys_getsockopt:
>> + return gdb_sys_getsockopt;
>> +
>> + case aarch64_sys_clone:
>> + return gdb_sys_clone;
>> +
>> + case aarch64_sys_execve:
>> + return gdb_sys_execve;
>> +
>> + case aarch64_sys_exit:
>> + return gdb_sys_exit;
>> +
>> + case aarch64_sys_wait4:
>> + return gdb_sys_wait4;
>> +
>> + case aarch64_sys_kill:
>> + return gdb_sys_kill;
>> +
>> + case aarch64_sys_uname:
>> + return gdb_sys_uname;
>> +
>> + case aarch64_sys_semget:
>> + return gdb_sys_semget;
>> +
>> + case aarch64_sys_semop:
>> + return gdb_sys_semop;
>> +
>> + case aarch64_sys_semctl:
>> + return gdb_sys_semctl;
>> +
>> + case aarch64_sys_shmdt:
>> + return gdb_sys_shmdt;
>> +
>> + case aarch64_sys_msgget:
>> + return gdb_sys_msgget;
>> +
>> + case aarch64_sys_msgsnd:
>> + return gdb_sys_msgsnd;
>> +
>> + case aarch64_sys_msgrcv:
>> + return gdb_sys_msgrcv;
>> +
>> + case aarch64_sys_msgctl:
>> + return gdb_sys_msgctl;
>> +
>> + case aarch64_sys_fcntl:
>> + return gdb_sys_fcntl;
>> +
>> + case aarch64_sys_flock:
>> + return gdb_sys_flock;
>> +
>> + case aarch64_sys_fsync:
>> + return gdb_sys_fsync;
>> +
>> + case aarch64_sys_fdatasync:
>> + return gdb_sys_fdatasync;
>> +
>> + case aarch64_sys_truncate:
>> + return gdb_sys_truncate;
>> +
>> + case aarch64_sys_ftruncate:
>> + return gdb_sys_ftruncate;
>> +
>> + case aarch64_sys_getcwd:
>> + return gdb_sys_getcwd;
>> +
>> + case aarch64_sys_chdir:
>> + return gdb_sys_chdir;
>> +
>> + case aarch64_sys_fchdir:
>> + return gdb_sys_fchdir;
>> +
>> + case aarch64_sys_rename:
>> + return gdb_sys_rename;
>> +
>> + case aarch64_sys_mkdir:
>> + return gdb_sys_mkdir;
>> +
>> + case aarch64_sys_link:
>> + return gdb_sys_link;
>> +
>> + case aarch64_sys_unlink:
>> + return gdb_sys_unlink;
>> +
>> + case aarch64_sys_symlink:
>> + return gdb_sys_symlink;
>> +
>> + case aarch64_sys_readlink:
>> + return gdb_sys_readlink;
>> +
>> + case aarch64_sys_fchmodat:
>> + return gdb_sys_fchmodat;
>> +
>> + case aarch64_sys_fchmod:
>> + return gdb_sys_fchmod;
>> +
>> + case aarch64_sys_fchownat:
>> + return gdb_sys_fchownat;
>> +
>> + case aarch64_sys_fchown:
>> + return gdb_sys_fchown;
>> +
>> + case aarch64_sys_umask:
>> + return gdb_sys_umask;
>> +
>> + case aarch64_sys_gettimeofday:
>> + return gdb_sys_gettimeofday;
>> +
>> + case aarch64_sys_getrlimit:
>> + return gdb_sys_getrlimit;
>> +
>> + case aarch64_sys_getrusage:
>> + return gdb_sys_getrusage;
>> +
>> + case aarch64_sys_sysinfo:
>> + return gdb_sys_sysinfo;
>> +
>> + case aarch64_sys_ptrace:
>> + return gdb_sys_ptrace;
>> +
>> + case aarch64_sys_getuid:
>> + return gdb_sys_getuid;
>> +
>> + case aarch64_sys_syslog:
>> + return gdb_sys_syslog;
>> +
>> + case aarch64_sys_getgid:
>> + return gdb_sys_getgid;
>> +
>> + case aarch64_sys_setuid:
>> + return gdb_sys_setuid;
>> +
>> + case aarch64_sys_setgid:
>> + return gdb_sys_setgid;
>> +
>> + case aarch64_sys_geteuid:
>> + return gdb_sys_geteuid;
>> +
>> + case aarch64_sys_getegid:
>> + return gdb_sys_getegid;
>> +
>> + case aarch64_sys_setpgid:
>> + return gdb_sys_setpgid;
>> +
>> + case aarch64_sys_getppid:
>> + return gdb_sys_getppid;
>> +
>> + case aarch64_sys_setsid:
>> + return gdb_sys_setsid;
>> +
>> + case aarch64_sys_setreuid:
>> + return gdb_sys_setreuid;
>> +
>> + case aarch64_sys_setregid:
>> + return gdb_sys_setregid;
>> +
>> + case aarch64_sys_getgroups:
>> + return gdb_sys_getgroups;
>> +
>> + case aarch64_sys_setgroups:
>> + return gdb_sys_setgroups;
>> +
>> + case aarch64_sys_setresuid:
>> + return gdb_sys_setresuid;
>> +
>> + case aarch64_sys_getresuid:
>> + return gdb_sys_getresuid;
>> +
>> + case aarch64_sys_setresgid:
>> + return gdb_sys_setresgid;
>> +
>> + case aarch64_sys_getresgid:
>> + return gdb_sys_getresgid;
>> +
>> + case aarch64_sys_getpgid:
>> + return gdb_sys_getpgid;
>> +
>> + case aarch64_sys_setfsuid:
>> + return gdb_sys_setfsuid;
>> +
>> + case aarch64_sys_setfsgid:
>> + return gdb_sys_setfsgid;
>> +
>> + case aarch64_sys_getsid:
>> + return gdb_sys_getsid;
>> +
>> + case aarch64_sys_capget:
>> + return gdb_sys_capget;
>> +
>> + case aarch64_sys_capset:
>> + return gdb_sys_capset;
>> +
>> + case aarch64_sys_rt_sigpending:
>> + return gdb_sys_rt_sigpending;
>> +
>> + case aarch64_sys_rt_sigtimedwait:
>> + return gdb_sys_rt_sigtimedwait;
>> +
>> + case aarch64_sys_rt_sigqueueinfo:
>> + return gdb_sys_rt_sigqueueinfo;
>> +
>> + case aarch64_sys_rt_sigsuspend:
>> + return gdb_sys_rt_sigsuspend;
>> +
>> + case aarch64_sys_sigaltstack:
>> + return gdb_sys_sigaltstack;
>> +
>> + case aarch64_sys_mknod:
>> + return gdb_sys_mknod;
>> +
>> + case aarch64_sys_personality:
>> + return gdb_sys_personality;
>> +
>> + case aarch64_sys_statfs:
>> + return gdb_sys_statfs;
>> +
>> + case aarch64_sys_fstat:
>> + return gdb_sys_fstat;
>> +
>> + case aarch64_sys_fstatfs:
>> + return gdb_sys_fstatfs;
>> +
>> + case aarch64_sys_getpriority:
>> + return gdb_sys_getpriority;
>> +
>> + case aarch64_sys_setpriority:
>> + return gdb_sys_setpriority;
>> +
>> + case aarch64_sys_sched_setparam:
>> + return gdb_sys_sched_setparam;
>> +
>> + case aarch64_sys_sched_getparam:
>> + return gdb_sys_sched_getparam;
>> +
>> + case aarch64_sys_sched_setscheduler:
>> + return gdb_sys_sched_setscheduler;
>> +
>> + case aarch64_sys_sched_getscheduler:
>> + return gdb_sys_sched_getscheduler;
>> +
>> + case aarch64_sys_sched_get_priority_max:
>> + return gdb_sys_sched_get_priority_max;
>> +
>> + case aarch64_sys_sched_get_priority_min:
>> + return gdb_sys_sched_get_priority_min;
>> +
>> + case aarch64_sys_sched_rr_get_interval:
>> + return gdb_sys_sched_rr_get_interval;
>> +
>> + case aarch64_sys_mlock:
>> + return gdb_sys_mlock;
>> +
>> + case aarch64_sys_munlock:
>> + return gdb_sys_munlock;
>> +
>> + case aarch64_sys_mlockall:
>> + return gdb_sys_mlockall;
>> +
>> + case aarch64_sys_munlockall:
>> + return gdb_sys_munlockall;
>> +
>> + case aarch64_sys_vhangup:
>> + return gdb_sys_vhangup;
>> +
>> + case aarch64_sys_prctl:
>> + return gdb_sys_prctl;
>> +
>> + case aarch64_sys_adjtimex:
>> + return gdb_sys_adjtimex;
>> +
>> + case aarch64_sys_setrlimit:
>> + return gdb_sys_setrlimit;
>> +
>> + case aarch64_sys_chroot:
>> + return gdb_sys_chroot;
>> +
>> + case aarch64_sys_sync:
>> + return gdb_sys_sync;
>> +
>> + case aarch64_sys_acct:
>> + return gdb_sys_acct;
>> +
>> + case aarch64_sys_settimeofday:
>> + return gdb_sys_settimeofday;
>> +
>> + case aarch64_sys_mount:
>> + return gdb_sys_mount;
>> +
>> + case aarch64_sys_swapon:
>> + return gdb_sys_swapon;
>> +
>> + case aarch64_sys_swapoff:
>> + return gdb_sys_swapoff;
>> +
>> + case aarch64_sys_reboot:
>> + return gdb_sys_reboot;
>> +
>> + case aarch64_sys_sethostname:
>> + return gdb_sys_sethostname;
>> +
>> + case aarch64_sys_setdomainname:
>> + return gdb_sys_setdomainname;
>> +
>> + case aarch64_sys_init_module:
>> + return gdb_sys_init_module;
>> +
>> + case aarch64_sys_delete_module:
>> + return gdb_sys_delete_module;
>> +
>> + case aarch64_sys_quotactl:
>> + return gdb_sys_quotactl;
>> +
>> + case aarch64_sys_nfsservctl:
>> + return gdb_sys_nfsservctl;
>> +
>> + case aarch64_sys_gettid:
>> + return gdb_sys_gettid;
>> +
>> + case aarch64_sys_readahead:
>> + return gdb_sys_readahead;
>> +
>> + case aarch64_sys_setxattr:
>> + return gdb_sys_setxattr;
>> +
>> + case aarch64_sys_lsetxattr:
>> + return gdb_sys_lsetxattr;
>> +
>> + case aarch64_sys_fsetxattr:
>> + return gdb_sys_fsetxattr;
>> +
>> + case aarch64_sys_getxattr:
>> + return gdb_sys_getxattr;
>> +
>> + case aarch64_sys_lgetxattr:
>> + return gdb_sys_lgetxattr;
>> +
>> + case aarch64_sys_fgetxattr:
>> + return gdb_sys_fgetxattr;
>> +
>> + case aarch64_sys_listxattr:
>> + return gdb_sys_listxattr;
>> +
>> + case aarch64_sys_llistxattr:
>> + return gdb_sys_llistxattr;
>> +
>> + case aarch64_sys_flistxattr:
>> + return gdb_sys_flistxattr;
>> +
>> + case aarch64_sys_removexattr:
>> + return gdb_sys_removexattr;
>> +
>> + case aarch64_sys_lremovexattr:
>> + return gdb_sys_lremovexattr;
>> +
>> + case aarch64_sys_fremovexattr:
>> + return gdb_sys_fremovexattr;
>> +
>> + case aarch64_sys_tkill:
>> + return gdb_sys_tkill;
>> +
>> + case aarch64_sys_times:
>> + return gdb_sys_times;
>> +
>> + case aarch64_sys_futex:
>> + return gdb_sys_futex;
>> +
>> + case aarch64_sys_sched_setaffinity:
>> + return gdb_sys_sched_setaffinity;
>> +
>> + case aarch64_sys_sched_getaffinity:
>> + return gdb_sys_sched_getaffinity;
>> +
>> + case aarch64_sys_io_setup:
>> + return gdb_sys_io_setup;
>> +
>> + case aarch64_sys_io_destroy:
>> + return gdb_sys_io_destroy;
>> +
>> + case aarch64_sys_io_getevents:
>> + return gdb_sys_io_getevents;
>> +
>> + case aarch64_sys_io_submit:
>> + return gdb_sys_io_submit;
>> +
>> + case aarch64_sys_io_cancel:
>> + return gdb_sys_io_cancel;
>> +
>> + case aarch64_sys_lookup_dcookie:
>> + return gdb_sys_lookup_dcookie;
>> +
>> + case aarch64_sys_epoll_create1:
>> + return gdb_sys_epoll_create;
>> +
>> + case aarch64_sys_remap_file_pages:
>> + return gdb_sys_remap_file_pages;
>> +
>> + case aarch64_sys_getdents64:
>> + return gdb_sys_getdents64;
>> +
>> + case aarch64_sys_set_tid_address:
>> + return gdb_sys_set_tid_address;
>> +
>> + case aarch64_sys_semtimedop:
>> + return gdb_sys_semtimedop;
>> +
>> + case aarch64_sys_fadvise64:
>> + return gdb_sys_fadvise64;
>> +
>> + case aarch64_sys_timer_create:
>> + return gdb_sys_timer_create;
>> +
>> + case aarch64_sys_timer_settime:
>> + return gdb_sys_timer_settime;
>> +
>> + case aarch64_sys_timer_gettime:
>> + return gdb_sys_timer_gettime;
>> +
>> + case aarch64_sys_timer_getoverrun:
>> + return gdb_sys_timer_getoverrun;
>> +
>> + case aarch64_sys_timer_delete:
>> + return gdb_sys_timer_delete;
>> +
>> + case aarch64_sys_clock_settime:
>> + return gdb_sys_clock_settime;
>> +
>> + case aarch64_sys_clock_gettime:
>> + return gdb_sys_clock_gettime;
>> +
>> + case aarch64_sys_clock_getres:
>> + return gdb_sys_clock_getres;
>> +
>> + case aarch64_sys_clock_nanosleep:
>> + return gdb_sys_clock_nanosleep;
>> +
>> + case aarch64_sys_exit_group:
>> + return gdb_sys_exit_group;
>> +
>> + case aarch64_sys_epoll_pwait:
>> + return gdb_sys_epoll_pwait;
>> +
>> + case aarch64_sys_epoll_ctl:
>> + return gdb_sys_epoll_ctl;
>> +
>> + case aarch64_sys_tgkill:
>> + return gdb_sys_tgkill;
>> +
>> + case aarch64_sys_mbind:
>> + return gdb_sys_mbind;
>> +
>> + case aarch64_sys_set_mempolicy:
>> + return gdb_sys_set_mempolicy;
>> +
>> + case aarch64_sys_get_mempolicy:
>> + return gdb_sys_get_mempolicy;
>> +
>> + case aarch64_sys_mq_open:
>> + return gdb_sys_mq_open;
>> +
>> + case aarch64_sys_mq_unlink:
>> + return gdb_sys_mq_unlink;
>> +
>> + case aarch64_sys_mq_timedsend:
>> + return gdb_sys_mq_timedsend;
>> +
>> + case aarch64_sys_mq_timedreceive:
>> + return gdb_sys_mq_timedreceive;
>> +
>> + case aarch64_sys_mq_notify:
>> + return gdb_sys_mq_notify;
>> +
>> + case aarch64_sys_mq_getsetattr:
>> + return gdb_sys_mq_getsetattr;
>> +
>> + case aarch64_sys_kexec_load:
>> + return gdb_sys_kexec_load;
>> +
>> + case aarch64_sys_waitid:
>> + return gdb_sys_waitid;
>> +
>> + case aarch64_sys_add_key:
>> + return gdb_sys_add_key;
>> +
>> + case aarch64_sys_request_key:
>> + return gdb_sys_request_key;
>> +
>> + case aarch64_sys_keyctl:
>> + return gdb_sys_keyctl;
>> +
>> + case aarch64_sys_ioprio_set:
>> + return gdb_sys_ioprio_set;
>> +
>> + case aarch64_sys_ioprio_get:
>> + return gdb_sys_ioprio_get;
>> +
>> + case aarch64_sys_inotify_add_watch:
>> + return gdb_sys_inotify_add_watch;
>> +
>> + case aarch64_sys_inotify_rm_watch:
>> + return gdb_sys_inotify_rm_watch;
>> +
>> + case aarch64_sys_migrate_pages:
>> + return gdb_sys_migrate_pages;
>> +
>> + case aarch64_sys_pselect6:
>> + return gdb_sys_pselect6;
>> +
>> + case aarch64_sys_ppoll:
>> + return gdb_sys_ppoll;
>> +
>> + case aarch64_sys_unshare:
>> + return gdb_sys_unshare;
>> +
>> + case aarch64_sys_set_robust_list:
>> + return gdb_sys_set_robust_list;
>> +
>> + case aarch64_sys_get_robust_list:
>> + return gdb_sys_get_robust_list;
>> +
>> + case aarch64_sys_splice:
>> + return gdb_sys_splice;
>> +
>> + case aarch64_sys_tee:
>> + return gdb_sys_tee;
>> +
>> + case aarch64_sys_sync_file_range:
>> + return gdb_sys_sync_file_range;
>> +
>> + case aarch64_sys_vmsplice:
>> + return gdb_sys_vmsplice;
>> +
>> + case aarch64_sys_move_pages:
>> + return gdb_sys_move_pages;
>> +
>> + default:
>> + return -1;
>> + }
>> +}
>> +
>> +/* Record all registers but PC register for process-record. */
>> +
>> +static int
>> +aarch64_all_but_pc_registers_record (struct regcache *regcache)
>> +{
>> + int i;
>> +
>> + for (i = 0; i < AARCH64_PC_REGNUM; i++)
>> + if (record_full_arch_list_add_reg (regcache, AARCH64_X0_REGNUM + i))
>> + return -1;
>> +
>> + if (record_full_arch_list_add_reg (regcache, AARCH64_CPSR_REGNUM))
>> + return -1;
>> +
>> + return 0;
>> +}
>> +
>> +/* Handler for arm system call instruction recording. */
>> +
>> +static int
>> +aarch64_linux_syscall_record (struct regcache *regcache, unsigned long svc_number)
>> +{
>> + int ret = 0;
>> + enum gdb_syscall syscall_gdb;
>> +
>> + printf_unfiltered (_("syscall number %s\n"),
>> + plongest (svc_number));
>> + syscall_gdb = aarch64_canonicalize_syscall (svc_number);
>> +
>> + if (syscall_gdb < 0)
>> + {
>> + printf_unfiltered (_("Process record and replay target doesn't "
>> + "support syscall number %s\n"),
>> + plongest (svc_number));
>> + return -1;
>> + }
>> +
>> + if (syscall_gdb == gdb_sys_sigreturn
>> + || syscall_gdb == gdb_sys_rt_sigreturn)
>> + {
>> + if (aarch64_all_but_pc_registers_record (regcache))
>> + return -1;
>> + return 0;
>> + }
>> +
>> + ret = record_linux_system_call (syscall_gdb, regcache,
>> + &aarch64_linux_record_tdep);
>> + if (ret != 0)
>> + return ret;
>> +
>> + /* Record the return value of the system call. */
>> + if (record_full_arch_list_add_reg (regcache, AARCH64_X0_REGNUM))
>> + return -1;
>> + /* Record LR. */
>> + if (record_full_arch_list_add_reg (regcache, AARCH64_LR_REGNUM))
>> + return -1;
>> + /* Record CPSR. */
>> + if (record_full_arch_list_add_reg (regcache, AARCH64_CPSR_REGNUM))
>> + return -1;
>> +
>> + return 0;
>> +}
>> +
>> static void
>> aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>> {
>> @@ -404,6 +1153,170 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>>
>> /* Reversible debugging, process record. */
>> set_gdbarch_process_record (gdbarch, aarch64_process_record);
>> + /* Syscall record. */
>> + tdep->aarch64_syscall_record = aarch64_linux_syscall_record;
>> +
>> + /* Initialize the aarch64_linux_record_tdep. */
>> + /* These values are the size of the type that will be used in a system
>> + call. They are obtained from Linux Kernel source. */
>> + aarch64_linux_record_tdep.size_pointer
>> + = gdbarch_ptr_bit (gdbarch) / TARGET_CHAR_BIT;
>> + aarch64_linux_record_tdep.size__old_kernel_stat = 32;
>> + aarch64_linux_record_tdep.size_tms = 32;
>> + aarch64_linux_record_tdep.size_loff_t = 8;
>> + aarch64_linux_record_tdep.size_flock = 32;
>> + aarch64_linux_record_tdep.size_oldold_utsname = 45;
>> + aarch64_linux_record_tdep.size_ustat = 32;
>> + aarch64_linux_record_tdep.size_old_sigaction = 152;
>> + aarch64_linux_record_tdep.size_old_sigset_t = 128;
>> + aarch64_linux_record_tdep.size_rlimit = 16;
>> + aarch64_linux_record_tdep.size_rusage = 144;
>> + aarch64_linux_record_tdep.size_timeval = 16;
>> + aarch64_linux_record_tdep.size_timezone = 8;
>> + aarch64_linux_record_tdep.size_old_gid_t = 2;
>> + aarch64_linux_record_tdep.size_old_uid_t = 2;
>> + aarch64_linux_record_tdep.size_fd_set = 128;
>> + aarch64_linux_record_tdep.size_dirent = 280;
>> + aarch64_linux_record_tdep.size_dirent64 = 280;
>> + aarch64_linux_record_tdep.size_statfs = 120;
>> + aarch64_linux_record_tdep.size_statfs64 = 120;
>> + aarch64_linux_record_tdep.size_sockaddr = 16;
>> + aarch64_linux_record_tdep.size_int
>> + = gdbarch_int_bit (gdbarch) / TARGET_CHAR_BIT;
>> + aarch64_linux_record_tdep.size_long
>> + = gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
>> + aarch64_linux_record_tdep.size_ulong
>> + = gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
>> + aarch64_linux_record_tdep.size_msghdr = 56;
>> + aarch64_linux_record_tdep.size_itimerval = 32;
>> + aarch64_linux_record_tdep.size_stat = 144;
>> + aarch64_linux_record_tdep.size_old_utsname = 325;
>> + aarch64_linux_record_tdep.size_sysinfo = 112;
>> + aarch64_linux_record_tdep.size_msqid_ds = 120;
>> + aarch64_linux_record_tdep.size_shmid_ds = 112;
>> + aarch64_linux_record_tdep.size_new_utsname = 390;
>> + aarch64_linux_record_tdep.size_timex = 208;
>> + aarch64_linux_record_tdep.size_mem_dqinfo = 24;
>> + aarch64_linux_record_tdep.size_if_dqblk = 72;
>> + aarch64_linux_record_tdep.size_fs_quota_stat = 80;
>> + aarch64_linux_record_tdep.size_timespec = 16;
>> + aarch64_linux_record_tdep.size_pollfd = 8;
>> + aarch64_linux_record_tdep.size_NFS_FHSIZE = 32;
>> + aarch64_linux_record_tdep.size_knfsd_fh = 132;
>> + aarch64_linux_record_tdep.size_TASK_COMM_LEN = 16;
>> + aarch64_linux_record_tdep.size_sigaction = 152;
>> + aarch64_linux_record_tdep.size_sigset_t = 128;
>> + aarch64_linux_record_tdep.size_siginfo_t = 128;
>> + aarch64_linux_record_tdep.size_cap_user_data_t = 8;
>> + aarch64_linux_record_tdep.size_stack_t = 24;
>> + aarch64_linux_record_tdep.size_off_t = 8;
>> + aarch64_linux_record_tdep.size_stat64 = 144;
>> + aarch64_linux_record_tdep.size_gid_t = 4;
>> + aarch64_linux_record_tdep.size_uid_t = 4;
>> + aarch64_linux_record_tdep.size_PAGE_SIZE = 4096;
>> + aarch64_linux_record_tdep.size_flock64 = 32;
>> + aarch64_linux_record_tdep.size_user_desc = 16;
>> + aarch64_linux_record_tdep.size_io_event = 32;
>> + aarch64_linux_record_tdep.size_iocb = 64;
>> + aarch64_linux_record_tdep.size_epoll_event = 12;
>> + aarch64_linux_record_tdep.size_itimerspec = 32;
>> + aarch64_linux_record_tdep.size_mq_attr = 64;
>> + aarch64_linux_record_tdep.size_siginfo = 128;
>> + aarch64_linux_record_tdep.size_termios = 60;
>> + aarch64_linux_record_tdep.size_termios2 = 44;
>> + aarch64_linux_record_tdep.size_pid_t = 4;
>> + aarch64_linux_record_tdep.size_winsize = 8;
>> + aarch64_linux_record_tdep.size_serial_struct = 72;
>> + aarch64_linux_record_tdep.size_serial_icounter_struct = 80;
>> + aarch64_linux_record_tdep.size_hayes_esp_config = 12;
>> + aarch64_linux_record_tdep.size_size_t = 8;
>> + aarch64_linux_record_tdep.size_iovec = 16;
>> +
>> + /* These values are the second argument of system call "sys_ioctl".
>> + They are obtained from Linux Kernel source. */
>> + aarch64_linux_record_tdep.ioctl_TCGETS = 0x5401;
>> + aarch64_linux_record_tdep.ioctl_TCSETS = 0x5402;
>> + aarch64_linux_record_tdep.ioctl_TCSETSW = 0x5403;
>> + aarch64_linux_record_tdep.ioctl_TCSETSF = 0x5404;
>> + aarch64_linux_record_tdep.ioctl_TCGETA = 0x5405;
>> + aarch64_linux_record_tdep.ioctl_TCSETA = 0x5406;
>> + aarch64_linux_record_tdep.ioctl_TCSETAW = 0x5407;
>> + aarch64_linux_record_tdep.ioctl_TCSETAF = 0x5408;
>> + aarch64_linux_record_tdep.ioctl_TCSBRK = 0x5409;
>> + aarch64_linux_record_tdep.ioctl_TCXONC = 0x540a;
>> + aarch64_linux_record_tdep.ioctl_TCFLSH = 0x540b;
>> + aarch64_linux_record_tdep.ioctl_TIOCEXCL = 0x540c;
>> + aarch64_linux_record_tdep.ioctl_TIOCNXCL = 0x540d;
>> + aarch64_linux_record_tdep.ioctl_TIOCSCTTY = 0x540e;
>> + aarch64_linux_record_tdep.ioctl_TIOCGPGRP = 0x540f;
>> + aarch64_linux_record_tdep.ioctl_TIOCSPGRP = 0x5410;
>> + aarch64_linux_record_tdep.ioctl_TIOCOUTQ = 0x5411;
>> + aarch64_linux_record_tdep.ioctl_TIOCSTI = 0x5412;
>> + aarch64_linux_record_tdep.ioctl_TIOCGWINSZ = 0x5413;
>> + aarch64_linux_record_tdep.ioctl_TIOCSWINSZ = 0x5414;
>> + aarch64_linux_record_tdep.ioctl_TIOCMGET = 0x5415;
>> + aarch64_linux_record_tdep.ioctl_TIOCMBIS = 0x5416;
>> + aarch64_linux_record_tdep.ioctl_TIOCMBIC = 0x5417;
>> + aarch64_linux_record_tdep.ioctl_TIOCMSET = 0x5418;
>> + aarch64_linux_record_tdep.ioctl_TIOCGSOFTCAR = 0x5419;
>> + aarch64_linux_record_tdep.ioctl_TIOCSSOFTCAR = 0x541a;
>> + aarch64_linux_record_tdep.ioctl_FIONREAD = 0x541b;
>> + aarch64_linux_record_tdep.ioctl_TIOCINQ = 0x541b;
>> + aarch64_linux_record_tdep.ioctl_TIOCLINUX = 0x541c;
>> + aarch64_linux_record_tdep.ioctl_TIOCCONS = 0x541d;
>> + aarch64_linux_record_tdep.ioctl_TIOCGSERIAL = 0x541e;
>> + aarch64_linux_record_tdep.ioctl_TIOCSSERIAL = 0x541f;
>> + aarch64_linux_record_tdep.ioctl_TIOCPKT = 0x5420;
>> + aarch64_linux_record_tdep.ioctl_FIONBIO = 0x5421;
>> + aarch64_linux_record_tdep.ioctl_TIOCNOTTY = 0x5422;
>> + aarch64_linux_record_tdep.ioctl_TIOCSETD = 0x5423;
>> + aarch64_linux_record_tdep.ioctl_TIOCGETD = 0x5424;
>> + aarch64_linux_record_tdep.ioctl_TCSBRKP = 0x5425;
>> + aarch64_linux_record_tdep.ioctl_TIOCTTYGSTRUCT = 0x5426;
>> + aarch64_linux_record_tdep.ioctl_TIOCSBRK = 0x5427;
>> + aarch64_linux_record_tdep.ioctl_TIOCCBRK = 0x5428;
>> + aarch64_linux_record_tdep.ioctl_TIOCGSID = 0x5429;
>> + aarch64_linux_record_tdep.ioctl_TCGETS2 = 0x802c542a;
>> + aarch64_linux_record_tdep.ioctl_TCSETS2 = 0x402c542b;
>> + aarch64_linux_record_tdep.ioctl_TCSETSW2 = 0x402c542c;
>> + aarch64_linux_record_tdep.ioctl_TCSETSF2 = 0x402c542d;
>> + aarch64_linux_record_tdep.ioctl_TIOCGPTN = 0x80045430;
>> + aarch64_linux_record_tdep.ioctl_TIOCSPTLCK = 0x40045431;
>> + aarch64_linux_record_tdep.ioctl_FIONCLEX = 0x5450;
>> + aarch64_linux_record_tdep.ioctl_FIOCLEX = 0x5451;
>> + aarch64_linux_record_tdep.ioctl_FIOASYNC = 0x5452;
>> + aarch64_linux_record_tdep.ioctl_TIOCSERCONFIG = 0x5453;
>> + aarch64_linux_record_tdep.ioctl_TIOCSERGWILD = 0x5454;
>> + aarch64_linux_record_tdep.ioctl_TIOCSERSWILD = 0x5455;
>> + aarch64_linux_record_tdep.ioctl_TIOCGLCKTRMIOS = 0x5456;
>> + aarch64_linux_record_tdep.ioctl_TIOCSLCKTRMIOS = 0x5457;
>> + aarch64_linux_record_tdep.ioctl_TIOCSERGSTRUCT = 0x5458;
>> + aarch64_linux_record_tdep.ioctl_TIOCSERGETLSR = 0x5459;
>> + aarch64_linux_record_tdep.ioctl_TIOCSERGETMULTI = 0x545a;
>> + aarch64_linux_record_tdep.ioctl_TIOCSERSETMULTI = 0x545b;
>> + aarch64_linux_record_tdep.ioctl_TIOCMIWAIT = 0x545c;
>> + aarch64_linux_record_tdep.ioctl_TIOCGICOUNT = 0x545d;
>> + aarch64_linux_record_tdep.ioctl_TIOCGHAYESESP = 0x545e;
>> + aarch64_linux_record_tdep.ioctl_TIOCSHAYESESP = 0x545f;
>> + aarch64_linux_record_tdep.ioctl_FIOQSIZE = 0x5460;
>> +
>> + /* These values are the second argument of system call "sys_fcntl"
>> + and "sys_fcntl64". They are obtained from Linux Kernel source. */
>> + aarch64_linux_record_tdep.fcntl_F_GETLK = 5;
>> + aarch64_linux_record_tdep.fcntl_F_GETLK64 = 12;
>> + aarch64_linux_record_tdep.fcntl_F_SETLK64 = 13;
>> + aarch64_linux_record_tdep.fcntl_F_SETLKW64 = 14;
>> +
>> + /* The AArch64 syscall calling convention: reg x0-x7 for arguments,
>> + reg x8 for syscall number and return value in reg x0. */
>> + aarch64_linux_record_tdep.arg1 = AARCH64_X0_REGNUM + 0;
>> + aarch64_linux_record_tdep.arg2 = AARCH64_X0_REGNUM + 1;
>> + aarch64_linux_record_tdep.arg3 = AARCH64_X0_REGNUM + 2;
>> + aarch64_linux_record_tdep.arg4 = AARCH64_X0_REGNUM + 3;
>> + aarch64_linux_record_tdep.arg5 = AARCH64_X0_REGNUM + 4;
>> + aarch64_linux_record_tdep.arg6 = AARCH64_X0_REGNUM + 5;
>> + aarch64_linux_record_tdep.arg7 = AARCH64_X0_REGNUM + 6;
>> + aarch64_linux_record_tdep.arg8 = AARCH64_X0_REGNUM + 7;
>> }
>>
>> /* Provide a prototype to silence -Wmissing-prototypes. */
>> diff --git a/gdb/aarch64-linux-tdep.h b/gdb/aarch64-linux-tdep.h
>> index 2e1de60..1ae3786 100644
>> --- a/gdb/aarch64-linux-tdep.h
>> +++ b/gdb/aarch64-linux-tdep.h
>> @@ -32,3 +32,269 @@
>>
>> extern const struct regset aarch64_linux_gregset;
>> extern const struct regset aarch64_linux_fpregset;
>> +
>> +/* Enum that defines the AArch64 linux specific syscall identifiers used for
>> + process record/replay. */
>> +
>> +enum aarch64_syscall {
>> + aarch64_sys_io_setup = 0,
>> + aarch64_sys_io_destroy = 1,
>> + aarch64_sys_io_submit = 2,
>> + aarch64_sys_io_cancel = 3,
>> + aarch64_sys_io_getevents = 4,
>> + aarch64_sys_setxattr = 5,
>> + aarch64_sys_lsetxattr = 6,
>> + aarch64_sys_fsetxattr = 7,
>> + aarch64_sys_getxattr = 8,
>> + aarch64_sys_lgetxattr = 9,
>> + aarch64_sys_fgetxattr = 10,
>> + aarch64_sys_listxattr = 11,
>> + aarch64_sys_llistxattr = 12,
>> + aarch64_sys_flistxattr = 13,
>> + aarch64_sys_removexattr = 14,
>> + aarch64_sys_lremovexattr = 15,
>> + aarch64_sys_fremovexattr = 16,
>> + aarch64_sys_getcwd = 17,
>> + aarch64_sys_lookup_dcookie = 18,
>> + aarch64_sys_eventfd2 = 19,
>> + aarch64_sys_epoll_create1 = 20,
>> + aarch64_sys_epoll_ctl = 21,
>> + aarch64_sys_epoll_pwait = 22,
>> + aarch64_sys_dup = 23,
>> + aarch64_sys_dup3 = 24,
>> + aarch64_sys_fcntl = 25,
>> + aarch64_sys_inotify_init1 = 26,
>> + aarch64_sys_inotify_add_watch = 27,
>> + aarch64_sys_inotify_rm_watch = 28,
>> + aarch64_sys_ioctl = 29,
>> + aarch64_sys_ioprio_set = 30,
>> + aarch64_sys_ioprio_get = 31,
>> + aarch64_sys_flock = 32,
>> + aarch64_sys_mknod = 33,
>> + aarch64_sys_mkdir = 34,
>> + aarch64_sys_unlink = 35,
>> + aarch64_sys_symlink = 36,
>> + aarch64_sys_link = 37,
>> + aarch64_sys_rename = 38,
>> + aarch64_sys_umount2 = 39,
>> + aarch64_sys_mount = 40,
>> + aarch64_sys_pivot_root = 41,
>> + aarch64_sys_nfsservctl = 42,
>> + aarch64_sys_statfs = 43,
>> + aarch64_sys_fstatfs = 44,
>> + aarch64_sys_truncate = 45,
>> + aarch64_sys_ftruncate = 46,
>> + aarch64_sys_fallocate = 47,
>> + aarch64_sys_faccess = 48,
>> + aarch64_sys_chdir = 49,
>> + aarch64_sys_fchdir = 50,
>> + aarch64_sys_chroot = 51,
>> + aarch64_sys_fchmod = 52,
>> + aarch64_sys_fchmodat = 53,
>> + aarch64_sys_fchownat = 54,
>> + aarch64_sys_fchown = 55,
>> + aarch64_sys_open = 56,
>> + aarch64_sys_close = 57,
>> + aarch64_sys_vhangup = 58,
>> + aarch64_sys_pipe2 = 59,
>> + aarch64_sys_quotactl = 60,
>> + aarch64_sys_getdents64 = 61,
>> + aarch64_sys_lseek = 62,
>> + aarch64_sys_read = 63,
>> + aarch64_sys_write = 64,
>> + aarch64_sys_readv = 65,
>> + aarch64_sys_writev = 66,
>> + aarch64_sys_pread64 = 67,
>> + aarch64_sys_pwrite64 = 68,
>> + aarch64_sys_preadv = 69,
>> + aarch64_sys_pwritev = 70,
>> + aarch64_sys_sendfile = 71,
>> + aarch64_sys_pselect6 = 72,
>> + aarch64_sys_ppoll = 73,
>> + aarch64_sys_signalfd4 = 74,
>> + aarch64_sys_vmsplice = 75,
>> + aarch64_sys_splice = 76,
>> + aarch64_sys_tee = 77,
>> + aarch64_sys_readlink = 78,
>> + aarch64_sys_fstatat = 79,
>> + aarch64_sys_fstat = 80,
>> + aarch64_sys_sync = 81,
>> + aarch64_sys_fsync = 82,
>> + aarch64_sys_fdatasync = 83,
>> + aarch64_sys_sync_file_range2 = 84,
>> + aarch64_sys_sync_file_range = 84,
>> + aarch64_sys_timerfd_create = 85,
>> + aarch64_sys_timerfd_settime = 86,
>> + aarch64_sys_timerfd_gettime = 87,
>> + aarch64_sys_utimensat = 88,
>> + aarch64_sys_acct = 89,
>> + aarch64_sys_capget = 90,
>> + aarch64_sys_capset = 91,
>> + aarch64_sys_personality = 92,
>> + aarch64_sys_exit = 93,
>> + aarch64_sys_exit_group = 94,
>> + aarch64_sys_waitid = 95,
>> + aarch64_sys_set_tid_address = 96,
>> + aarch64_sys_unshare = 97,
>> + aarch64_sys_futex = 98,
>> + aarch64_sys_set_robust_list = 99,
>> + aarch64_sys_get_robust_list = 100,
>> + aarch64_sys_nanosleep = 101,
>> + aarch64_sys_getitimer = 102,
>> + aarch64_sys_setitimer = 103,
>> + aarch64_sys_kexec_load = 104,
>> + aarch64_sys_init_module = 105,
>> + aarch64_sys_delete_module = 106,
>> + aarch64_sys_timer_create = 107,
>> + aarch64_sys_timer_gettime = 108,
>> + aarch64_sys_timer_getoverrun = 109,
>> + aarch64_sys_timer_settime = 110,
>> + aarch64_sys_timer_delete = 111,
>> + aarch64_sys_clock_settime = 112,
>> + aarch64_sys_clock_gettime = 113,
>> + aarch64_sys_clock_getres = 114,
>> + aarch64_sys_clock_nanosleep = 115,
>> + aarch64_sys_syslog = 116,
>> + aarch64_sys_ptrace = 117,
>> + aarch64_sys_sched_setparam = 118,
>> + aarch64_sys_sched_setscheduler = 119,
>> + aarch64_sys_sched_getscheduler = 120,
>> + aarch64_sys_sched_getparam = 121,
>> + aarch64_sys_sched_setaffinity = 122,
>> + aarch64_sys_sched_getaffinity = 123,
>> + aarch64_sys_sched_yield = 124,
>> + aarch64_sys_sched_get_priority_max = 125,
>> + aarch64_sys_sched_get_priority_min = 126,
>> + aarch64_sys_sched_rr_get_interval = 127,
>> + aarch64_sys_kill = 129,
>> + aarch64_sys_tkill = 130,
>> + aarch64_sys_tgkill = 131,
>> + aarch64_sys_sigaltstack = 132,
>> + aarch64_sys_rt_sigsuspend = 133,
>> + aarch64_sys_rt_sigaction = 134,
>> + aarch64_sys_rt_sigprocmask = 135,
>> + aarch64_sys_rt_sigpending = 136,
>> + aarch64_sys_rt_sigtimedwait = 137,
>> + aarch64_sys_rt_sigqueueinfo = 138,
>> + aarch64_sys_rt_sigreturn = 139,
>> + aarch64_sys_setpriority = 140,
>> + aarch64_sys_getpriority = 141,
>> + aarch64_sys_reboot = 142,
>> + aarch64_sys_setregid = 143,
>> + aarch64_sys_setgid = 144,
>> + aarch64_sys_setreuid = 145,
>> + aarch64_sys_setuid = 146,
>> + aarch64_sys_setresuid = 147,
>> + aarch64_sys_getresuid = 148,
>> + aarch64_sys_setresgid = 149,
>> + aarch64_sys_getresgid = 150,
>> + aarch64_sys_setfsuid = 151,
>> + aarch64_sys_setfsgid = 152,
>> + aarch64_sys_times = 153,
>> + aarch64_sys_setpgid = 154,
>> + aarch64_sys_getpgid = 155,
>> + aarch64_sys_getsid = 156,
>> + aarch64_sys_setsid = 157,
>> + aarch64_sys_getgroups = 158,
>> + aarch64_sys_setgroups = 159,
>> + aarch64_sys_uname = 160,
>> + aarch64_sys_sethostname = 161,
>> + aarch64_sys_setdomainname = 162,
>> + aarch64_sys_getrlimit = 163,
>> + aarch64_sys_setrlimit = 164,
>> + aarch64_sys_getrusage = 165,
>> + aarch64_sys_umask = 166,
>> + aarch64_sys_prctl = 167,
>> + aarch64_sys_getcpu = 168,
>> + aarch64_sys_gettimeofday = 169,
>> + aarch64_sys_settimeofday = 170,
>> + aarch64_sys_adjtimex = 171,
>> + aarch64_sys_getpid = 172,
>> + aarch64_sys_getppid = 173,
>> + aarch64_sys_getuid = 174,
>> + aarch64_sys_geteuid = 175,
>> + aarch64_sys_getgid = 176,
>> + aarch64_sys_getegid = 177,
>> + aarch64_sys_gettid = 178,
>> + aarch64_sys_sysinfo = 179,
>> + aarch64_sys_mq_open = 180,
>> + aarch64_sys_mq_unlink = 181,
>> + aarch64_sys_mq_timedsend = 182,
>> + aarch64_sys_mq_timedreceive = 183,
>> + aarch64_sys_mq_notify = 184,
>> + aarch64_sys_mq_getsetattr = 185,
>> + aarch64_sys_msgget = 186,
>> + aarch64_sys_msgctl = 187,
>> + aarch64_sys_msgrcv = 188,
>> + aarch64_sys_msgsnd = 189,
>> + aarch64_sys_semget = 190,
>> + aarch64_sys_semctl = 191,
>> + aarch64_sys_semtimedop = 192,
>> + aarch64_sys_semop = 193,
>> + aarch64_sys_shmget = 194,
>> + aarch64_sys_shmctl = 195,
>> + aarch64_sys_shmat = 196,
>> + aarch64_sys_shmdt = 197,
>> + aarch64_sys_socket = 198,
>> + aarch64_sys_socketpair = 199,
>> + aarch64_sys_bind = 200,
>> + aarch64_sys_listen = 201,
>> + aarch64_sys_accept = 202,
>> + aarch64_sys_connect = 203,
>> + aarch64_sys_getsockname = 204,
>> + aarch64_sys_getpeername = 205,
>> + aarch64_sys_sendto = 206,
>> + aarch64_sys_recvfrom = 207,
>> + aarch64_sys_setsockopt = 208,
>> + aarch64_sys_getsockopt = 209,
>> + aarch64_sys_shutdown = 210,
>> + aarch64_sys_sendmsg = 211,
>> + aarch64_sys_recvmsg = 212,
>> + aarch64_sys_readahead = 213,
>> + aarch64_sys_brk = 214,
>> + aarch64_sys_munmap = 215,
>> + aarch64_sys_mremap = 216,
>> + aarch64_sys_add_key = 217,
>> + aarch64_sys_request_key = 218,
>> + aarch64_sys_keyctl = 219,
>> + aarch64_sys_clone = 220,
>> + aarch64_sys_execve = 221,
>> + aarch64_sys_mmap = 222,
>> + aarch64_sys_fadvise64 = 223,
>> + aarch64_sys_swapon = 224,
>> + aarch64_sys_swapoff = 225,
>> + aarch64_sys_mprotect = 226,
>> + aarch64_sys_msync = 227,
>> + aarch64_sys_mlock = 228,
>> + aarch64_sys_munlock = 229,
>> + aarch64_sys_mlockall = 230,
>> + aarch64_sys_munlockall = 231,
>> + aarch64_sys_mincore = 232,
>> + aarch64_sys_madvise = 233,
>> + aarch64_sys_remap_file_pages = 234,
>> + aarch64_sys_mbind = 235,
>> + aarch64_sys_get_mempolicy = 236,
>> + aarch64_sys_set_mempolicy = 237,
>> + aarch64_sys_migrate_pages = 238,
>> + aarch64_sys_move_pages = 239,
>> + aarch64_sys_rt_tgsigqueueinfo = 240,
>> + aarch64_sys_perf_event_open = 241,
>> + aarch64_sys_accept4 = 242,
>> + aarch64_sys_recvmmsg = 243,
>> + aarch64_sys_wait4 = 260,
>> + aarch64_sys_prlimit64 = 261,
>> + aarch64_sys_fanotify_init = 262,
>> + aarch64_sys_fanotify_mark = 263,
>> + aarch64_sys_name_to_handle_at = 264,
>> + aarch64_sys_open_by_handle_at = 265,
>> + aarch64_sys_clock_adjtime = 266,
>> + aarch64_sys_syncfs = 267,
>> + aarch64_sys_setns = 268,
>> + aarch64_sys_sendmmsg = 269,
>> + aarch64_sys_process_vm_readv = 270,
>> + aarch64_sys_process_vm_writev = 271,
>> + aarch64_sys_kcmp = 272,
>> + aarch64_sys_finit_module = 273,
>> + aarch64_sys_sched_setattr = 274,
>> + aarch64_sys_sched_getattr = 275,
>> +};
>> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
>> index 0847585..c6da25a 100644
>> --- a/gdb/aarch64-tdep.c
>> +++ b/gdb/aarch64-tdep.c
>> @@ -2941,7 +2941,20 @@ aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
>> {
>> /* Exception generation instructions. */
>> if (insn_bits24_27 == 0x04)
>> - return AARCH64_RECORD_UNSUPPORTED;
>> + {
>> + if (!bits (aarch64_insn_r->aarch64_insn, 2, 4) &&
>> + !bits (aarch64_insn_r->aarch64_insn, 21, 23) &&
>> + bits (aarch64_insn_r->aarch64_insn, 0, 1) == 0x01)
>> + {
>> + ULONGEST svc_number;
>> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, 8,
>> + &svc_number);
>> + return tdep->aarch64_syscall_record (aarch64_insn_r->regcache,
>> + svc_number);
>> + }
>> + else
>> + return AARCH64_RECORD_UNSUPPORTED;
>> + }
>> /* System instructions. */
>> else if (insn_bits24_27 == 0x05 && insn_bits22_23 == 0x00)
>> {
>> diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
>> index 1d74ef8..25751fe 100644
>> --- a/gdb/aarch64-tdep.h
>> +++ b/gdb/aarch64-tdep.h
>> @@ -88,6 +88,9 @@ struct gdbarch_tdep
>> struct type *vns_type;
>> struct type *vnh_type;
>> struct type *vnb_type;
>> +
>> + /* syscall record. */
>> + int (*aarch64_syscall_record) (struct regcache *regcache, unsigned long svc_number);
>> };
>>
>> /* AArch64 process record-replay related structures, defines etc. */
>> diff --git a/gdb/linux-record.h b/gdb/linux-record.h
>> index 7b5218e..2649ce5 100644
>> --- a/gdb/linux-record.h
>> +++ b/gdb/linux-record.h
>> @@ -174,6 +174,8 @@ struct linux_record_tdep
>> int arg4;
>> int arg5;
>> int arg6;
>> + int arg7;
>> + int arg8;
>> };
>>
>> /* Enum that defines the gdb-canonical set of Linux syscall identifiers.
>> --
>> 1.9.1
>>
>
>
>
> --
> Will Newton
> Toolchain Working Group, Linaro
Ping! Kindly help me approve this patch.
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 5/7] Support for recording syscall on aarch64-linux
2014-09-18 22:28 ` Omair Javaid
@ 2014-10-14 12:47 ` Omair Javaid
2014-10-21 9:09 ` Omair Javaid
0 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-10-14 12:47 UTC (permalink / raw)
To: Will Newton, Pedro Alves; +Cc: gdb-patches
On 19 September 2014 03:27, Omair Javaid <omair.javaid@linaro.org> wrote:
> On 18 September 2014 05:22, Will Newton <will.newton@linaro.org> wrote:
>> On 29 August 2014 04:53, Omair Javaid <omair.javaid@linaro.org> wrote:
>>> Suggestion have been incorporated and updated patch is given below.
>>>
>>> gdb:
>>>
>>> 2014-08-28 Omair Javaid <omair.javaid@linaro.org>
>>>
>>> * aarch64-linux-tdep.c (record.h): Include.
>>> (record-full.h): Include.
>>> (struct linux_record_tdep aarch64_linux_record_tdep): Declare.
>>> (aarch64_canonicalize_syscall): New function to translate syscall
>>> numbers from aarch64 to canonical.
>>> (aarch64_all_but_pc_registers_record): New function.
>>> (aarch64_linux_syscall_record): New function.
>>> (aarch64_linux_init_abi): Update to handle syscall recording.
>>> * aarch64-linux-tdep.h (aarch64_syscall): New enum.
>>> * aarch64-tdep.c (aarch64_record_branch_except_sys): Add code to
>>> handle recording of syscalls.
>>> * aarch64-tdep.h
>>> (struct gdbarch_tdep) <aarch64_syscall_record>: Defined.
>>> * linux-record.h (struct linux_record_tdep): Add two more syscall
>>> argument fields.
>>>
>>> ---
>>> gdb/aarch64-linux-tdep.c | 913 +++++++++++++++++++++++++++++++++++++++++++++++
>>> gdb/aarch64-linux-tdep.h | 266 ++++++++++++++
>>> gdb/aarch64-tdep.c | 15 +-
>>> gdb/aarch64-tdep.h | 3 +
>>> gdb/linux-record.h | 2 +
>>> 5 files changed, 1198 insertions(+), 1 deletion(-)
>>
>> This one looks ok to me now.
>>
>>> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
>>> index 5ab7b37..82b55b6 100644
>>> --- a/gdb/aarch64-linux-tdep.c
>>> +++ b/gdb/aarch64-linux-tdep.c
>>> @@ -41,6 +41,9 @@
>>> #include "user-regs.h"
>>> #include <ctype.h>
>>>
>>> +#include "record-full.h"
>>> +#include "linux-record.h"
>>> +
>>> /* Signal frame handling.
>>>
>>> +------------+ ^
>>> @@ -354,6 +357,752 @@ aarch64_stap_parse_special_token (struct gdbarch *gdbarch,
>>> return 1;
>>> }
>>>
>>> +/* AArch64 process record-replay constructs: syscall, signal etc. */
>>> +
>>> +struct linux_record_tdep aarch64_linux_record_tdep;
>>> +
>>> +/* aarch64_canonicalize_syscall maps syscall ids from the native AArch64
>>> + linux set of syscall ids into a canonical set of syscall ids used by
>>> + process record. */
>>> +
>>> +static enum gdb_syscall
>>> +aarch64_canonicalize_syscall (enum aarch64_syscall syscall_number)
>>> +{
>>> + switch (syscall_number) {
>>> + case aarch64_sys_read:
>>> + return gdb_sys_read;
>>> +
>>> + case aarch64_sys_write:
>>> + return gdb_sys_write;
>>> +
>>> + case aarch64_sys_open:
>>> + return gdb_sys_open;
>>> +
>>> + case aarch64_sys_close:
>>> + return gdb_sys_close;
>>> +
>>> + case aarch64_sys_lseek:
>>> + return gdb_sys_lseek;
>>> +
>>> + case aarch64_sys_mprotect:
>>> + return gdb_sys_mprotect;
>>> +
>>> + case aarch64_sys_munmap:
>>> + return gdb_sys_munmap;
>>> +
>>> + case aarch64_sys_brk:
>>> + return gdb_sys_brk;
>>> +
>>> + case aarch64_sys_rt_sigaction:
>>> + return gdb_sys_rt_sigaction;
>>> +
>>> + case aarch64_sys_rt_sigprocmask:
>>> + return gdb_sys_rt_sigprocmask;
>>> +
>>> + case aarch64_sys_rt_sigreturn:
>>> + return gdb_sys_rt_sigreturn;
>>> +
>>> + case aarch64_sys_ioctl:
>>> + return gdb_sys_ioctl;
>>> +
>>> + case aarch64_sys_pread64:
>>> + return gdb_sys_pread64;
>>> +
>>> + case aarch64_sys_pwrite64:
>>> + return gdb_sys_pwrite64;
>>> +
>>> + case aarch64_sys_readv:
>>> + return gdb_sys_readv;
>>> +
>>> + case aarch64_sys_writev:
>>> + return gdb_sys_writev;
>>> +
>>> + case aarch64_sys_sched_yield:
>>> + return gdb_sys_sched_yield;
>>> +
>>> + case aarch64_sys_mremap:
>>> + return gdb_sys_mremap;
>>> +
>>> + case aarch64_sys_msync:
>>> + return gdb_sys_msync;
>>> +
>>> + case aarch64_sys_mincore:
>>> + return gdb_sys_mincore;
>>> +
>>> + case aarch64_sys_madvise:
>>> + return gdb_sys_madvise;
>>> +
>>> + case aarch64_sys_shmget:
>>> + return gdb_sys_shmget;
>>> +
>>> + case aarch64_sys_shmat:
>>> + return gdb_sys_shmat;
>>> +
>>> + case aarch64_sys_shmctl:
>>> + return gdb_sys_shmctl;
>>> +
>>> + case aarch64_sys_dup:
>>> + return gdb_sys_dup;
>>> +
>>> + case aarch64_sys_nanosleep:
>>> + return gdb_sys_nanosleep;
>>> +
>>> + case aarch64_sys_getitimer:
>>> + return gdb_sys_getitimer;
>>> +
>>> + case aarch64_sys_setitimer:
>>> + return gdb_sys_setitimer;
>>> +
>>> + case aarch64_sys_getpid:
>>> + return gdb_sys_getpid;
>>> +
>>> + case aarch64_sys_sendfile:
>>> + return gdb_sys_sendfile;
>>> +
>>> + case aarch64_sys_socket:
>>> + return gdb_sys_socket;
>>> +
>>> + case aarch64_sys_connect:
>>> + return gdb_sys_connect;
>>> +
>>> + case aarch64_sys_accept:
>>> + return gdb_sys_accept;
>>> +
>>> + case aarch64_sys_sendto:
>>> + return gdb_sys_sendto;
>>> +
>>> + case aarch64_sys_recvfrom:
>>> + return gdb_sys_recvfrom;
>>> +
>>> + case aarch64_sys_sendmsg:
>>> + return gdb_sys_sendmsg;
>>> +
>>> + case aarch64_sys_recvmsg:
>>> + return gdb_sys_recvmsg;
>>> +
>>> + case aarch64_sys_shutdown:
>>> + return gdb_sys_shutdown;
>>> +
>>> + case aarch64_sys_bind:
>>> + return gdb_sys_bind;
>>> +
>>> + case aarch64_sys_listen:
>>> + return gdb_sys_listen;
>>> +
>>> + case aarch64_sys_getsockname:
>>> + return gdb_sys_getsockname;
>>> +
>>> + case aarch64_sys_getpeername:
>>> + return gdb_sys_getpeername;
>>> +
>>> + case aarch64_sys_socketpair:
>>> + return gdb_sys_socketpair;
>>> +
>>> + case aarch64_sys_setsockopt:
>>> + return gdb_sys_setsockopt;
>>> +
>>> + case aarch64_sys_getsockopt:
>>> + return gdb_sys_getsockopt;
>>> +
>>> + case aarch64_sys_clone:
>>> + return gdb_sys_clone;
>>> +
>>> + case aarch64_sys_execve:
>>> + return gdb_sys_execve;
>>> +
>>> + case aarch64_sys_exit:
>>> + return gdb_sys_exit;
>>> +
>>> + case aarch64_sys_wait4:
>>> + return gdb_sys_wait4;
>>> +
>>> + case aarch64_sys_kill:
>>> + return gdb_sys_kill;
>>> +
>>> + case aarch64_sys_uname:
>>> + return gdb_sys_uname;
>>> +
>>> + case aarch64_sys_semget:
>>> + return gdb_sys_semget;
>>> +
>>> + case aarch64_sys_semop:
>>> + return gdb_sys_semop;
>>> +
>>> + case aarch64_sys_semctl:
>>> + return gdb_sys_semctl;
>>> +
>>> + case aarch64_sys_shmdt:
>>> + return gdb_sys_shmdt;
>>> +
>>> + case aarch64_sys_msgget:
>>> + return gdb_sys_msgget;
>>> +
>>> + case aarch64_sys_msgsnd:
>>> + return gdb_sys_msgsnd;
>>> +
>>> + case aarch64_sys_msgrcv:
>>> + return gdb_sys_msgrcv;
>>> +
>>> + case aarch64_sys_msgctl:
>>> + return gdb_sys_msgctl;
>>> +
>>> + case aarch64_sys_fcntl:
>>> + return gdb_sys_fcntl;
>>> +
>>> + case aarch64_sys_flock:
>>> + return gdb_sys_flock;
>>> +
>>> + case aarch64_sys_fsync:
>>> + return gdb_sys_fsync;
>>> +
>>> + case aarch64_sys_fdatasync:
>>> + return gdb_sys_fdatasync;
>>> +
>>> + case aarch64_sys_truncate:
>>> + return gdb_sys_truncate;
>>> +
>>> + case aarch64_sys_ftruncate:
>>> + return gdb_sys_ftruncate;
>>> +
>>> + case aarch64_sys_getcwd:
>>> + return gdb_sys_getcwd;
>>> +
>>> + case aarch64_sys_chdir:
>>> + return gdb_sys_chdir;
>>> +
>>> + case aarch64_sys_fchdir:
>>> + return gdb_sys_fchdir;
>>> +
>>> + case aarch64_sys_rename:
>>> + return gdb_sys_rename;
>>> +
>>> + case aarch64_sys_mkdir:
>>> + return gdb_sys_mkdir;
>>> +
>>> + case aarch64_sys_link:
>>> + return gdb_sys_link;
>>> +
>>> + case aarch64_sys_unlink:
>>> + return gdb_sys_unlink;
>>> +
>>> + case aarch64_sys_symlink:
>>> + return gdb_sys_symlink;
>>> +
>>> + case aarch64_sys_readlink:
>>> + return gdb_sys_readlink;
>>> +
>>> + case aarch64_sys_fchmodat:
>>> + return gdb_sys_fchmodat;
>>> +
>>> + case aarch64_sys_fchmod:
>>> + return gdb_sys_fchmod;
>>> +
>>> + case aarch64_sys_fchownat:
>>> + return gdb_sys_fchownat;
>>> +
>>> + case aarch64_sys_fchown:
>>> + return gdb_sys_fchown;
>>> +
>>> + case aarch64_sys_umask:
>>> + return gdb_sys_umask;
>>> +
>>> + case aarch64_sys_gettimeofday:
>>> + return gdb_sys_gettimeofday;
>>> +
>>> + case aarch64_sys_getrlimit:
>>> + return gdb_sys_getrlimit;
>>> +
>>> + case aarch64_sys_getrusage:
>>> + return gdb_sys_getrusage;
>>> +
>>> + case aarch64_sys_sysinfo:
>>> + return gdb_sys_sysinfo;
>>> +
>>> + case aarch64_sys_ptrace:
>>> + return gdb_sys_ptrace;
>>> +
>>> + case aarch64_sys_getuid:
>>> + return gdb_sys_getuid;
>>> +
>>> + case aarch64_sys_syslog:
>>> + return gdb_sys_syslog;
>>> +
>>> + case aarch64_sys_getgid:
>>> + return gdb_sys_getgid;
>>> +
>>> + case aarch64_sys_setuid:
>>> + return gdb_sys_setuid;
>>> +
>>> + case aarch64_sys_setgid:
>>> + return gdb_sys_setgid;
>>> +
>>> + case aarch64_sys_geteuid:
>>> + return gdb_sys_geteuid;
>>> +
>>> + case aarch64_sys_getegid:
>>> + return gdb_sys_getegid;
>>> +
>>> + case aarch64_sys_setpgid:
>>> + return gdb_sys_setpgid;
>>> +
>>> + case aarch64_sys_getppid:
>>> + return gdb_sys_getppid;
>>> +
>>> + case aarch64_sys_setsid:
>>> + return gdb_sys_setsid;
>>> +
>>> + case aarch64_sys_setreuid:
>>> + return gdb_sys_setreuid;
>>> +
>>> + case aarch64_sys_setregid:
>>> + return gdb_sys_setregid;
>>> +
>>> + case aarch64_sys_getgroups:
>>> + return gdb_sys_getgroups;
>>> +
>>> + case aarch64_sys_setgroups:
>>> + return gdb_sys_setgroups;
>>> +
>>> + case aarch64_sys_setresuid:
>>> + return gdb_sys_setresuid;
>>> +
>>> + case aarch64_sys_getresuid:
>>> + return gdb_sys_getresuid;
>>> +
>>> + case aarch64_sys_setresgid:
>>> + return gdb_sys_setresgid;
>>> +
>>> + case aarch64_sys_getresgid:
>>> + return gdb_sys_getresgid;
>>> +
>>> + case aarch64_sys_getpgid:
>>> + return gdb_sys_getpgid;
>>> +
>>> + case aarch64_sys_setfsuid:
>>> + return gdb_sys_setfsuid;
>>> +
>>> + case aarch64_sys_setfsgid:
>>> + return gdb_sys_setfsgid;
>>> +
>>> + case aarch64_sys_getsid:
>>> + return gdb_sys_getsid;
>>> +
>>> + case aarch64_sys_capget:
>>> + return gdb_sys_capget;
>>> +
>>> + case aarch64_sys_capset:
>>> + return gdb_sys_capset;
>>> +
>>> + case aarch64_sys_rt_sigpending:
>>> + return gdb_sys_rt_sigpending;
>>> +
>>> + case aarch64_sys_rt_sigtimedwait:
>>> + return gdb_sys_rt_sigtimedwait;
>>> +
>>> + case aarch64_sys_rt_sigqueueinfo:
>>> + return gdb_sys_rt_sigqueueinfo;
>>> +
>>> + case aarch64_sys_rt_sigsuspend:
>>> + return gdb_sys_rt_sigsuspend;
>>> +
>>> + case aarch64_sys_sigaltstack:
>>> + return gdb_sys_sigaltstack;
>>> +
>>> + case aarch64_sys_mknod:
>>> + return gdb_sys_mknod;
>>> +
>>> + case aarch64_sys_personality:
>>> + return gdb_sys_personality;
>>> +
>>> + case aarch64_sys_statfs:
>>> + return gdb_sys_statfs;
>>> +
>>> + case aarch64_sys_fstat:
>>> + return gdb_sys_fstat;
>>> +
>>> + case aarch64_sys_fstatfs:
>>> + return gdb_sys_fstatfs;
>>> +
>>> + case aarch64_sys_getpriority:
>>> + return gdb_sys_getpriority;
>>> +
>>> + case aarch64_sys_setpriority:
>>> + return gdb_sys_setpriority;
>>> +
>>> + case aarch64_sys_sched_setparam:
>>> + return gdb_sys_sched_setparam;
>>> +
>>> + case aarch64_sys_sched_getparam:
>>> + return gdb_sys_sched_getparam;
>>> +
>>> + case aarch64_sys_sched_setscheduler:
>>> + return gdb_sys_sched_setscheduler;
>>> +
>>> + case aarch64_sys_sched_getscheduler:
>>> + return gdb_sys_sched_getscheduler;
>>> +
>>> + case aarch64_sys_sched_get_priority_max:
>>> + return gdb_sys_sched_get_priority_max;
>>> +
>>> + case aarch64_sys_sched_get_priority_min:
>>> + return gdb_sys_sched_get_priority_min;
>>> +
>>> + case aarch64_sys_sched_rr_get_interval:
>>> + return gdb_sys_sched_rr_get_interval;
>>> +
>>> + case aarch64_sys_mlock:
>>> + return gdb_sys_mlock;
>>> +
>>> + case aarch64_sys_munlock:
>>> + return gdb_sys_munlock;
>>> +
>>> + case aarch64_sys_mlockall:
>>> + return gdb_sys_mlockall;
>>> +
>>> + case aarch64_sys_munlockall:
>>> + return gdb_sys_munlockall;
>>> +
>>> + case aarch64_sys_vhangup:
>>> + return gdb_sys_vhangup;
>>> +
>>> + case aarch64_sys_prctl:
>>> + return gdb_sys_prctl;
>>> +
>>> + case aarch64_sys_adjtimex:
>>> + return gdb_sys_adjtimex;
>>> +
>>> + case aarch64_sys_setrlimit:
>>> + return gdb_sys_setrlimit;
>>> +
>>> + case aarch64_sys_chroot:
>>> + return gdb_sys_chroot;
>>> +
>>> + case aarch64_sys_sync:
>>> + return gdb_sys_sync;
>>> +
>>> + case aarch64_sys_acct:
>>> + return gdb_sys_acct;
>>> +
>>> + case aarch64_sys_settimeofday:
>>> + return gdb_sys_settimeofday;
>>> +
>>> + case aarch64_sys_mount:
>>> + return gdb_sys_mount;
>>> +
>>> + case aarch64_sys_swapon:
>>> + return gdb_sys_swapon;
>>> +
>>> + case aarch64_sys_swapoff:
>>> + return gdb_sys_swapoff;
>>> +
>>> + case aarch64_sys_reboot:
>>> + return gdb_sys_reboot;
>>> +
>>> + case aarch64_sys_sethostname:
>>> + return gdb_sys_sethostname;
>>> +
>>> + case aarch64_sys_setdomainname:
>>> + return gdb_sys_setdomainname;
>>> +
>>> + case aarch64_sys_init_module:
>>> + return gdb_sys_init_module;
>>> +
>>> + case aarch64_sys_delete_module:
>>> + return gdb_sys_delete_module;
>>> +
>>> + case aarch64_sys_quotactl:
>>> + return gdb_sys_quotactl;
>>> +
>>> + case aarch64_sys_nfsservctl:
>>> + return gdb_sys_nfsservctl;
>>> +
>>> + case aarch64_sys_gettid:
>>> + return gdb_sys_gettid;
>>> +
>>> + case aarch64_sys_readahead:
>>> + return gdb_sys_readahead;
>>> +
>>> + case aarch64_sys_setxattr:
>>> + return gdb_sys_setxattr;
>>> +
>>> + case aarch64_sys_lsetxattr:
>>> + return gdb_sys_lsetxattr;
>>> +
>>> + case aarch64_sys_fsetxattr:
>>> + return gdb_sys_fsetxattr;
>>> +
>>> + case aarch64_sys_getxattr:
>>> + return gdb_sys_getxattr;
>>> +
>>> + case aarch64_sys_lgetxattr:
>>> + return gdb_sys_lgetxattr;
>>> +
>>> + case aarch64_sys_fgetxattr:
>>> + return gdb_sys_fgetxattr;
>>> +
>>> + case aarch64_sys_listxattr:
>>> + return gdb_sys_listxattr;
>>> +
>>> + case aarch64_sys_llistxattr:
>>> + return gdb_sys_llistxattr;
>>> +
>>> + case aarch64_sys_flistxattr:
>>> + return gdb_sys_flistxattr;
>>> +
>>> + case aarch64_sys_removexattr:
>>> + return gdb_sys_removexattr;
>>> +
>>> + case aarch64_sys_lremovexattr:
>>> + return gdb_sys_lremovexattr;
>>> +
>>> + case aarch64_sys_fremovexattr:
>>> + return gdb_sys_fremovexattr;
>>> +
>>> + case aarch64_sys_tkill:
>>> + return gdb_sys_tkill;
>>> +
>>> + case aarch64_sys_times:
>>> + return gdb_sys_times;
>>> +
>>> + case aarch64_sys_futex:
>>> + return gdb_sys_futex;
>>> +
>>> + case aarch64_sys_sched_setaffinity:
>>> + return gdb_sys_sched_setaffinity;
>>> +
>>> + case aarch64_sys_sched_getaffinity:
>>> + return gdb_sys_sched_getaffinity;
>>> +
>>> + case aarch64_sys_io_setup:
>>> + return gdb_sys_io_setup;
>>> +
>>> + case aarch64_sys_io_destroy:
>>> + return gdb_sys_io_destroy;
>>> +
>>> + case aarch64_sys_io_getevents:
>>> + return gdb_sys_io_getevents;
>>> +
>>> + case aarch64_sys_io_submit:
>>> + return gdb_sys_io_submit;
>>> +
>>> + case aarch64_sys_io_cancel:
>>> + return gdb_sys_io_cancel;
>>> +
>>> + case aarch64_sys_lookup_dcookie:
>>> + return gdb_sys_lookup_dcookie;
>>> +
>>> + case aarch64_sys_epoll_create1:
>>> + return gdb_sys_epoll_create;
>>> +
>>> + case aarch64_sys_remap_file_pages:
>>> + return gdb_sys_remap_file_pages;
>>> +
>>> + case aarch64_sys_getdents64:
>>> + return gdb_sys_getdents64;
>>> +
>>> + case aarch64_sys_set_tid_address:
>>> + return gdb_sys_set_tid_address;
>>> +
>>> + case aarch64_sys_semtimedop:
>>> + return gdb_sys_semtimedop;
>>> +
>>> + case aarch64_sys_fadvise64:
>>> + return gdb_sys_fadvise64;
>>> +
>>> + case aarch64_sys_timer_create:
>>> + return gdb_sys_timer_create;
>>> +
>>> + case aarch64_sys_timer_settime:
>>> + return gdb_sys_timer_settime;
>>> +
>>> + case aarch64_sys_timer_gettime:
>>> + return gdb_sys_timer_gettime;
>>> +
>>> + case aarch64_sys_timer_getoverrun:
>>> + return gdb_sys_timer_getoverrun;
>>> +
>>> + case aarch64_sys_timer_delete:
>>> + return gdb_sys_timer_delete;
>>> +
>>> + case aarch64_sys_clock_settime:
>>> + return gdb_sys_clock_settime;
>>> +
>>> + case aarch64_sys_clock_gettime:
>>> + return gdb_sys_clock_gettime;
>>> +
>>> + case aarch64_sys_clock_getres:
>>> + return gdb_sys_clock_getres;
>>> +
>>> + case aarch64_sys_clock_nanosleep:
>>> + return gdb_sys_clock_nanosleep;
>>> +
>>> + case aarch64_sys_exit_group:
>>> + return gdb_sys_exit_group;
>>> +
>>> + case aarch64_sys_epoll_pwait:
>>> + return gdb_sys_epoll_pwait;
>>> +
>>> + case aarch64_sys_epoll_ctl:
>>> + return gdb_sys_epoll_ctl;
>>> +
>>> + case aarch64_sys_tgkill:
>>> + return gdb_sys_tgkill;
>>> +
>>> + case aarch64_sys_mbind:
>>> + return gdb_sys_mbind;
>>> +
>>> + case aarch64_sys_set_mempolicy:
>>> + return gdb_sys_set_mempolicy;
>>> +
>>> + case aarch64_sys_get_mempolicy:
>>> + return gdb_sys_get_mempolicy;
>>> +
>>> + case aarch64_sys_mq_open:
>>> + return gdb_sys_mq_open;
>>> +
>>> + case aarch64_sys_mq_unlink:
>>> + return gdb_sys_mq_unlink;
>>> +
>>> + case aarch64_sys_mq_timedsend:
>>> + return gdb_sys_mq_timedsend;
>>> +
>>> + case aarch64_sys_mq_timedreceive:
>>> + return gdb_sys_mq_timedreceive;
>>> +
>>> + case aarch64_sys_mq_notify:
>>> + return gdb_sys_mq_notify;
>>> +
>>> + case aarch64_sys_mq_getsetattr:
>>> + return gdb_sys_mq_getsetattr;
>>> +
>>> + case aarch64_sys_kexec_load:
>>> + return gdb_sys_kexec_load;
>>> +
>>> + case aarch64_sys_waitid:
>>> + return gdb_sys_waitid;
>>> +
>>> + case aarch64_sys_add_key:
>>> + return gdb_sys_add_key;
>>> +
>>> + case aarch64_sys_request_key:
>>> + return gdb_sys_request_key;
>>> +
>>> + case aarch64_sys_keyctl:
>>> + return gdb_sys_keyctl;
>>> +
>>> + case aarch64_sys_ioprio_set:
>>> + return gdb_sys_ioprio_set;
>>> +
>>> + case aarch64_sys_ioprio_get:
>>> + return gdb_sys_ioprio_get;
>>> +
>>> + case aarch64_sys_inotify_add_watch:
>>> + return gdb_sys_inotify_add_watch;
>>> +
>>> + case aarch64_sys_inotify_rm_watch:
>>> + return gdb_sys_inotify_rm_watch;
>>> +
>>> + case aarch64_sys_migrate_pages:
>>> + return gdb_sys_migrate_pages;
>>> +
>>> + case aarch64_sys_pselect6:
>>> + return gdb_sys_pselect6;
>>> +
>>> + case aarch64_sys_ppoll:
>>> + return gdb_sys_ppoll;
>>> +
>>> + case aarch64_sys_unshare:
>>> + return gdb_sys_unshare;
>>> +
>>> + case aarch64_sys_set_robust_list:
>>> + return gdb_sys_set_robust_list;
>>> +
>>> + case aarch64_sys_get_robust_list:
>>> + return gdb_sys_get_robust_list;
>>> +
>>> + case aarch64_sys_splice:
>>> + return gdb_sys_splice;
>>> +
>>> + case aarch64_sys_tee:
>>> + return gdb_sys_tee;
>>> +
>>> + case aarch64_sys_sync_file_range:
>>> + return gdb_sys_sync_file_range;
>>> +
>>> + case aarch64_sys_vmsplice:
>>> + return gdb_sys_vmsplice;
>>> +
>>> + case aarch64_sys_move_pages:
>>> + return gdb_sys_move_pages;
>>> +
>>> + default:
>>> + return -1;
>>> + }
>>> +}
>>> +
>>> +/* Record all registers but PC register for process-record. */
>>> +
>>> +static int
>>> +aarch64_all_but_pc_registers_record (struct regcache *regcache)
>>> +{
>>> + int i;
>>> +
>>> + for (i = 0; i < AARCH64_PC_REGNUM; i++)
>>> + if (record_full_arch_list_add_reg (regcache, AARCH64_X0_REGNUM + i))
>>> + return -1;
>>> +
>>> + if (record_full_arch_list_add_reg (regcache, AARCH64_CPSR_REGNUM))
>>> + return -1;
>>> +
>>> + return 0;
>>> +}
>>> +
>>> +/* Handler for arm system call instruction recording. */
>>> +
>>> +static int
>>> +aarch64_linux_syscall_record (struct regcache *regcache, unsigned long svc_number)
>>> +{
>>> + int ret = 0;
>>> + enum gdb_syscall syscall_gdb;
>>> +
>>> + printf_unfiltered (_("syscall number %s\n"),
>>> + plongest (svc_number));
>>> + syscall_gdb = aarch64_canonicalize_syscall (svc_number);
>>> +
>>> + if (syscall_gdb < 0)
>>> + {
>>> + printf_unfiltered (_("Process record and replay target doesn't "
>>> + "support syscall number %s\n"),
>>> + plongest (svc_number));
>>> + return -1;
>>> + }
>>> +
>>> + if (syscall_gdb == gdb_sys_sigreturn
>>> + || syscall_gdb == gdb_sys_rt_sigreturn)
>>> + {
>>> + if (aarch64_all_but_pc_registers_record (regcache))
>>> + return -1;
>>> + return 0;
>>> + }
>>> +
>>> + ret = record_linux_system_call (syscall_gdb, regcache,
>>> + &aarch64_linux_record_tdep);
>>> + if (ret != 0)
>>> + return ret;
>>> +
>>> + /* Record the return value of the system call. */
>>> + if (record_full_arch_list_add_reg (regcache, AARCH64_X0_REGNUM))
>>> + return -1;
>>> + /* Record LR. */
>>> + if (record_full_arch_list_add_reg (regcache, AARCH64_LR_REGNUM))
>>> + return -1;
>>> + /* Record CPSR. */
>>> + if (record_full_arch_list_add_reg (regcache, AARCH64_CPSR_REGNUM))
>>> + return -1;
>>> +
>>> + return 0;
>>> +}
>>> +
>>> static void
>>> aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>>> {
>>> @@ -404,6 +1153,170 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>>>
>>> /* Reversible debugging, process record. */
>>> set_gdbarch_process_record (gdbarch, aarch64_process_record);
>>> + /* Syscall record. */
>>> + tdep->aarch64_syscall_record = aarch64_linux_syscall_record;
>>> +
>>> + /* Initialize the aarch64_linux_record_tdep. */
>>> + /* These values are the size of the type that will be used in a system
>>> + call. They are obtained from Linux Kernel source. */
>>> + aarch64_linux_record_tdep.size_pointer
>>> + = gdbarch_ptr_bit (gdbarch) / TARGET_CHAR_BIT;
>>> + aarch64_linux_record_tdep.size__old_kernel_stat = 32;
>>> + aarch64_linux_record_tdep.size_tms = 32;
>>> + aarch64_linux_record_tdep.size_loff_t = 8;
>>> + aarch64_linux_record_tdep.size_flock = 32;
>>> + aarch64_linux_record_tdep.size_oldold_utsname = 45;
>>> + aarch64_linux_record_tdep.size_ustat = 32;
>>> + aarch64_linux_record_tdep.size_old_sigaction = 152;
>>> + aarch64_linux_record_tdep.size_old_sigset_t = 128;
>>> + aarch64_linux_record_tdep.size_rlimit = 16;
>>> + aarch64_linux_record_tdep.size_rusage = 144;
>>> + aarch64_linux_record_tdep.size_timeval = 16;
>>> + aarch64_linux_record_tdep.size_timezone = 8;
>>> + aarch64_linux_record_tdep.size_old_gid_t = 2;
>>> + aarch64_linux_record_tdep.size_old_uid_t = 2;
>>> + aarch64_linux_record_tdep.size_fd_set = 128;
>>> + aarch64_linux_record_tdep.size_dirent = 280;
>>> + aarch64_linux_record_tdep.size_dirent64 = 280;
>>> + aarch64_linux_record_tdep.size_statfs = 120;
>>> + aarch64_linux_record_tdep.size_statfs64 = 120;
>>> + aarch64_linux_record_tdep.size_sockaddr = 16;
>>> + aarch64_linux_record_tdep.size_int
>>> + = gdbarch_int_bit (gdbarch) / TARGET_CHAR_BIT;
>>> + aarch64_linux_record_tdep.size_long
>>> + = gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
>>> + aarch64_linux_record_tdep.size_ulong
>>> + = gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
>>> + aarch64_linux_record_tdep.size_msghdr = 56;
>>> + aarch64_linux_record_tdep.size_itimerval = 32;
>>> + aarch64_linux_record_tdep.size_stat = 144;
>>> + aarch64_linux_record_tdep.size_old_utsname = 325;
>>> + aarch64_linux_record_tdep.size_sysinfo = 112;
>>> + aarch64_linux_record_tdep.size_msqid_ds = 120;
>>> + aarch64_linux_record_tdep.size_shmid_ds = 112;
>>> + aarch64_linux_record_tdep.size_new_utsname = 390;
>>> + aarch64_linux_record_tdep.size_timex = 208;
>>> + aarch64_linux_record_tdep.size_mem_dqinfo = 24;
>>> + aarch64_linux_record_tdep.size_if_dqblk = 72;
>>> + aarch64_linux_record_tdep.size_fs_quota_stat = 80;
>>> + aarch64_linux_record_tdep.size_timespec = 16;
>>> + aarch64_linux_record_tdep.size_pollfd = 8;
>>> + aarch64_linux_record_tdep.size_NFS_FHSIZE = 32;
>>> + aarch64_linux_record_tdep.size_knfsd_fh = 132;
>>> + aarch64_linux_record_tdep.size_TASK_COMM_LEN = 16;
>>> + aarch64_linux_record_tdep.size_sigaction = 152;
>>> + aarch64_linux_record_tdep.size_sigset_t = 128;
>>> + aarch64_linux_record_tdep.size_siginfo_t = 128;
>>> + aarch64_linux_record_tdep.size_cap_user_data_t = 8;
>>> + aarch64_linux_record_tdep.size_stack_t = 24;
>>> + aarch64_linux_record_tdep.size_off_t = 8;
>>> + aarch64_linux_record_tdep.size_stat64 = 144;
>>> + aarch64_linux_record_tdep.size_gid_t = 4;
>>> + aarch64_linux_record_tdep.size_uid_t = 4;
>>> + aarch64_linux_record_tdep.size_PAGE_SIZE = 4096;
>>> + aarch64_linux_record_tdep.size_flock64 = 32;
>>> + aarch64_linux_record_tdep.size_user_desc = 16;
>>> + aarch64_linux_record_tdep.size_io_event = 32;
>>> + aarch64_linux_record_tdep.size_iocb = 64;
>>> + aarch64_linux_record_tdep.size_epoll_event = 12;
>>> + aarch64_linux_record_tdep.size_itimerspec = 32;
>>> + aarch64_linux_record_tdep.size_mq_attr = 64;
>>> + aarch64_linux_record_tdep.size_siginfo = 128;
>>> + aarch64_linux_record_tdep.size_termios = 60;
>>> + aarch64_linux_record_tdep.size_termios2 = 44;
>>> + aarch64_linux_record_tdep.size_pid_t = 4;
>>> + aarch64_linux_record_tdep.size_winsize = 8;
>>> + aarch64_linux_record_tdep.size_serial_struct = 72;
>>> + aarch64_linux_record_tdep.size_serial_icounter_struct = 80;
>>> + aarch64_linux_record_tdep.size_hayes_esp_config = 12;
>>> + aarch64_linux_record_tdep.size_size_t = 8;
>>> + aarch64_linux_record_tdep.size_iovec = 16;
>>> +
>>> + /* These values are the second argument of system call "sys_ioctl".
>>> + They are obtained from Linux Kernel source. */
>>> + aarch64_linux_record_tdep.ioctl_TCGETS = 0x5401;
>>> + aarch64_linux_record_tdep.ioctl_TCSETS = 0x5402;
>>> + aarch64_linux_record_tdep.ioctl_TCSETSW = 0x5403;
>>> + aarch64_linux_record_tdep.ioctl_TCSETSF = 0x5404;
>>> + aarch64_linux_record_tdep.ioctl_TCGETA = 0x5405;
>>> + aarch64_linux_record_tdep.ioctl_TCSETA = 0x5406;
>>> + aarch64_linux_record_tdep.ioctl_TCSETAW = 0x5407;
>>> + aarch64_linux_record_tdep.ioctl_TCSETAF = 0x5408;
>>> + aarch64_linux_record_tdep.ioctl_TCSBRK = 0x5409;
>>> + aarch64_linux_record_tdep.ioctl_TCXONC = 0x540a;
>>> + aarch64_linux_record_tdep.ioctl_TCFLSH = 0x540b;
>>> + aarch64_linux_record_tdep.ioctl_TIOCEXCL = 0x540c;
>>> + aarch64_linux_record_tdep.ioctl_TIOCNXCL = 0x540d;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSCTTY = 0x540e;
>>> + aarch64_linux_record_tdep.ioctl_TIOCGPGRP = 0x540f;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSPGRP = 0x5410;
>>> + aarch64_linux_record_tdep.ioctl_TIOCOUTQ = 0x5411;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSTI = 0x5412;
>>> + aarch64_linux_record_tdep.ioctl_TIOCGWINSZ = 0x5413;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSWINSZ = 0x5414;
>>> + aarch64_linux_record_tdep.ioctl_TIOCMGET = 0x5415;
>>> + aarch64_linux_record_tdep.ioctl_TIOCMBIS = 0x5416;
>>> + aarch64_linux_record_tdep.ioctl_TIOCMBIC = 0x5417;
>>> + aarch64_linux_record_tdep.ioctl_TIOCMSET = 0x5418;
>>> + aarch64_linux_record_tdep.ioctl_TIOCGSOFTCAR = 0x5419;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSSOFTCAR = 0x541a;
>>> + aarch64_linux_record_tdep.ioctl_FIONREAD = 0x541b;
>>> + aarch64_linux_record_tdep.ioctl_TIOCINQ = 0x541b;
>>> + aarch64_linux_record_tdep.ioctl_TIOCLINUX = 0x541c;
>>> + aarch64_linux_record_tdep.ioctl_TIOCCONS = 0x541d;
>>> + aarch64_linux_record_tdep.ioctl_TIOCGSERIAL = 0x541e;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSSERIAL = 0x541f;
>>> + aarch64_linux_record_tdep.ioctl_TIOCPKT = 0x5420;
>>> + aarch64_linux_record_tdep.ioctl_FIONBIO = 0x5421;
>>> + aarch64_linux_record_tdep.ioctl_TIOCNOTTY = 0x5422;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSETD = 0x5423;
>>> + aarch64_linux_record_tdep.ioctl_TIOCGETD = 0x5424;
>>> + aarch64_linux_record_tdep.ioctl_TCSBRKP = 0x5425;
>>> + aarch64_linux_record_tdep.ioctl_TIOCTTYGSTRUCT = 0x5426;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSBRK = 0x5427;
>>> + aarch64_linux_record_tdep.ioctl_TIOCCBRK = 0x5428;
>>> + aarch64_linux_record_tdep.ioctl_TIOCGSID = 0x5429;
>>> + aarch64_linux_record_tdep.ioctl_TCGETS2 = 0x802c542a;
>>> + aarch64_linux_record_tdep.ioctl_TCSETS2 = 0x402c542b;
>>> + aarch64_linux_record_tdep.ioctl_TCSETSW2 = 0x402c542c;
>>> + aarch64_linux_record_tdep.ioctl_TCSETSF2 = 0x402c542d;
>>> + aarch64_linux_record_tdep.ioctl_TIOCGPTN = 0x80045430;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSPTLCK = 0x40045431;
>>> + aarch64_linux_record_tdep.ioctl_FIONCLEX = 0x5450;
>>> + aarch64_linux_record_tdep.ioctl_FIOCLEX = 0x5451;
>>> + aarch64_linux_record_tdep.ioctl_FIOASYNC = 0x5452;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSERCONFIG = 0x5453;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSERGWILD = 0x5454;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSERSWILD = 0x5455;
>>> + aarch64_linux_record_tdep.ioctl_TIOCGLCKTRMIOS = 0x5456;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSLCKTRMIOS = 0x5457;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSERGSTRUCT = 0x5458;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSERGETLSR = 0x5459;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSERGETMULTI = 0x545a;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSERSETMULTI = 0x545b;
>>> + aarch64_linux_record_tdep.ioctl_TIOCMIWAIT = 0x545c;
>>> + aarch64_linux_record_tdep.ioctl_TIOCGICOUNT = 0x545d;
>>> + aarch64_linux_record_tdep.ioctl_TIOCGHAYESESP = 0x545e;
>>> + aarch64_linux_record_tdep.ioctl_TIOCSHAYESESP = 0x545f;
>>> + aarch64_linux_record_tdep.ioctl_FIOQSIZE = 0x5460;
>>> +
>>> + /* These values are the second argument of system call "sys_fcntl"
>>> + and "sys_fcntl64". They are obtained from Linux Kernel source. */
>>> + aarch64_linux_record_tdep.fcntl_F_GETLK = 5;
>>> + aarch64_linux_record_tdep.fcntl_F_GETLK64 = 12;
>>> + aarch64_linux_record_tdep.fcntl_F_SETLK64 = 13;
>>> + aarch64_linux_record_tdep.fcntl_F_SETLKW64 = 14;
>>> +
>>> + /* The AArch64 syscall calling convention: reg x0-x7 for arguments,
>>> + reg x8 for syscall number and return value in reg x0. */
>>> + aarch64_linux_record_tdep.arg1 = AARCH64_X0_REGNUM + 0;
>>> + aarch64_linux_record_tdep.arg2 = AARCH64_X0_REGNUM + 1;
>>> + aarch64_linux_record_tdep.arg3 = AARCH64_X0_REGNUM + 2;
>>> + aarch64_linux_record_tdep.arg4 = AARCH64_X0_REGNUM + 3;
>>> + aarch64_linux_record_tdep.arg5 = AARCH64_X0_REGNUM + 4;
>>> + aarch64_linux_record_tdep.arg6 = AARCH64_X0_REGNUM + 5;
>>> + aarch64_linux_record_tdep.arg7 = AARCH64_X0_REGNUM + 6;
>>> + aarch64_linux_record_tdep.arg8 = AARCH64_X0_REGNUM + 7;
>>> }
>>>
>>> /* Provide a prototype to silence -Wmissing-prototypes. */
>>> diff --git a/gdb/aarch64-linux-tdep.h b/gdb/aarch64-linux-tdep.h
>>> index 2e1de60..1ae3786 100644
>>> --- a/gdb/aarch64-linux-tdep.h
>>> +++ b/gdb/aarch64-linux-tdep.h
>>> @@ -32,3 +32,269 @@
>>>
>>> extern const struct regset aarch64_linux_gregset;
>>> extern const struct regset aarch64_linux_fpregset;
>>> +
>>> +/* Enum that defines the AArch64 linux specific syscall identifiers used for
>>> + process record/replay. */
>>> +
>>> +enum aarch64_syscall {
>>> + aarch64_sys_io_setup = 0,
>>> + aarch64_sys_io_destroy = 1,
>>> + aarch64_sys_io_submit = 2,
>>> + aarch64_sys_io_cancel = 3,
>>> + aarch64_sys_io_getevents = 4,
>>> + aarch64_sys_setxattr = 5,
>>> + aarch64_sys_lsetxattr = 6,
>>> + aarch64_sys_fsetxattr = 7,
>>> + aarch64_sys_getxattr = 8,
>>> + aarch64_sys_lgetxattr = 9,
>>> + aarch64_sys_fgetxattr = 10,
>>> + aarch64_sys_listxattr = 11,
>>> + aarch64_sys_llistxattr = 12,
>>> + aarch64_sys_flistxattr = 13,
>>> + aarch64_sys_removexattr = 14,
>>> + aarch64_sys_lremovexattr = 15,
>>> + aarch64_sys_fremovexattr = 16,
>>> + aarch64_sys_getcwd = 17,
>>> + aarch64_sys_lookup_dcookie = 18,
>>> + aarch64_sys_eventfd2 = 19,
>>> + aarch64_sys_epoll_create1 = 20,
>>> + aarch64_sys_epoll_ctl = 21,
>>> + aarch64_sys_epoll_pwait = 22,
>>> + aarch64_sys_dup = 23,
>>> + aarch64_sys_dup3 = 24,
>>> + aarch64_sys_fcntl = 25,
>>> + aarch64_sys_inotify_init1 = 26,
>>> + aarch64_sys_inotify_add_watch = 27,
>>> + aarch64_sys_inotify_rm_watch = 28,
>>> + aarch64_sys_ioctl = 29,
>>> + aarch64_sys_ioprio_set = 30,
>>> + aarch64_sys_ioprio_get = 31,
>>> + aarch64_sys_flock = 32,
>>> + aarch64_sys_mknod = 33,
>>> + aarch64_sys_mkdir = 34,
>>> + aarch64_sys_unlink = 35,
>>> + aarch64_sys_symlink = 36,
>>> + aarch64_sys_link = 37,
>>> + aarch64_sys_rename = 38,
>>> + aarch64_sys_umount2 = 39,
>>> + aarch64_sys_mount = 40,
>>> + aarch64_sys_pivot_root = 41,
>>> + aarch64_sys_nfsservctl = 42,
>>> + aarch64_sys_statfs = 43,
>>> + aarch64_sys_fstatfs = 44,
>>> + aarch64_sys_truncate = 45,
>>> + aarch64_sys_ftruncate = 46,
>>> + aarch64_sys_fallocate = 47,
>>> + aarch64_sys_faccess = 48,
>>> + aarch64_sys_chdir = 49,
>>> + aarch64_sys_fchdir = 50,
>>> + aarch64_sys_chroot = 51,
>>> + aarch64_sys_fchmod = 52,
>>> + aarch64_sys_fchmodat = 53,
>>> + aarch64_sys_fchownat = 54,
>>> + aarch64_sys_fchown = 55,
>>> + aarch64_sys_open = 56,
>>> + aarch64_sys_close = 57,
>>> + aarch64_sys_vhangup = 58,
>>> + aarch64_sys_pipe2 = 59,
>>> + aarch64_sys_quotactl = 60,
>>> + aarch64_sys_getdents64 = 61,
>>> + aarch64_sys_lseek = 62,
>>> + aarch64_sys_read = 63,
>>> + aarch64_sys_write = 64,
>>> + aarch64_sys_readv = 65,
>>> + aarch64_sys_writev = 66,
>>> + aarch64_sys_pread64 = 67,
>>> + aarch64_sys_pwrite64 = 68,
>>> + aarch64_sys_preadv = 69,
>>> + aarch64_sys_pwritev = 70,
>>> + aarch64_sys_sendfile = 71,
>>> + aarch64_sys_pselect6 = 72,
>>> + aarch64_sys_ppoll = 73,
>>> + aarch64_sys_signalfd4 = 74,
>>> + aarch64_sys_vmsplice = 75,
>>> + aarch64_sys_splice = 76,
>>> + aarch64_sys_tee = 77,
>>> + aarch64_sys_readlink = 78,
>>> + aarch64_sys_fstatat = 79,
>>> + aarch64_sys_fstat = 80,
>>> + aarch64_sys_sync = 81,
>>> + aarch64_sys_fsync = 82,
>>> + aarch64_sys_fdatasync = 83,
>>> + aarch64_sys_sync_file_range2 = 84,
>>> + aarch64_sys_sync_file_range = 84,
>>> + aarch64_sys_timerfd_create = 85,
>>> + aarch64_sys_timerfd_settime = 86,
>>> + aarch64_sys_timerfd_gettime = 87,
>>> + aarch64_sys_utimensat = 88,
>>> + aarch64_sys_acct = 89,
>>> + aarch64_sys_capget = 90,
>>> + aarch64_sys_capset = 91,
>>> + aarch64_sys_personality = 92,
>>> + aarch64_sys_exit = 93,
>>> + aarch64_sys_exit_group = 94,
>>> + aarch64_sys_waitid = 95,
>>> + aarch64_sys_set_tid_address = 96,
>>> + aarch64_sys_unshare = 97,
>>> + aarch64_sys_futex = 98,
>>> + aarch64_sys_set_robust_list = 99,
>>> + aarch64_sys_get_robust_list = 100,
>>> + aarch64_sys_nanosleep = 101,
>>> + aarch64_sys_getitimer = 102,
>>> + aarch64_sys_setitimer = 103,
>>> + aarch64_sys_kexec_load = 104,
>>> + aarch64_sys_init_module = 105,
>>> + aarch64_sys_delete_module = 106,
>>> + aarch64_sys_timer_create = 107,
>>> + aarch64_sys_timer_gettime = 108,
>>> + aarch64_sys_timer_getoverrun = 109,
>>> + aarch64_sys_timer_settime = 110,
>>> + aarch64_sys_timer_delete = 111,
>>> + aarch64_sys_clock_settime = 112,
>>> + aarch64_sys_clock_gettime = 113,
>>> + aarch64_sys_clock_getres = 114,
>>> + aarch64_sys_clock_nanosleep = 115,
>>> + aarch64_sys_syslog = 116,
>>> + aarch64_sys_ptrace = 117,
>>> + aarch64_sys_sched_setparam = 118,
>>> + aarch64_sys_sched_setscheduler = 119,
>>> + aarch64_sys_sched_getscheduler = 120,
>>> + aarch64_sys_sched_getparam = 121,
>>> + aarch64_sys_sched_setaffinity = 122,
>>> + aarch64_sys_sched_getaffinity = 123,
>>> + aarch64_sys_sched_yield = 124,
>>> + aarch64_sys_sched_get_priority_max = 125,
>>> + aarch64_sys_sched_get_priority_min = 126,
>>> + aarch64_sys_sched_rr_get_interval = 127,
>>> + aarch64_sys_kill = 129,
>>> + aarch64_sys_tkill = 130,
>>> + aarch64_sys_tgkill = 131,
>>> + aarch64_sys_sigaltstack = 132,
>>> + aarch64_sys_rt_sigsuspend = 133,
>>> + aarch64_sys_rt_sigaction = 134,
>>> + aarch64_sys_rt_sigprocmask = 135,
>>> + aarch64_sys_rt_sigpending = 136,
>>> + aarch64_sys_rt_sigtimedwait = 137,
>>> + aarch64_sys_rt_sigqueueinfo = 138,
>>> + aarch64_sys_rt_sigreturn = 139,
>>> + aarch64_sys_setpriority = 140,
>>> + aarch64_sys_getpriority = 141,
>>> + aarch64_sys_reboot = 142,
>>> + aarch64_sys_setregid = 143,
>>> + aarch64_sys_setgid = 144,
>>> + aarch64_sys_setreuid = 145,
>>> + aarch64_sys_setuid = 146,
>>> + aarch64_sys_setresuid = 147,
>>> + aarch64_sys_getresuid = 148,
>>> + aarch64_sys_setresgid = 149,
>>> + aarch64_sys_getresgid = 150,
>>> + aarch64_sys_setfsuid = 151,
>>> + aarch64_sys_setfsgid = 152,
>>> + aarch64_sys_times = 153,
>>> + aarch64_sys_setpgid = 154,
>>> + aarch64_sys_getpgid = 155,
>>> + aarch64_sys_getsid = 156,
>>> + aarch64_sys_setsid = 157,
>>> + aarch64_sys_getgroups = 158,
>>> + aarch64_sys_setgroups = 159,
>>> + aarch64_sys_uname = 160,
>>> + aarch64_sys_sethostname = 161,
>>> + aarch64_sys_setdomainname = 162,
>>> + aarch64_sys_getrlimit = 163,
>>> + aarch64_sys_setrlimit = 164,
>>> + aarch64_sys_getrusage = 165,
>>> + aarch64_sys_umask = 166,
>>> + aarch64_sys_prctl = 167,
>>> + aarch64_sys_getcpu = 168,
>>> + aarch64_sys_gettimeofday = 169,
>>> + aarch64_sys_settimeofday = 170,
>>> + aarch64_sys_adjtimex = 171,
>>> + aarch64_sys_getpid = 172,
>>> + aarch64_sys_getppid = 173,
>>> + aarch64_sys_getuid = 174,
>>> + aarch64_sys_geteuid = 175,
>>> + aarch64_sys_getgid = 176,
>>> + aarch64_sys_getegid = 177,
>>> + aarch64_sys_gettid = 178,
>>> + aarch64_sys_sysinfo = 179,
>>> + aarch64_sys_mq_open = 180,
>>> + aarch64_sys_mq_unlink = 181,
>>> + aarch64_sys_mq_timedsend = 182,
>>> + aarch64_sys_mq_timedreceive = 183,
>>> + aarch64_sys_mq_notify = 184,
>>> + aarch64_sys_mq_getsetattr = 185,
>>> + aarch64_sys_msgget = 186,
>>> + aarch64_sys_msgctl = 187,
>>> + aarch64_sys_msgrcv = 188,
>>> + aarch64_sys_msgsnd = 189,
>>> + aarch64_sys_semget = 190,
>>> + aarch64_sys_semctl = 191,
>>> + aarch64_sys_semtimedop = 192,
>>> + aarch64_sys_semop = 193,
>>> + aarch64_sys_shmget = 194,
>>> + aarch64_sys_shmctl = 195,
>>> + aarch64_sys_shmat = 196,
>>> + aarch64_sys_shmdt = 197,
>>> + aarch64_sys_socket = 198,
>>> + aarch64_sys_socketpair = 199,
>>> + aarch64_sys_bind = 200,
>>> + aarch64_sys_listen = 201,
>>> + aarch64_sys_accept = 202,
>>> + aarch64_sys_connect = 203,
>>> + aarch64_sys_getsockname = 204,
>>> + aarch64_sys_getpeername = 205,
>>> + aarch64_sys_sendto = 206,
>>> + aarch64_sys_recvfrom = 207,
>>> + aarch64_sys_setsockopt = 208,
>>> + aarch64_sys_getsockopt = 209,
>>> + aarch64_sys_shutdown = 210,
>>> + aarch64_sys_sendmsg = 211,
>>> + aarch64_sys_recvmsg = 212,
>>> + aarch64_sys_readahead = 213,
>>> + aarch64_sys_brk = 214,
>>> + aarch64_sys_munmap = 215,
>>> + aarch64_sys_mremap = 216,
>>> + aarch64_sys_add_key = 217,
>>> + aarch64_sys_request_key = 218,
>>> + aarch64_sys_keyctl = 219,
>>> + aarch64_sys_clone = 220,
>>> + aarch64_sys_execve = 221,
>>> + aarch64_sys_mmap = 222,
>>> + aarch64_sys_fadvise64 = 223,
>>> + aarch64_sys_swapon = 224,
>>> + aarch64_sys_swapoff = 225,
>>> + aarch64_sys_mprotect = 226,
>>> + aarch64_sys_msync = 227,
>>> + aarch64_sys_mlock = 228,
>>> + aarch64_sys_munlock = 229,
>>> + aarch64_sys_mlockall = 230,
>>> + aarch64_sys_munlockall = 231,
>>> + aarch64_sys_mincore = 232,
>>> + aarch64_sys_madvise = 233,
>>> + aarch64_sys_remap_file_pages = 234,
>>> + aarch64_sys_mbind = 235,
>>> + aarch64_sys_get_mempolicy = 236,
>>> + aarch64_sys_set_mempolicy = 237,
>>> + aarch64_sys_migrate_pages = 238,
>>> + aarch64_sys_move_pages = 239,
>>> + aarch64_sys_rt_tgsigqueueinfo = 240,
>>> + aarch64_sys_perf_event_open = 241,
>>> + aarch64_sys_accept4 = 242,
>>> + aarch64_sys_recvmmsg = 243,
>>> + aarch64_sys_wait4 = 260,
>>> + aarch64_sys_prlimit64 = 261,
>>> + aarch64_sys_fanotify_init = 262,
>>> + aarch64_sys_fanotify_mark = 263,
>>> + aarch64_sys_name_to_handle_at = 264,
>>> + aarch64_sys_open_by_handle_at = 265,
>>> + aarch64_sys_clock_adjtime = 266,
>>> + aarch64_sys_syncfs = 267,
>>> + aarch64_sys_setns = 268,
>>> + aarch64_sys_sendmmsg = 269,
>>> + aarch64_sys_process_vm_readv = 270,
>>> + aarch64_sys_process_vm_writev = 271,
>>> + aarch64_sys_kcmp = 272,
>>> + aarch64_sys_finit_module = 273,
>>> + aarch64_sys_sched_setattr = 274,
>>> + aarch64_sys_sched_getattr = 275,
>>> +};
>>> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
>>> index 0847585..c6da25a 100644
>>> --- a/gdb/aarch64-tdep.c
>>> +++ b/gdb/aarch64-tdep.c
>>> @@ -2941,7 +2941,20 @@ aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
>>> {
>>> /* Exception generation instructions. */
>>> if (insn_bits24_27 == 0x04)
>>> - return AARCH64_RECORD_UNSUPPORTED;
>>> + {
>>> + if (!bits (aarch64_insn_r->aarch64_insn, 2, 4) &&
>>> + !bits (aarch64_insn_r->aarch64_insn, 21, 23) &&
>>> + bits (aarch64_insn_r->aarch64_insn, 0, 1) == 0x01)
>>> + {
>>> + ULONGEST svc_number;
>>> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, 8,
>>> + &svc_number);
>>> + return tdep->aarch64_syscall_record (aarch64_insn_r->regcache,
>>> + svc_number);
>>> + }
>>> + else
>>> + return AARCH64_RECORD_UNSUPPORTED;
>>> + }
>>> /* System instructions. */
>>> else if (insn_bits24_27 == 0x05 && insn_bits22_23 == 0x00)
>>> {
>>> diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
>>> index 1d74ef8..25751fe 100644
>>> --- a/gdb/aarch64-tdep.h
>>> +++ b/gdb/aarch64-tdep.h
>>> @@ -88,6 +88,9 @@ struct gdbarch_tdep
>>> struct type *vns_type;
>>> struct type *vnh_type;
>>> struct type *vnb_type;
>>> +
>>> + /* syscall record. */
>>> + int (*aarch64_syscall_record) (struct regcache *regcache, unsigned long svc_number);
>>> };
>>>
>>> /* AArch64 process record-replay related structures, defines etc. */
>>> diff --git a/gdb/linux-record.h b/gdb/linux-record.h
>>> index 7b5218e..2649ce5 100644
>>> --- a/gdb/linux-record.h
>>> +++ b/gdb/linux-record.h
>>> @@ -174,6 +174,8 @@ struct linux_record_tdep
>>> int arg4;
>>> int arg5;
>>> int arg6;
>>> + int arg7;
>>> + int arg8;
>>> };
>>>
>>> /* Enum that defines the gdb-canonical set of Linux syscall identifiers.
>>> --
>>> 1.9.1
>>>
>>
>>
>>
>> --
>> Will Newton
>> Toolchain Working Group, Linaro
>
> Ping! Kindly help me approve this patch.
ping!
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 5/7] Support for recording syscall on aarch64-linux
2014-10-14 12:47 ` Omair Javaid
@ 2014-10-21 9:09 ` Omair Javaid
0 siblings, 0 replies; 53+ messages in thread
From: Omair Javaid @ 2014-10-21 9:09 UTC (permalink / raw)
To: Will Newton, Pedro Alves; +Cc: gdb-patches
On 14/10/2014 17:47, Omair Javaid wrote:
> On 19 September 2014 03:27, Omair Javaid <omair.javaid@linaro.org> wrote:
>> On 18 September 2014 05:22, Will Newton <will.newton@linaro.org> wrote:
>>> On 29 August 2014 04:53, Omair Javaid <omair.javaid@linaro.org> wrote:
>>>> Suggestion have been incorporated and updated patch is given below.
>>>>
>>>> gdb:
>>>>
>>>> 2014-08-28 Omair Javaid <omair.javaid@linaro.org>
>>>>
>>>> * aarch64-linux-tdep.c (record.h): Include.
>>>> (record-full.h): Include.
>>>> (struct linux_record_tdep aarch64_linux_record_tdep): Declare.
>>>> (aarch64_canonicalize_syscall): New function to translate syscall
>>>> numbers from aarch64 to canonical.
>>>> (aarch64_all_but_pc_registers_record): New function.
>>>> (aarch64_linux_syscall_record): New function.
>>>> (aarch64_linux_init_abi): Update to handle syscall recording.
>>>> * aarch64-linux-tdep.h (aarch64_syscall): New enum.
>>>> * aarch64-tdep.c (aarch64_record_branch_except_sys): Add code to
>>>> handle recording of syscalls.
>>>> * aarch64-tdep.h
>>>> (struct gdbarch_tdep) <aarch64_syscall_record>: Defined.
>>>> * linux-record.h (struct linux_record_tdep): Add two more syscall
>>>> argument fields.
>>>>
>>>> ---
>>>> gdb/aarch64-linux-tdep.c | 913 +++++++++++++++++++++++++++++++++++++++++++++++
>>>> gdb/aarch64-linux-tdep.h | 266 ++++++++++++++
>>>> gdb/aarch64-tdep.c | 15 +-
>>>> gdb/aarch64-tdep.h | 3 +
>>>> gdb/linux-record.h | 2 +
>>>> 5 files changed, 1198 insertions(+), 1 deletion(-)
>>>
>>> This one looks ok to me now.
>>>
>>>> diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c
>>>> index 5ab7b37..82b55b6 100644
>>>> --- a/gdb/aarch64-linux-tdep.c
>>>> +++ b/gdb/aarch64-linux-tdep.c
>>>> @@ -41,6 +41,9 @@
>>>> #include "user-regs.h"
>>>> #include <ctype.h>
>>>>
>>>> +#include "record-full.h"
>>>> +#include "linux-record.h"
>>>> +
>>>> /* Signal frame handling.
>>>>
>>>> +------------+ ^
>>>> @@ -354,6 +357,752 @@ aarch64_stap_parse_special_token (struct gdbarch *gdbarch,
>>>> return 1;
>>>> }
>>>>
>>>> +/* AArch64 process record-replay constructs: syscall, signal etc. */
>>>> +
>>>> +struct linux_record_tdep aarch64_linux_record_tdep;
>>>> +
>>>> +/* aarch64_canonicalize_syscall maps syscall ids from the native AArch64
>>>> + linux set of syscall ids into a canonical set of syscall ids used by
>>>> + process record. */
>>>> +
>>>> +static enum gdb_syscall
>>>> +aarch64_canonicalize_syscall (enum aarch64_syscall syscall_number)
>>>> +{
>>>> + switch (syscall_number) {
>>>> + case aarch64_sys_read:
>>>> + return gdb_sys_read;
>>>> +
>>>> + case aarch64_sys_write:
>>>> + return gdb_sys_write;
>>>> +
>>>> + case aarch64_sys_open:
>>>> + return gdb_sys_open;
>>>> +
>>>> + case aarch64_sys_close:
>>>> + return gdb_sys_close;
>>>> +
>>>> + case aarch64_sys_lseek:
>>>> + return gdb_sys_lseek;
>>>> +
>>>> + case aarch64_sys_mprotect:
>>>> + return gdb_sys_mprotect;
>>>> +
>>>> + case aarch64_sys_munmap:
>>>> + return gdb_sys_munmap;
>>>> +
>>>> + case aarch64_sys_brk:
>>>> + return gdb_sys_brk;
>>>> +
>>>> + case aarch64_sys_rt_sigaction:
>>>> + return gdb_sys_rt_sigaction;
>>>> +
>>>> + case aarch64_sys_rt_sigprocmask:
>>>> + return gdb_sys_rt_sigprocmask;
>>>> +
>>>> + case aarch64_sys_rt_sigreturn:
>>>> + return gdb_sys_rt_sigreturn;
>>>> +
>>>> + case aarch64_sys_ioctl:
>>>> + return gdb_sys_ioctl;
>>>> +
>>>> + case aarch64_sys_pread64:
>>>> + return gdb_sys_pread64;
>>>> +
>>>> + case aarch64_sys_pwrite64:
>>>> + return gdb_sys_pwrite64;
>>>> +
>>>> + case aarch64_sys_readv:
>>>> + return gdb_sys_readv;
>>>> +
>>>> + case aarch64_sys_writev:
>>>> + return gdb_sys_writev;
>>>> +
>>>> + case aarch64_sys_sched_yield:
>>>> + return gdb_sys_sched_yield;
>>>> +
>>>> + case aarch64_sys_mremap:
>>>> + return gdb_sys_mremap;
>>>> +
>>>> + case aarch64_sys_msync:
>>>> + return gdb_sys_msync;
>>>> +
>>>> + case aarch64_sys_mincore:
>>>> + return gdb_sys_mincore;
>>>> +
>>>> + case aarch64_sys_madvise:
>>>> + return gdb_sys_madvise;
>>>> +
>>>> + case aarch64_sys_shmget:
>>>> + return gdb_sys_shmget;
>>>> +
>>>> + case aarch64_sys_shmat:
>>>> + return gdb_sys_shmat;
>>>> +
>>>> + case aarch64_sys_shmctl:
>>>> + return gdb_sys_shmctl;
>>>> +
>>>> + case aarch64_sys_dup:
>>>> + return gdb_sys_dup;
>>>> +
>>>> + case aarch64_sys_nanosleep:
>>>> + return gdb_sys_nanosleep;
>>>> +
>>>> + case aarch64_sys_getitimer:
>>>> + return gdb_sys_getitimer;
>>>> +
>>>> + case aarch64_sys_setitimer:
>>>> + return gdb_sys_setitimer;
>>>> +
>>>> + case aarch64_sys_getpid:
>>>> + return gdb_sys_getpid;
>>>> +
>>>> + case aarch64_sys_sendfile:
>>>> + return gdb_sys_sendfile;
>>>> +
>>>> + case aarch64_sys_socket:
>>>> + return gdb_sys_socket;
>>>> +
>>>> + case aarch64_sys_connect:
>>>> + return gdb_sys_connect;
>>>> +
>>>> + case aarch64_sys_accept:
>>>> + return gdb_sys_accept;
>>>> +
>>>> + case aarch64_sys_sendto:
>>>> + return gdb_sys_sendto;
>>>> +
>>>> + case aarch64_sys_recvfrom:
>>>> + return gdb_sys_recvfrom;
>>>> +
>>>> + case aarch64_sys_sendmsg:
>>>> + return gdb_sys_sendmsg;
>>>> +
>>>> + case aarch64_sys_recvmsg:
>>>> + return gdb_sys_recvmsg;
>>>> +
>>>> + case aarch64_sys_shutdown:
>>>> + return gdb_sys_shutdown;
>>>> +
>>>> + case aarch64_sys_bind:
>>>> + return gdb_sys_bind;
>>>> +
>>>> + case aarch64_sys_listen:
>>>> + return gdb_sys_listen;
>>>> +
>>>> + case aarch64_sys_getsockname:
>>>> + return gdb_sys_getsockname;
>>>> +
>>>> + case aarch64_sys_getpeername:
>>>> + return gdb_sys_getpeername;
>>>> +
>>>> + case aarch64_sys_socketpair:
>>>> + return gdb_sys_socketpair;
>>>> +
>>>> + case aarch64_sys_setsockopt:
>>>> + return gdb_sys_setsockopt;
>>>> +
>>>> + case aarch64_sys_getsockopt:
>>>> + return gdb_sys_getsockopt;
>>>> +
>>>> + case aarch64_sys_clone:
>>>> + return gdb_sys_clone;
>>>> +
>>>> + case aarch64_sys_execve:
>>>> + return gdb_sys_execve;
>>>> +
>>>> + case aarch64_sys_exit:
>>>> + return gdb_sys_exit;
>>>> +
>>>> + case aarch64_sys_wait4:
>>>> + return gdb_sys_wait4;
>>>> +
>>>> + case aarch64_sys_kill:
>>>> + return gdb_sys_kill;
>>>> +
>>>> + case aarch64_sys_uname:
>>>> + return gdb_sys_uname;
>>>> +
>>>> + case aarch64_sys_semget:
>>>> + return gdb_sys_semget;
>>>> +
>>>> + case aarch64_sys_semop:
>>>> + return gdb_sys_semop;
>>>> +
>>>> + case aarch64_sys_semctl:
>>>> + return gdb_sys_semctl;
>>>> +
>>>> + case aarch64_sys_shmdt:
>>>> + return gdb_sys_shmdt;
>>>> +
>>>> + case aarch64_sys_msgget:
>>>> + return gdb_sys_msgget;
>>>> +
>>>> + case aarch64_sys_msgsnd:
>>>> + return gdb_sys_msgsnd;
>>>> +
>>>> + case aarch64_sys_msgrcv:
>>>> + return gdb_sys_msgrcv;
>>>> +
>>>> + case aarch64_sys_msgctl:
>>>> + return gdb_sys_msgctl;
>>>> +
>>>> + case aarch64_sys_fcntl:
>>>> + return gdb_sys_fcntl;
>>>> +
>>>> + case aarch64_sys_flock:
>>>> + return gdb_sys_flock;
>>>> +
>>>> + case aarch64_sys_fsync:
>>>> + return gdb_sys_fsync;
>>>> +
>>>> + case aarch64_sys_fdatasync:
>>>> + return gdb_sys_fdatasync;
>>>> +
>>>> + case aarch64_sys_truncate:
>>>> + return gdb_sys_truncate;
>>>> +
>>>> + case aarch64_sys_ftruncate:
>>>> + return gdb_sys_ftruncate;
>>>> +
>>>> + case aarch64_sys_getcwd:
>>>> + return gdb_sys_getcwd;
>>>> +
>>>> + case aarch64_sys_chdir:
>>>> + return gdb_sys_chdir;
>>>> +
>>>> + case aarch64_sys_fchdir:
>>>> + return gdb_sys_fchdir;
>>>> +
>>>> + case aarch64_sys_rename:
>>>> + return gdb_sys_rename;
>>>> +
>>>> + case aarch64_sys_mkdir:
>>>> + return gdb_sys_mkdir;
>>>> +
>>>> + case aarch64_sys_link:
>>>> + return gdb_sys_link;
>>>> +
>>>> + case aarch64_sys_unlink:
>>>> + return gdb_sys_unlink;
>>>> +
>>>> + case aarch64_sys_symlink:
>>>> + return gdb_sys_symlink;
>>>> +
>>>> + case aarch64_sys_readlink:
>>>> + return gdb_sys_readlink;
>>>> +
>>>> + case aarch64_sys_fchmodat:
>>>> + return gdb_sys_fchmodat;
>>>> +
>>>> + case aarch64_sys_fchmod:
>>>> + return gdb_sys_fchmod;
>>>> +
>>>> + case aarch64_sys_fchownat:
>>>> + return gdb_sys_fchownat;
>>>> +
>>>> + case aarch64_sys_fchown:
>>>> + return gdb_sys_fchown;
>>>> +
>>>> + case aarch64_sys_umask:
>>>> + return gdb_sys_umask;
>>>> +
>>>> + case aarch64_sys_gettimeofday:
>>>> + return gdb_sys_gettimeofday;
>>>> +
>>>> + case aarch64_sys_getrlimit:
>>>> + return gdb_sys_getrlimit;
>>>> +
>>>> + case aarch64_sys_getrusage:
>>>> + return gdb_sys_getrusage;
>>>> +
>>>> + case aarch64_sys_sysinfo:
>>>> + return gdb_sys_sysinfo;
>>>> +
>>>> + case aarch64_sys_ptrace:
>>>> + return gdb_sys_ptrace;
>>>> +
>>>> + case aarch64_sys_getuid:
>>>> + return gdb_sys_getuid;
>>>> +
>>>> + case aarch64_sys_syslog:
>>>> + return gdb_sys_syslog;
>>>> +
>>>> + case aarch64_sys_getgid:
>>>> + return gdb_sys_getgid;
>>>> +
>>>> + case aarch64_sys_setuid:
>>>> + return gdb_sys_setuid;
>>>> +
>>>> + case aarch64_sys_setgid:
>>>> + return gdb_sys_setgid;
>>>> +
>>>> + case aarch64_sys_geteuid:
>>>> + return gdb_sys_geteuid;
>>>> +
>>>> + case aarch64_sys_getegid:
>>>> + return gdb_sys_getegid;
>>>> +
>>>> + case aarch64_sys_setpgid:
>>>> + return gdb_sys_setpgid;
>>>> +
>>>> + case aarch64_sys_getppid:
>>>> + return gdb_sys_getppid;
>>>> +
>>>> + case aarch64_sys_setsid:
>>>> + return gdb_sys_setsid;
>>>> +
>>>> + case aarch64_sys_setreuid:
>>>> + return gdb_sys_setreuid;
>>>> +
>>>> + case aarch64_sys_setregid:
>>>> + return gdb_sys_setregid;
>>>> +
>>>> + case aarch64_sys_getgroups:
>>>> + return gdb_sys_getgroups;
>>>> +
>>>> + case aarch64_sys_setgroups:
>>>> + return gdb_sys_setgroups;
>>>> +
>>>> + case aarch64_sys_setresuid:
>>>> + return gdb_sys_setresuid;
>>>> +
>>>> + case aarch64_sys_getresuid:
>>>> + return gdb_sys_getresuid;
>>>> +
>>>> + case aarch64_sys_setresgid:
>>>> + return gdb_sys_setresgid;
>>>> +
>>>> + case aarch64_sys_getresgid:
>>>> + return gdb_sys_getresgid;
>>>> +
>>>> + case aarch64_sys_getpgid:
>>>> + return gdb_sys_getpgid;
>>>> +
>>>> + case aarch64_sys_setfsuid:
>>>> + return gdb_sys_setfsuid;
>>>> +
>>>> + case aarch64_sys_setfsgid:
>>>> + return gdb_sys_setfsgid;
>>>> +
>>>> + case aarch64_sys_getsid:
>>>> + return gdb_sys_getsid;
>>>> +
>>>> + case aarch64_sys_capget:
>>>> + return gdb_sys_capget;
>>>> +
>>>> + case aarch64_sys_capset:
>>>> + return gdb_sys_capset;
>>>> +
>>>> + case aarch64_sys_rt_sigpending:
>>>> + return gdb_sys_rt_sigpending;
>>>> +
>>>> + case aarch64_sys_rt_sigtimedwait:
>>>> + return gdb_sys_rt_sigtimedwait;
>>>> +
>>>> + case aarch64_sys_rt_sigqueueinfo:
>>>> + return gdb_sys_rt_sigqueueinfo;
>>>> +
>>>> + case aarch64_sys_rt_sigsuspend:
>>>> + return gdb_sys_rt_sigsuspend;
>>>> +
>>>> + case aarch64_sys_sigaltstack:
>>>> + return gdb_sys_sigaltstack;
>>>> +
>>>> + case aarch64_sys_mknod:
>>>> + return gdb_sys_mknod;
>>>> +
>>>> + case aarch64_sys_personality:
>>>> + return gdb_sys_personality;
>>>> +
>>>> + case aarch64_sys_statfs:
>>>> + return gdb_sys_statfs;
>>>> +
>>>> + case aarch64_sys_fstat:
>>>> + return gdb_sys_fstat;
>>>> +
>>>> + case aarch64_sys_fstatfs:
>>>> + return gdb_sys_fstatfs;
>>>> +
>>>> + case aarch64_sys_getpriority:
>>>> + return gdb_sys_getpriority;
>>>> +
>>>> + case aarch64_sys_setpriority:
>>>> + return gdb_sys_setpriority;
>>>> +
>>>> + case aarch64_sys_sched_setparam:
>>>> + return gdb_sys_sched_setparam;
>>>> +
>>>> + case aarch64_sys_sched_getparam:
>>>> + return gdb_sys_sched_getparam;
>>>> +
>>>> + case aarch64_sys_sched_setscheduler:
>>>> + return gdb_sys_sched_setscheduler;
>>>> +
>>>> + case aarch64_sys_sched_getscheduler:
>>>> + return gdb_sys_sched_getscheduler;
>>>> +
>>>> + case aarch64_sys_sched_get_priority_max:
>>>> + return gdb_sys_sched_get_priority_max;
>>>> +
>>>> + case aarch64_sys_sched_get_priority_min:
>>>> + return gdb_sys_sched_get_priority_min;
>>>> +
>>>> + case aarch64_sys_sched_rr_get_interval:
>>>> + return gdb_sys_sched_rr_get_interval;
>>>> +
>>>> + case aarch64_sys_mlock:
>>>> + return gdb_sys_mlock;
>>>> +
>>>> + case aarch64_sys_munlock:
>>>> + return gdb_sys_munlock;
>>>> +
>>>> + case aarch64_sys_mlockall:
>>>> + return gdb_sys_mlockall;
>>>> +
>>>> + case aarch64_sys_munlockall:
>>>> + return gdb_sys_munlockall;
>>>> +
>>>> + case aarch64_sys_vhangup:
>>>> + return gdb_sys_vhangup;
>>>> +
>>>> + case aarch64_sys_prctl:
>>>> + return gdb_sys_prctl;
>>>> +
>>>> + case aarch64_sys_adjtimex:
>>>> + return gdb_sys_adjtimex;
>>>> +
>>>> + case aarch64_sys_setrlimit:
>>>> + return gdb_sys_setrlimit;
>>>> +
>>>> + case aarch64_sys_chroot:
>>>> + return gdb_sys_chroot;
>>>> +
>>>> + case aarch64_sys_sync:
>>>> + return gdb_sys_sync;
>>>> +
>>>> + case aarch64_sys_acct:
>>>> + return gdb_sys_acct;
>>>> +
>>>> + case aarch64_sys_settimeofday:
>>>> + return gdb_sys_settimeofday;
>>>> +
>>>> + case aarch64_sys_mount:
>>>> + return gdb_sys_mount;
>>>> +
>>>> + case aarch64_sys_swapon:
>>>> + return gdb_sys_swapon;
>>>> +
>>>> + case aarch64_sys_swapoff:
>>>> + return gdb_sys_swapoff;
>>>> +
>>>> + case aarch64_sys_reboot:
>>>> + return gdb_sys_reboot;
>>>> +
>>>> + case aarch64_sys_sethostname:
>>>> + return gdb_sys_sethostname;
>>>> +
>>>> + case aarch64_sys_setdomainname:
>>>> + return gdb_sys_setdomainname;
>>>> +
>>>> + case aarch64_sys_init_module:
>>>> + return gdb_sys_init_module;
>>>> +
>>>> + case aarch64_sys_delete_module:
>>>> + return gdb_sys_delete_module;
>>>> +
>>>> + case aarch64_sys_quotactl:
>>>> + return gdb_sys_quotactl;
>>>> +
>>>> + case aarch64_sys_nfsservctl:
>>>> + return gdb_sys_nfsservctl;
>>>> +
>>>> + case aarch64_sys_gettid:
>>>> + return gdb_sys_gettid;
>>>> +
>>>> + case aarch64_sys_readahead:
>>>> + return gdb_sys_readahead;
>>>> +
>>>> + case aarch64_sys_setxattr:
>>>> + return gdb_sys_setxattr;
>>>> +
>>>> + case aarch64_sys_lsetxattr:
>>>> + return gdb_sys_lsetxattr;
>>>> +
>>>> + case aarch64_sys_fsetxattr:
>>>> + return gdb_sys_fsetxattr;
>>>> +
>>>> + case aarch64_sys_getxattr:
>>>> + return gdb_sys_getxattr;
>>>> +
>>>> + case aarch64_sys_lgetxattr:
>>>> + return gdb_sys_lgetxattr;
>>>> +
>>>> + case aarch64_sys_fgetxattr:
>>>> + return gdb_sys_fgetxattr;
>>>> +
>>>> + case aarch64_sys_listxattr:
>>>> + return gdb_sys_listxattr;
>>>> +
>>>> + case aarch64_sys_llistxattr:
>>>> + return gdb_sys_llistxattr;
>>>> +
>>>> + case aarch64_sys_flistxattr:
>>>> + return gdb_sys_flistxattr;
>>>> +
>>>> + case aarch64_sys_removexattr:
>>>> + return gdb_sys_removexattr;
>>>> +
>>>> + case aarch64_sys_lremovexattr:
>>>> + return gdb_sys_lremovexattr;
>>>> +
>>>> + case aarch64_sys_fremovexattr:
>>>> + return gdb_sys_fremovexattr;
>>>> +
>>>> + case aarch64_sys_tkill:
>>>> + return gdb_sys_tkill;
>>>> +
>>>> + case aarch64_sys_times:
>>>> + return gdb_sys_times;
>>>> +
>>>> + case aarch64_sys_futex:
>>>> + return gdb_sys_futex;
>>>> +
>>>> + case aarch64_sys_sched_setaffinity:
>>>> + return gdb_sys_sched_setaffinity;
>>>> +
>>>> + case aarch64_sys_sched_getaffinity:
>>>> + return gdb_sys_sched_getaffinity;
>>>> +
>>>> + case aarch64_sys_io_setup:
>>>> + return gdb_sys_io_setup;
>>>> +
>>>> + case aarch64_sys_io_destroy:
>>>> + return gdb_sys_io_destroy;
>>>> +
>>>> + case aarch64_sys_io_getevents:
>>>> + return gdb_sys_io_getevents;
>>>> +
>>>> + case aarch64_sys_io_submit:
>>>> + return gdb_sys_io_submit;
>>>> +
>>>> + case aarch64_sys_io_cancel:
>>>> + return gdb_sys_io_cancel;
>>>> +
>>>> + case aarch64_sys_lookup_dcookie:
>>>> + return gdb_sys_lookup_dcookie;
>>>> +
>>>> + case aarch64_sys_epoll_create1:
>>>> + return gdb_sys_epoll_create;
>>>> +
>>>> + case aarch64_sys_remap_file_pages:
>>>> + return gdb_sys_remap_file_pages;
>>>> +
>>>> + case aarch64_sys_getdents64:
>>>> + return gdb_sys_getdents64;
>>>> +
>>>> + case aarch64_sys_set_tid_address:
>>>> + return gdb_sys_set_tid_address;
>>>> +
>>>> + case aarch64_sys_semtimedop:
>>>> + return gdb_sys_semtimedop;
>>>> +
>>>> + case aarch64_sys_fadvise64:
>>>> + return gdb_sys_fadvise64;
>>>> +
>>>> + case aarch64_sys_timer_create:
>>>> + return gdb_sys_timer_create;
>>>> +
>>>> + case aarch64_sys_timer_settime:
>>>> + return gdb_sys_timer_settime;
>>>> +
>>>> + case aarch64_sys_timer_gettime:
>>>> + return gdb_sys_timer_gettime;
>>>> +
>>>> + case aarch64_sys_timer_getoverrun:
>>>> + return gdb_sys_timer_getoverrun;
>>>> +
>>>> + case aarch64_sys_timer_delete:
>>>> + return gdb_sys_timer_delete;
>>>> +
>>>> + case aarch64_sys_clock_settime:
>>>> + return gdb_sys_clock_settime;
>>>> +
>>>> + case aarch64_sys_clock_gettime:
>>>> + return gdb_sys_clock_gettime;
>>>> +
>>>> + case aarch64_sys_clock_getres:
>>>> + return gdb_sys_clock_getres;
>>>> +
>>>> + case aarch64_sys_clock_nanosleep:
>>>> + return gdb_sys_clock_nanosleep;
>>>> +
>>>> + case aarch64_sys_exit_group:
>>>> + return gdb_sys_exit_group;
>>>> +
>>>> + case aarch64_sys_epoll_pwait:
>>>> + return gdb_sys_epoll_pwait;
>>>> +
>>>> + case aarch64_sys_epoll_ctl:
>>>> + return gdb_sys_epoll_ctl;
>>>> +
>>>> + case aarch64_sys_tgkill:
>>>> + return gdb_sys_tgkill;
>>>> +
>>>> + case aarch64_sys_mbind:
>>>> + return gdb_sys_mbind;
>>>> +
>>>> + case aarch64_sys_set_mempolicy:
>>>> + return gdb_sys_set_mempolicy;
>>>> +
>>>> + case aarch64_sys_get_mempolicy:
>>>> + return gdb_sys_get_mempolicy;
>>>> +
>>>> + case aarch64_sys_mq_open:
>>>> + return gdb_sys_mq_open;
>>>> +
>>>> + case aarch64_sys_mq_unlink:
>>>> + return gdb_sys_mq_unlink;
>>>> +
>>>> + case aarch64_sys_mq_timedsend:
>>>> + return gdb_sys_mq_timedsend;
>>>> +
>>>> + case aarch64_sys_mq_timedreceive:
>>>> + return gdb_sys_mq_timedreceive;
>>>> +
>>>> + case aarch64_sys_mq_notify:
>>>> + return gdb_sys_mq_notify;
>>>> +
>>>> + case aarch64_sys_mq_getsetattr:
>>>> + return gdb_sys_mq_getsetattr;
>>>> +
>>>> + case aarch64_sys_kexec_load:
>>>> + return gdb_sys_kexec_load;
>>>> +
>>>> + case aarch64_sys_waitid:
>>>> + return gdb_sys_waitid;
>>>> +
>>>> + case aarch64_sys_add_key:
>>>> + return gdb_sys_add_key;
>>>> +
>>>> + case aarch64_sys_request_key:
>>>> + return gdb_sys_request_key;
>>>> +
>>>> + case aarch64_sys_keyctl:
>>>> + return gdb_sys_keyctl;
>>>> +
>>>> + case aarch64_sys_ioprio_set:
>>>> + return gdb_sys_ioprio_set;
>>>> +
>>>> + case aarch64_sys_ioprio_get:
>>>> + return gdb_sys_ioprio_get;
>>>> +
>>>> + case aarch64_sys_inotify_add_watch:
>>>> + return gdb_sys_inotify_add_watch;
>>>> +
>>>> + case aarch64_sys_inotify_rm_watch:
>>>> + return gdb_sys_inotify_rm_watch;
>>>> +
>>>> + case aarch64_sys_migrate_pages:
>>>> + return gdb_sys_migrate_pages;
>>>> +
>>>> + case aarch64_sys_pselect6:
>>>> + return gdb_sys_pselect6;
>>>> +
>>>> + case aarch64_sys_ppoll:
>>>> + return gdb_sys_ppoll;
>>>> +
>>>> + case aarch64_sys_unshare:
>>>> + return gdb_sys_unshare;
>>>> +
>>>> + case aarch64_sys_set_robust_list:
>>>> + return gdb_sys_set_robust_list;
>>>> +
>>>> + case aarch64_sys_get_robust_list:
>>>> + return gdb_sys_get_robust_list;
>>>> +
>>>> + case aarch64_sys_splice:
>>>> + return gdb_sys_splice;
>>>> +
>>>> + case aarch64_sys_tee:
>>>> + return gdb_sys_tee;
>>>> +
>>>> + case aarch64_sys_sync_file_range:
>>>> + return gdb_sys_sync_file_range;
>>>> +
>>>> + case aarch64_sys_vmsplice:
>>>> + return gdb_sys_vmsplice;
>>>> +
>>>> + case aarch64_sys_move_pages:
>>>> + return gdb_sys_move_pages;
>>>> +
>>>> + default:
>>>> + return -1;
>>>> + }
>>>> +}
>>>> +
>>>> +/* Record all registers but PC register for process-record. */
>>>> +
>>>> +static int
>>>> +aarch64_all_but_pc_registers_record (struct regcache *regcache)
>>>> +{
>>>> + int i;
>>>> +
>>>> + for (i = 0; i < AARCH64_PC_REGNUM; i++)
>>>> + if (record_full_arch_list_add_reg (regcache, AARCH64_X0_REGNUM + i))
>>>> + return -1;
>>>> +
>>>> + if (record_full_arch_list_add_reg (regcache, AARCH64_CPSR_REGNUM))
>>>> + return -1;
>>>> +
>>>> + return 0;
>>>> +}
>>>> +
>>>> +/* Handler for arm system call instruction recording. */
>>>> +
>>>> +static int
>>>> +aarch64_linux_syscall_record (struct regcache *regcache, unsigned long svc_number)
>>>> +{
>>>> + int ret = 0;
>>>> + enum gdb_syscall syscall_gdb;
>>>> +
>>>> + printf_unfiltered (_("syscall number %s\n"),
>>>> + plongest (svc_number));
>>>> + syscall_gdb = aarch64_canonicalize_syscall (svc_number);
>>>> +
>>>> + if (syscall_gdb < 0)
>>>> + {
>>>> + printf_unfiltered (_("Process record and replay target doesn't "
>>>> + "support syscall number %s\n"),
>>>> + plongest (svc_number));
>>>> + return -1;
>>>> + }
>>>> +
>>>> + if (syscall_gdb == gdb_sys_sigreturn
>>>> + || syscall_gdb == gdb_sys_rt_sigreturn)
>>>> + {
>>>> + if (aarch64_all_but_pc_registers_record (regcache))
>>>> + return -1;
>>>> + return 0;
>>>> + }
>>>> +
>>>> + ret = record_linux_system_call (syscall_gdb, regcache,
>>>> + &aarch64_linux_record_tdep);
>>>> + if (ret != 0)
>>>> + return ret;
>>>> +
>>>> + /* Record the return value of the system call. */
>>>> + if (record_full_arch_list_add_reg (regcache, AARCH64_X0_REGNUM))
>>>> + return -1;
>>>> + /* Record LR. */
>>>> + if (record_full_arch_list_add_reg (regcache, AARCH64_LR_REGNUM))
>>>> + return -1;
>>>> + /* Record CPSR. */
>>>> + if (record_full_arch_list_add_reg (regcache, AARCH64_CPSR_REGNUM))
>>>> + return -1;
>>>> +
>>>> + return 0;
>>>> +}
>>>> +
>>>> static void
>>>> aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>>>> {
>>>> @@ -404,6 +1153,170 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
>>>>
>>>> /* Reversible debugging, process record. */
>>>> set_gdbarch_process_record (gdbarch, aarch64_process_record);
>>>> + /* Syscall record. */
>>>> + tdep->aarch64_syscall_record = aarch64_linux_syscall_record;
>>>> +
>>>> + /* Initialize the aarch64_linux_record_tdep. */
>>>> + /* These values are the size of the type that will be used in a system
>>>> + call. They are obtained from Linux Kernel source. */
>>>> + aarch64_linux_record_tdep.size_pointer
>>>> + = gdbarch_ptr_bit (gdbarch) / TARGET_CHAR_BIT;
>>>> + aarch64_linux_record_tdep.size__old_kernel_stat = 32;
>>>> + aarch64_linux_record_tdep.size_tms = 32;
>>>> + aarch64_linux_record_tdep.size_loff_t = 8;
>>>> + aarch64_linux_record_tdep.size_flock = 32;
>>>> + aarch64_linux_record_tdep.size_oldold_utsname = 45;
>>>> + aarch64_linux_record_tdep.size_ustat = 32;
>>>> + aarch64_linux_record_tdep.size_old_sigaction = 152;
>>>> + aarch64_linux_record_tdep.size_old_sigset_t = 128;
>>>> + aarch64_linux_record_tdep.size_rlimit = 16;
>>>> + aarch64_linux_record_tdep.size_rusage = 144;
>>>> + aarch64_linux_record_tdep.size_timeval = 16;
>>>> + aarch64_linux_record_tdep.size_timezone = 8;
>>>> + aarch64_linux_record_tdep.size_old_gid_t = 2;
>>>> + aarch64_linux_record_tdep.size_old_uid_t = 2;
>>>> + aarch64_linux_record_tdep.size_fd_set = 128;
>>>> + aarch64_linux_record_tdep.size_dirent = 280;
>>>> + aarch64_linux_record_tdep.size_dirent64 = 280;
>>>> + aarch64_linux_record_tdep.size_statfs = 120;
>>>> + aarch64_linux_record_tdep.size_statfs64 = 120;
>>>> + aarch64_linux_record_tdep.size_sockaddr = 16;
>>>> + aarch64_linux_record_tdep.size_int
>>>> + = gdbarch_int_bit (gdbarch) / TARGET_CHAR_BIT;
>>>> + aarch64_linux_record_tdep.size_long
>>>> + = gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
>>>> + aarch64_linux_record_tdep.size_ulong
>>>> + = gdbarch_long_bit (gdbarch) / TARGET_CHAR_BIT;
>>>> + aarch64_linux_record_tdep.size_msghdr = 56;
>>>> + aarch64_linux_record_tdep.size_itimerval = 32;
>>>> + aarch64_linux_record_tdep.size_stat = 144;
>>>> + aarch64_linux_record_tdep.size_old_utsname = 325;
>>>> + aarch64_linux_record_tdep.size_sysinfo = 112;
>>>> + aarch64_linux_record_tdep.size_msqid_ds = 120;
>>>> + aarch64_linux_record_tdep.size_shmid_ds = 112;
>>>> + aarch64_linux_record_tdep.size_new_utsname = 390;
>>>> + aarch64_linux_record_tdep.size_timex = 208;
>>>> + aarch64_linux_record_tdep.size_mem_dqinfo = 24;
>>>> + aarch64_linux_record_tdep.size_if_dqblk = 72;
>>>> + aarch64_linux_record_tdep.size_fs_quota_stat = 80;
>>>> + aarch64_linux_record_tdep.size_timespec = 16;
>>>> + aarch64_linux_record_tdep.size_pollfd = 8;
>>>> + aarch64_linux_record_tdep.size_NFS_FHSIZE = 32;
>>>> + aarch64_linux_record_tdep.size_knfsd_fh = 132;
>>>> + aarch64_linux_record_tdep.size_TASK_COMM_LEN = 16;
>>>> + aarch64_linux_record_tdep.size_sigaction = 152;
>>>> + aarch64_linux_record_tdep.size_sigset_t = 128;
>>>> + aarch64_linux_record_tdep.size_siginfo_t = 128;
>>>> + aarch64_linux_record_tdep.size_cap_user_data_t = 8;
>>>> + aarch64_linux_record_tdep.size_stack_t = 24;
>>>> + aarch64_linux_record_tdep.size_off_t = 8;
>>>> + aarch64_linux_record_tdep.size_stat64 = 144;
>>>> + aarch64_linux_record_tdep.size_gid_t = 4;
>>>> + aarch64_linux_record_tdep.size_uid_t = 4;
>>>> + aarch64_linux_record_tdep.size_PAGE_SIZE = 4096;
>>>> + aarch64_linux_record_tdep.size_flock64 = 32;
>>>> + aarch64_linux_record_tdep.size_user_desc = 16;
>>>> + aarch64_linux_record_tdep.size_io_event = 32;
>>>> + aarch64_linux_record_tdep.size_iocb = 64;
>>>> + aarch64_linux_record_tdep.size_epoll_event = 12;
>>>> + aarch64_linux_record_tdep.size_itimerspec = 32;
>>>> + aarch64_linux_record_tdep.size_mq_attr = 64;
>>>> + aarch64_linux_record_tdep.size_siginfo = 128;
>>>> + aarch64_linux_record_tdep.size_termios = 60;
>>>> + aarch64_linux_record_tdep.size_termios2 = 44;
>>>> + aarch64_linux_record_tdep.size_pid_t = 4;
>>>> + aarch64_linux_record_tdep.size_winsize = 8;
>>>> + aarch64_linux_record_tdep.size_serial_struct = 72;
>>>> + aarch64_linux_record_tdep.size_serial_icounter_struct = 80;
>>>> + aarch64_linux_record_tdep.size_hayes_esp_config = 12;
>>>> + aarch64_linux_record_tdep.size_size_t = 8;
>>>> + aarch64_linux_record_tdep.size_iovec = 16;
>>>> +
>>>> + /* These values are the second argument of system call "sys_ioctl".
>>>> + They are obtained from Linux Kernel source. */
>>>> + aarch64_linux_record_tdep.ioctl_TCGETS = 0x5401;
>>>> + aarch64_linux_record_tdep.ioctl_TCSETS = 0x5402;
>>>> + aarch64_linux_record_tdep.ioctl_TCSETSW = 0x5403;
>>>> + aarch64_linux_record_tdep.ioctl_TCSETSF = 0x5404;
>>>> + aarch64_linux_record_tdep.ioctl_TCGETA = 0x5405;
>>>> + aarch64_linux_record_tdep.ioctl_TCSETA = 0x5406;
>>>> + aarch64_linux_record_tdep.ioctl_TCSETAW = 0x5407;
>>>> + aarch64_linux_record_tdep.ioctl_TCSETAF = 0x5408;
>>>> + aarch64_linux_record_tdep.ioctl_TCSBRK = 0x5409;
>>>> + aarch64_linux_record_tdep.ioctl_TCXONC = 0x540a;
>>>> + aarch64_linux_record_tdep.ioctl_TCFLSH = 0x540b;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCEXCL = 0x540c;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCNXCL = 0x540d;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSCTTY = 0x540e;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCGPGRP = 0x540f;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSPGRP = 0x5410;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCOUTQ = 0x5411;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSTI = 0x5412;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCGWINSZ = 0x5413;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSWINSZ = 0x5414;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCMGET = 0x5415;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCMBIS = 0x5416;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCMBIC = 0x5417;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCMSET = 0x5418;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCGSOFTCAR = 0x5419;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSSOFTCAR = 0x541a;
>>>> + aarch64_linux_record_tdep.ioctl_FIONREAD = 0x541b;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCINQ = 0x541b;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCLINUX = 0x541c;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCCONS = 0x541d;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCGSERIAL = 0x541e;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSSERIAL = 0x541f;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCPKT = 0x5420;
>>>> + aarch64_linux_record_tdep.ioctl_FIONBIO = 0x5421;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCNOTTY = 0x5422;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSETD = 0x5423;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCGETD = 0x5424;
>>>> + aarch64_linux_record_tdep.ioctl_TCSBRKP = 0x5425;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCTTYGSTRUCT = 0x5426;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSBRK = 0x5427;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCCBRK = 0x5428;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCGSID = 0x5429;
>>>> + aarch64_linux_record_tdep.ioctl_TCGETS2 = 0x802c542a;
>>>> + aarch64_linux_record_tdep.ioctl_TCSETS2 = 0x402c542b;
>>>> + aarch64_linux_record_tdep.ioctl_TCSETSW2 = 0x402c542c;
>>>> + aarch64_linux_record_tdep.ioctl_TCSETSF2 = 0x402c542d;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCGPTN = 0x80045430;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSPTLCK = 0x40045431;
>>>> + aarch64_linux_record_tdep.ioctl_FIONCLEX = 0x5450;
>>>> + aarch64_linux_record_tdep.ioctl_FIOCLEX = 0x5451;
>>>> + aarch64_linux_record_tdep.ioctl_FIOASYNC = 0x5452;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSERCONFIG = 0x5453;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSERGWILD = 0x5454;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSERSWILD = 0x5455;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCGLCKTRMIOS = 0x5456;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSLCKTRMIOS = 0x5457;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSERGSTRUCT = 0x5458;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSERGETLSR = 0x5459;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSERGETMULTI = 0x545a;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSERSETMULTI = 0x545b;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCMIWAIT = 0x545c;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCGICOUNT = 0x545d;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCGHAYESESP = 0x545e;
>>>> + aarch64_linux_record_tdep.ioctl_TIOCSHAYESESP = 0x545f;
>>>> + aarch64_linux_record_tdep.ioctl_FIOQSIZE = 0x5460;
>>>> +
>>>> + /* These values are the second argument of system call "sys_fcntl"
>>>> + and "sys_fcntl64". They are obtained from Linux Kernel source. */
>>>> + aarch64_linux_record_tdep.fcntl_F_GETLK = 5;
>>>> + aarch64_linux_record_tdep.fcntl_F_GETLK64 = 12;
>>>> + aarch64_linux_record_tdep.fcntl_F_SETLK64 = 13;
>>>> + aarch64_linux_record_tdep.fcntl_F_SETLKW64 = 14;
>>>> +
>>>> + /* The AArch64 syscall calling convention: reg x0-x7 for arguments,
>>>> + reg x8 for syscall number and return value in reg x0. */
>>>> + aarch64_linux_record_tdep.arg1 = AARCH64_X0_REGNUM + 0;
>>>> + aarch64_linux_record_tdep.arg2 = AARCH64_X0_REGNUM + 1;
>>>> + aarch64_linux_record_tdep.arg3 = AARCH64_X0_REGNUM + 2;
>>>> + aarch64_linux_record_tdep.arg4 = AARCH64_X0_REGNUM + 3;
>>>> + aarch64_linux_record_tdep.arg5 = AARCH64_X0_REGNUM + 4;
>>>> + aarch64_linux_record_tdep.arg6 = AARCH64_X0_REGNUM + 5;
>>>> + aarch64_linux_record_tdep.arg7 = AARCH64_X0_REGNUM + 6;
>>>> + aarch64_linux_record_tdep.arg8 = AARCH64_X0_REGNUM + 7;
>>>> }
>>>>
>>>> /* Provide a prototype to silence -Wmissing-prototypes. */
>>>> diff --git a/gdb/aarch64-linux-tdep.h b/gdb/aarch64-linux-tdep.h
>>>> index 2e1de60..1ae3786 100644
>>>> --- a/gdb/aarch64-linux-tdep.h
>>>> +++ b/gdb/aarch64-linux-tdep.h
>>>> @@ -32,3 +32,269 @@
>>>>
>>>> extern const struct regset aarch64_linux_gregset;
>>>> extern const struct regset aarch64_linux_fpregset;
>>>> +
>>>> +/* Enum that defines the AArch64 linux specific syscall identifiers used for
>>>> + process record/replay. */
>>>> +
>>>> +enum aarch64_syscall {
>>>> + aarch64_sys_io_setup = 0,
>>>> + aarch64_sys_io_destroy = 1,
>>>> + aarch64_sys_io_submit = 2,
>>>> + aarch64_sys_io_cancel = 3,
>>>> + aarch64_sys_io_getevents = 4,
>>>> + aarch64_sys_setxattr = 5,
>>>> + aarch64_sys_lsetxattr = 6,
>>>> + aarch64_sys_fsetxattr = 7,
>>>> + aarch64_sys_getxattr = 8,
>>>> + aarch64_sys_lgetxattr = 9,
>>>> + aarch64_sys_fgetxattr = 10,
>>>> + aarch64_sys_listxattr = 11,
>>>> + aarch64_sys_llistxattr = 12,
>>>> + aarch64_sys_flistxattr = 13,
>>>> + aarch64_sys_removexattr = 14,
>>>> + aarch64_sys_lremovexattr = 15,
>>>> + aarch64_sys_fremovexattr = 16,
>>>> + aarch64_sys_getcwd = 17,
>>>> + aarch64_sys_lookup_dcookie = 18,
>>>> + aarch64_sys_eventfd2 = 19,
>>>> + aarch64_sys_epoll_create1 = 20,
>>>> + aarch64_sys_epoll_ctl = 21,
>>>> + aarch64_sys_epoll_pwait = 22,
>>>> + aarch64_sys_dup = 23,
>>>> + aarch64_sys_dup3 = 24,
>>>> + aarch64_sys_fcntl = 25,
>>>> + aarch64_sys_inotify_init1 = 26,
>>>> + aarch64_sys_inotify_add_watch = 27,
>>>> + aarch64_sys_inotify_rm_watch = 28,
>>>> + aarch64_sys_ioctl = 29,
>>>> + aarch64_sys_ioprio_set = 30,
>>>> + aarch64_sys_ioprio_get = 31,
>>>> + aarch64_sys_flock = 32,
>>>> + aarch64_sys_mknod = 33,
>>>> + aarch64_sys_mkdir = 34,
>>>> + aarch64_sys_unlink = 35,
>>>> + aarch64_sys_symlink = 36,
>>>> + aarch64_sys_link = 37,
>>>> + aarch64_sys_rename = 38,
>>>> + aarch64_sys_umount2 = 39,
>>>> + aarch64_sys_mount = 40,
>>>> + aarch64_sys_pivot_root = 41,
>>>> + aarch64_sys_nfsservctl = 42,
>>>> + aarch64_sys_statfs = 43,
>>>> + aarch64_sys_fstatfs = 44,
>>>> + aarch64_sys_truncate = 45,
>>>> + aarch64_sys_ftruncate = 46,
>>>> + aarch64_sys_fallocate = 47,
>>>> + aarch64_sys_faccess = 48,
>>>> + aarch64_sys_chdir = 49,
>>>> + aarch64_sys_fchdir = 50,
>>>> + aarch64_sys_chroot = 51,
>>>> + aarch64_sys_fchmod = 52,
>>>> + aarch64_sys_fchmodat = 53,
>>>> + aarch64_sys_fchownat = 54,
>>>> + aarch64_sys_fchown = 55,
>>>> + aarch64_sys_open = 56,
>>>> + aarch64_sys_close = 57,
>>>> + aarch64_sys_vhangup = 58,
>>>> + aarch64_sys_pipe2 = 59,
>>>> + aarch64_sys_quotactl = 60,
>>>> + aarch64_sys_getdents64 = 61,
>>>> + aarch64_sys_lseek = 62,
>>>> + aarch64_sys_read = 63,
>>>> + aarch64_sys_write = 64,
>>>> + aarch64_sys_readv = 65,
>>>> + aarch64_sys_writev = 66,
>>>> + aarch64_sys_pread64 = 67,
>>>> + aarch64_sys_pwrite64 = 68,
>>>> + aarch64_sys_preadv = 69,
>>>> + aarch64_sys_pwritev = 70,
>>>> + aarch64_sys_sendfile = 71,
>>>> + aarch64_sys_pselect6 = 72,
>>>> + aarch64_sys_ppoll = 73,
>>>> + aarch64_sys_signalfd4 = 74,
>>>> + aarch64_sys_vmsplice = 75,
>>>> + aarch64_sys_splice = 76,
>>>> + aarch64_sys_tee = 77,
>>>> + aarch64_sys_readlink = 78,
>>>> + aarch64_sys_fstatat = 79,
>>>> + aarch64_sys_fstat = 80,
>>>> + aarch64_sys_sync = 81,
>>>> + aarch64_sys_fsync = 82,
>>>> + aarch64_sys_fdatasync = 83,
>>>> + aarch64_sys_sync_file_range2 = 84,
>>>> + aarch64_sys_sync_file_range = 84,
>>>> + aarch64_sys_timerfd_create = 85,
>>>> + aarch64_sys_timerfd_settime = 86,
>>>> + aarch64_sys_timerfd_gettime = 87,
>>>> + aarch64_sys_utimensat = 88,
>>>> + aarch64_sys_acct = 89,
>>>> + aarch64_sys_capget = 90,
>>>> + aarch64_sys_capset = 91,
>>>> + aarch64_sys_personality = 92,
>>>> + aarch64_sys_exit = 93,
>>>> + aarch64_sys_exit_group = 94,
>>>> + aarch64_sys_waitid = 95,
>>>> + aarch64_sys_set_tid_address = 96,
>>>> + aarch64_sys_unshare = 97,
>>>> + aarch64_sys_futex = 98,
>>>> + aarch64_sys_set_robust_list = 99,
>>>> + aarch64_sys_get_robust_list = 100,
>>>> + aarch64_sys_nanosleep = 101,
>>>> + aarch64_sys_getitimer = 102,
>>>> + aarch64_sys_setitimer = 103,
>>>> + aarch64_sys_kexec_load = 104,
>>>> + aarch64_sys_init_module = 105,
>>>> + aarch64_sys_delete_module = 106,
>>>> + aarch64_sys_timer_create = 107,
>>>> + aarch64_sys_timer_gettime = 108,
>>>> + aarch64_sys_timer_getoverrun = 109,
>>>> + aarch64_sys_timer_settime = 110,
>>>> + aarch64_sys_timer_delete = 111,
>>>> + aarch64_sys_clock_settime = 112,
>>>> + aarch64_sys_clock_gettime = 113,
>>>> + aarch64_sys_clock_getres = 114,
>>>> + aarch64_sys_clock_nanosleep = 115,
>>>> + aarch64_sys_syslog = 116,
>>>> + aarch64_sys_ptrace = 117,
>>>> + aarch64_sys_sched_setparam = 118,
>>>> + aarch64_sys_sched_setscheduler = 119,
>>>> + aarch64_sys_sched_getscheduler = 120,
>>>> + aarch64_sys_sched_getparam = 121,
>>>> + aarch64_sys_sched_setaffinity = 122,
>>>> + aarch64_sys_sched_getaffinity = 123,
>>>> + aarch64_sys_sched_yield = 124,
>>>> + aarch64_sys_sched_get_priority_max = 125,
>>>> + aarch64_sys_sched_get_priority_min = 126,
>>>> + aarch64_sys_sched_rr_get_interval = 127,
>>>> + aarch64_sys_kill = 129,
>>>> + aarch64_sys_tkill = 130,
>>>> + aarch64_sys_tgkill = 131,
>>>> + aarch64_sys_sigaltstack = 132,
>>>> + aarch64_sys_rt_sigsuspend = 133,
>>>> + aarch64_sys_rt_sigaction = 134,
>>>> + aarch64_sys_rt_sigprocmask = 135,
>>>> + aarch64_sys_rt_sigpending = 136,
>>>> + aarch64_sys_rt_sigtimedwait = 137,
>>>> + aarch64_sys_rt_sigqueueinfo = 138,
>>>> + aarch64_sys_rt_sigreturn = 139,
>>>> + aarch64_sys_setpriority = 140,
>>>> + aarch64_sys_getpriority = 141,
>>>> + aarch64_sys_reboot = 142,
>>>> + aarch64_sys_setregid = 143,
>>>> + aarch64_sys_setgid = 144,
>>>> + aarch64_sys_setreuid = 145,
>>>> + aarch64_sys_setuid = 146,
>>>> + aarch64_sys_setresuid = 147,
>>>> + aarch64_sys_getresuid = 148,
>>>> + aarch64_sys_setresgid = 149,
>>>> + aarch64_sys_getresgid = 150,
>>>> + aarch64_sys_setfsuid = 151,
>>>> + aarch64_sys_setfsgid = 152,
>>>> + aarch64_sys_times = 153,
>>>> + aarch64_sys_setpgid = 154,
>>>> + aarch64_sys_getpgid = 155,
>>>> + aarch64_sys_getsid = 156,
>>>> + aarch64_sys_setsid = 157,
>>>> + aarch64_sys_getgroups = 158,
>>>> + aarch64_sys_setgroups = 159,
>>>> + aarch64_sys_uname = 160,
>>>> + aarch64_sys_sethostname = 161,
>>>> + aarch64_sys_setdomainname = 162,
>>>> + aarch64_sys_getrlimit = 163,
>>>> + aarch64_sys_setrlimit = 164,
>>>> + aarch64_sys_getrusage = 165,
>>>> + aarch64_sys_umask = 166,
>>>> + aarch64_sys_prctl = 167,
>>>> + aarch64_sys_getcpu = 168,
>>>> + aarch64_sys_gettimeofday = 169,
>>>> + aarch64_sys_settimeofday = 170,
>>>> + aarch64_sys_adjtimex = 171,
>>>> + aarch64_sys_getpid = 172,
>>>> + aarch64_sys_getppid = 173,
>>>> + aarch64_sys_getuid = 174,
>>>> + aarch64_sys_geteuid = 175,
>>>> + aarch64_sys_getgid = 176,
>>>> + aarch64_sys_getegid = 177,
>>>> + aarch64_sys_gettid = 178,
>>>> + aarch64_sys_sysinfo = 179,
>>>> + aarch64_sys_mq_open = 180,
>>>> + aarch64_sys_mq_unlink = 181,
>>>> + aarch64_sys_mq_timedsend = 182,
>>>> + aarch64_sys_mq_timedreceive = 183,
>>>> + aarch64_sys_mq_notify = 184,
>>>> + aarch64_sys_mq_getsetattr = 185,
>>>> + aarch64_sys_msgget = 186,
>>>> + aarch64_sys_msgctl = 187,
>>>> + aarch64_sys_msgrcv = 188,
>>>> + aarch64_sys_msgsnd = 189,
>>>> + aarch64_sys_semget = 190,
>>>> + aarch64_sys_semctl = 191,
>>>> + aarch64_sys_semtimedop = 192,
>>>> + aarch64_sys_semop = 193,
>>>> + aarch64_sys_shmget = 194,
>>>> + aarch64_sys_shmctl = 195,
>>>> + aarch64_sys_shmat = 196,
>>>> + aarch64_sys_shmdt = 197,
>>>> + aarch64_sys_socket = 198,
>>>> + aarch64_sys_socketpair = 199,
>>>> + aarch64_sys_bind = 200,
>>>> + aarch64_sys_listen = 201,
>>>> + aarch64_sys_accept = 202,
>>>> + aarch64_sys_connect = 203,
>>>> + aarch64_sys_getsockname = 204,
>>>> + aarch64_sys_getpeername = 205,
>>>> + aarch64_sys_sendto = 206,
>>>> + aarch64_sys_recvfrom = 207,
>>>> + aarch64_sys_setsockopt = 208,
>>>> + aarch64_sys_getsockopt = 209,
>>>> + aarch64_sys_shutdown = 210,
>>>> + aarch64_sys_sendmsg = 211,
>>>> + aarch64_sys_recvmsg = 212,
>>>> + aarch64_sys_readahead = 213,
>>>> + aarch64_sys_brk = 214,
>>>> + aarch64_sys_munmap = 215,
>>>> + aarch64_sys_mremap = 216,
>>>> + aarch64_sys_add_key = 217,
>>>> + aarch64_sys_request_key = 218,
>>>> + aarch64_sys_keyctl = 219,
>>>> + aarch64_sys_clone = 220,
>>>> + aarch64_sys_execve = 221,
>>>> + aarch64_sys_mmap = 222,
>>>> + aarch64_sys_fadvise64 = 223,
>>>> + aarch64_sys_swapon = 224,
>>>> + aarch64_sys_swapoff = 225,
>>>> + aarch64_sys_mprotect = 226,
>>>> + aarch64_sys_msync = 227,
>>>> + aarch64_sys_mlock = 228,
>>>> + aarch64_sys_munlock = 229,
>>>> + aarch64_sys_mlockall = 230,
>>>> + aarch64_sys_munlockall = 231,
>>>> + aarch64_sys_mincore = 232,
>>>> + aarch64_sys_madvise = 233,
>>>> + aarch64_sys_remap_file_pages = 234,
>>>> + aarch64_sys_mbind = 235,
>>>> + aarch64_sys_get_mempolicy = 236,
>>>> + aarch64_sys_set_mempolicy = 237,
>>>> + aarch64_sys_migrate_pages = 238,
>>>> + aarch64_sys_move_pages = 239,
>>>> + aarch64_sys_rt_tgsigqueueinfo = 240,
>>>> + aarch64_sys_perf_event_open = 241,
>>>> + aarch64_sys_accept4 = 242,
>>>> + aarch64_sys_recvmmsg = 243,
>>>> + aarch64_sys_wait4 = 260,
>>>> + aarch64_sys_prlimit64 = 261,
>>>> + aarch64_sys_fanotify_init = 262,
>>>> + aarch64_sys_fanotify_mark = 263,
>>>> + aarch64_sys_name_to_handle_at = 264,
>>>> + aarch64_sys_open_by_handle_at = 265,
>>>> + aarch64_sys_clock_adjtime = 266,
>>>> + aarch64_sys_syncfs = 267,
>>>> + aarch64_sys_setns = 268,
>>>> + aarch64_sys_sendmmsg = 269,
>>>> + aarch64_sys_process_vm_readv = 270,
>>>> + aarch64_sys_process_vm_writev = 271,
>>>> + aarch64_sys_kcmp = 272,
>>>> + aarch64_sys_finit_module = 273,
>>>> + aarch64_sys_sched_setattr = 274,
>>>> + aarch64_sys_sched_getattr = 275,
>>>> +};
>>>> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
>>>> index 0847585..c6da25a 100644
>>>> --- a/gdb/aarch64-tdep.c
>>>> +++ b/gdb/aarch64-tdep.c
>>>> @@ -2941,7 +2941,20 @@ aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
>>>> {
>>>> /* Exception generation instructions. */
>>>> if (insn_bits24_27 == 0x04)
>>>> - return AARCH64_RECORD_UNSUPPORTED;
>>>> + {
>>>> + if (!bits (aarch64_insn_r->aarch64_insn, 2, 4) &&
>>>> + !bits (aarch64_insn_r->aarch64_insn, 21, 23) &&
>>>> + bits (aarch64_insn_r->aarch64_insn, 0, 1) == 0x01)
>>>> + {
>>>> + ULONGEST svc_number;
>>>> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, 8,
>>>> + &svc_number);
>>>> + return tdep->aarch64_syscall_record (aarch64_insn_r->regcache,
>>>> + svc_number);
>>>> + }
>>>> + else
>>>> + return AARCH64_RECORD_UNSUPPORTED;
>>>> + }
>>>> /* System instructions. */
>>>> else if (insn_bits24_27 == 0x05 && insn_bits22_23 == 0x00)
>>>> {
>>>> diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
>>>> index 1d74ef8..25751fe 100644
>>>> --- a/gdb/aarch64-tdep.h
>>>> +++ b/gdb/aarch64-tdep.h
>>>> @@ -88,6 +88,9 @@ struct gdbarch_tdep
>>>> struct type *vns_type;
>>>> struct type *vnh_type;
>>>> struct type *vnb_type;
>>>> +
>>>> + /* syscall record. */
>>>> + int (*aarch64_syscall_record) (struct regcache *regcache, unsigned long svc_number);
>>>> };
>>>>
>>>> /* AArch64 process record-replay related structures, defines etc. */
>>>> diff --git a/gdb/linux-record.h b/gdb/linux-record.h
>>>> index 7b5218e..2649ce5 100644
>>>> --- a/gdb/linux-record.h
>>>> +++ b/gdb/linux-record.h
>>>> @@ -174,6 +174,8 @@ struct linux_record_tdep
>>>> int arg4;
>>>> int arg5;
>>>> int arg6;
>>>> + int arg7;
>>>> + int arg8;
>>>> };
>>>>
>>>> /* Enum that defines the gdb-canonical set of Linux syscall identifiers.
>>>> --
>>>> 1.9.1
>>>>
>>>
>>>
>>>
>>> --
>>> Will Newton
>>> Toolchain Working Group, Linaro
>>
>> Ping! Kindly help me approve this patch.
>
> ping!
>
ping!
^ permalink raw reply [flat|nested] 53+ messages in thread
* [PATCH 6/7] Support for recording aarch64 advance simd instructions
2014-06-04 16:21 [PATCH 0/7] Process record and reverse debugging support on aarch64-linux Omair Javaid
` (5 preceding siblings ...)
2014-06-04 16:21 ` [PATCH 5/7] Support for recording syscall on aarch64-linux Omair Javaid
@ 2014-06-04 16:21 ` Omair Javaid
2014-06-05 8:58 ` Will Newton
2014-06-23 10:41 ` [PATCH 0/7] Process record and reverse debugging support on aarch64-linux Omair Javaid
2014-08-30 3:45 ` Yao Qi
8 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-06-04 16:21 UTC (permalink / raw)
To: gdb-patches; +Cc: Omair Javaid
This patch adds support for recording A64 advance simd load/store and
data processing instructions on aarch64-linux targets.
gdb:
2014-06-04 Omair Javaid <omair.javaid@linaro.org>
* aarch64-tdep.c (aarch64_record_load_store): Updated.
(aarch64_record_data_proc_simd_fp): New function.
(aarch64_record_decode_insn_handler): Updated.
(aarch64_record_asimd_load_store): New function.
---
gdb/aarch64-tdep.c | 227 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 225 insertions(+), 2 deletions(-)
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index 2e2dc15..221006a 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -2988,6 +2988,144 @@ aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
return AARCH64_RECORD_SUCCESS;
}
+/* Record handler for advance simd load and store instructions. */
+static unsigned int
+aarch64_record_asimd_load_store (insn_decode_record *aarch64_insn_r)
+{
+ CORE_ADDR address;
+ uint64_t addr_offset = 0;
+ uint32_t record_buf[24];
+ uint64_t record_buf_mem[24];
+ uint32_t reg_rn, reg_rt, reg_rm;
+ uint32_t reg_index = 0, mem_index = 0;
+ uint8_t eindex, rindex, sindex, reg_tt, replicate;
+ uint8_t elements, esize, rpt, selem, ebytes, single, scale;
+ uint8_t opcode_bits, qbit, size_bits, ld_flag, data_size, wback;
+
+ reg_rt = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ reg_rn = bits (aarch64_insn_r->aarch64_insn, 5, 9);
+ reg_rm = bits (aarch64_insn_r->aarch64_insn, 16, 20);
+
+ wback = bit (aarch64_insn_r->aarch64_insn, 23);
+ single = bit (aarch64_insn_r->aarch64_insn, 24);
+ ld_flag = bit (aarch64_insn_r->aarch64_insn, 22);
+ size_bits = bits (aarch64_insn_r->aarch64_insn, 10, 11);
+ opcode_bits = bits (aarch64_insn_r->aarch64_insn, 12, 15);
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn, &address);
+
+ if (single)
+ {
+ scale = opcode_bits >> 2;
+ selem = ((opcode_bits & 0x02) |
+ bit (aarch64_insn_r->aarch64_insn, 21)) + 1;
+ replicate = 0;
+ switch (scale)
+ {
+ case 2:
+ if (!(size_bits & 0x01) && ((size_bits >> 1) & 0x01))
+ scale = 3;
+ break;
+ case 3:
+ scale = size_bits;
+ replicate = 1;
+ break;
+ default:
+ break;
+ }
+ esize = 8 << scale;
+ if (replicate)
+ for (sindex = 0; sindex < selem; sindex++)
+ {
+ record_buf[reg_index++] = reg_rt + AARCH64_V0_REGNUM;
+ reg_rt = (reg_rt + 1) % 32;
+ }
+ else
+ {
+ for (sindex = 0; sindex < selem; sindex++)
+ if (ld_flag)
+ record_buf[reg_index++] = reg_rt + AARCH64_V0_REGNUM;
+ else
+ {
+ record_buf_mem[mem_index++] = esize / 8;
+ record_buf_mem[mem_index++] = address + addr_offset;
+ }
+ addr_offset = addr_offset + (esize / 8);
+ reg_rt = (reg_rt + 1) % 32;
+ }
+ }
+ else
+ {
+ esize = 8 << size_bits;
+ if (bit (aarch64_insn_r->aarch64_insn, 30))
+ elements = 128 / esize;
+ else
+ elements = 64 / esize;
+
+ switch (opcode_bits)
+ {
+ case 0:
+ rpt = 1;
+ selem = 4;
+ break;
+ case 2:
+ rpt = 4;
+ selem = 1;
+ break;
+ case 4:
+ rpt = 1;
+ selem = 3;
+ break;
+ case 6:
+ rpt = 3;
+ selem = 1;
+ break;
+ case 7:
+ rpt = 1;
+ selem = 1;
+ break;
+ case 8:
+ rpt = 1;
+ selem = 2;
+ break;
+ case 10:
+ rpt = 2;
+ selem = 1;
+ break;
+ default:
+ return AARCH64_RECORD_USUPPORTED;
+ break;
+ }
+ for (rindex = 0; rindex < rpt; rindex++)
+ for (eindex = 0; eindex < elements; eindex++)
+ {
+ reg_tt = (reg_rt + rindex) % 32;
+ for (sindex = 0; sindex < selem; sindex++)
+ {
+ if (ld_flag)
+ record_buf[reg_index++] = reg_tt + AARCH64_V0_REGNUM;
+ else
+ {
+ record_buf_mem[mem_index++] = esize / 8;
+ record_buf_mem[mem_index++] = address + addr_offset;
+ }
+ addr_offset = addr_offset + (esize / 8);
+ reg_tt = (reg_tt + 1) % 32;
+ }
+ }
+ }
+
+ if (wback)
+ record_buf[reg_index++] = reg_rn;
+
+ aarch64_insn_r->reg_rec_count = reg_index;
+ aarch64_insn_r->mem_rec_count = mem_index / 2;
+ MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count,
+ record_buf_mem);
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+
/* Record handler for load and store instructions. */
static unsigned int
aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
@@ -3226,7 +3364,7 @@ aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
}
/* Advanced SIMD load/store instructions. */
else
- return AARCH64_RECORD_USUPPORTED;
+ return aarch64_record_asimd_load_store (aarch64_insn_r);
MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count,
record_buf_mem);
@@ -3234,6 +3372,91 @@ aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
record_buf);
return AARCH64_RECORD_SUCCESS;
}
+
+/* Record handler for data processing SIMD and floating point instructions. */
+
+static unsigned int
+aarch64_record_data_proc_simd_fp (insn_decode_record *aarch64_insn_r)
+{
+ uint8_t insn_bit21, opcode, rmode, reg_rd;
+ uint8_t insn_bits24_27, insn_bits28_31, insn_bits10_11, insn_bits12_15;
+ uint8_t insn_bits11_14;
+ uint32_t record_buf[2];
+
+ insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
+ insn_bits28_31 = bits (aarch64_insn_r->aarch64_insn, 28, 31);
+ insn_bits10_11 = bits (aarch64_insn_r->aarch64_insn, 10, 11);
+ insn_bits12_15 = bits (aarch64_insn_r->aarch64_insn, 12, 15);
+ insn_bits11_14 = bits (aarch64_insn_r->aarch64_insn, 11, 14);
+ opcode = bits (aarch64_insn_r->aarch64_insn, 16, 18);
+ rmode = bits (aarch64_insn_r->aarch64_insn, 19, 20);
+ reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ insn_bit21 = bit (aarch64_insn_r->aarch64_insn, 21);
+
+ if ((insn_bits28_31 & 0x05) == 0x01 && insn_bits24_27 == 0x0e)
+ {
+ /* Floating point - fixed-point conversion instructions. */
+ if (!insn_bit21)
+ if ((opcode >> 1) == 0x0 && rmode == 0x03)
+ record_buf[0] = reg_rd;
+ else
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+ /* Floating point conditional compare instructions. */
+ else if (insn_bits10_11 == 0x01) //
+ record_buf[0] = AARCH64_CPSR_REGNUM;
+ /* Floating-point data-processing (2-source) and conditional select. */
+ else if (insn_bits10_11 == 0x02 || insn_bits10_11 == 0x03)
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+ else if (insn_bits10_11 == 0x00)
+ {
+ /* Floating point immediate instructions. */
+ if ((insn_bits12_15 & 0x01) == 0x01 || (insn_bits12_15 & 0x07) == 0x04)
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+ /* Floating point compare instructions. */
+ else if ((insn_bits12_15 & 0x03) == 0x02)
+ record_buf[0] = AARCH64_CPSR_REGNUM;
+ /* Floating-point - integer conversions instructions. */
+ if (insn_bits12_15 == 0x00)
+ {
+ /* Type - convert float to integer. */
+ if (!(opcode >> 1) || ((opcode >> 1) == 0x02 && !rmode))
+ record_buf[0] = reg_rd + AARCH64_X0_REGNUM;
+ /* Type - convert integer to float. */
+ else if ((opcode >> 1) == 0x01 && !rmode)
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+ /* Type - move float to integer. */
+ else if ((opcode >> 1) == 0x03)
+ {
+ if (!(opcode & 0x01))
+ record_buf[0] = reg_rd + AARCH64_X0_REGNUM;
+ else
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+ }
+ }
+ }
+ }
+ else if ((insn_bits28_31 & 0x09) == 0x00 && insn_bits24_27 == 0x0E)
+ {
+ /* Advanced SIMD copy instructions. */
+ if (!bits (aarch64_insn_r->aarch64_insn, 21, 23) &&
+ !bit (aarch64_insn_r->aarch64_insn, 15) &&
+ bit (aarch64_insn_r->aarch64_insn, 10))
+ if (insn_bits11_14 == 0x05 || insn_bits11_14 == 0x07)
+ record_buf[0] = reg_rd + AARCH64_X0_REGNUM;
+ else
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+ else
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+ }
+ /* All remaining floating point or advanced SIMD instructions. */
+ else
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+
/* Decodes thumb2 instruction type and invokes its record handler. */
static unsigned int
@@ -3264,7 +3487,7 @@ aarch64_record_decode_insn_handler (insn_decode_record *aarch64_insn_r)
/* Data processing - SIMD and floating point instructions. */
if (ins_bit25 && ins_bit26 && ins_bit27)
- return AARCH64_RECORD_USUPPORTED;
+ return aarch64_record_data_proc_simd_fp (aarch64_insn_r);
return AARCH64_RECORD_USUPPORTED;
}
--
1.9.1
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 6/7] Support for recording aarch64 advance simd instructions
2014-06-04 16:21 ` [PATCH 6/7] Support for recording aarch64 advance simd instructions Omair Javaid
@ 2014-06-05 8:58 ` Will Newton
2014-08-29 13:41 ` [PATCH 6/7] Support for recording aarch64 advanced SIMD instructions Omair Javaid
0 siblings, 1 reply; 53+ messages in thread
From: Will Newton @ 2014-06-05 8:58 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
On 4 June 2014 17:21, Omair Javaid <omair.javaid@linaro.org> wrote:
> This patch adds support for recording A64 advance simd load/store and
> data processing instructions on aarch64-linux targets.
>
> gdb:
>
> 2014-06-04 Omair Javaid <omair.javaid@linaro.org>
>
> * aarch64-tdep.c (aarch64_record_load_store): Updated.
> (aarch64_record_data_proc_simd_fp): New function.
> (aarch64_record_decode_insn_handler): Updated.
> (aarch64_record_asimd_load_store): New function.
>
> ---
> gdb/aarch64-tdep.c | 227 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 225 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index 2e2dc15..221006a 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -2988,6 +2988,144 @@ aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
> return AARCH64_RECORD_SUCCESS;
> }
>
> +/* Record handler for advance simd load and store instructions. */
I guess we should be consistent and call it "Advanced SIMD".
> +static unsigned int
> +aarch64_record_asimd_load_store (insn_decode_record *aarch64_insn_r)
> +{
> + CORE_ADDR address;
> + uint64_t addr_offset = 0;
> + uint32_t record_buf[24];
> + uint64_t record_buf_mem[24];
> + uint32_t reg_rn, reg_rt, reg_rm;
> + uint32_t reg_index = 0, mem_index = 0;
> + uint8_t eindex, rindex, sindex, reg_tt, replicate;
> + uint8_t elements, esize, rpt, selem, ebytes, single, scale;
I don't think ebytes is used.
> + uint8_t opcode_bits, qbit, size_bits, ld_flag, data_size, wback;
And qbit seems not to be used either.
> +
> + reg_rt = bits (aarch64_insn_r->aarch64_insn, 0, 4);
> + reg_rn = bits (aarch64_insn_r->aarch64_insn, 5, 9);
> + reg_rm = bits (aarch64_insn_r->aarch64_insn, 16, 20);
> +
> + wback = bit (aarch64_insn_r->aarch64_insn, 23);
> + single = bit (aarch64_insn_r->aarch64_insn, 24);
> + ld_flag = bit (aarch64_insn_r->aarch64_insn, 22);
> + size_bits = bits (aarch64_insn_r->aarch64_insn, 10, 11);
> + opcode_bits = bits (aarch64_insn_r->aarch64_insn, 12, 15);
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn, &address);
> +
> + if (single)
> + {
> + scale = opcode_bits >> 2;
> + selem = ((opcode_bits & 0x02) |
> + bit (aarch64_insn_r->aarch64_insn, 21)) + 1;
> + replicate = 0;
> + switch (scale)
> + {
> + case 2:
> + if (!(size_bits & 0x01) && ((size_bits >> 1) & 0x01))
> + scale = 3;
> + break;
> + case 3:
> + scale = size_bits;
> + replicate = 1;
> + break;
> + default:
> + break;
> + }
> + esize = 8 << scale;
> + if (replicate)
> + for (sindex = 0; sindex < selem; sindex++)
> + {
> + record_buf[reg_index++] = reg_rt + AARCH64_V0_REGNUM;
> + reg_rt = (reg_rt + 1) % 32;
> + }
> + else
> + {
> + for (sindex = 0; sindex < selem; sindex++)
> + if (ld_flag)
> + record_buf[reg_index++] = reg_rt + AARCH64_V0_REGNUM;
> + else
> + {
> + record_buf_mem[mem_index++] = esize / 8;
> + record_buf_mem[mem_index++] = address + addr_offset;
> + }
> + addr_offset = addr_offset + (esize / 8);
> + reg_rt = (reg_rt + 1) % 32;
> + }
> + }
> + else
> + {
> + esize = 8 << size_bits;
> + if (bit (aarch64_insn_r->aarch64_insn, 30))
> + elements = 128 / esize;
> + else
> + elements = 64 / esize;
> +
> + switch (opcode_bits)
> + {
> + case 0:
> + rpt = 1;
> + selem = 4;
> + break;
> + case 2:
> + rpt = 4;
> + selem = 1;
> + break;
> + case 4:
> + rpt = 1;
> + selem = 3;
> + break;
> + case 6:
> + rpt = 3;
> + selem = 1;
> + break;
> + case 7:
> + rpt = 1;
> + selem = 1;
> + break;
> + case 8:
> + rpt = 1;
> + selem = 2;
> + break;
> + case 10:
> + rpt = 2;
> + selem = 1;
> + break;
> + default:
> + return AARCH64_RECORD_USUPPORTED;
> + break;
> + }
> + for (rindex = 0; rindex < rpt; rindex++)
> + for (eindex = 0; eindex < elements; eindex++)
> + {
> + reg_tt = (reg_rt + rindex) % 32;
> + for (sindex = 0; sindex < selem; sindex++)
> + {
> + if (ld_flag)
> + record_buf[reg_index++] = reg_tt + AARCH64_V0_REGNUM;
> + else
> + {
> + record_buf_mem[mem_index++] = esize / 8;
> + record_buf_mem[mem_index++] = address + addr_offset;
> + }
> + addr_offset = addr_offset + (esize / 8);
> + reg_tt = (reg_tt + 1) % 32;
> + }
> + }
> + }
> +
> + if (wback)
> + record_buf[reg_index++] = reg_rn;
> +
> + aarch64_insn_r->reg_rec_count = reg_index;
> + aarch64_insn_r->mem_rec_count = mem_index / 2;
> + MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count,
> + record_buf_mem);
> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
> + record_buf);
> + return AARCH64_RECORD_SUCCESS;
> +}
> +
> /* Record handler for load and store instructions. */
> static unsigned int
> aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
> @@ -3226,7 +3364,7 @@ aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
> }
> /* Advanced SIMD load/store instructions. */
> else
> - return AARCH64_RECORD_USUPPORTED;
> + return aarch64_record_asimd_load_store (aarch64_insn_r);
>
> MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count,
> record_buf_mem);
> @@ -3234,6 +3372,91 @@ aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
> record_buf);
> return AARCH64_RECORD_SUCCESS;
> }
> +
> +/* Record handler for data processing SIMD and floating point instructions. */
> +
> +static unsigned int
> +aarch64_record_data_proc_simd_fp (insn_decode_record *aarch64_insn_r)
> +{
> + uint8_t insn_bit21, opcode, rmode, reg_rd;
> + uint8_t insn_bits24_27, insn_bits28_31, insn_bits10_11, insn_bits12_15;
> + uint8_t insn_bits11_14;
> + uint32_t record_buf[2];
> +
> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
> + insn_bits28_31 = bits (aarch64_insn_r->aarch64_insn, 28, 31);
> + insn_bits10_11 = bits (aarch64_insn_r->aarch64_insn, 10, 11);
> + insn_bits12_15 = bits (aarch64_insn_r->aarch64_insn, 12, 15);
> + insn_bits11_14 = bits (aarch64_insn_r->aarch64_insn, 11, 14);
> + opcode = bits (aarch64_insn_r->aarch64_insn, 16, 18);
> + rmode = bits (aarch64_insn_r->aarch64_insn, 19, 20);
> + reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
> + insn_bit21 = bit (aarch64_insn_r->aarch64_insn, 21);
> +
> + if ((insn_bits28_31 & 0x05) == 0x01 && insn_bits24_27 == 0x0e)
> + {
> + /* Floating point - fixed-point conversion instructions. */
> + if (!insn_bit21)
> + if ((opcode >> 1) == 0x0 && rmode == 0x03)
> + record_buf[0] = reg_rd;
> + else
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> + /* Floating point conditional compare instructions. */
> + else if (insn_bits10_11 == 0x01) //
> + record_buf[0] = AARCH64_CPSR_REGNUM;
> + /* Floating-point data-processing (2-source) and conditional select. */
> + else if (insn_bits10_11 == 0x02 || insn_bits10_11 == 0x03)
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> + else if (insn_bits10_11 == 0x00)
> + {
> + /* Floating point immediate instructions. */
> + if ((insn_bits12_15 & 0x01) == 0x01 || (insn_bits12_15 & 0x07) == 0x04)
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> + /* Floating point compare instructions. */
> + else if ((insn_bits12_15 & 0x03) == 0x02)
> + record_buf[0] = AARCH64_CPSR_REGNUM;
> + /* Floating-point - integer conversions instructions. */
> + if (insn_bits12_15 == 0x00)
> + {
> + /* Type - convert float to integer. */
> + if (!(opcode >> 1) || ((opcode >> 1) == 0x02 && !rmode))
> + record_buf[0] = reg_rd + AARCH64_X0_REGNUM;
> + /* Type - convert integer to float. */
> + else if ((opcode >> 1) == 0x01 && !rmode)
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> + /* Type - move float to integer. */
> + else if ((opcode >> 1) == 0x03)
> + {
> + if (!(opcode & 0x01))
> + record_buf[0] = reg_rd + AARCH64_X0_REGNUM;
> + else
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> + }
> + }
> + }
> + }
> + else if ((insn_bits28_31 & 0x09) == 0x00 && insn_bits24_27 == 0x0E)
> + {
> + /* Advanced SIMD copy instructions. */
> + if (!bits (aarch64_insn_r->aarch64_insn, 21, 23) &&
> + !bit (aarch64_insn_r->aarch64_insn, 15) &&
> + bit (aarch64_insn_r->aarch64_insn, 10))
> + if (insn_bits11_14 == 0x05 || insn_bits11_14 == 0x07)
> + record_buf[0] = reg_rd + AARCH64_X0_REGNUM;
> + else
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> + else
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> + }
> + /* All remaining floating point or advanced SIMD instructions. */
> + else
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> +
> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
> + record_buf);
> + return AARCH64_RECORD_SUCCESS;
> +}
> +
> /* Decodes thumb2 instruction type and invokes its record handler. */
>
> static unsigned int
> @@ -3264,7 +3487,7 @@ aarch64_record_decode_insn_handler (insn_decode_record *aarch64_insn_r)
>
> /* Data processing - SIMD and floating point instructions. */
> if (ins_bit25 && ins_bit26 && ins_bit27)
> - return AARCH64_RECORD_USUPPORTED;
> + return aarch64_record_data_proc_simd_fp (aarch64_insn_r);
>
> return AARCH64_RECORD_USUPPORTED;
> }
> --
> 1.9.1
>
--
Will Newton
Toolchain Working Group, Linaro
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 6/7] Support for recording aarch64 advanced SIMD instructions
2014-06-05 8:58 ` Will Newton
@ 2014-08-29 13:41 ` Omair Javaid
2014-09-02 15:01 ` Will Newton
0 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-08-29 13:41 UTC (permalink / raw)
To: gdb-patches
Updated patch after incorporating suggestions.
gdb:
2014-08-28 Omair Javaid <omair.javaid@linaro.org>
* aarch64-tdep.c (aarch64_record_data_proc_simd_fp): Add handler
for data processing SIMD and floating point insns.
(aarch64_record_asimd_load_store): Add handler to record ASIMD load
store insns.
(aarch64_record_load_store): Install record handler
aarch64_record_asimd_load_store.
(aarch64_record_decode_insn_handler): Install record handler
aarch64_record_data_proc_simd_fp.
---
gdb/aarch64-tdep.c | 228 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 226 insertions(+), 2 deletions(-)
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index c6da25a..9437280 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -2986,6 +2986,144 @@ aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
return AARCH64_RECORD_SUCCESS;
}
+/* Record handler for advanced SIMD load and store instructions. */
+static unsigned int
+aarch64_record_asimd_load_store (insn_decode_record *aarch64_insn_r)
+{
+ CORE_ADDR address;
+ uint64_t addr_offset = 0;
+ uint32_t record_buf[24];
+ uint64_t record_buf_mem[24];
+ uint32_t reg_rn, reg_rt, reg_rm;
+ uint32_t reg_index = 0, mem_index = 0;
+ uint8_t eindex, rindex, sindex, reg_tt, replicate;
+ uint8_t elements, esize, rpt, selem, single, scale;
+ uint8_t opcode_bits, size_bits, ld_flag, data_size, wback;
+
+ reg_rt = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ reg_rn = bits (aarch64_insn_r->aarch64_insn, 5, 9);
+ reg_rm = bits (aarch64_insn_r->aarch64_insn, 16, 20);
+
+ wback = bit (aarch64_insn_r->aarch64_insn, 23);
+ single = bit (aarch64_insn_r->aarch64_insn, 24);
+ ld_flag = bit (aarch64_insn_r->aarch64_insn, 22);
+ size_bits = bits (aarch64_insn_r->aarch64_insn, 10, 11);
+ opcode_bits = bits (aarch64_insn_r->aarch64_insn, 12, 15);
+ regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn, &address);
+
+ if (single)
+ {
+ scale = opcode_bits >> 2;
+ selem = ((opcode_bits & 0x02) |
+ bit (aarch64_insn_r->aarch64_insn, 21)) + 1;
+ replicate = 0;
+ switch (scale)
+ {
+ case 2:
+ if (!(size_bits & 0x01) && ((size_bits >> 1) & 0x01))
+ scale = 3;
+ break;
+ case 3:
+ scale = size_bits;
+ replicate = 1;
+ break;
+ default:
+ break;
+ }
+ esize = 8 << scale;
+ if (replicate)
+ for (sindex = 0; sindex < selem; sindex++)
+ {
+ record_buf[reg_index++] = reg_rt + AARCH64_V0_REGNUM;
+ reg_rt = (reg_rt + 1) % 32;
+ }
+ else
+ {
+ for (sindex = 0; sindex < selem; sindex++)
+ if (ld_flag)
+ record_buf[reg_index++] = reg_rt + AARCH64_V0_REGNUM;
+ else
+ {
+ record_buf_mem[mem_index++] = esize / 8;
+ record_buf_mem[mem_index++] = address + addr_offset;
+ }
+ addr_offset = addr_offset + (esize / 8);
+ reg_rt = (reg_rt + 1) % 32;
+ }
+ }
+ else
+ {
+ esize = 8 << size_bits;
+ if (bit (aarch64_insn_r->aarch64_insn, 30))
+ elements = 128 / esize;
+ else
+ elements = 64 / esize;
+
+ switch (opcode_bits)
+ {
+ case 0:
+ rpt = 1;
+ selem = 4;
+ break;
+ case 2:
+ rpt = 4;
+ selem = 1;
+ break;
+ case 4:
+ rpt = 1;
+ selem = 3;
+ break;
+ case 6:
+ rpt = 3;
+ selem = 1;
+ break;
+ case 7:
+ rpt = 1;
+ selem = 1;
+ break;
+ case 8:
+ rpt = 1;
+ selem = 2;
+ break;
+ case 10:
+ rpt = 2;
+ selem = 1;
+ break;
+ default:
+ return AARCH64_RECORD_UNSUPPORTED;
+ break;
+ }
+ for (rindex = 0; rindex < rpt; rindex++)
+ for (eindex = 0; eindex < elements; eindex++)
+ {
+ reg_tt = (reg_rt + rindex) % 32;
+ for (sindex = 0; sindex < selem; sindex++)
+ {
+ if (ld_flag)
+ record_buf[reg_index++] = reg_tt + AARCH64_V0_REGNUM;
+ else
+ {
+ record_buf_mem[mem_index++] = esize / 8;
+ record_buf_mem[mem_index++] = address + addr_offset;
+ }
+ addr_offset = addr_offset + (esize / 8);
+ reg_tt = (reg_tt + 1) % 32;
+ }
+ }
+ }
+
+ if (wback)
+ record_buf[reg_index++] = reg_rn;
+
+ aarch64_insn_r->reg_rec_count = reg_index;
+ aarch64_insn_r->mem_rec_count = mem_index / 2;
+ MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count,
+ record_buf_mem);
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+
/* Record handler for load and store instructions. */
static unsigned int
aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
@@ -3224,7 +3362,7 @@ aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
}
/* Advanced SIMD load/store instructions. */
else
- return AARCH64_RECORD_UNSUPPORTED;
+ return aarch64_record_asimd_load_store (aarch64_insn_r);
MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count,
record_buf_mem);
@@ -3232,6 +3370,92 @@ aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
record_buf);
return AARCH64_RECORD_SUCCESS;
}
+
+/* Record handler for data processing SIMD and floating point instructions. */
+
+static unsigned int
+aarch64_record_data_proc_simd_fp (insn_decode_record *aarch64_insn_r)
+{
+ uint8_t insn_bit21, opcode, rmode, reg_rd;
+ uint8_t insn_bits24_27, insn_bits28_31, insn_bits10_11, insn_bits12_15;
+ uint8_t insn_bits11_14;
+ uint32_t record_buf[2];
+
+ insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
+ insn_bits28_31 = bits (aarch64_insn_r->aarch64_insn, 28, 31);
+ insn_bits10_11 = bits (aarch64_insn_r->aarch64_insn, 10, 11);
+ insn_bits12_15 = bits (aarch64_insn_r->aarch64_insn, 12, 15);
+ insn_bits11_14 = bits (aarch64_insn_r->aarch64_insn, 11, 14);
+ opcode = bits (aarch64_insn_r->aarch64_insn, 16, 18);
+ rmode = bits (aarch64_insn_r->aarch64_insn, 19, 20);
+ reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
+ insn_bit21 = bit (aarch64_insn_r->aarch64_insn, 21);
+
+ if ((insn_bits28_31 & 0x05) == 0x01 && insn_bits24_27 == 0x0e)
+ {
+ /* Floating point - fixed point conversion instructions. */
+ if (!insn_bit21)
+ if ((opcode >> 1) == 0x0 && rmode == 0x03)
+ record_buf[0] = reg_rd;
+ else
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+ /* Floating point - conditional compare instructions. */
+ else if (insn_bits10_11 == 0x01)
+ record_buf[0] = AARCH64_CPSR_REGNUM;
+ /* Floating point - data processing (2-source) and
+ conditional select instructions. */
+ else if (insn_bits10_11 == 0x02 || insn_bits10_11 == 0x03)
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+ else if (insn_bits10_11 == 0x00)
+ {
+ /* Floating point - immediate instructions. */
+ if ((insn_bits12_15 & 0x01) == 0x01 || (insn_bits12_15 & 0x07) == 0x04)
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+ /* Floating point - compare instructions. */
+ else if ((insn_bits12_15 & 0x03) == 0x02)
+ record_buf[0] = AARCH64_CPSR_REGNUM;
+ /* Floating point - integer conversions instructions. */
+ if (insn_bits12_15 == 0x00)
+ {
+ /* Convert float to integer instruction. */
+ if (!(opcode >> 1) || ((opcode >> 1) == 0x02 && !rmode))
+ record_buf[0] = reg_rd + AARCH64_X0_REGNUM;
+ /* Convert integer to float instruction. */
+ else if ((opcode >> 1) == 0x01 && !rmode)
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+ /* Move float to integer instruction. */
+ else if ((opcode >> 1) == 0x03)
+ {
+ if (!(opcode & 0x01))
+ record_buf[0] = reg_rd + AARCH64_X0_REGNUM;
+ else
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+ }
+ }
+ }
+ }
+ else if ((insn_bits28_31 & 0x09) == 0x00 && insn_bits24_27 == 0x0E)
+ {
+ /* Advanced SIMD copy instructions. */
+ if (!bits (aarch64_insn_r->aarch64_insn, 21, 23) &&
+ !bit (aarch64_insn_r->aarch64_insn, 15) &&
+ bit (aarch64_insn_r->aarch64_insn, 10))
+ if (insn_bits11_14 == 0x05 || insn_bits11_14 == 0x07)
+ record_buf[0] = reg_rd + AARCH64_X0_REGNUM;
+ else
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+ else
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+ }
+ /* All remaining floating point or advanced SIMD instructions. */
+ else
+ record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
+
+ REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
+ record_buf);
+ return AARCH64_RECORD_SUCCESS;
+}
+
/* Decodes insns type and invokes its record handler. */
static unsigned int
@@ -3262,7 +3486,7 @@ aarch64_record_decode_insn_handler (insn_decode_record *aarch64_insn_r)
/* Data processing - SIMD and floating point instructions. */
if (ins_bit25 && ins_bit26 && ins_bit27)
- return AARCH64_RECORD_UNSUPPORTED;
+ return aarch64_record_data_proc_simd_fp (aarch64_insn_r);
return AARCH64_RECORD_UNSUPPORTED;
}
--
1.9.1
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 6/7] Support for recording aarch64 advanced SIMD instructions
2014-08-29 13:41 ` [PATCH 6/7] Support for recording aarch64 advanced SIMD instructions Omair Javaid
@ 2014-09-02 15:01 ` Will Newton
0 siblings, 0 replies; 53+ messages in thread
From: Will Newton @ 2014-09-02 15:01 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
On 29 August 2014 14:41, Omair Javaid <omair.javaid@linaro.org> wrote:
> Updated patch after incorporating suggestions.
>
> gdb:
>
> 2014-08-28 Omair Javaid <omair.javaid@linaro.org>
>
> * aarch64-tdep.c (aarch64_record_data_proc_simd_fp): Add handler
> for data processing SIMD and floating point insns.
> (aarch64_record_asimd_load_store): Add handler to record ASIMD load
> store insns.
> (aarch64_record_load_store): Install record handler
> aarch64_record_asimd_load_store.
> (aarch64_record_decode_insn_handler): Install record handler
> aarch64_record_data_proc_simd_fp.
>
> ---
> gdb/aarch64-tdep.c | 228 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 226 insertions(+), 2 deletions(-)
This looks OK to me.
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index c6da25a..9437280 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -2986,6 +2986,144 @@ aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r)
> return AARCH64_RECORD_SUCCESS;
> }
>
> +/* Record handler for advanced SIMD load and store instructions. */
> +static unsigned int
> +aarch64_record_asimd_load_store (insn_decode_record *aarch64_insn_r)
> +{
> + CORE_ADDR address;
> + uint64_t addr_offset = 0;
> + uint32_t record_buf[24];
> + uint64_t record_buf_mem[24];
> + uint32_t reg_rn, reg_rt, reg_rm;
> + uint32_t reg_index = 0, mem_index = 0;
> + uint8_t eindex, rindex, sindex, reg_tt, replicate;
> + uint8_t elements, esize, rpt, selem, single, scale;
> + uint8_t opcode_bits, size_bits, ld_flag, data_size, wback;
> +
> + reg_rt = bits (aarch64_insn_r->aarch64_insn, 0, 4);
> + reg_rn = bits (aarch64_insn_r->aarch64_insn, 5, 9);
> + reg_rm = bits (aarch64_insn_r->aarch64_insn, 16, 20);
> +
> + wback = bit (aarch64_insn_r->aarch64_insn, 23);
> + single = bit (aarch64_insn_r->aarch64_insn, 24);
> + ld_flag = bit (aarch64_insn_r->aarch64_insn, 22);
> + size_bits = bits (aarch64_insn_r->aarch64_insn, 10, 11);
> + opcode_bits = bits (aarch64_insn_r->aarch64_insn, 12, 15);
> + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn, &address);
> +
> + if (single)
> + {
> + scale = opcode_bits >> 2;
> + selem = ((opcode_bits & 0x02) |
> + bit (aarch64_insn_r->aarch64_insn, 21)) + 1;
> + replicate = 0;
> + switch (scale)
> + {
> + case 2:
> + if (!(size_bits & 0x01) && ((size_bits >> 1) & 0x01))
> + scale = 3;
> + break;
> + case 3:
> + scale = size_bits;
> + replicate = 1;
> + break;
> + default:
> + break;
> + }
> + esize = 8 << scale;
> + if (replicate)
> + for (sindex = 0; sindex < selem; sindex++)
> + {
> + record_buf[reg_index++] = reg_rt + AARCH64_V0_REGNUM;
> + reg_rt = (reg_rt + 1) % 32;
> + }
> + else
> + {
> + for (sindex = 0; sindex < selem; sindex++)
> + if (ld_flag)
> + record_buf[reg_index++] = reg_rt + AARCH64_V0_REGNUM;
> + else
> + {
> + record_buf_mem[mem_index++] = esize / 8;
> + record_buf_mem[mem_index++] = address + addr_offset;
> + }
> + addr_offset = addr_offset + (esize / 8);
> + reg_rt = (reg_rt + 1) % 32;
> + }
> + }
> + else
> + {
> + esize = 8 << size_bits;
> + if (bit (aarch64_insn_r->aarch64_insn, 30))
> + elements = 128 / esize;
> + else
> + elements = 64 / esize;
> +
> + switch (opcode_bits)
> + {
> + case 0:
> + rpt = 1;
> + selem = 4;
> + break;
> + case 2:
> + rpt = 4;
> + selem = 1;
> + break;
> + case 4:
> + rpt = 1;
> + selem = 3;
> + break;
> + case 6:
> + rpt = 3;
> + selem = 1;
> + break;
> + case 7:
> + rpt = 1;
> + selem = 1;
> + break;
> + case 8:
> + rpt = 1;
> + selem = 2;
> + break;
> + case 10:
> + rpt = 2;
> + selem = 1;
> + break;
> + default:
> + return AARCH64_RECORD_UNSUPPORTED;
> + break;
> + }
> + for (rindex = 0; rindex < rpt; rindex++)
> + for (eindex = 0; eindex < elements; eindex++)
> + {
> + reg_tt = (reg_rt + rindex) % 32;
> + for (sindex = 0; sindex < selem; sindex++)
> + {
> + if (ld_flag)
> + record_buf[reg_index++] = reg_tt + AARCH64_V0_REGNUM;
> + else
> + {
> + record_buf_mem[mem_index++] = esize / 8;
> + record_buf_mem[mem_index++] = address + addr_offset;
> + }
> + addr_offset = addr_offset + (esize / 8);
> + reg_tt = (reg_tt + 1) % 32;
> + }
> + }
> + }
> +
> + if (wback)
> + record_buf[reg_index++] = reg_rn;
> +
> + aarch64_insn_r->reg_rec_count = reg_index;
> + aarch64_insn_r->mem_rec_count = mem_index / 2;
> + MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count,
> + record_buf_mem);
> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
> + record_buf);
> + return AARCH64_RECORD_SUCCESS;
> +}
> +
> /* Record handler for load and store instructions. */
> static unsigned int
> aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
> @@ -3224,7 +3362,7 @@ aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
> }
> /* Advanced SIMD load/store instructions. */
> else
> - return AARCH64_RECORD_UNSUPPORTED;
> + return aarch64_record_asimd_load_store (aarch64_insn_r);
>
> MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count,
> record_buf_mem);
> @@ -3232,6 +3370,92 @@ aarch64_record_load_store (insn_decode_record *aarch64_insn_r)
> record_buf);
> return AARCH64_RECORD_SUCCESS;
> }
> +
> +/* Record handler for data processing SIMD and floating point instructions. */
> +
> +static unsigned int
> +aarch64_record_data_proc_simd_fp (insn_decode_record *aarch64_insn_r)
> +{
> + uint8_t insn_bit21, opcode, rmode, reg_rd;
> + uint8_t insn_bits24_27, insn_bits28_31, insn_bits10_11, insn_bits12_15;
> + uint8_t insn_bits11_14;
> + uint32_t record_buf[2];
> +
> + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27);
> + insn_bits28_31 = bits (aarch64_insn_r->aarch64_insn, 28, 31);
> + insn_bits10_11 = bits (aarch64_insn_r->aarch64_insn, 10, 11);
> + insn_bits12_15 = bits (aarch64_insn_r->aarch64_insn, 12, 15);
> + insn_bits11_14 = bits (aarch64_insn_r->aarch64_insn, 11, 14);
> + opcode = bits (aarch64_insn_r->aarch64_insn, 16, 18);
> + rmode = bits (aarch64_insn_r->aarch64_insn, 19, 20);
> + reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4);
> + insn_bit21 = bit (aarch64_insn_r->aarch64_insn, 21);
> +
> + if ((insn_bits28_31 & 0x05) == 0x01 && insn_bits24_27 == 0x0e)
> + {
> + /* Floating point - fixed point conversion instructions. */
> + if (!insn_bit21)
> + if ((opcode >> 1) == 0x0 && rmode == 0x03)
> + record_buf[0] = reg_rd;
> + else
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> + /* Floating point - conditional compare instructions. */
> + else if (insn_bits10_11 == 0x01)
> + record_buf[0] = AARCH64_CPSR_REGNUM;
> + /* Floating point - data processing (2-source) and
> + conditional select instructions. */
> + else if (insn_bits10_11 == 0x02 || insn_bits10_11 == 0x03)
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> + else if (insn_bits10_11 == 0x00)
> + {
> + /* Floating point - immediate instructions. */
> + if ((insn_bits12_15 & 0x01) == 0x01 || (insn_bits12_15 & 0x07) == 0x04)
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> + /* Floating point - compare instructions. */
> + else if ((insn_bits12_15 & 0x03) == 0x02)
> + record_buf[0] = AARCH64_CPSR_REGNUM;
> + /* Floating point - integer conversions instructions. */
> + if (insn_bits12_15 == 0x00)
> + {
> + /* Convert float to integer instruction. */
> + if (!(opcode >> 1) || ((opcode >> 1) == 0x02 && !rmode))
> + record_buf[0] = reg_rd + AARCH64_X0_REGNUM;
> + /* Convert integer to float instruction. */
> + else if ((opcode >> 1) == 0x01 && !rmode)
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> + /* Move float to integer instruction. */
> + else if ((opcode >> 1) == 0x03)
> + {
> + if (!(opcode & 0x01))
> + record_buf[0] = reg_rd + AARCH64_X0_REGNUM;
> + else
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> + }
> + }
> + }
> + }
> + else if ((insn_bits28_31 & 0x09) == 0x00 && insn_bits24_27 == 0x0E)
> + {
> + /* Advanced SIMD copy instructions. */
> + if (!bits (aarch64_insn_r->aarch64_insn, 21, 23) &&
> + !bit (aarch64_insn_r->aarch64_insn, 15) &&
> + bit (aarch64_insn_r->aarch64_insn, 10))
> + if (insn_bits11_14 == 0x05 || insn_bits11_14 == 0x07)
> + record_buf[0] = reg_rd + AARCH64_X0_REGNUM;
> + else
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> + else
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> + }
> + /* All remaining floating point or advanced SIMD instructions. */
> + else
> + record_buf[0] = reg_rd + AARCH64_V0_REGNUM;
> +
> + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count,
> + record_buf);
> + return AARCH64_RECORD_SUCCESS;
> +}
> +
> /* Decodes insns type and invokes its record handler. */
>
> static unsigned int
> @@ -3262,7 +3486,7 @@ aarch64_record_decode_insn_handler (insn_decode_record *aarch64_insn_r)
>
> /* Data processing - SIMD and floating point instructions. */
> if (ins_bit25 && ins_bit26 && ins_bit27)
> - return AARCH64_RECORD_UNSUPPORTED;
> + return aarch64_record_data_proc_simd_fp (aarch64_insn_r);
>
> return AARCH64_RECORD_UNSUPPORTED;
> }
> --
> 1.9.1
>
--
Will Newton
Toolchain Working Group, Linaro
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH 0/7] Process record and reverse debugging support on aarch64-linux
2014-06-04 16:21 [PATCH 0/7] Process record and reverse debugging support on aarch64-linux Omair Javaid
` (6 preceding siblings ...)
2014-06-04 16:21 ` [PATCH 6/7] Support for recording aarch64 advance simd instructions Omair Javaid
@ 2014-06-23 10:41 ` Omair Javaid
2014-08-30 3:45 ` Yao Qi
8 siblings, 0 replies; 53+ messages in thread
From: Omair Javaid @ 2014-06-23 10:41 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
On Wed 04 Jun 2014 09:21:04 PM PKT, Omair Javaid wrote:
> Hi,
> This patch series adds gdb process record-replay and reverse debugging
> support for aarch64*-linux* targets.
>
> These patches have been tested on aarch64 foundation model as well as hardware
> board in native and remote configurations.
>
> gdb.reverse Testsuite Results
>
> (AARCH64-Native Configuration)
> gdb.reverse testsuite: 2273 Pass 51 failures
>
> (AARCH64-Remote Configuration)
> gdb.reverse testsuite: 2273 Pass 51 failures
>
> Omair Javaid (7):
> NEWS entry about aarch64-linux record/replay support
> Fixes aarch64-linux gdb core file support
> Enable gdb process record on aarch64-linux targets
> Implements aarch64 process record and reverse debugging support
> Support for recording syscall on aarch64-linux
> support for recording aarch64 advance simd instructions
> Enables gdb.reverse testsuite for aarch64*-linux targets
>
> gdb/NEWS | 4 +
> gdb/aarch64-linux-nat.c | 4 +-
> gdb/aarch64-linux-tdep.c | 1018 +++++++++++++++++++++++++++++++++++++++++++--
> gdb/aarch64-linux-tdep.h | 288 ++++++++++++-
> gdb/aarch64-tdep.c | 753 +++++++++++++++++++++++++++++++++
> gdb/aarch64-tdep.h | 68 +++
> gdb/configure.tgt | 2 +-
> gdb/testsuite/lib/gdb.exp | 8 +-
> 8 files changed, 2106 insertions(+), 39 deletions(-)
>
Ping! Are there any further comments to these patches?
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 0/7] Process record and reverse debugging support on aarch64-linux
2014-06-04 16:21 [PATCH 0/7] Process record and reverse debugging support on aarch64-linux Omair Javaid
` (7 preceding siblings ...)
2014-06-23 10:41 ` [PATCH 0/7] Process record and reverse debugging support on aarch64-linux Omair Javaid
@ 2014-08-30 3:45 ` Yao Qi
2014-09-01 19:42 ` Omair Javaid
8 siblings, 1 reply; 53+ messages in thread
From: Yao Qi @ 2014-08-30 3:45 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
Omair Javaid <omair.javaid@linaro.org> writes:
> These patches have been tested on aarch64 foundation model as well as hardware
> board in native and remote configurations.
>
> gdb.reverse Testsuite Results
>
> (AARCH64-Native Configuration)
> gdb.reverse testsuite: 2273 Pass 51 failures
>
> (AARCH64-Remote Configuration)
> gdb.reverse testsuite: 2273 Pass 51 failures
The result looks good, but gdb.reverse/*.exp can't cover some
instructions, such as advance simd instructions. IWBN to add some arch
specific tests in gdb.reverse/, so that we can be more confident. x86
and amd64 have already had some arch specific tests under gdb.reverse.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 53+ messages in thread* Re: [PATCH 0/7] Process record and reverse debugging support on aarch64-linux
2014-08-30 3:45 ` Yao Qi
@ 2014-09-01 19:42 ` Omair Javaid
2014-09-02 1:12 ` Yao Qi
0 siblings, 1 reply; 53+ messages in thread
From: Omair Javaid @ 2014-09-01 19:42 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
On 30 August 2014 08:41, Yao Qi <yao@codesourcery.com> wrote:
> Omair Javaid <omair.javaid@linaro.org> writes:
>
>> These patches have been tested on aarch64 foundation model as well as hardware
>> board in native and remote configurations.
>>
>> gdb.reverse Testsuite Results
>>
>> (AARCH64-Native Configuration)
>> gdb.reverse testsuite: 2273 Pass 51 failures
>>
>> (AARCH64-Remote Configuration)
>> gdb.reverse testsuite: 2273 Pass 51 failures
>
> The result looks good, but gdb.reverse/*.exp can't cover some
> instructions, such as advance simd instructions. IWBN to add some arch
> specific tests in gdb.reverse/, so that we can be more confident. x86
> and amd64 have already had some arch specific tests under gdb.reverse.
I agree that currently we cannot test full instructions coverage but
there are so many permutations for each instruction that adding these
tests dont full fill a cost vs benefit for now. I have marked this
task in my future todo list.
>
> --
> Yao (齐尧)
^ permalink raw reply [flat|nested] 53+ messages in thread
* Re: [PATCH 0/7] Process record and reverse debugging support on aarch64-linux
2014-09-01 19:42 ` Omair Javaid
@ 2014-09-02 1:12 ` Yao Qi
0 siblings, 0 replies; 53+ messages in thread
From: Yao Qi @ 2014-09-02 1:12 UTC (permalink / raw)
To: Omair Javaid; +Cc: gdb-patches
Omair Javaid <omair.javaid@linaro.org> writes:
> I agree that currently we cannot test full instructions coverage but
> there are so many permutations for each instruction that adding these
> tests dont full fill a cost vs benefit for now. I have marked this
> task in my future todo list.
That will be great, thanks!
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 53+ messages in thread