From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30165 invoked by alias); 11 Jun 2014 07:11:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30151 invoked by uid 89); 11 Jun 2014 07:11:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ob0-f175.google.com Received: from mail-ob0-f175.google.com (HELO mail-ob0-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 11 Jun 2014 07:11:15 +0000 Received: by mail-ob0-f175.google.com with SMTP id wo20so8684215obc.20 for ; Wed, 11 Jun 2014 00:11:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=GsRcUo22qf8+d+bSbe9OdyIpRe6hK2n8S6gc+cqn3vE=; b=X6Icys0KDL25G/e0SSow1YZNQ63AGK+vhYVoEkf8/VakeuYzD26aIL8temRmtdcFj3 LQi8cLVchZSSBMFEfyrxJ9EmMWShWHlm46YqflzxerQcO/gtDdAvVQjU1o/04T2zywyq fgEKZg/RmHIRf+DDZ4LPVaC0SE5BtPOJpqTznAWLp+eAmjsjHjcyg85A2YAL7YXRobcu OBjjBPPmeXywSpFhXk9mcAjkpJm6Kc+7MGdJju/jrrjMJSonptsfOjq+tYQLGpp2x4Xo xvFOGdzPShP7L3JcrCUrPMhiGx0WQOR/iJeXMxS/mkEHHCd1K8r3qwdz+3UBagxIL4xf V+MA== X-Gm-Message-State: ALoCoQkv2E6mygjCzSkS96zWJAc3s0d51j7VyM8bSyjBSu3Vvdra3eDR1Hy2mfI+AL5jq4JpdurA X-Received: by 10.182.114.229 with SMTP id jj5mr15749499obb.53.1402470673594; Wed, 11 Jun 2014 00:11:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.211.36 with HTTP; Wed, 11 Jun 2014 00:10:53 -0700 (PDT) In-Reply-To: <87tx7y3u9b.fsf@br87z6lw.de.ibm.com> References: <1401898871-2270-1-git-send-email-omair.javaid@linaro.org> <1401898871-2270-6-git-send-email-omair.javaid@linaro.org> <87tx7y3u9b.fsf@br87z6lw.de.ibm.com> From: Omair Javaid Date: Wed, 11 Jun 2014 07:11:00 -0000 Message-ID: Subject: Re: [PATCH 5/7] Support for recording syscall on aarch64-linux To: Andreas Arnez Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00435.txt.bz2 On 6 June 2014 20:58, Andreas Arnez wrote: > On Wed, Jun 04 2014, Omair Javaid wrote: > >> This patch adds support for recording system call instruction on aarch64-linux >> targets. >> >> [...] >> @@ -471,6 +1237,164 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) >> [...] >> + >> + aarch64_linux_record_tdep.arg1 = AARCH64_X0_REGNUM + 1; >> + aarch64_linux_record_tdep.arg2 = AARCH64_X0_REGNUM + 2; >> + aarch64_linux_record_tdep.arg3 = AARCH64_X0_REGNUM + 3; >> + aarch64_linux_record_tdep.arg4 = AARCH64_X0_REGNUM + 3; > > Is this a typo? Otherwise the reason for this specialty should be > documented in a comment here, IMO. > After a bit of digging up found out that AArch64 system calls take between 0 and 7 arguments in register x1 to x7. I will update this change with comment in upcoming update to this patch.