From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25673 invoked by alias); 27 Oct 2014 12:33:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25664 invoked by uid 89); 27 Oct 2014 12:33:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f49.google.com Received: from mail-oi0-f49.google.com (HELO mail-oi0-f49.google.com) (209.85.218.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 27 Oct 2014 12:33:32 +0000 Received: by mail-oi0-f49.google.com with SMTP id a3so3175752oib.8 for ; Mon, 27 Oct 2014 05:33:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=syNV9aNh1N8t9UJWRZRahfeg+/mYjWOEkb2oK7+0Ps4=; b=MURytf2SLqHazVvhwjQwONaNCBF2jrBBKgPeNnmlQTVC7m5c+Vs+qSAjnc5D7+zsaM cUXUbQxX2NtnvWPDUZuZr29szqBjHJEl5M+wltGy1uhVuqe3k3UE5hGlTpZ12JsZQD4E Q5Gk1LCeS8VLzb9p2w0ttCYrqZJNjhRHrEEui7qpgXXgC83EM68esc9zaHsntViKewRZ Yn9+3Rl43MGZsrfVL5wxg94FESFLzmyb7jEsHgbqm6+nVwbEAVYq265RKNaPlgsiT60o uhnrzaM5e40j0EwAUef4pKwcNhGDpUMEupGgD5BqCfSDU6EtFvkdmUAApDP6PzwWL9AV A5kA== X-Gm-Message-State: ALoCoQmTsNkZlL7IE2o9qqh8hm+ea/CEc5pTuuyr1QgRVBzc6h+4aHJlpnk5+FhZ/mTqn38h37fJ X-Received: by 10.202.92.2 with SMTP id q2mr123664oib.120.1414413210774; Mon, 27 Oct 2014 05:33:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.66.114 with HTTP; Mon, 27 Oct 2014 05:33:00 -0700 (PDT) In-Reply-To: <87fvehimht.fsf@codesourcery.com> References: <1409233743-26944-1-git-send-email-omair.javaid@linaro.org> <87fvehimht.fsf@codesourcery.com> From: Omair Javaid Date: Mon, 27 Oct 2014 12:33:00 -0000 Message-ID: Subject: Re: [PATCH 2/7] Fixes for aarch64-linux core file support To: Yao Qi Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00737.txt.bz2 On 21 October 2014 18:24, Yao Qi wrote: > Omair Javaid writes: > >> @@ -376,6 +385,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, st= ruct gdbarch *gdbarch) >> /* Enable longjmp. */ >> tdep->jb_pc =3D 11; >> >> + /* Install supported register note sections. */ >> + set_gdbarch_core_regset_sections (gdbarch, aarch64_linux_regset_secti= ons); >> + >> set_gdbarch_regset_from_core_section (gdbarch, >> aarch64_linux_regset_from_core_sec= tion); > > Is this patch stale? I don't see the definition of > set_gdbarch_core_regset_sections. On the other hand, I see > aarch64-linux-tdep.c already has: > > /* Implement the "regset_from_core_section" gdbarch method. */ > > static void > aarch64_linux_iterate_over_regset_sections (struct gdbarch *gdbarch, > iterate_over_regset_sections_= cb *cb, > void *cb_data, > const struct regcache *regcac= he) > { > cb (".reg", AARCH64_LINUX_SIZEOF_GREGSET, &aarch64_linux_gregset, > NULL, cb_data); > cb (".reg2", AARCH64_LINUX_SIZEOF_FPREGSET, &aarch64_linux_fpregset, > NULL, cb_data); > } > > ... > set_gdbarch_iterate_over_regset_sections > (gdbarch, aarch64_linux_iterate_over_regset_sections); > > I assume this patch is no longer needed. Agreed! > > -- > Yao (=E9=BD=90=E5=B0=A7)