From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-116873-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9856 invoked by alias); 21 Oct 2014 13:28:43 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 9846 invoked by uid 89); 21 Oct 2014 13:28:42 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Oct 2014 13:28:41 +0000
Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43])	by relay1.mentorg.com with esmtp 	id 1XgZUM-0004gW-2E from Yao_Qi@mentor.com ; Tue, 21 Oct 2014 06:28:38 -0700
Received: from GreenOnly (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.181.6; Tue, 21 Oct 2014 06:28:37 -0700
From: Yao Qi <yao@codesourcery.com>
To: Omair Javaid <omair.javaid@linaro.org>
CC: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/7] Fixes for aarch64-linux core file support
References: <CANW4E-0xQ0mHfHN1UsXXjL7knxfdot=of8PzBghyVmvZ7xiU-g@mail.gmail.com>	<1409233743-26944-1-git-send-email-omair.javaid@linaro.org>
Date: Tue, 21 Oct 2014 13:28:00 -0000
In-Reply-To: <1409233743-26944-1-git-send-email-omair.javaid@linaro.org>	(Omair Javaid's message of "Thu, 28 Aug 2014 18:49:03 +0500")
Message-ID: <87fvehimht.fsf@codesourcery.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
X-SW-Source: 2014-10/txt/msg00549.txt.bz2

Omair Javaid <omair.javaid@linaro.org> writes:

> @@ -376,6 +385,9 @@ aarch64_linux_init_abi (struct gdbarch_info info, str=
uct gdbarch *gdbarch)
>    /* Enable longjmp.  */
>    tdep->jb_pc =3D 11;
>=20=20
> +  /* Install supported register note sections.  */
> +  set_gdbarch_core_regset_sections (gdbarch, aarch64_linux_regset_sectio=
ns);
> +
>    set_gdbarch_regset_from_core_section (gdbarch,
>  					aarch64_linux_regset_from_core_section);

Is this patch stale?  I don't see the definition of
set_gdbarch_core_regset_sections.  On the other hand, I see
aarch64-linux-tdep.c already has:

/* Implement the "regset_from_core_section" gdbarch method.  */

static void
aarch64_linux_iterate_over_regset_sections (struct gdbarch *gdbarch,
                                            iterate_over_regset_sections_cb=
 *cb,
                                            void *cb_data,
                                            const struct regcache *regcache)
{
  cb (".reg", AARCH64_LINUX_SIZEOF_GREGSET, &aarch64_linux_gregset,
      NULL, cb_data);
  cb (".reg2", AARCH64_LINUX_SIZEOF_FPREGSET, &aarch64_linux_fpregset,
      NULL, cb_data);
}

...
  set_gdbarch_iterate_over_regset_sections
    (gdbarch, aarch64_linux_iterate_over_regset_sections);

I assume this patch is no longer needed.

--=20
Yao (=E9=BD=90=E5=B0=A7)