From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10879 invoked by alias); 6 Jun 2014 15:58:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10808 invoked by uid 89); 6 Jun 2014 15:58:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp13.uk.ibm.com Received: from e06smtp13.uk.ibm.com (HELO e06smtp13.uk.ibm.com) (195.75.94.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 06 Jun 2014 15:58:15 +0000 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 6 Jun 2014 16:58:12 +0100 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 6 Jun 2014 16:58:10 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 377B12190041 for ; Fri, 6 Jun 2014 16:57:59 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s56Fw9gA27197688 for ; Fri, 6 Jun 2014 15:58:09 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s56Fw9Un030495 for ; Fri, 6 Jun 2014 11:58:09 -0400 Received: from br87z6lw.de.ibm.com (dyn-9-152-212-188.boeblingen.de.ibm.com [9.152.212.188]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s56Fw8Xb030476; Fri, 6 Jun 2014 11:58:09 -0400 From: Andreas Arnez To: Omair Javaid Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/7] Support for recording syscall on aarch64-linux References: <1401898871-2270-1-git-send-email-omair.javaid@linaro.org> <1401898871-2270-6-git-send-email-omair.javaid@linaro.org> Date: Fri, 06 Jun 2014 15:58:00 -0000 In-Reply-To: <1401898871-2270-6-git-send-email-omair.javaid@linaro.org> (Omair Javaid's message of "Wed, 4 Jun 2014 21:21:09 +0500") Message-ID: <87tx7y3u9b.fsf@br87z6lw.de.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14060615-2966-0000-0000-0000001A0C9C X-IsSubscribed: yes X-SW-Source: 2014-06/txt/msg00332.txt.bz2 On Wed, Jun 04 2014, Omair Javaid wrote: > This patch adds support for recording system call instruction on aarch64-linux > targets. > > [...] > @@ -471,6 +1237,164 @@ aarch64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) > [...] > + > + aarch64_linux_record_tdep.arg1 = AARCH64_X0_REGNUM + 1; > + aarch64_linux_record_tdep.arg2 = AARCH64_X0_REGNUM + 2; > + aarch64_linux_record_tdep.arg3 = AARCH64_X0_REGNUM + 3; > + aarch64_linux_record_tdep.arg4 = AARCH64_X0_REGNUM + 3; Is this a typo? Otherwise the reason for this specialty should be documented in a comment here, IMO.