RE: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.

["Tedeschi, Walfred" <walfred.tedeschi@intel.com>]

Hello Mark,

Ok, I Will let it symmetrical to the AVX, i.e:

/* In case one of the MPX XCR0 bits is set we consider we have MPX.  
 #define HAS_MPX(XCR0) ((XCR0) & I386_XSTATE_MPX) == I386_XSTATE_MPX


Thanks a lot for your review,
Regards,
-Fred
-----Original Message-----
From: Mark Kettenis [mailto:mark.kettenis@xs4all.nl] 
Sent: Monday, November 25, 2013 3:49 PM
To: Tedeschi, Walfred
Cc: palves@redhat.com; yao@codesourcery.com; gdb-patches@sourceware.org; Tedeschi, Walfred
Subject: Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.

> From: Walfred Tedeschi <walfred.tedeschi@intel.com>
> Date: Mon, 25 Nov 2013 14:40:02 +0100
> 
> Macro returning the size of the xsave buffer got broken with the MPX 
> patch.  Fix improves the macro to make it more readable.
> 
> 2013-12-25  Walfred Tedeschi  <walfred.tedeschi@intel.com>
> 
> 	* i386-xstate.h (I386_XSTATE_MPX): New Macro.
> 	(I386_XSTATE_MPX_MASK): Makes use of I386_XSTATE_MPX.
> 	(HAS_MPX): New macro.
> 	(HAS_AVX): New macro.
> 	(I386_XSTATE_SIZE): Refactored macro using HAS_MPX and
> 	HAS_AVX.
> ---
>  gdb/common/i386-xstate.h | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
> 
> +/* In case one of the MPX XCR0 bits is set we consider we have MPX.  
> +*/ #define HAS_MPX(XCR0) (((XCR0) & I386_XSTATE_MPX) == I386_XSTATE_BNDREGS) \
> +        || (((XCR0) & I386_XSTATE_MPX) == I386_XSTATE_BNDCFG)

That doesn't seem to do what it says on the tin!
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052