RE: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.

["Tedeschi, Walfred" <walfred.tedeschi@intel.com>]

Pedro,

This should be the fix. The issue was that the buffer size was not matching the size actually read.
Macro was really broken, for any XCR0 value it was returning 576, as pointed by Joel:
https://sourceware.org/ml/gdb-patches/2013-11/msg00761.html

I have tested the macros on an ad-hoc application to verify its functionality.

Do you still see the issue when applying this?

Thanks for your review!
Regards,
-Fred

-----Original Message-----
From: Pedro Alves [mailto:palves@redhat.com] 
Sent: Monday, November 25, 2013 3:24 PM
To: Tedeschi, Walfred
Cc: yao@codesourcery.com; gdb-patches@sourceware.org
Subject: Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.

Thanks.

On 11/25/2013 01:40 PM, Walfred Tedeschi wrote:
> Macro returning the size of the xsave buffer got broken with the MPX 
> patch.  Fix improves the macro to make it more readable.

To be clear, this patch doesn't do any fix yet -- it's just a preparatory cleanup, right?

--
Pedro Alves

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052