From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1554 invoked by alias); 25 Nov 2013 14:33:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1544 invoked by uid 89); 25 Nov 2013 14:33:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mga01.intel.com Received: from Unknown (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Nov 2013 14:33:42 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 25 Nov 2013 06:33:30 -0800 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga001.fm.intel.com with ESMTP; 25 Nov 2013 06:33:01 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.135]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0123.003; Mon, 25 Nov 2013 14:32:29 +0000 From: "Tedeschi, Walfred" To: Pedro Alves CC: "yao@codesourcery.com" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts. Date: Mon, 25 Nov 2013 14:49:00 -0000 Message-ID: References: <1385386802-16948-1-git-send-email-walfred.tedeschi@intel.com> <52935D6A.1060301@redhat.com> In-Reply-To: <52935D6A.1060301@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00772.txt.bz2 Pedro, This should be the fix. The issue was that the buffer size was not matching= the size actually read. Macro was really broken, for any XCR0 value it was returning 576, as pointe= d by Joel: https://sourceware.org/ml/gdb-patches/2013-11/msg00761.html I have tested the macros on an ad-hoc application to verify its functionali= ty. Do you still see the issue when applying this? Thanks for your review! Regards, -Fred -----Original Message----- From: Pedro Alves [mailto:palves@redhat.com]=20 Sent: Monday, November 25, 2013 3:24 PM To: Tedeschi, Walfred Cc: yao@codesourcery.com; gdb-patches@sourceware.org Subject: Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts. Thanks. On 11/25/2013 01:40 PM, Walfred Tedeschi wrote: > Macro returning the size of the xsave buffer got broken with the MPX=20 > patch. Fix improves the macro to make it more readable. To be clear, this patch doesn't do any fix yet -- it's just a preparatory c= leanup, right? -- Pedro Alves Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052