Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.

[Pedro Alves <palves@redhat.com>]

On 11/25/2013 02:32 PM, Tedeschi, Walfred wrote:
> This should be the fix. The issue was that the buffer size was not matching the size actually read.

I'm staring at the patch, and not seeing what the actual functional
change was.  Can you point it out?  That's the sort of thing that helps
review, and that is good to have in the email/commit log -- a rationale
for the fix, an explanation of what was wrong, how the fix actually fixes it, etc.

> Macro was really broken, for any XCR0 value it was returning 576, as pointed by Joel:
> https://sourceware.org/ml/gdb-patches/2013-11/msg00761.html
> 
> I have tested the macros on an ad-hoc application to verify its functionality.
> 
> Do you still see the issue when applying this?

I haven't tried it yet.  I'll do that now.

Thanks,
-- 
Pedro Alves