From: Pedro Alves <palves@redhat.com>
To: Walfred Tedeschi <walfred.tedeschi@intel.com>
Cc: yao@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.
Date: Mon, 25 Nov 2013 15:04:00 -0000 [thread overview]
Message-ID: <52936646.9030704@redhat.com> (raw)
In-Reply-To: <529363FF.3060602@intel.com>
On 11/25/2013 02:51 PM, Walfred Tedeschi wrote:
> Hello All,
>
> For clarification the macro I386_XSTATE_SIZE(XCR0) was returning for any
> XCR0 the value 576.
I must be very dense today, sorry. :-( Can you point out why that
was so before the patch, and no longer is so after the patch?
>> > /* Get I386 XSAVE extended state size. */
>> > #define I386_XSTATE_SIZE(XCR0) \
>> > - (((XCR0) & I386_XSTATE_BNDCFG) != 0 ? I386_XSTATE_BNDCFG_SIZE \
>> > - : (((XCR0) & I386_XSTATE_BNDREGS) != 0 ? I386_XSTATE_BNDCFG_SIZE \
>> > - : (((XCR0) & I386_XSTATE_AVX_SIZE) != 0 ? I386_XSTATE_AVX_SIZE \
>> > - : I386_XSTATE_SSE_SIZE)))
>> > + (HAS_MPX (XCR0) ? I386_XSTATE_BNDCFG_SIZE : \
>> > + (HAS_AVX (XCR0) ? I386_XSTATE_AVX_SIZE : I386_XSTATE_SSE_SIZE))
I'm unrolling the new macros in my head, and I can figure out why
does this now return a different value. :-/
--
Pedro Alves
prev parent reply other threads:[~2013-11-25 15:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 14:33 Walfred Tedeschi
2013-11-25 14:40 ` Pedro Alves
2013-11-25 14:49 ` Tedeschi, Walfred
2013-11-25 14:51 ` Pedro Alves
2013-11-25 15:19 ` Pedro Alves
2013-11-25 14:57 ` Mark Kettenis
2013-11-25 15:03 ` Tedeschi, Walfred
2013-11-25 15:14 ` Pedro Alves
2013-11-25 15:31 ` Mark Kettenis
2013-11-25 15:48 ` Walfred Tedeschi
2013-11-25 15:01 ` Walfred Tedeschi
2013-11-25 15:04 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52936646.9030704@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=walfred.tedeschi@intel.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox