From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: walfred.tedeschi@intel.com
Cc: palves@redhat.com, yao@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.
Date: Mon, 25 Nov 2013 15:31:00 -0000 [thread overview]
Message-ID: <201311251518.rAPFIgbc010735@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <AC542571535E904D8E8ADAE745D60B191B1DBFEC@IRSMSX104.ger.corp.intel.com> (walfred.tedeschi@intel.com)
> From: "Tedeschi, Walfred" <walfred.tedeschi@intel.com>
> Date: Mon, 25 Nov 2013 14:56:59 +0000
>
> Hello Mark,
>
> Ok, I Will let it symmetrical to the AVX, i.e:
>
> /* In case one of the MPX XCR0 bits is set we consider we have MPX.
> #define HAS_MPX(XCR0) ((XCR0) & I386_XSTATE_MPX) == I386_XSTATE_MPX
Still doesn't do what it says on the tin. The macro is checking if
*both* bits are set. If you want to have the code match the comment
it needs to be changed to something like:
#define HAS_MPX(XRC0) (((XRC0) & I386_XSTATE_MPX) != 0)
or you need to change the comment to state that all bits need to be set.
next prev parent reply other threads:[~2013-11-25 15:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 14:33 Walfred Tedeschi
2013-11-25 14:40 ` Pedro Alves
2013-11-25 14:49 ` Tedeschi, Walfred
2013-11-25 14:51 ` Pedro Alves
2013-11-25 15:19 ` Pedro Alves
2013-11-25 14:57 ` Mark Kettenis
2013-11-25 15:03 ` Tedeschi, Walfred
2013-11-25 15:14 ` Pedro Alves
2013-11-25 15:31 ` Mark Kettenis [this message]
2013-11-25 15:48 ` Walfred Tedeschi
2013-11-25 15:01 ` Walfred Tedeschi
2013-11-25 15:04 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311251518.rAPFIgbc010735@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=walfred.tedeschi@intel.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox