From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: walfred.tedeschi@intel.com
Cc: palves@redhat.com, yao@codesourcery.com,
gdb-patches@sourceware.org, walfred.tedeschi@intel.com
Subject: Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.
Date: Mon, 25 Nov 2013 14:57:00 -0000 [thread overview]
Message-ID: <201311251449.rAPEn6uZ014952@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <1385386802-16948-1-git-send-email-walfred.tedeschi@intel.com> (message from Walfred Tedeschi on Mon, 25 Nov 2013 14:40:02 +0100)
> From: Walfred Tedeschi <walfred.tedeschi@intel.com>
> Date: Mon, 25 Nov 2013 14:40:02 +0100
>
> Macro returning the size of the xsave buffer got broken with the MPX
> patch. Fix improves the macro to make it more readable.
>
> 2013-12-25 Walfred Tedeschi <walfred.tedeschi@intel.com>
>
> * i386-xstate.h (I386_XSTATE_MPX): New Macro.
> (I386_XSTATE_MPX_MASK): Makes use of I386_XSTATE_MPX.
> (HAS_MPX): New macro.
> (HAS_AVX): New macro.
> (I386_XSTATE_SIZE): Refactored macro using HAS_MPX and
> HAS_AVX.
> ---
> gdb/common/i386-xstate.h | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> +/* In case one of the MPX XCR0 bits is set we consider we have MPX. */
> +#define HAS_MPX(XCR0) (((XCR0) & I386_XSTATE_MPX) == I386_XSTATE_BNDREGS) \
> + || (((XCR0) & I386_XSTATE_MPX) == I386_XSTATE_BNDCFG)
That doesn't seem to do what it says on the tin!
next prev parent reply other threads:[~2013-11-25 14:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 14:33 Walfred Tedeschi
2013-11-25 14:40 ` Pedro Alves
2013-11-25 14:49 ` Tedeschi, Walfred
2013-11-25 14:51 ` Pedro Alves
2013-11-25 15:19 ` Pedro Alves
2013-11-25 14:57 ` Mark Kettenis [this message]
2013-11-25 15:03 ` Tedeschi, Walfred
2013-11-25 15:14 ` Pedro Alves
2013-11-25 15:31 ` Mark Kettenis
2013-11-25 15:48 ` Walfred Tedeschi
2013-11-25 15:01 ` Walfred Tedeschi
2013-11-25 15:04 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311251449.rAPEn6uZ014952@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=walfred.tedeschi@intel.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox