From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-107607-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8867 invoked by alias); 25 Nov 2013 14:49:28 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 8855 invoked by uid 89); 25 Nov 2013 14:49:27 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2
X-HELO: glazunov.sibelius.xs4all.nl
Received: from Unknown (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 25 Nov 2013 14:49:26 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id rAPEn7C8023620;	Mon, 25 Nov 2013 15:49:07 +0100 (CET)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id rAPEn6uZ014952;	Mon, 25 Nov 2013 15:49:06 +0100 (CET)
Date: Mon, 25 Nov 2013 14:57:00 -0000
Message-Id: <201311251449.rAPEn6uZ014952@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: walfred.tedeschi@intel.com
CC: palves@redhat.com, yao@codesourcery.com, gdb-patches@sourceware.org,        walfred.tedeschi@intel.com
In-reply-to: <1385386802-16948-1-git-send-email-walfred.tedeschi@intel.com>	(message from Walfred Tedeschi on Mon, 25 Nov 2013 14:40:02 +0100)
Subject: Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.
References:  <1385386802-16948-1-git-send-email-walfred.tedeschi@intel.com>
X-SW-Source: 2013-11/txt/msg00774.txt.bz2

> From: Walfred Tedeschi <walfred.tedeschi@intel.com>
> Date: Mon, 25 Nov 2013 14:40:02 +0100
> 
> Macro returning the size of the xsave buffer got broken with the MPX
> patch.  Fix improves the macro to make it more readable.
> 
> 2013-12-25  Walfred Tedeschi  <walfred.tedeschi@intel.com>
> 
> 	* i386-xstate.h (I386_XSTATE_MPX): New Macro.
> 	(I386_XSTATE_MPX_MASK): Makes use of I386_XSTATE_MPX.
> 	(HAS_MPX): New macro.
> 	(HAS_AVX): New macro.
> 	(I386_XSTATE_SIZE): Refactored macro using HAS_MPX and
> 	HAS_AVX.
> ---
>  gdb/common/i386-xstate.h | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
> 
> +/* In case one of the MPX XCR0 bits is set we consider we have MPX.  */
> +#define HAS_MPX(XCR0) (((XCR0) & I386_XSTATE_MPX) == I386_XSTATE_BNDREGS) \
> +        || (((XCR0) & I386_XSTATE_MPX) == I386_XSTATE_BNDCFG)

That doesn't seem to do what it says on the tin!