From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-107614-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4060 invoked by alias); 25 Nov 2013 15:19:05 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 4044 invoked by uid 89); 25 Nov 2013 15:19:03 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,URIBL_BLOCKED autolearn=no version=3.3.2
X-HELO: glazunov.sibelius.xs4all.nl
Received: from Unknown (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 25 Nov 2013 15:19:02 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id rAPFIhKL007916;	Mon, 25 Nov 2013 16:18:43 +0100 (CET)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id rAPFIgbc010735;	Mon, 25 Nov 2013 16:18:42 +0100 (CET)
Date: Mon, 25 Nov 2013 15:31:00 -0000
Message-Id: <201311251518.rAPFIgbc010735@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: walfred.tedeschi@intel.com
CC: palves@redhat.com, yao@codesourcery.com, gdb-patches@sourceware.org
In-reply-to:	<AC542571535E904D8E8ADAE745D60B191B1DBFEC@IRSMSX104.ger.corp.intel.com>	(walfred.tedeschi@intel.com)
Subject: Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.
References: <1385386802-16948-1-git-send-email-walfred.tedeschi@intel.com> <201311251449.rAPEn6uZ014952@glazunov.sibelius.xs4all.nl> <AC542571535E904D8E8ADAE745D60B191B1DBFEC@IRSMSX104.ger.corp.intel.com>
X-SW-Source: 2013-11/txt/msg00781.txt.bz2

> From: "Tedeschi, Walfred" <walfred.tedeschi@intel.com>
> Date: Mon, 25 Nov 2013 14:56:59 +0000
> 
> Hello Mark,
> 
> Ok, I Will let it symmetrical to the AVX, i.e:
> 
> /* In case one of the MPX XCR0 bits is set we consider we have MPX.  
>  #define HAS_MPX(XCR0) ((XCR0) & I386_XSTATE_MPX) == I386_XSTATE_MPX

Still doesn't do what it says on the tin.  The macro is checking if
*both* bits are set.  If you want to have the code match the comment
it needs to be changed to something like:

#define HAS_MPX(XRC0) (((XRC0) & I386_XSTATE_MPX) != 0)

or you need to change the comment to state that all bits need to be set.