From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19348 invoked by alias); 25 Nov 2013 14:57:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19337 invoked by uid 89); 25 Nov 2013 14:57:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mga03.intel.com Received: from Unknown (HELO mga03.intel.com) (143.182.124.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Nov 2013 14:57:10 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by azsmga101.ch.intel.com with ESMTP; 25 Nov 2013 06:57:01 -0800 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga001.fm.intel.com with ESMTP; 25 Nov 2013 06:57:00 -0800 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.135]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0123.003; Mon, 25 Nov 2013 14:56:59 +0000 From: "Tedeschi, Walfred" To: Mark Kettenis CC: "palves@redhat.com" , "yao@codesourcery.com" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts. Date: Mon, 25 Nov 2013 15:03:00 -0000 Message-ID: References: <1385386802-16948-1-git-send-email-walfred.tedeschi@intel.com> <201311251449.rAPEn6uZ014952@glazunov.sibelius.xs4all.nl> In-Reply-To: <201311251449.rAPEn6uZ014952@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00776.txt.bz2 Hello Mark, Ok, I Will let it symmetrical to the AVX, i.e: /* In case one of the MPX XCR0 bits is set we consider we have MPX.=20=20 #define HAS_MPX(XCR0) ((XCR0) & I386_XSTATE_MPX) =3D=3D I386_XSTATE_MPX Thanks a lot for your review, Regards, -Fred -----Original Message----- From: Mark Kettenis [mailto:mark.kettenis@xs4all.nl]=20 Sent: Monday, November 25, 2013 3:49 PM To: Tedeschi, Walfred Cc: palves@redhat.com; yao@codesourcery.com; gdb-patches@sourceware.org; Te= deschi, Walfred Subject: Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts. > From: Walfred Tedeschi > Date: Mon, 25 Nov 2013 14:40:02 +0100 >=20 > Macro returning the size of the xsave buffer got broken with the MPX=20 > patch. Fix improves the macro to make it more readable. >=20 > 2013-12-25 Walfred Tedeschi >=20 > * i386-xstate.h (I386_XSTATE_MPX): New Macro. > (I386_XSTATE_MPX_MASK): Makes use of I386_XSTATE_MPX. > (HAS_MPX): New macro. > (HAS_AVX): New macro. > (I386_XSTATE_SIZE): Refactored macro using HAS_MPX and > HAS_AVX. > --- > gdb/common/i386-xstate.h | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) >=20 > +/* In case one of the MPX XCR0 bits is set we consider we have MPX.=20=20 > +*/ #define HAS_MPX(XCR0) (((XCR0) & I386_XSTATE_MPX) =3D=3D I386_XSTATE_= BNDREGS) \ > + || (((XCR0) & I386_XSTATE_MPX) =3D=3D I386_XSTATE_BNDCFG) That doesn't seem to do what it says on the tin! Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052