Re: [PATCH 2/4] gdb/aarch64: Test record/replay support for CSSC

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

<Ezra.Sitorus@arm.com> writes:

> +proc test_single_asm { name } {
> +    global decimal hex
> +
> +    set before_seq [gdb_get_line_number "Before ${name}"]
> +    set after_seq [gdb_get_line_number "After ${name}"]
> +    set regs { x19 x20 x21 }
> +
> +    set insn [lindex [split $name "-"] 0]

Unlike the aarch64-lrcpc3.exp test from the previous patch, this one
uses $insn rather than $name to differentiate the test names. As a
result, for instructions which are tested twice (e.g., smax-1 and
smax-2) all the tests in this function cause DUPLICATE errors.

My suggestion here is the same as the one for the previous patch: wrap
the body of the function in with_test_prefix $name { ... }.

> +
> +    gdb_test "break $before_seq" \
> +	"Breakpoint $decimal at $hex: file .*/aarch64-cssc.c, line $decimal\\." \
> +	"$insn: break before instruction sequence"
> +    gdb_continue_to_breakpoint "$insn: about to execute instruction sequence" \
> +	[multi_line ".*/aarch64-cssc.c:$decimal" \
> +	    "$decimal\[ \t\]+__asm__ volatile \\(\"${insn} \[^\r\n\]+\""]

-- 
Thiago