Re: [PATCH 0/4] gdb/aarch64: record/replay support for AArch64

[Guinevere Larsen <guinevere@redhat.com>]

On 4/20/26 6:52 PM, Ezra.Sitorus@arm.com wrote:
> From: Ezra Sitorus <ezra.sitorus@arm.com>
>
> This patch series enables record/replay for the following AArch64
> features:
> * FEAT_LRCPC3 (+rcpc3)
> * FEAT_CSSC (+cssc)
> * FEAT_RPRFM (+rprfm)
> * FEAT_LSE128 (+lse128)
>
> These were tested either with QEMU or Shrinkwrap. In both cases, I seem
> to have test failures that are not related to my patches (gdb.threads,
> gdb.mi tests for example). In these cases, is it fair to ignore these?
> Or is there some underlying issue I've missed?

gdb.threads tests are pretty often unreliable (we usually call them 
racy, as in, failing due to race conditions), and unfortunately some 
tests consistently fail on some configurations. My general 
recommendation while you're getting used to the tests is to run the 
testsuite before and after your changes, so you have a feel for what is 
likely to be a regression of yours or not.

For reference, my system usually shows 4 failures, but can go up to 6 
depending on what I do. If I run it with clang, I can expect between 50 
and 70 failures.

>
> In addition, whenever I used QEMU, I disabled gcs because it seems to
> cause test failures - address/memory accesses seem to always cause a
> fault. Am I doing something wrong?

Unfortunately I can't help here, never tried running reverse tests on 
QEMU...

I'll try to review your patches tomorrow, to get this moving :)

-- 
Cheers,
Guinevere Larsen
It/she

>
> Ezra
>
> Ezra Sitorus (4):
>    gdb/aarch64: record/replay support for LRCPC3
>    gdb/aarch64: Test record/replay support for CSSC
>    gdb/aarch64: record/replay support for RPRFM and PRFM (reg)
>    gdb/aarch64: record/replay support for LSE128
>
>   gdb/aarch64-tdep.c                           | 105 ++++++
>   gdb/testsuite/gdb.reverse/aarch64-cssc.c     | 113 +++++++
>   gdb/testsuite/gdb.reverse/aarch64-cssc.exp   | 141 ++++++++
>   gdb/testsuite/gdb.reverse/aarch64-lrcpc3.c   | 319 +++++++++++++++++++
>   gdb/testsuite/gdb.reverse/aarch64-lrcpc3.exp | 203 ++++++++++++
>   gdb/testsuite/gdb.reverse/aarch64-lse128.c   | 139 ++++++++
>   gdb/testsuite/gdb.reverse/aarch64-lse128.exp | 138 ++++++++
>   gdb/testsuite/lib/gdb.exp                    | 171 ++++++++++
>   8 files changed, 1329 insertions(+)
>   create mode 100644 gdb/testsuite/gdb.reverse/aarch64-cssc.c
>   create mode 100644 gdb/testsuite/gdb.reverse/aarch64-cssc.exp
>   create mode 100644 gdb/testsuite/gdb.reverse/aarch64-lrcpc3.c
>   create mode 100644 gdb/testsuite/gdb.reverse/aarch64-lrcpc3.exp
>   create mode 100644 gdb/testsuite/gdb.reverse/aarch64-lse128.c
>   create mode 100644 gdb/testsuite/gdb.reverse/aarch64-lse128.exp
>