Re: [PATCH 2/4] gdb/aarch64: Test record/replay support for CSSC

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

<Ezra.Sitorus@arm.com> writes:

> From: Ezra Sitorus <ezra.sitorus@arm.com>
>
> This patch checks that the handling of CSSC instructions is correct.
> There is no explicit support for handling these instructions which is
> why this patch is composed of tests.
>
> Regression tested on aarch64-none-linux-gnu on QEMU with CSSC support.
> I observe unrelated regressions that appear to be environmental rather
> than caused by this patch.
> ---
>  gdb/testsuite/gdb.reverse/aarch64-cssc.c   | 113 +++++++++++++++++
>  gdb/testsuite/gdb.reverse/aarch64-cssc.exp | 141 +++++++++++++++++++++
>  gdb/testsuite/lib/gdb.exp                  |  52 ++++++++
>  3 files changed, 306 insertions(+)
>  create mode 100644 gdb/testsuite/gdb.reverse/aarch64-cssc.c
>  create mode 100644 gdb/testsuite/gdb.reverse/aarch64-cssc.exp

Following the decoding of CSSC instructions in
aarch64_record_data_proc_imm and aarch64_record_load_store made me
realize how clever the AArch64 instruction encoding is. :)

For this patch I only have the same comments I had about the testcase in
patch 1: the copyright year, the formatting of the if condition block
and the top-level return statements.

-- 
Thiago