Re: [PATCH 3/4] gdb/aarch64: record/replay support for RPRFM and PRFM (reg)

[Guinevere Larsen <guinevere@redhat.com>]

On 4/20/26 6:52 PM, Ezra.Sitorus@arm.com wrote:
> From: Ezra Sitorus <ezra.sitorus@arm.com>
>
> The PRFM (register) instruction variant was unsupported. This is added
> along with RPRFM.
>
> No testcase has been added as these are hint instructions which don't
> modify registers/memory. I'm happy to add them in if you think these are
> required.
>
> The full testsuite was done on aarch64-none-linux-gnu without RPRFM.
> The gdb.arch and gdb.reverse tests were run on Shrinkwrap with RPRFM
> support. I've observed unrelated regressions that appear to be due to
> Shrinkwrap rather than my patch.
Just popping by to ack that no tests are needed. I'll leave the review 
to Luis
> ---
>   gdb/aarch64-tdep.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index 81d4f160f8f..61c462979b3 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -5914,6 +5914,11 @@ aarch64_record_load_store (aarch64_insn_decode_record *aarch64_insn_r)
>         else
>   	if (size_bits != 0x03)
>   	  ld_flag = 0x01;
> +	else if (size_bits == 0x3 && vector_flag == 0x0 && opc == 0x2)
> +	  {
> +	    /* PRFM (register) or RPRFM */
> +	    return AARCH64_RECORD_SUCCESS;
> +	  }
>   	else
>   	  return AARCH64_RECORD_UNKNOWN;
>   


-- 
Cheers,
Guinevere Larsen
It/she