Re: [PATCH 4/4] gdb/aarch64: record/replay support for LSE128

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

<Ezra.Sitorus@arm.com> writes:

> From: Ezra Sitorus <ezra.sitorus@arm.com>
>
> FEAT_LSE128 introduces support for 128-bit atomic instructions. This
> patch teaches GDB to decode these instructions for recording and
> reversing.
>
> Regression tested on aarch64-none-linux-gnu on QEMU with LSE128 support.
> I observe unrelated regressions that appear to be environmental rather
> than caused by this patch.
> ---
>  gdb/aarch64-tdep.c                           |  13 ++
>  gdb/testsuite/gdb.reverse/aarch64-lse128.c   | 139 +++++++++++++++++++
>  gdb/testsuite/gdb.reverse/aarch64-lse128.exp | 138 ++++++++++++++++++
>  gdb/testsuite/lib/gdb.exp                    |  56 ++++++++
>  4 files changed, 346 insertions(+)
>  create mode 100644 gdb/testsuite/gdb.reverse/aarch64-lse128.c
>  create mode 100644 gdb/testsuite/gdb.reverse/aarch64-lse128.exp

For this patch I only have the same comments I had about the testcase in
patch 1: the copyright year, the formatting of the if condition block,
the top-level return statements and the with_test_prefix change to avoid
DUPLICATE errors.

-- 
Thiago