Re: [PATCH 0/4] gdb/aarch64: record/replay support for AArch64

[Ezra Sitorus <ezra.sitorus@arm.com>]

> > These were tested either with QEMU or Shrinkwrap. In both cases, I seem
> > to have test failures that are not related to my patches (gdb.threads,
> > gdb.mi tests for example). In these cases, is it fair to ignore these?
> > Or is there some underlying issue I've missed?
> 
> gdb.threads tests are pretty often unreliable (we usually call them racy, as
> in, failing due to race conditions), and unfortunately some tests
> consistently fail on some configurations. My general recommendation while
> you're getting used to the tests is to run the testsuite before and after
> your changes, so you have a feel for what is likely to be a regression of
> yours or not.
> 
> For reference, my system usually shows 4 failures, but can go up to 6
> depending on what I do. If I run it with clang, I can expect between 50 and
> 70 failures.

I just re-read what I sent, I should clarify that on Shrinkwrap (which is much
slower than QEMU), I can only feasibly do gdb.arch and gdb.reverse tests.  On
QEMU I do a full testsuite run. That said, even on Shrinkwrap with the smaller
set of tests, I still get failures on some gdb.arch and gdb.reverse tests,
which essentially make it hard for me to compare what's happening. On the
whole, the gdb.reverse/aarch64-*.exp tests pass.

> I'll try to review your patches tomorrow, to get this moving :)

Thanks!
Ezra