From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bPZIM+2g62mqADkAWB0awg (envelope-from ) for ; Fri, 24 Apr 2026 12:57:17 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=D0QHRXxG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C09611E0BA; Fri, 24 Apr 2026 12:57:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 57B041E093 for ; Fri, 24 Apr 2026 12:57:17 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 057884BB589F for ; Fri, 24 Apr 2026 16:57:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 057884BB589F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=D0QHRXxG Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 247DF4BB593A for ; Fri, 24 Apr 2026 16:56:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 247DF4BB593A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 247DF4BB593A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777049811; cv=none; b=tPvPsG46L4iwBhu5KbbZL5hyQelGiB2ayrL7ryTYTyi6lGJ2fR+YmVQuw9z5fpfcO2sTMLfvhUzkirRnfhQzi4MtfZ0itOnXrrcXHd2X9w2nfzm6R4R44bvZExg5sXmHyBSsd+41jPTKOTJwwJxJEoBcppLgVkFgKDLlH5Q6sxw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777049811; c=relaxed/simple; bh=nME+YrA9c+lwAt14OfeOhZ9yHMMDW4f73xrLcTLeOT0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=SFvaq2Jen6NUFJYq5I8FkPNC2omAJraSJBSpcb832LpuO0qpKbp9WHpzuqrpwikjBQmmzaqYzYkBuyzPUGrkrfmik+rhQoxeic6v8WTwvKYtCaEYfoo3ljqN400rqHA/4qIZxP/1nwCYf2APjiCjHxK1Vt12sA3D0Ik/BLlcdjA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 247DF4BB593A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777049810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WzQnlU01a38yH6zCPXZRO8h/8RVHaVZ5p+QAwVIGy5I=; b=D0QHRXxGQS5E+mv6c0tZY7jvr+qVH/CMGz4yzy6Gri3aNIskWVtPj5pp8E1MeytX7HGuAk 2wCVlEqJUptj/oYth6lhnjOeBQqEVs/B52qsujUyJmLJTdGL6JraVxhL6cO4OxRBZBbHe+ gYtzdvT5juMP4pZgbG7rGOVsUT9EQPU= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-AtCml5m5NT2DRVqGkPCGSw-1; Fri, 24 Apr 2026 12:56:49 -0400 X-MC-Unique: AtCml5m5NT2DRVqGkPCGSw-1 X-Mimecast-MFC-AGG-ID: AtCml5m5NT2DRVqGkPCGSw_1777049809 Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-6104087f037so3777645137.0 for ; Fri, 24 Apr 2026 09:56:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777049809; x=1777654609; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WzQnlU01a38yH6zCPXZRO8h/8RVHaVZ5p+QAwVIGy5I=; b=qbTVCfu4Isz7iy1ki411uwc+xJalaMtiTjsHzj0LhSdOjyzC4T43f1bznVeL97rIn8 GxYS1dYrD13vy8J8RR68Zc74OGeX203yeEC3lalfEv/vntx44c0IJH+ILIBGQImioSfs I0E1JZaJAKnJlZguNcpcpU2PbbAMZOEIJvWvZz+ic4ZPLKj5WlCnSZZ9IyckIKcDi7Xx GZxWWOJLNEkhSts+0oJ0EtDGTTRDslXSALs14/SO8uhCr0AjctsmO+79Fe5N72MdaQSh F3DJd4J76CL+qhbasHVpV3eq8vM2N+dzj5rI3tn3Vr5dFQgN/XSfUaOzJkpM2QFA9GKz YGcg== X-Forwarded-Encrypted: i=1; AFNElJ+Iv2fTxet1jrm+jGC26YoSnHBSqx832DTd1xBx2Csi6V01LyUtTmiOclef8T8TvVlIxsB2jg8EKXDWRw==@sourceware.org X-Gm-Message-State: AOJu0YxxEcMnARZD2+nkoEB6MklpY7rIKmP/RKiM0Wa5O/VQ2Qe/jFsZ CySsIXo3IurW5mZSCBxdIMpx/jxsGJaWqcKf/yCV8LKkLFDc2v8qrkIoZ46qHqCFimMqBDOqoA6 LhSuFvFGK/Vi2/BOouehguumkRNXOf2JRCoG0zUhWtOyMWFtOqIBAZ6H3zpUJQpY= X-Gm-Gg: AeBDieuBd4kDulF64ZJfO5bht+MX92Rp7lgz+0vqDscuJX+H/ehMEUFbWCTRvxbF1xt l3NRVmMy2AWvmFKx7S2OdKvOxsg3tJinMjwp2s2+bnE5c34JHSCBfBYZQaTY9smxh0rrKdfi+0U xfiHzdD5a6VclB2dYfLEU8piFFCKWZT8ZSXa8cTmbm+1uk7IuxREaGeN7NrwmgVwHU7yGKnn6as vgbeLbUp4MuLjrblxWxvU5MJqdShFDePuvzVq3da/1dg25xiJUVrPeLsjtRGKdb+d+66fSuZD74 YJnxyUBQveLSyjPnQUR3EznS6d2jcGLS//YD925Ay51caMrpIUYPyGYuvW/nSLflALSnpqgu+cN x+HU6rK9s5N4OO2QEtNG3g0WITXik8/ukZwteSLqpoA== X-Received: by 2002:a05:6102:3e05:b0:5f5:7723:28ee with SMTP id ada2fe7eead31-616f4f72488mr16350473137.11.1777049809009; Fri, 24 Apr 2026 09:56:49 -0700 (PDT) X-Received: by 2002:a05:6102:3e05:b0:5f5:7723:28ee with SMTP id ada2fe7eead31-616f4f72488mr16350463137.11.1777049808546; Fri, 24 Apr 2026 09:56:48 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e::75d? ([2804:14d:8084:993e::75d]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-9589097ec5csm11353875241.4.2026.04.24.09.56.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 09:56:48 -0700 (PDT) Message-ID: <7b1435e7-e402-4dc6-ad53-4a3ec7214c4f@redhat.com> Date: Fri, 24 Apr 2026 13:56:42 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] gdb/aarch64: record/replay support for RPRFM and PRFM (reg) To: Ezra.Sitorus@arm.com, gdb-patches@sourceware.org Cc: luis.machado.foss@gmail.com, thiago.bauermann@linaro.org References: <20260420215232.68675-1-Ezra.Sitorus@arm.com> <20260420215232.68675-4-Ezra.Sitorus@arm.com> From: Guinevere Larsen In-Reply-To: <20260420215232.68675-4-Ezra.Sitorus@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WZu2cJgmcYD-CfP8MGRLU-ufG4mSrHdi4Mu5k9tHoJk_1777049809 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/20/26 6:52 PM, Ezra.Sitorus@arm.com wrote: > From: Ezra Sitorus > > The PRFM (register) instruction variant was unsupported. This is added > along with RPRFM. > > No testcase has been added as these are hint instructions which don't > modify registers/memory. I'm happy to add them in if you think these are > required. > > The full testsuite was done on aarch64-none-linux-gnu without RPRFM. > The gdb.arch and gdb.reverse tests were run on Shrinkwrap with RPRFM > support. I've observed unrelated regressions that appear to be due to > Shrinkwrap rather than my patch. Just popping by to ack that no tests are needed. I'll leave the review to Luis > --- > gdb/aarch64-tdep.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c > index 81d4f160f8f..61c462979b3 100644 > --- a/gdb/aarch64-tdep.c > +++ b/gdb/aarch64-tdep.c > @@ -5914,6 +5914,11 @@ aarch64_record_load_store (aarch64_insn_decode_record *aarch64_insn_r) > else > if (size_bits != 0x03) > ld_flag = 0x01; > + else if (size_bits == 0x3 && vector_flag == 0x0 && opc == 0x2) > + { > + /* PRFM (register) or RPRFM */ > + return AARCH64_RECORD_SUCCESS; > + } > else > return AARCH64_RECORD_UNKNOWN; > -- Cheers, Guinevere Larsen It/she