From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id vMNiOeBa7GnKEDoAWB0awg (envelope-from ) for ; Sat, 25 Apr 2026 02:10:40 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=PQCgLQYT; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DAC111E067; Sat, 25 Apr 2026 02:10:40 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8C6B51E067 for ; Sat, 25 Apr 2026 02:10:39 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id B6A0B4BB1C35 for ; Sat, 25 Apr 2026 06:10:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B6A0B4BB1C35 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=PQCgLQYT Received: from mail-dy1-x132e.google.com (mail-dy1-x132e.google.com [IPv6:2607:f8b0:4864:20::132e]) by sourceware.org (Postfix) with ESMTPS id E97C64B9DB43 for ; Sat, 25 Apr 2026 06:10:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E97C64B9DB43 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E97C64B9DB43 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::132e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777097415; cv=none; b=IibR8gweVuRTcuhxL2InLTo13N2qWEHnpWtaaTlfia4I4TMU5+0jL3ymWUvamnSCH+s/JyzD/Gigc2WXKdgG3FLaAQewopPdo1ij6rY76iSMBPCJPIAeElHgCXmHeO0AxpXCYL+wr+GUv4JYmgMBNPkZ1hypHFgQFYIOL5fXkEo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777097415; c=relaxed/simple; bh=tdWoOy7NRVtwuxPEUVMOh9iUIrEDyKUgVylu59QuYs8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bK1nM1d7HC99AEu/k6V3yJsMdbLK5aXIbOmflMqagUPIn0cNIoaTeAtnI00xhY7FZ5t/ECbGCxD5uGWoW+NmNGHdnnIoRDf4iz1wrTL6eJTHVUfueoTnioHfuScH+fJ8550kXW9ix2CxPkp+U+lHk6WOOeCETsp74QUl9YI0SPE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E97C64B9DB43 Received: by mail-dy1-x132e.google.com with SMTP id 5a478bee46e88-2b6b0500e06so13606435eec.1 for ; Fri, 24 Apr 2026 23:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777097414; x=1777702214; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=PVDi54wAwRCIePSw2gOGiOQZ8EmaYXmZ2+qvaLvPwhc=; b=PQCgLQYTxLyJJKdk97DwrU31osYNjB5OvWvSrK9vOyZ17dULuQc0P3kw21/w/MeP5H 2t0V2z8RqeEVR05XLcZnx4D+QxYnsHr503Zb6P5l53N4qpgasfdbgTumcy7mV7PggoPK kkHrfyJmy4bLMpNgbALoMmQQLlDNvdDQqj4672NkGH37+/k2LJ4jB82/eALPVBxBGpV7 KQCgHfpdyxQVl3eNqVcAARJqCqAYUO038s0OsoKemI73QQXgEe3tHAMUehGDGf4pZP+E RHZPKOsdFJOd8N4U8HA5ujnxt7GvzLnsjC37s5ILvd8ZWxxRczMZ7tzuy6PGpnoUbWBj IR9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777097414; x=1777702214; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=PVDi54wAwRCIePSw2gOGiOQZ8EmaYXmZ2+qvaLvPwhc=; b=CDyj7QoEmm2VBSLEhuB/NK6/MwZL125asZBU7uxbUkF/dkYcQfiSOHY3t7t8DZoEGC nHSv3ZvTGgffAwscCrDlKbgXFLHte61db+yUigTtsHsXeulqgB2NWfmQs1tgsWHmLWSS MygdyDTeDeRfVGICequbYIxdupDHZVdzQsixlb8MqYXg14daHCSo26BeTqi+Mb61yXSy FvI6DnfNLqbhgTg4Exk2V4jHESyCUkCa6w00h/7CAk91bo1PuwBlRk+wQbRMLQDzka2u l7csLqrxNjAGls3Cle+XzDj4hbwYH9nN/UDyr4ukVamui+ThAu1lAoLa+B9HwXswXZT/ BL4w== X-Gm-Message-State: AOJu0YxucCd9kOh8sR52ChqRBnfP06Tj0o4fl0KUHJ47COurjwyr/VV/ thVhPrubHiX7tEcgqFO1H8ISgOXuE/WHGSuzr///cGUvORbns7Dz/qbTDVh9Vf5Ob+E= X-Gm-Gg: AeBDievuCLDztyyJXFVBJiPChFuBLSxHfu3UgAuq6OW/2wkcaLyvoGFAndfZJmMnbWU BTBOhz5AApEHQXveHbtvfweIlQub0rkNfPbc8LAyFyAZ99X749H6sFfg6V+hvQ09Ts+Ex3OBXCp z5rzSqaxyb16DpbjaYsb300QaiScieA9SfHFrMpa3ZfGLmYKTgx/8SJEGOuj5/N2gKJNBoIdxJK NTYdVieWtoIJSIDktOrySSc3kC646s+qg4gUC7LMDw5msicqmVsRhr4Tgueq1i6fTinS2B5hRko V8/YrsYsRtaZA4UKq5OzKXUVPem3xyvqecvSzYnd0hY30lNoa6js2bSugqP3Xm24Bom0EV0ZziY vAQc0JWaQNuBX+0ZbogFkva/YUgIQCGauu065xlgkW9Qbj38jHYVS1OO9Vg+DMiJL9qZ8a4He3l Wgi+7FkrjzzFYwhpNuEFtEYE75WcPWZTxy8GpuiY8KrJ84 X-Received: by 2002:a05:7301:1f17:b0:2ea:b975:3db1 with SMTP id 5a478bee46e88-2eab9753fd9mr7914542eec.23.1777097413813; Fri, 24 Apr 2026 23:10:13 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e7025cf413sm31088628eec.15.2026.04.24.23.10.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 23:10:13 -0700 (PDT) From: Thiago Jung Bauermann To: Cc: , Subject: Re: [PATCH 2/4] gdb/aarch64: Test record/replay support for CSSC In-Reply-To: <20260420215232.68675-3-Ezra.Sitorus@arm.com> (Ezra Sitorus's message of "Mon, 20 Apr 2026 22:52:30 +0100") References: <20260420215232.68675-1-Ezra.Sitorus@arm.com> <20260420215232.68675-3-Ezra.Sitorus@arm.com> User-Agent: mu4e 1.14.0; emacs 30.2 Date: Sat, 25 Apr 2026 03:10:10 -0300 Message-ID: <87fr4jbmf1.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org writes: > From: Ezra Sitorus > > This patch checks that the handling of CSSC instructions is correct. > There is no explicit support for handling these instructions which is > why this patch is composed of tests. > > Regression tested on aarch64-none-linux-gnu on QEMU with CSSC support. > I observe unrelated regressions that appear to be environmental rather > than caused by this patch. > --- > gdb/testsuite/gdb.reverse/aarch64-cssc.c | 113 +++++++++++++++++ > gdb/testsuite/gdb.reverse/aarch64-cssc.exp | 141 +++++++++++++++++++++ > gdb/testsuite/lib/gdb.exp | 52 ++++++++ > 3 files changed, 306 insertions(+) > create mode 100644 gdb/testsuite/gdb.reverse/aarch64-cssc.c > create mode 100644 gdb/testsuite/gdb.reverse/aarch64-cssc.exp Following the decoding of CSSC instructions in aarch64_record_data_proc_imm and aarch64_record_load_store made me realize how clever the AArch64 instruction encoding is. :) For this patch I only have the same comments I had about the testcase in patch 1: the copyright year, the formatting of the if condition block and the top-level return statements. -- Thiago