From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id w8frND1t7GltKjoAWB0awg (envelope-from ) for ; Sat, 25 Apr 2026 03:29:01 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=nPkaDmmD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C1E0B1E0BA; Sat, 25 Apr 2026 03:29:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C77D01E067 for ; Sat, 25 Apr 2026 03:29:00 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 487034BB3BEB for ; Sat, 25 Apr 2026 07:28:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 487034BB3BEB Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=nPkaDmmD Received: from mail-dl1-x122f.google.com (mail-dl1-x122f.google.com [IPv6:2607:f8b0:4864:20::122f]) by sourceware.org (Postfix) with ESMTPS id E9A7E4BB3BD3 for ; Sat, 25 Apr 2026 07:28:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E9A7E4BB3BD3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E9A7E4BB3BD3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::122f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777102112; cv=none; b=btbfgmS+uibWYZzoCYomPX3vy0odIw0Sv85olVMLFmcci6SDYgBDqwT/3Q1Oz7ESMM156/ZFR+ddAtEHqo8IR2Z9DXgYHKmEsqHiridXCtvrC4QhBCqN0wrA0/soQDyXnuET16mddIMzZKyzq0mBTkpkhO3dik2hV9sHv0DtnHI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777102112; c=relaxed/simple; bh=etFZoyyyPXYUlNN5n7qMzwuZgpIE0WQK8xcWjUx31sg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=efB7NxiNNxAV+6zHtfLZNhLZC5ouCS/ErfFRSj6us6LqY1lyTMVepfpYLls0Fwvdw7XLl/nV1p/isMVIMGYmthhdF8FoxHGofZ9oTBURSY2ygTekP+KXZJarFug9uoCJNNkqTri9i6+B2bUgtnBmx/GJUGW1BmQ1ehfb2gZUxQQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E9A7E4BB3BD3 Received: by mail-dl1-x122f.google.com with SMTP id a92af1059eb24-12c565dd3a7so1091950c88.1 for ; Sat, 25 Apr 2026 00:28:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777102111; x=1777706911; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=rsKrdWnQPDOYMg9qHUF/xaFTzg17uYU3fGw0sjNRwzk=; b=nPkaDmmDWFRfaMipEccU4nLaMMHjsNCIpkQ/fZ4+RNByCHgn4QOPmW3+PlNUZn0u5f ilFtIPSLLzPaRqXPkvBrSI84gZAqWJFCEMZ8z89Oey2BD2caD5rKR+4NMl/O/XaLDDmu UmbLaUngVP5G46CT6AupSqicdPgdcw+58tuY02U/yYh+TgBQcnbn1IlN2fvaJLUCB77d FiTRYP3MkF7IGOPT8dHCHK3rbbWOEBH3CN2Q+3nK+rkkun0sDpMmi2HV4t3oIKwTa3Zh JnvPZc+jx8Dyarvl/v2rgSfIgHDilH8y7XZkTWYInhZJJk5Lj5gG/Fbroy+r6ugchkGD CUPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777102111; x=1777706911; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rsKrdWnQPDOYMg9qHUF/xaFTzg17uYU3fGw0sjNRwzk=; b=UTa3uynPWxskzfz3xJlaxXqx8oQ9QlK3PgTm6ZdgOYwnqmqkFyar9BQZGVpF78adZ4 rjs9I/vZtDVkxfvG9cdaxOgfe9ZUtpDP4glTyYgomWQRwZpjR7WHXDwmLAKb12vNdVAr QYl0V9JGnfV1ffpf1GT56d65hD2YVaoToeFskRM6lLXZFR5P9hOKJExVcRCOnCeq6yf9 l1/UgeKAJUZwXjNCjvVocZ5pWd7qp7fXo3Jix6/XkxLHmWUhRr1A7Dtqpf39SUa+WwXq kv1cWLHS9PA2jmm/QUcBjE+fglFwaz7AemHkfHZHB+t5YuqDvdcJ4AY2tEPpsHEdCe6E 2zgA== X-Gm-Message-State: AOJu0YxGMUDOTUvPNTvBfaM3Nq1V3CYr4kby4n4wShmm/WizDjhZTWNf bx3txuHdnbIDMGnVKxxxiu6DQZ0PY/yazzXcCHDoUsglWvnB5fDEyfKvHNsc/RD2dOgzqswofI4 AYFS8 X-Gm-Gg: AeBDieuUKISGzzW9rhnzMfKyqEJsLWWh1rJrnFUcwPob+oJS3WaVD4mOxXd2wzg4vdF tlw2Z0C8f+rylIlExss3uAv0TDQPA4hQeM/fAJ2r7uaUF1951Qz+JKpk2zI+v7m62TCtno6Vbtj DDQFVPlz+iOagwajm5fIooC9e/z9mSWrEvBQjPIobW0tO6IcX/y6sKRM5nv0BwLhp5elsYCNeUp pixAJarqPXwvEUM/UBdtXDff+TdYijhlsRaEkozFYcA2C522ee9aMefQpZLm4MUYPYNX8ke+YnO NUn1fATK3FwUzQVacMf2srkX/sKXP58vHklbLl06WDomLqVblH341wGJWpCvgGKo7Aq/hIS51L9 PiSuy9ipc/Z893HonqxvyxfjeiughCrnGja7FadBgbM4+j31qGRc/qOmfRO1hIdru+m+VVmADA/ Y4XcRu4YV7ddb5/hQ+sqUgJQvx1ibzgx1IWF0vnV8UfJ4t1imuh1PonGg= X-Received: by 2002:a05:7022:6627:b0:12c:8b9:720c with SMTP id a92af1059eb24-12c73f95bd6mr21119455c88.18.1777102110468; Sat, 25 Apr 2026 00:28:30 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53ccd2564sm36369642eec.18.2026.04.25.00.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 00:28:30 -0700 (PDT) From: Thiago Jung Bauermann To: Cc: , Subject: Re: [PATCH 2/4] gdb/aarch64: Test record/replay support for CSSC In-Reply-To: <20260420215232.68675-3-Ezra.Sitorus@arm.com> (Ezra Sitorus's message of "Mon, 20 Apr 2026 22:52:30 +0100") References: <20260420215232.68675-1-Ezra.Sitorus@arm.com> <20260420215232.68675-3-Ezra.Sitorus@arm.com> User-Agent: mu4e 1.14.0; emacs 30.2 Date: Sat, 25 Apr 2026 04:28:27 -0300 Message-ID: <87y0iba484.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org writes: > +proc test_single_asm { name } { > + global decimal hex > + > + set before_seq [gdb_get_line_number "Before ${name}"] > + set after_seq [gdb_get_line_number "After ${name}"] > + set regs { x19 x20 x21 } > + > + set insn [lindex [split $name "-"] 0] Unlike the aarch64-lrcpc3.exp test from the previous patch, this one uses $insn rather than $name to differentiate the test names. As a result, for instructions which are tested twice (e.g., smax-1 and smax-2) all the tests in this function cause DUPLICATE errors. My suggestion here is the same as the one for the previous patch: wrap the body of the function in with_test_prefix $name { ... }. > + > + gdb_test "break $before_seq" \ > + "Breakpoint $decimal at $hex: file .*/aarch64-cssc.c, line $decimal\\." \ > + "$insn: break before instruction sequence" > + gdb_continue_to_breakpoint "$insn: about to execute instruction sequence" \ > + [multi_line ".*/aarch64-cssc.c:$decimal" \ > + "$decimal\[ \t\]+__asm__ volatile \\(\"${insn} \[^\r\n\]+\""] -- Thiago