From: Tom Tromey <tom@tromey.com>
To: Matthieu Longo <matthieu.longo@arm.com>
Cc: Tom Tromey <tom@tromey.com>,
Andrew Burgess <aburgess@redhat.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v1] gdb/python: fix memory leak in gdb_py_tp_name
Date: Fri, 05 Jun 2026 14:49:09 -0600 [thread overview]
Message-ID: <87pl24hfwa.fsf@tromey.com> (raw)
In-Reply-To: <b75b1963-d593-4579-b48c-fafbde899707@arm.com> (Matthieu Longo's message of "Wed, 3 Jun 2026 17:30:38 +0100")
>>>>> "Matthieu" == Matthieu Longo <matthieu.longo@arm.com> writes:
Matthieu> + /* This helper should be used for cases when the called CPython function
Matthieu> + informs the caller that an error occurred, and a Python error was set. */
Matthieu> + auto handle_err = [&]() -> std::string
Matthieu> + {
Matthieu> + gdbpy_print_stack ();
Matthieu> + PyErr_Clear ();
Matthieu> + return NO_TYPE_NAME;
The PyErr_Clear is redundant as gdbpy_print_stack guarantees that no
error is set when it returns.
Tom
next prev parent reply other threads:[~2026-06-05 20:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 16:04 Matthieu Longo
2026-05-26 16:35 ` Tom Tromey
2026-05-28 12:46 ` Matthieu Longo
2026-05-28 16:43 ` Tom Tromey
2026-05-28 17:08 ` Matthieu Longo
2026-05-28 19:00 ` Tom Tromey
2026-05-29 10:08 ` Matthieu Longo
2026-05-29 10:52 ` Andrew Burgess
2026-05-29 13:09 ` Tom Tromey
2026-06-01 9:57 ` Matthieu Longo
2026-06-02 9:36 ` Andrew Burgess
2026-06-02 14:22 ` Tom Tromey
2026-06-03 16:30 ` Matthieu Longo
2026-06-04 9:30 ` Andrew Burgess
2026-06-05 20:49 ` Tom Tromey [this message]
2026-06-08 10:31 ` Matthieu Longo
2026-06-08 18:51 ` Andrew Burgess
2026-06-05 10:06 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pl24hfwa.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=matthieu.longo@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox