Re: [PATCH v1] gdb/python: fix memory leak in gdb_py_tp_name

[Tom Tromey <tom@tromey.com>]

>>>>> Matthieu Longo <matthieu.longo@arm.com> writes:

> Sorry, I completely missed those issues while I was changing the code
> in others places.  I should definitely have spotted them if it was not
> my thoughtlessness in those last days.

Don't beat yourself up, it's all just normal stuff.

> -  PyObject *fully_qualified_name = PyType_GetFullyQualifiedName (py_type);
> +  gdbpy_ref<> fully_qualified_name (PyType_GetFullyQualifiedName (py_type));
>    if (fully_qualified_name == nullptr)
> -    return nullptr;
> +    return {};

Something I missed in the initial patch to add gdb_py_tp_name is that if
it fails, then the exception will be set, and the callers don't seem to
be prepared to handle that.

I'm not really sure what to do about it.  I guess the principled thing
would be to change the callers (including those of gdbpy_py_obj_tp_name)
to handle this properly :(

Though if we're really sure that this can only fail pathologically
somehow, I suppose we could add asserts in gdb_py_tp_name itself.

Tom