Re: [PATCH v1] gdb/python: fix memory leak in gdb_py_tp_name

[Tom de Vries <tdevries@suse.de>]

On 5/26/26 6:04 PM, Matthieu Longo wrote:
> @@ -1067,7 +1067,7 @@ bppy_init (PyObject *self, PyObject *args, PyObject *kwargs)
>   static PyObject *
>   bppy_repr (PyObject *self)
>   {
> -  const char *tp_name = gdbpy_py_obj_tp_name (self);
> +  const auto &tp_name = gdbpy_py_obj_tp_name (self);
>   
>     const auto bp = (struct gdbpy_breakpoint_object*) self;
>     if (bp->bp == nullptr)
> @@ -1083,7 +1083,7 @@ bppy_repr (PyObject *self)
>     str.pop_back ();
>   
>     return PyUnicode_FromFormat ("<%s%s number=%d hits=%d%s>",
> -			       tp_name,
> +			       tp_name.c_str (),
>   			       (bp->bp->enable_state == bp_enabled
>   				? "" : " disabled"), bp->bp->number,
>   			       bp->bp->hit_count, str.c_str ());

This updates the second use of tp_name, but not the first, which caused 
a build breaker with clang.  I've submitted a fix ( 
https://sourceware.org/pipermail/gdb-patches/2026-June/227823.html ).

Thanks,
- Tom