Re: [PATCH v1] gdb/python: fix memory leak in gdb_py_tp_name

[Andrew Burgess <aburgess@redhat.com>]

Matthieu Longo <matthieu.longo@arm.com> writes:

> On 05/06/2026 21:49, Tom Tromey wrote:
>>>>>>> "Matthieu" == Matthieu Longo <matthieu.longo@arm.com> writes:
>> 
>> Matthieu> +  /* This helper should be used for cases when the called CPython function
>> Matthieu> +     informs the caller that an error occurred, and a Python error was set.  */
>> Matthieu> +  auto handle_err = [&]() -> std::string
>> Matthieu> +  {
>> Matthieu> +    gdbpy_print_stack ();
>> Matthieu> +    PyErr_Clear ();
>> Matthieu> +    return NO_TYPE_NAME;
>> 
>> The PyErr_Clear is redundant as gdbpy_print_stack guarantees that no
>> error is set when it returns.
>> 
>> Tom
>
> Since I already merged the previous patch, can I apply this obvious
> fix ?

Yes please.  Sorry for not spotting this in my previous review.

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew


>
> Matthieu
>
> commit f8e8c76fbfe2a1b5b9b58add57edb24443d3c660
> Author: Matthieu Longo <matthieu.longo@arm.com>
> Date:   Mon Jun 8 11:27:44 2026 +0100
>
>      gdb_py_tp_name: remove redundant PyErr_Clear
>
>      gdbpy_print_stack() already clears the error indicator.
>      Thus remove the following call to PyErr_Clear().
>
> diff --git a/gdb/python/py-obj-type.c b/gdb/python/py-obj-type.c
> index 3ed57d0cbab..bd27b255679 100644
> --- a/gdb/python/py-obj-type.c
> +++ b/gdb/python/py-obj-type.c
> @@ -31,7 +31,6 @@ gdb_py_tp_name (PyTypeObject *py_type) noexcept
>     auto handle_err = [&]() -> std::string
>     {
>       gdbpy_print_stack ();
> -    PyErr_Clear ();
>       return NO_TYPE_NAME;
>     };