From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kQb+OIAPJ2qTgjwAWB0awg (envelope-from ) for ; Mon, 08 Jun 2026 14:52:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CL6Kn9YA; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D67A11E0A3; Mon, 08 Jun 2026 14:52:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5C3CB1E062 for ; Mon, 08 Jun 2026 14:52:48 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5650F44EBD52 for ; Mon, 8 Jun 2026 18:52:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5650F44EBD52 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CL6Kn9YA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id B03A951A4335 for ; Mon, 8 Jun 2026 18:51:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B03A951A4335 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B03A951A4335 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780944716; cv=none; b=RjvroDYGCz/j8XIFJ4B/iK8wpICnbuihBksz4bylD7AE+9BJHOAJhEJwo0qLVmBDd60TP5uyiSzWRK28dtoh7hD1RZZB58NzkKt1mKJgY2SVGNmzyYdzHMMEDrwlsYyspyzZkFIX2ZVqZh0xPkZ/kJ3mG44+YUV+zStdXSXTVFc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780944716; c=relaxed/simple; bh=af02yYYT9/UQqE8mFQl83y6+ZGcQA1ZeuBmQh6fEJNU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=S0MkjK6IhMzlFrw5FpCPmcF9zWV8XzLEvsaX6pCI5AyJ7MF1Qt2YQzl6Z/JXWOiwTFHxWlmKIH1H1JpQrDRLBsovUbq19lKC5kW+CKJjJToiCuiVgi/JDe/UT1N23RU2AXnM+eHilWPpC94vXtrks3uzwSntSu//TAgVJfKJbts= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CL6Kn9YA DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B03A951A4335 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780944716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RopDLFmoq4LeEyygM/vMe+o5qhltYPfTIc6NJTiNghI=; b=CL6Kn9YAKWF10A67F5gdv4+JEN/aBDOOxCtsfSQDdNP57ss+H1M6gSFMdpAYsZ8/y7kgdE 8Y5l1f7cLAKIjm7EfOGYg+Yw8DN3sAT2qWP/L2O/mqsNuqkg1puviLO1+H7F0IwQeLZGIz liIyYkczPbSC0abq46gdLC0Dn4RxGRY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-377-YAiX6lxVOXmkSYGjX2XbDA-1; Mon, 08 Jun 2026 14:51:55 -0400 X-MC-Unique: YAiX6lxVOXmkSYGjX2XbDA-1 X-Mimecast-MFC-AGG-ID: YAiX6lxVOXmkSYGjX2XbDA_1780944714 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-4601102c30dso2629082f8f.2 for ; Mon, 08 Jun 2026 11:51:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780944714; x=1781549514; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RopDLFmoq4LeEyygM/vMe+o5qhltYPfTIc6NJTiNghI=; b=GPG4BLzG30V8dnjX/dgAlOxlrGd1GAknSSwt1UjoEqPqBK6iIOjOYa+t3zvvX7s2pu 4DZrKaowxWK/VEgrUeTAUg3GdbC4/f5BUmFbONhNyw322g05/t7wbIKyyD2HnzOrDGxm 5bE3FDYHQNAeEkDnc2kbHBe061r+I02nIJL3R+i/igRzWFQg7AsaHnAJppEujLDNJe1m akTshr4tYXs+TDdf/YDbaM9GlNl5iK4pUQzGy0vppjXKvJWoC23pfl0qDEIMtQ7BX4SE Qj6Lmot2SmL709bbujlWocq6ZiV9pSQYx7CkkF8CwTWmSPAWkSl6IEi3EFvKkgSA08+n m/sw== X-Gm-Message-State: AOJu0YzAT/dryzVy0K9atP9Mg3EH8yKitPyvOK4O3LYYjaB0ZSAKaX3K js5iBS7IHqfkHGrmwjtYvyvrYbvxbMLgNskvPedZkilnh06lod8328LyseXlUEbPCZBXP/UDXIO xQxs5KmhQEMM8VbcAfw/pe6ShqtvkcxhI22nXHWkWIxcp86TuJmHib9kDVZk2NhYc6AmjqIE= X-Gm-Gg: Acq92OFYvzg7Vbzp93WBMgbqL9WQdNKjE4/IwK7wBTA3WY3uy/FQ68KWT1ho2/mq9tD NqyyDWe/QfObcs5hbNoW8hSmtGZZyRIWNHTqkiwuAHRTjJRNl3APEkCGJRLyaii8BeDehm9J6GZ 3zRbEBgzAqEC7H3phY6TFYE45owozdb+Nyfm7VLNH52dt9YSBH8SCRFeBuO5bfbLz7bhfL7ZKHQ eirk6ygnwchAa53IWzWz8CPvaISYDtJhJn9aaNvIH7/VrJJ3IbY2dLah2ILiyWlMhbttikScckO NcLrgcAAJJz3ak0G/4JoBJbKQEG3MOBZWBso9Pg0dPGJ8FNreCUAZofFlWopt4C4jxjKLFJQIj5 nv8ZdEau8skVwh/vo0OhdNG+Xqg== X-Received: by 2002:a05:600c:c16f:b0:490:bb59:63b7 with SMTP id 5b1f17b1804b1-490c25ff02emr278153065e9.28.1780944713740; Mon, 08 Jun 2026 11:51:53 -0700 (PDT) X-Received: by 2002:a05:600c:c16f:b0:490:bb59:63b7 with SMTP id 5b1f17b1804b1-490c25ff02emr278152735e9.28.1780944713321; Mon, 08 Jun 2026 11:51:53 -0700 (PDT) Received: from localhost ([213.31.44.97]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490c2d2d11asm360267325e9.1.2026.06.08.11.51.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 11:51:52 -0700 (PDT) From: Andrew Burgess To: Matthieu Longo , Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v1] gdb/python: fix memory leak in gdb_py_tp_name In-Reply-To: <3114bd25-227d-4cf1-83ac-3634a29d99f6@arm.com> References: <20260526160459.270322-1-matthieu.longo@arm.com> <87fr3e6sdp.fsf@tromey.com> <11b35b46-7e18-471a-94e2-91fef5b287d2@arm.com> <87tsrr5vtl.fsf@tromey.com> <62841b2c-9d0e-4efc-9b26-ca9bfd8787b9@arm.com> <87ldd35php.fsf@tromey.com> <87zf1ixzc9.fsf@redhat.com> <87cxye5pn0.fsf@tromey.com> <65c7d5c1-37ba-4e49-8d2a-800421075fb2@arm.com> <87o6hts2q0.fsf@redhat.com> <87fr35hvjb.fsf@tromey.com> <87pl24hfwa.fsf@tromey.com> <3114bd25-227d-4cf1-83ac-3634a29d99f6@arm.com> Date: Mon, 08 Jun 2026 19:51:51 +0100 Message-ID: <87h5ncrhko.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: extIkvhsCQkVvBxI_2e0oaHudmBGypNITmOEYNSx8XQ_1780944714 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Matthieu Longo writes: > On 05/06/2026 21:49, Tom Tromey wrote: >>>>>>> "Matthieu" == Matthieu Longo writes: >> >> Matthieu> + /* This helper should be used for cases when the called CPython function >> Matthieu> + informs the caller that an error occurred, and a Python error was set. */ >> Matthieu> + auto handle_err = [&]() -> std::string >> Matthieu> + { >> Matthieu> + gdbpy_print_stack (); >> Matthieu> + PyErr_Clear (); >> Matthieu> + return NO_TYPE_NAME; >> >> The PyErr_Clear is redundant as gdbpy_print_stack guarantees that no >> error is set when it returns. >> >> Tom > > Since I already merged the previous patch, can I apply this obvious > fix ? Yes please. Sorry for not spotting this in my previous review. Approved-By: Andrew Burgess Thanks, Andrew > > Matthieu > > commit f8e8c76fbfe2a1b5b9b58add57edb24443d3c660 > Author: Matthieu Longo > Date: Mon Jun 8 11:27:44 2026 +0100 > > gdb_py_tp_name: remove redundant PyErr_Clear > > gdbpy_print_stack() already clears the error indicator. > Thus remove the following call to PyErr_Clear(). > > diff --git a/gdb/python/py-obj-type.c b/gdb/python/py-obj-type.c > index 3ed57d0cbab..bd27b255679 100644 > --- a/gdb/python/py-obj-type.c > +++ b/gdb/python/py-obj-type.c > @@ -31,7 +31,6 @@ gdb_py_tp_name (PyTypeObject *py_type) noexcept > auto handle_err = [&]() -> std::string > { > gdbpy_print_stack (); > - PyErr_Clear (); > return NO_TYPE_NAME; > };