Re: [PATCH v1] gdb/python: fix memory leak in gdb_py_tp_name

[Tom Tromey <tom@tromey.com>]

>>>>> "Matthieu" == Matthieu Longo <matthieu.longo@arm.com> writes:

Matthieu> Indeed that can happen, for instance, when this function is called
Matthieu> inside a tp_clear() in the middle of a PyObject destruction.

Thanks.

Matthieu> Something like below would at least avoid the general abort, but it
Matthieu> would cause logging of errors in the middle of the destruction. How
Matthieu> useful would it be ?

Matthieu> gdbpy_ref<> fully_qualified_name (PyType_GetFullyQualifiedName (py_type));
Matthieu> if (fully_qualified_name == nullptr)
Matthieu>   {
Matthieu>     PyErr_Print();
Matthieu>     PyErr_Clear();
Matthieu>     return {};
Matthieu>   }

Matthieu> At this point, I don't think that it is super important not to crash
Matthieu> because there is a serious logic error somewhere if we are unable to
Matthieu> get this name. Consequently, an assert might be more appropriate.

If we think it could conceivably happen then it should probably just
call gdbpy_print_stack (which is basically the above but with some user
controls) and then return some error string.

Tom