Re: [PATCH v1] gdb/python: fix memory leak in gdb_py_tp_name

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

>> +    const char *s = PyUnicode_AsUTF8AndSize (name, nullptr);
>> +    if (s == nullptr)
>> +      return NO_TYPE_NAME;

Andrew> If PyUnicode_AsUTF8AndSize fails then a Python exception will be set.
Andrew> As we're not going to propagate that back to the actual Python
Andrew> interpreter, should we not clear the exception at this point?

Andrew> And the same question each time NO_TYPE_NAME is injected instead of an
Andrew> error?

Also worth noting that normally gdb doesn't simply discard Python
exceptions.  (To be clear, there are a couple of spots I think, but
maybe they are bugs.)

Normally either the exception is propagated, standard Python style; or
it is displayed using gdbpy_print_stack.  This function is used because
it respects some user settings that control what is displayed.

Tom