From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yaxEFOmfImp30TUAWB0awg (envelope-from ) for ; Fri, 05 Jun 2026 06:07:37 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YkJVl8HV; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=n8HUtEVP; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YkJVl8HV; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=n8HUtEVP; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4D7F71E0A6; Fri, 05 Jun 2026 06:07:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 96BB71E062 for ; Fri, 05 Jun 2026 06:07:36 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 72DB04BA798E for ; Fri, 5 Jun 2026 10:07:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 72DB04BA798E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YkJVl8HV; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=n8HUtEVP; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YkJVl8HV; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=n8HUtEVP Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 50F724BA5436 for ; Fri, 5 Jun 2026 10:07:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 50F724BA5436 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 50F724BA5436 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780654021; cv=none; b=nDai/QupmiUmWIxfHbUBBKiU+bIcVmk2hKq0sX+fnpOOJH7WmKeWIggy/oifTj3hOSL+6KYyEwEKTUpsrv6SxQ4wd6eV99NYvyqghZw411e3j4byPQkDjdRi9s7dEa5zv6KpJR+DRkL3FNRdgdG3nucL1/5LQBZIWIY3G9vVSmA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780654021; c=relaxed/simple; bh=w227EjOsQrs8leixdmCdWqZDZcYyKchJjnob/Z2Ch3Q=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=FxedqHmHzXxcplCsA6I8D7zw6qOBzlxNkcAVU0PV4fZuM7WjVWZl0GXXamXfz+4D8NvUJJ1+2q9OmthvOVlUu6s+Bj5zR+mSp7NKYINqCFb/T3y24shvCTOKQjEMY33ez1xniFt/BqtwXY1FvfyH/vGvK59HwwPYdIgsbUXpVcQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YkJVl8HV; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=n8HUtEVP; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YkJVl8HV; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=n8HUtEVP DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50F724BA5436 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 16EFE6B252; Fri, 5 Jun 2026 10:07:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780654020; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Flj4ktUMWjhs223mNDuo6F8t+qoQHcL5YOmVii7gWao=; b=YkJVl8HV0qE6/CeES2G20r6VWXej4II8KYUAKgAr8nmuQBc34y+phMkeajASb6BahW8CqV ks5gaO2tjjI8Xp9V2Hv69yKP2WBH6yXPYioGt0vGmVsidhCwkxUBRQmQ4cTYCBwHhpkbaQ AOc+Hbfd9JZF+wUSuh0Hut0cpeOQgrg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780654020; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Flj4ktUMWjhs223mNDuo6F8t+qoQHcL5YOmVii7gWao=; b=n8HUtEVPQD6JwaVQQZz2TUP83u8B05mWCDVs7e/pTwlO3Dh3eWyYVjHrqLm4YCstk21maN YPbRLEAq380+57Dw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=YkJVl8HV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=n8HUtEVP DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780654020; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Flj4ktUMWjhs223mNDuo6F8t+qoQHcL5YOmVii7gWao=; b=YkJVl8HV0qE6/CeES2G20r6VWXej4II8KYUAKgAr8nmuQBc34y+phMkeajASb6BahW8CqV ks5gaO2tjjI8Xp9V2Hv69yKP2WBH6yXPYioGt0vGmVsidhCwkxUBRQmQ4cTYCBwHhpkbaQ AOc+Hbfd9JZF+wUSuh0Hut0cpeOQgrg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780654020; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Flj4ktUMWjhs223mNDuo6F8t+qoQHcL5YOmVii7gWao=; b=n8HUtEVPQD6JwaVQQZz2TUP83u8B05mWCDVs7e/pTwlO3Dh3eWyYVjHrqLm4YCstk21maN YPbRLEAq380+57Dw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EAE63779A8; Fri, 5 Jun 2026 10:06:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 5Bj/N8OfImr5SwAAD6G6ig (envelope-from ); Fri, 05 Jun 2026 10:06:59 +0000 Message-ID: <247ba966-7850-4067-8017-8b35d1a6a74c@suse.de> Date: Fri, 5 Jun 2026 12:06:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] gdb/python: fix memory leak in gdb_py_tp_name To: Matthieu Longo , gdb-patches@sourceware.org, Tom Tromey Cc: Andrew Burgess References: <20260526160459.270322-1-matthieu.longo@arm.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260526160459.270322-1-matthieu.longo@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.44 / 50.00]; BAYES_HAM(-2.93)[99.69%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 16EFE6B252 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/26/26 6:04 PM, Matthieu Longo wrote: > @@ -1067,7 +1067,7 @@ bppy_init (PyObject *self, PyObject *args, PyObject *kwargs) > static PyObject * > bppy_repr (PyObject *self) > { > - const char *tp_name = gdbpy_py_obj_tp_name (self); > + const auto &tp_name = gdbpy_py_obj_tp_name (self); > > const auto bp = (struct gdbpy_breakpoint_object*) self; > if (bp->bp == nullptr) > @@ -1083,7 +1083,7 @@ bppy_repr (PyObject *self) > str.pop_back (); > > return PyUnicode_FromFormat ("<%s%s number=%d hits=%d%s>", > - tp_name, > + tp_name.c_str (), > (bp->bp->enable_state == bp_enabled > ? "" : " disabled"), bp->bp->number, > bp->bp->hit_count, str.c_str ()); This updates the second use of tp_name, but not the first, which caused a build breaker with clang. I've submitted a fix ( https://sourceware.org/pipermail/gdb-patches/2026-June/227823.html ). Thanks, - Tom